Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): respect baseURL when rendering payload path - #7809

Merged
pi0 merged 1 commit into
mainfrom
fix/base-payload
Sep 26, 2022
Merged

fix(nuxt): respect baseURL when rendering payload path#7809
pi0 merged 1 commit into
mainfrom
fix/base-payload

Conversation

@danielroe

@danielroedanielroe commented Sep 24, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15023

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This respects the baseURL when rendering payload URL in HTML.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 24, 2022
@danielroe
danielroe requested a review from pi0September 24, 2022 19:59
@danielroedanielroe self-assigned this Sep 24, 2022
@codesandbox

codesandboxBot commented Sep 24, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Sep 24, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit8e02b47
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/632f61892c645100082fc9c7

pi0
pi0 reviewed Sep 26, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/runtime/nitro/renderer.ts
pi0
pi0 approved these changes Sep 26, 2022
View reviewed changes
@pi0
pi0 merged commit c0e99c7 into mainSep 26, 2022
@pi0
pi0 deleted the fix/base-payload branch September 26, 2022 09:16
This was referenced Oct 4, 2022
Merged
Merged
@danielroedanielroe mentioned this pull request Oct 11, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@woldtwerkwoldtwerkwoldtwerk left review comments
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Base URL doesn't get applied to /_payload.js when using Nuxi Generate

3 participants

@danielroe@pi0@woldtwerk