Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): use correct cache and add baseURL to payload - #7984

Merged
danielroe merged 1 commit into
mainfrom
fix/payload-url
Oct 9, 2022
Merged

fix(nuxt): use correct cache and add baseURL to payload#7984
danielroe merged 1 commit into
mainfrom
fix/payload-url

Conversation

@danielroe

@danielroedanielroe commented Oct 4, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

#7809 (comment)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Two issues:

  1. we were not caching payloads
  2. we were not respecting baseURL when fetching payloads on client side

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 4, 2022
@danielroe
danielroe requested a review from pi0October 4, 2022 10:16
@danielroedanielroe self-assigned this Oct 4, 2022
@codesandbox

codesandboxBot commented Oct 4, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroedanielroe mentioned this pull request Oct 4, 2022
Merged
7 tasks
@netlify

netlifyBot commented Oct 4, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit66e87fd
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/633c0812970d5300093055be

@vercel
vercelBot temporarily deployed to Preview October 4, 2022 10:19 Inactive
@tristan-smithtristan-smith mentioned this pull request Oct 7, 2022
Closed
4 tasks
@danielroe
danielroe merged commit 6d90466 into mainOct 9, 2022
@danielroe
danielroe deleted the fix/payload-url branch October 9, 2022 14:22
@danielroedanielroe mentioned this pull request Oct 9, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pi0pi0Awaiting requested review from pi0
2 more reviewers
@atinuxatinuxatinux approved these changes
@VatanayVatanayVatanay approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@atinux@Vatanay