Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): prevent overlap between vite assets and app routes - #7989

Merged
danielroe merged 1 commit into
mainfrom
fix/vite-base-workaround
Oct 11, 2022
Merged

fix(vite): prevent overlap between vite assets and app routes#7989
danielroe merged 1 commit into
mainfrom
fix/vite-base-workaround

Conversation

@danielroe

@danielroedanielroe commented Oct 4, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#15052

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

As is, /app will render /app.vue. (The base config option is completely ignored - and in fact removed by vite - so no need to do the same ourselves.) A workaround is to inject and remove a random string to bypass matching vite-handled paths.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 4, 2022
@danielroe
danielroe requested a review from antfuOctober 4, 2022 18:34
@danielroedanielroe self-assigned this Oct 4, 2022
@codesandbox

codesandboxBot commented Oct 4, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 4, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit550b4db
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/633c7cad0e4fdb00082febd7

@vercel
vercelBot temporarily deployed to Preview October 4, 2022 18:34 Inactive
@danielroe
danielroe requested a review from atinuxOctober 9, 2022 19:56
@danielroedanielroe mentioned this pull request Oct 9, 2022
Merged
@danielroe
danielroe merged commit ed1c704 into mainOct 11, 2022
@danielroe
danielroe deleted the fix/vite-base-workaround branch October 11, 2022 05:26
@danielroedanielroe mentioned this pull request Oct 22, 2022
Merged
7 tasks
@antfuantfu mentioned this pull request Nov 1, 2022
Merged
7 tasks
@ppoddsppodds mentioned this pull request Jan 19, 2023
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@atinuxatinuxatinux approved these changes
@antfuantfuantfu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagevite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

/app renders app.vue in development

3 participants

@danielroe@atinux@antfu