Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): don't use or assignment - #8299

Merged
pi0 merged 1 commit into
mainfrom
fix/or-assignment
Oct 19, 2022
Merged

fix(nuxt): don't use or assignment#8299
pi0 merged 1 commit into
mainfrom
fix/or-assignment

Conversation

@danielroe

@danielroedanielroe commented Oct 18, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is seemingly not compiled down 🤔 and is not compatible with Node 14.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the bug Something isn't working label Oct 18, 2022
@danielroe
danielroe requested a review from pi0October 18, 2022 21:34
@danielroedanielroe self-assigned this Oct 18, 2022
@codesandbox

codesandboxBot commented Oct 18, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 18, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitdd766ed
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/634f1bd4e2f57400081644e3

DamianGlowala
DamianGlowala reviewed Oct 18, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/composables/preload.ts
@IsraelOrtunoIsraelOrtuno mentioned this pull request Oct 19, 2022
Closed
pi0
pi0 approved these changes Oct 19, 2022
View reviewed changes
@pi0
pi0 merged commit d3f3f9f into mainOct 19, 2022
@pi0
pi0 deleted the fix/or-assignment branch October 19, 2022 07:55
@danielroedanielroe mentioned this pull request Oct 20, 2022
Closed
2 tasks
@HigherOrderLogicHigherOrderLogic mentioned this pull request Oct 22, 2022
Closed
@danielroedanielroe mentioned this pull request Oct 22, 2022
Merged
7 tasks
@HigherOrderLogicHigherOrderLogic mentioned this pull request Jan 19, 2023
Closed
@danielroedanielroe mentioned this pull request Oct 25, 2022
Closed
@pi0pi0 mentioned this pull request Nov 3, 2022
Merged
@TheAlexLichterTheAlexLichter mentioned this pull request Nov 4, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@DamianGlowalaDamianGlowalaDamianGlowala left review comments
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@pi0@DamianGlowala