Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: change required node version to be above 16.11 - #8408

Merged
pi0 merged 1 commit into
nuxt:mainfrom
zecka:patch-1
Oct 24, 2022
Merged

docs: change required node version to be above 16.11#8408
pi0 merged 1 commit into
nuxt:mainfrom
zecka:patch-1

Conversation

@zecka

Copy link
Copy Markdown
Contributor

🔗 Linked issue

nuxt/nuxt#15231
nuxt/nuxt#15203

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Nuxt 3 seems not work on node versions bellow 16. So the documentation need to be updated

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 22, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitd1ef18f
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/635396a0d330de0008acfbee
😎 Deploy Previewhttps://deploy-preview-8408--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux
atinux requested a review from danielroeOctober 22, 2022 08:27
@danielroe

danielroe commented Oct 22, 2022

Copy link
Copy Markdown
Member

This has already been resolved and is a regression only in nuxi@rc12 (in the prepare command only, iirc). The fix has been linked in the issue you raised: #8299

It might be appropriate to add a (temporary) note but we certainly don't want to drop node 14 support because of a bug that has been resolved.

@zecka

Copy link
Copy Markdown
ContributorAuthor

@danielroe understood. So we can close this PR.

@zeckazecka closed this Oct 22, 2022
@danielroe

Copy link
Copy Markdown
Member

(Or if you thought it helpful to add a temporary note with a link, I would also be up for that.)

Just to be clear, I do really appreciate your spotting the issue and raising the PR 😊

@pi0pi0 reopened this Oct 24, 2022
@pi0

pi0 commented Oct 24, 2022

Copy link
Copy Markdown
Member

Reopening this makes sense we reduce documentation endorsement for 14 as per notes in nuxt/nuxt#14965.

BTW Syntax usage is fixed and we will probably keep supporting Node.js 14 by best efforts until it's EOL in few months.

@pi0pi0 changed the title docs: Change required node versiondocs: change required node version to be above 16.11Oct 24, 2022
pi0
pi0 approved these changes Oct 24, 2022
@pi0
pi0 merged commit 708460d into nuxt:mainOct 24, 2022
@pi0pi0 mentioned this pull request Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zecka@danielroe@pi0