Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
docs: disable transitions by default - #8434
Merged
Merged
Conversation
|
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pi0
approved these changes
Oct 24, 2022
atinux
commented
Oct 24, 2022
Member
Thanks @danielroe Shall we simply disable transitions by default in Nuxt 3? 🤔 |
danielroe
commented
Oct 24, 2022
MemberAuthor
There is merit in that. They cause issues like nuxt/nuxt#13471 when many users may not be using them at all ... wdyt @pi0? |
7 tasks
atinux
commented
Oct 24, 2022
Member
It also brings Nuxt 3 as light as possible when starting |
pi0
commented
Oct 24, 2022
Member
Makese sense to disable transitions by default. We only need proper way to guide users to enable it back |
TheAlexLichter
commented
Oct 24, 2022
Member
I think disabling them by default is a good idea to reduce friction, as long as docs cover how to use them (e.g. with an extra section). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
hotfix to work around nuxt/nuxt#15239
❓ Type of change
📚 Description
I do not believe we are currently using transitions so we probably should disable these anyway. This also serves to seriously reduce a memory leak that we're looking into.
📝 Checklist