Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(schema)!: disable app.pageTransition and app.layoutTransition by default - #8436

Merged
pi0 merged 5 commits into
mainfrom
fix/disable-transitions
Oct 24, 2022
Merged

refactor(schema)!: disable app.pageTransition and app.layoutTransition by default#8436
pi0 merged 5 commits into
mainfrom
fix/disable-transitions

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

#8434 (comment)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This disables page/layout transitions by default. They cause issues like nuxt/nuxt#13471 and nuxt/nuxt#15239 when many users may not be using them at all ...

 👉 Migration

If you were using page/layout transitions, you can add the following to your nuxt config to re-enable the previous behaviour:

exportdefaultdefineNuxtConfig({app: {pageTransition: {name: 'page',mode: 'out-in'},layoutTransition: {name: 'layout',mode: 'out-in'}},})

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested review from atinux and pi0October 24, 2022 08:50
@danielroedanielroe self-assigned this Oct 24, 2022
@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlifyBot commented Oct 24, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commite47c6b0
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63566e1a2300040009fc0b2e
😎 Deploy Previewhttps://deploy-preview-8436--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux

Copy link
Copy Markdown
Member

Thank you @danielroe

We need to update the documentation as well (https://v3.nuxtjs.org/getting-started/transitions) to explain how to enable page transition and layouts transitions.

@danielroe

Copy link
Copy Markdown
MemberAuthor

Thank you - good catch! 🙏

@pi0pi0 changed the title fix(schema)!: disable page/layout transitions by defaultfix(schema)!: disable app.pageTransition and app. layoutTransition by defaultOct 24, 2022
@pi0pi0 changed the title fix(schema)!: disable app.pageTransition and app. layoutTransition by defaultrefactor(schema)!: disable app.pageTransition and app. layoutTransition by defaultOct 24, 2022
pi0
pi0 approved these changes Oct 24, 2022
@danielroedanielroe changed the title refactor(schema)!: disable app.pageTransition and app. layoutTransition by defaultrefactor(schema)!: disable app.pageTransition and app.layoutTransition by defaultOct 24, 2022
@danielroe

danielroe commented Oct 24, 2022

Copy link
Copy Markdown
MemberAuthor

Fixing test failure. On plane, so may take a minute.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@danielroe@atinux@pi0@antfu