Flip duly_duty.source and duly_task.source defaults from catalog to self - #54

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default
Sep 1, 2026
Merged

Flip duly_duty.source and duly_task.source defaults from catalog to self#54
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default

Conversation

@os-warren

@os-warrenos-warren commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes#50
Fixes#55

What

duly_duty.source and duly_task.source — the two caliber columns — both
declared catalog as the default option, so a hand-created record (no
source supplied) was born into the governed, scoreable set. That is the
exact inverse of the invariant source exists to serve: self-declared work
is surfaced, never scored. On the duty side it also exposed a hand-authored
duty to duly_catalog_sync, which rewrites cadence fields on anything whose
source is 'catalog'.

Moves default: true from the catalog option to the self option on both
duly_duty.source (src/objects/duty.object.ts, #50) and duly_task.source
(src/objects/task.object.ts, #55 — extended into this PR by PM call: the
task-side field is unowned this round, and splitting a one-line sibling-field
fix across two rounds was judged worse than the file-surface discipline was
worth). duly_catalog_item is untouched — a catalog item is the
organisation's declaration by construction.

Why this is safe — duty side (#50)

Every path that legitimately produces a governed duly_duty already stamps
source explicitly:

  • duly_catalog_apply writes source: 'catalog' — confirmed unchanged at
    src/actions/catalog.handlers.ts:324, and pinned by
    test/catalog-instantiate.test.ts ("copies the catalog item's content and
    cadence onto the duty").
  • The assignment fan-out (src/flows/assignment.flow.ts) writes
    source: 'assigned' — but on duly_task, not duly_duty (it never
    creates a duly_duty row at all; objectName: 'duly_task' at both
    create_record nodes). It is therefore orthogonal to this field's default.
    Confirmed unchanged by test/assignment-fanout.test.ts. Noting this
    because the issue and adjudication comment both describe the fan-out as a
    duty producer — it isn't; it produces tasks directly. Doesn't change the
    fix, but the premise as stated is imprecise (acknowledged on A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50).

So the duty-side default was only ever reachable by a hand-created
duly_duty, which is by definition self-declared.

Why this is safe — task side (#55), verified rather than copied

The producer set is different on duly_task, so each was re-checked rather
than assumed:

  • The dispatcher (src/jobs/dispatch.plan.ts, dispatch.job.ts) copies
    duty.source onto every dispatched task explicitly —
    source: duty.source ?? '' is always present in the TaskDraft, never
    omitted from the insert. Confirmed unchanged; still relies on nothing from
    the field default.
  • The assignment fan-out writes source: 'assigned' directly on both
    create_record nodes in assignment.flow.ts. Re-confirmed unchanged after
    the task-side edit.
  • The actual gap the default governs: duly_member's permission grant
    on duly_task is allowCreate: true (src/security/permission-sets.ts),
    and src/views/task.view.ts defines no create form that stamps source.
    A member hand-creating their own task falls through to the field default —
    which is exactly the self-declared case this fix protects. No producer was
    found riding on the old default; the finding is the create-path gap itself,
    now closed by the same mechanism as A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50.

Checked and found clean

  • docs/product/data-model.md's caliber paragraph — describes catalog/
    assigned as governed and self as surfaced-never-scored, but never
    states which is the default. No edit needed.
  • The seed (Demo seed data — the product working on first boot #7) — not yet landed (no seed files exist outside
    node_modules). Nothing to fix.
  • src/views/duty.view.ts — puts source on the form as a plain field with
    no override either way; out of file surface, unaffected by the fix.

Tests

test/invariants.test.ts carries one generalized test — a hand-created record is self-declared, not born governed (#50, #55) — looping over both
duly_duty and duly_task rather than duplicating the block per object, so
a third caliber-bearing object landing with the wrong default fails the same
assertion. Each iteration asserts exactly one source option carries
default: true, that its value is 'self', and that neither catalog nor
assigned does.

Ablation (both halves, same script shape)

For each object: committed the fix first, moved default: true back onto
catalog on disk, confirmed the mutation landed via grep/git diff --stat
before measuring, ran test/invariants.test.ts and got the expected red
naming that object (AssertionError: <object>.source: expected 'catalog' to be 'self'), then restored via a trap ... EXIT INT TERM from the committed
state. Verified git status --short / git diff --stat empty after each
restore, and the full suite green again both times.

Gates (all green on 1123013, final head)

pnpm validate # ✓ Validation passed
pnpm typecheck # ✓ (tsc --noEmit, no output)
pnpm test # ✓ 12 files, 371 tests passed
pnpm build # ✓ Build complete, dist/objectstack.json written

File surface

src/objects/duty.object.ts, src/objects/task.object.ts (PM-extended,
unowned this round — no collision with #46/#51/#27), test/invariants.test.ts.
Nothing in objectstack.config.ts or AGENTS.md touched.


Generated by Claude Code

A hand-created duty was born into the governed, scoreable set because
the source select's default option was 'catalog'. Every path that
legitimately produces a governed duty already stamps source
explicitly (duly_catalog_apply writes 'catalog' per #34; the
assignment fan-out writes 'assigned' on duly_task per #33), so the
field default was only ever reached by a hand-created duty, which is
by definition self-declared.
Moves default: true from the catalog option to the self option on
duly_duty.source. Adds a test pinning the direction next to the
existing invariant tests: the default is self, and both governed
values (catalog, assigned) are reachable only by explicit assignment,
never as a fallback.
Same defaulting bug as #50, on the sibling caliber column. Verified
before changing rather than copying: both manufactured producers
already stamp source explicitly and do not rely on the field default
-- the dispatcher copies duty.source onto every dispatched task
(dispatch.plan.ts), and the assignment fan-out writes 'assigned'
directly on both create_record nodes (assignment.flow.ts). The path
that actually reaches the default is duly_member's allowCreate: true
on duly_task with no create form stamping source -- a member
hand-creating their own task, which is self-declared by definition.
Generalizes the #50 pinning test in test/invariants.test.ts to assert
the caliber-defaults-to-self property on both duly_duty and duly_task
instead of duplicating the block, per PM extension of #50's file
surface to include this sibling field.
@os-warrenos-warren changed the title Flip duly_duty.source default from catalog to selfFlip duly_duty.source and duly_task.source defaults from catalog to selfSep 1, 2026
@os-warren
os-warren marked this pull request as ready for review September 1, 2026 06:06
@os-warren
os-warren merged commit 7c30a39 into mainSep 1, 2026
1 check passed
os-warren pushed a commit that referenced this pull request Sep 1, 2026
Picks up #54 (source defaults to self) and #56 (hierarchy-security). Both
touch objects this guard resolves against; no field was renamed or removed,
only `default:` flags on select options.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SqkTcrxUFci7nqXdbBSe2p
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant

@os-warren
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Flip duly_duty.source and duly_task.source defaults from catalog to self - #54

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default
Sep 1, 2026
Merged

Flip duly_duty.source and duly_task.source defaults from catalog to self#54
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default

Conversation

@os-warren

@os-warrenos-warren commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes#50
Fixes#55

What

duly_duty.source and duly_task.source — the two caliber columns — both
declared catalog as the default option, so a hand-created record (no
source supplied) was born into the governed, scoreable set. That is the
exact inverse of the invariant source exists to serve: self-declared work
is surfaced, never scored. On the duty side it also exposed a hand-authored
duty to duly_catalog_sync, which rewrites cadence fields on anything whose
source is 'catalog'.

Moves default: true from the catalog option to the self option on both
duly_duty.source (src/objects/duty.object.ts, #50) and duly_task.source
(src/objects/task.object.ts, #55 — extended into this PR by PM call: the
task-side field is unowned this round, and splitting a one-line sibling-field
fix across two rounds was judged worse than the file-surface discipline was
worth). duly_catalog_item is untouched — a catalog item is the
organisation's declaration by construction.

Why this is safe — duty side (#50)

Every path that legitimately produces a governed duly_duty already stamps
source explicitly:

  • duly_catalog_apply writes source: 'catalog' — confirmed unchanged at
    src/actions/catalog.handlers.ts:324, and pinned by
    test/catalog-instantiate.test.ts ("copies the catalog item's content and
    cadence onto the duty").
  • The assignment fan-out (src/flows/assignment.flow.ts) writes
    source: 'assigned' — but on duly_task, not duly_duty (it never
    creates a duly_duty row at all; objectName: 'duly_task' at both
    create_record nodes). It is therefore orthogonal to this field's default.
    Confirmed unchanged by test/assignment-fanout.test.ts. Noting this
    because the issue and adjudication comment both describe the fan-out as a
    duty producer — it isn't; it produces tasks directly. Doesn't change the
    fix, but the premise as stated is imprecise (acknowledged on A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50).

So the duty-side default was only ever reachable by a hand-created
duly_duty, which is by definition self-declared.

Why this is safe — task side (#55), verified rather than copied

The producer set is different on duly_task, so each was re-checked rather
than assumed:

  • The dispatcher (src/jobs/dispatch.plan.ts, dispatch.job.ts) copies
    duty.source onto every dispatched task explicitly —
    source: duty.source ?? '' is always present in the TaskDraft, never
    omitted from the insert. Confirmed unchanged; still relies on nothing from
    the field default.
  • The assignment fan-out writes source: 'assigned' directly on both
    create_record nodes in assignment.flow.ts. Re-confirmed unchanged after
    the task-side edit.
  • The actual gap the default governs: duly_member's permission grant
    on duly_task is allowCreate: true (src/security/permission-sets.ts),
    and src/views/task.view.ts defines no create form that stamps source.
    A member hand-creating their own task falls through to the field default —
    which is exactly the self-declared case this fix protects. No producer was
    found riding on the old default; the finding is the create-path gap itself,
    now closed by the same mechanism as A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50.

Checked and found clean

  • docs/product/data-model.md's caliber paragraph — describes catalog/
    assigned as governed and self as surfaced-never-scored, but never
    states which is the default. No edit needed.
  • The seed (Demo seed data — the product working on first boot #7) — not yet landed (no seed files exist outside
    node_modules). Nothing to fix.
  • src/views/duty.view.ts — puts source on the form as a plain field with
    no override either way; out of file surface, unaffected by the fix.

Tests

test/invariants.test.ts carries one generalized test — a hand-created record is self-declared, not born governed (#50, #55) — looping over both
duly_duty and duly_task rather than duplicating the block per object, so
a third caliber-bearing object landing with the wrong default fails the same
assertion. Each iteration asserts exactly one source option carries
default: true, that its value is 'self', and that neither catalog nor
assigned does.

Ablation (both halves, same script shape)

For each object: committed the fix first, moved default: true back onto
catalog on disk, confirmed the mutation landed via grep/git diff --stat
before measuring, ran test/invariants.test.ts and got the expected red
naming that object (AssertionError: <object>.source: expected 'catalog' to be 'self'), then restored via a trap ... EXIT INT TERM from the committed
state. Verified git status --short / git diff --stat empty after each
restore, and the full suite green again both times.

Gates (all green on 1123013, final head)

pnpm validate # ✓ Validation passed
pnpm typecheck # ✓ (tsc --noEmit, no output)
pnpm test # ✓ 12 files, 371 tests passed
pnpm build # ✓ Build complete, dist/objectstack.json written

File surface

src/objects/duty.object.ts, src/objects/task.object.ts (PM-extended,
unowned this round — no collision with #46/#51/#27), test/invariants.test.ts.
Nothing in objectstack.config.ts or AGENTS.md touched.


Generated by Claude Code

A hand-created duty was born into the governed, scoreable set because
the source select's default option was 'catalog'. Every path that
legitimately produces a governed duty already stamps source
explicitly (duly_catalog_apply writes 'catalog' per #34; the
assignment fan-out writes 'assigned' on duly_task per #33), so the
field default was only ever reached by a hand-created duty, which is
by definition self-declared.
Moves default: true from the catalog option to the self option on
duly_duty.source. Adds a test pinning the direction next to the
existing invariant tests: the default is self, and both governed
values (catalog, assigned) are reachable only by explicit assignment,
never as a fallback.
Same defaulting bug as #50, on the sibling caliber column. Verified
before changing rather than copying: both manufactured producers
already stamp source explicitly and do not rely on the field default
-- the dispatcher copies duty.source onto every dispatched task
(dispatch.plan.ts), and the assignment fan-out writes 'assigned'
directly on both create_record nodes (assignment.flow.ts). The path
that actually reaches the default is duly_member's allowCreate: true
on duly_task with no create form stamping source -- a member
hand-creating their own task, which is self-declared by definition.
Generalizes the #50 pinning test in test/invariants.test.ts to assert
the caliber-defaults-to-self property on both duly_duty and duly_task
instead of duplicating the block, per PM extension of #50's file
surface to include this sibling field.
@os-warrenos-warren changed the title Flip duly_duty.source default from catalog to selfFlip duly_duty.source and duly_task.source defaults from catalog to selfSep 1, 2026
@os-warren
os-warren marked this pull request as ready for review September 1, 2026 06:06
@os-warren
os-warren merged commit 7c30a39 into mainSep 1, 2026
1 check passed
os-warren pushed a commit that referenced this pull request Sep 1, 2026
Picks up #54 (source defaults to self) and #56 (hierarchy-security). Both
touch objects this guard resolves against; no field was renamed or removed,
only `default:` flags on select options.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SqkTcrxUFci7nqXdbBSe2p
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant

@os-warren
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Flip duly_duty.source and duly_task.source defaults from catalog to self - #54

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default
Sep 1, 2026
Merged

Flip duly_duty.source and duly_task.source defaults from catalog to self#54
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default

Conversation

@os-warren

@os-warrenos-warren commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes#50
Fixes#55

What

duly_duty.source and duly_task.source — the two caliber columns — both
declared catalog as the default option, so a hand-created record (no
source supplied) was born into the governed, scoreable set. That is the
exact inverse of the invariant source exists to serve: self-declared work
is surfaced, never scored. On the duty side it also exposed a hand-authored
duty to duly_catalog_sync, which rewrites cadence fields on anything whose
source is 'catalog'.

Moves default: true from the catalog option to the self option on both
duly_duty.source (src/objects/duty.object.ts, #50) and duly_task.source
(src/objects/task.object.ts, #55 — extended into this PR by PM call: the
task-side field is unowned this round, and splitting a one-line sibling-field
fix across two rounds was judged worse than the file-surface discipline was
worth). duly_catalog_item is untouched — a catalog item is the
organisation's declaration by construction.

Why this is safe — duty side (#50)

Every path that legitimately produces a governed duly_duty already stamps
source explicitly:

  • duly_catalog_apply writes source: 'catalog' — confirmed unchanged at
    src/actions/catalog.handlers.ts:324, and pinned by
    test/catalog-instantiate.test.ts ("copies the catalog item's content and
    cadence onto the duty").
  • The assignment fan-out (src/flows/assignment.flow.ts) writes
    source: 'assigned' — but on duly_task, not duly_duty (it never
    creates a duly_duty row at all; objectName: 'duly_task' at both
    create_record nodes). It is therefore orthogonal to this field's default.
    Confirmed unchanged by test/assignment-fanout.test.ts. Noting this
    because the issue and adjudication comment both describe the fan-out as a
    duty producer — it isn't; it produces tasks directly. Doesn't change the
    fix, but the premise as stated is imprecise (acknowledged on A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50).

So the duty-side default was only ever reachable by a hand-created
duly_duty, which is by definition self-declared.

Why this is safe — task side (#55), verified rather than copied

The producer set is different on duly_task, so each was re-checked rather
than assumed:

  • The dispatcher (src/jobs/dispatch.plan.ts, dispatch.job.ts) copies
    duty.source onto every dispatched task explicitly —
    source: duty.source ?? '' is always present in the TaskDraft, never
    omitted from the insert. Confirmed unchanged; still relies on nothing from
    the field default.
  • The assignment fan-out writes source: 'assigned' directly on both
    create_record nodes in assignment.flow.ts. Re-confirmed unchanged after
    the task-side edit.
  • The actual gap the default governs: duly_member's permission grant
    on duly_task is allowCreate: true (src/security/permission-sets.ts),
    and src/views/task.view.ts defines no create form that stamps source.
    A member hand-creating their own task falls through to the field default —
    which is exactly the self-declared case this fix protects. No producer was
    found riding on the old default; the finding is the create-path gap itself,
    now closed by the same mechanism as A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50.

Checked and found clean

  • docs/product/data-model.md's caliber paragraph — describes catalog/
    assigned as governed and self as surfaced-never-scored, but never
    states which is the default. No edit needed.
  • The seed (Demo seed data — the product working on first boot #7) — not yet landed (no seed files exist outside
    node_modules). Nothing to fix.
  • src/views/duty.view.ts — puts source on the form as a plain field with
    no override either way; out of file surface, unaffected by the fix.

Tests

test/invariants.test.ts carries one generalized test — a hand-created record is self-declared, not born governed (#50, #55) — looping over both
duly_duty and duly_task rather than duplicating the block per object, so
a third caliber-bearing object landing with the wrong default fails the same
assertion. Each iteration asserts exactly one source option carries
default: true, that its value is 'self', and that neither catalog nor
assigned does.

Ablation (both halves, same script shape)

For each object: committed the fix first, moved default: true back onto
catalog on disk, confirmed the mutation landed via grep/git diff --stat
before measuring, ran test/invariants.test.ts and got the expected red
naming that object (AssertionError: <object>.source: expected 'catalog' to be 'self'), then restored via a trap ... EXIT INT TERM from the committed
state. Verified git status --short / git diff --stat empty after each
restore, and the full suite green again both times.

Gates (all green on 1123013, final head)

pnpm validate # ✓ Validation passed
pnpm typecheck # ✓ (tsc --noEmit, no output)
pnpm test # ✓ 12 files, 371 tests passed
pnpm build # ✓ Build complete, dist/objectstack.json written

File surface

src/objects/duty.object.ts, src/objects/task.object.ts (PM-extended,
unowned this round — no collision with #46/#51/#27), test/invariants.test.ts.
Nothing in objectstack.config.ts or AGENTS.md touched.


Generated by Claude Code

A hand-created duty was born into the governed, scoreable set because
the source select's default option was 'catalog'. Every path that
legitimately produces a governed duty already stamps source
explicitly (duly_catalog_apply writes 'catalog' per #34; the
assignment fan-out writes 'assigned' on duly_task per #33), so the
field default was only ever reached by a hand-created duty, which is
by definition self-declared.
Moves default: true from the catalog option to the self option on
duly_duty.source. Adds a test pinning the direction next to the
existing invariant tests: the default is self, and both governed
values (catalog, assigned) are reachable only by explicit assignment,
never as a fallback.
Same defaulting bug as #50, on the sibling caliber column. Verified
before changing rather than copying: both manufactured producers
already stamp source explicitly and do not rely on the field default
-- the dispatcher copies duty.source onto every dispatched task
(dispatch.plan.ts), and the assignment fan-out writes 'assigned'
directly on both create_record nodes (assignment.flow.ts). The path
that actually reaches the default is duly_member's allowCreate: true
on duly_task with no create form stamping source -- a member
hand-creating their own task, which is self-declared by definition.
Generalizes the #50 pinning test in test/invariants.test.ts to assert
the caliber-defaults-to-self property on both duly_duty and duly_task
instead of duplicating the block, per PM extension of #50's file
surface to include this sibling field.
@os-warrenos-warren changed the title Flip duly_duty.source default from catalog to selfFlip duly_duty.source and duly_task.source defaults from catalog to selfSep 1, 2026
@os-warren
os-warren marked this pull request as ready for review September 1, 2026 06:06
@os-warren
os-warren merged commit 7c30a39 into mainSep 1, 2026
1 check passed
os-warren pushed a commit that referenced this pull request Sep 1, 2026
Picks up #54 (source defaults to self) and #56 (hierarchy-security). Both
touch objects this guard resolves against; no field was renamed or removed,
only `default:` flags on select options.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SqkTcrxUFci7nqXdbBSe2p
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant

@os-warren
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Flip duly_duty.source and duly_task.source defaults from catalog to self - #54

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default
Sep 1, 2026
Merged

Flip duly_duty.source and duly_task.source defaults from catalog to self#54
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default

Conversation

@os-warren

@os-warrenos-warren commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes#50
Fixes#55

What

duly_duty.source and duly_task.source — the two caliber columns — both
declared catalog as the default option, so a hand-created record (no
source supplied) was born into the governed, scoreable set. That is the
exact inverse of the invariant source exists to serve: self-declared work
is surfaced, never scored. On the duty side it also exposed a hand-authored
duty to duly_catalog_sync, which rewrites cadence fields on anything whose
source is 'catalog'.

Moves default: true from the catalog option to the self option on both
duly_duty.source (src/objects/duty.object.ts, #50) and duly_task.source
(src/objects/task.object.ts, #55 — extended into this PR by PM call: the
task-side field is unowned this round, and splitting a one-line sibling-field
fix across two rounds was judged worse than the file-surface discipline was
worth). duly_catalog_item is untouched — a catalog item is the
organisation's declaration by construction.

Why this is safe — duty side (#50)

Every path that legitimately produces a governed duly_duty already stamps
source explicitly:

  • duly_catalog_apply writes source: 'catalog' — confirmed unchanged at
    src/actions/catalog.handlers.ts:324, and pinned by
    test/catalog-instantiate.test.ts ("copies the catalog item's content and
    cadence onto the duty").
  • The assignment fan-out (src/flows/assignment.flow.ts) writes
    source: 'assigned' — but on duly_task, not duly_duty (it never
    creates a duly_duty row at all; objectName: 'duly_task' at both
    create_record nodes). It is therefore orthogonal to this field's default.
    Confirmed unchanged by test/assignment-fanout.test.ts. Noting this
    because the issue and adjudication comment both describe the fan-out as a
    duty producer — it isn't; it produces tasks directly. Doesn't change the
    fix, but the premise as stated is imprecise (acknowledged on A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50).

So the duty-side default was only ever reachable by a hand-created
duly_duty, which is by definition self-declared.

Why this is safe — task side (#55), verified rather than copied

The producer set is different on duly_task, so each was re-checked rather
than assumed:

  • The dispatcher (src/jobs/dispatch.plan.ts, dispatch.job.ts) copies
    duty.source onto every dispatched task explicitly —
    source: duty.source ?? '' is always present in the TaskDraft, never
    omitted from the insert. Confirmed unchanged; still relies on nothing from
    the field default.
  • The assignment fan-out writes source: 'assigned' directly on both
    create_record nodes in assignment.flow.ts. Re-confirmed unchanged after
    the task-side edit.
  • The actual gap the default governs: duly_member's permission grant
    on duly_task is allowCreate: true (src/security/permission-sets.ts),
    and src/views/task.view.ts defines no create form that stamps source.
    A member hand-creating their own task falls through to the field default —
    which is exactly the self-declared case this fix protects. No producer was
    found riding on the old default; the finding is the create-path gap itself,
    now closed by the same mechanism as A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50.

Checked and found clean

  • docs/product/data-model.md's caliber paragraph — describes catalog/
    assigned as governed and self as surfaced-never-scored, but never
    states which is the default. No edit needed.
  • The seed (Demo seed data — the product working on first boot #7) — not yet landed (no seed files exist outside
    node_modules). Nothing to fix.
  • src/views/duty.view.ts — puts source on the form as a plain field with
    no override either way; out of file surface, unaffected by the fix.

Tests

test/invariants.test.ts carries one generalized test — a hand-created record is self-declared, not born governed (#50, #55) — looping over both
duly_duty and duly_task rather than duplicating the block per object, so
a third caliber-bearing object landing with the wrong default fails the same
assertion. Each iteration asserts exactly one source option carries
default: true, that its value is 'self', and that neither catalog nor
assigned does.

Ablation (both halves, same script shape)

For each object: committed the fix first, moved default: true back onto
catalog on disk, confirmed the mutation landed via grep/git diff --stat
before measuring, ran test/invariants.test.ts and got the expected red
naming that object (AssertionError: <object>.source: expected 'catalog' to be 'self'), then restored via a trap ... EXIT INT TERM from the committed
state. Verified git status --short / git diff --stat empty after each
restore, and the full suite green again both times.

Gates (all green on 1123013, final head)

pnpm validate # ✓ Validation passed
pnpm typecheck # ✓ (tsc --noEmit, no output)
pnpm test # ✓ 12 files, 371 tests passed
pnpm build # ✓ Build complete, dist/objectstack.json written

File surface

src/objects/duty.object.ts, src/objects/task.object.ts (PM-extended,
unowned this round — no collision with #46/#51/#27), test/invariants.test.ts.
Nothing in objectstack.config.ts or AGENTS.md touched.


Generated by Claude Code

A hand-created duty was born into the governed, scoreable set because
the source select's default option was 'catalog'. Every path that
legitimately produces a governed duty already stamps source
explicitly (duly_catalog_apply writes 'catalog' per #34; the
assignment fan-out writes 'assigned' on duly_task per #33), so the
field default was only ever reached by a hand-created duty, which is
by definition self-declared.
Moves default: true from the catalog option to the self option on
duly_duty.source. Adds a test pinning the direction next to the
existing invariant tests: the default is self, and both governed
values (catalog, assigned) are reachable only by explicit assignment,
never as a fallback.
Same defaulting bug as #50, on the sibling caliber column. Verified
before changing rather than copying: both manufactured producers
already stamp source explicitly and do not rely on the field default
-- the dispatcher copies duty.source onto every dispatched task
(dispatch.plan.ts), and the assignment fan-out writes 'assigned'
directly on both create_record nodes (assignment.flow.ts). The path
that actually reaches the default is duly_member's allowCreate: true
on duly_task with no create form stamping source -- a member
hand-creating their own task, which is self-declared by definition.
Generalizes the #50 pinning test in test/invariants.test.ts to assert
the caliber-defaults-to-self property on both duly_duty and duly_task
instead of duplicating the block, per PM extension of #50's file
surface to include this sibling field.
@os-warrenos-warren changed the title Flip duly_duty.source default from catalog to selfFlip duly_duty.source and duly_task.source defaults from catalog to selfSep 1, 2026
@os-warren
os-warren marked this pull request as ready for review September 1, 2026 06:06
@os-warren
os-warren merged commit 7c30a39 into mainSep 1, 2026
1 check passed
os-warren pushed a commit that referenced this pull request Sep 1, 2026
Picks up #54 (source defaults to self) and #56 (hierarchy-security). Both
touch objects this guard resolves against; no field was renamed or removed,
only `default:` flags on select options.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SqkTcrxUFci7nqXdbBSe2p
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant

@os-warren
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Flip duly_duty.source and duly_task.source defaults from catalog to self - #54

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default
Sep 1, 2026
Merged

Flip duly_duty.source and duly_task.source defaults from catalog to self#54
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default

Conversation

@os-warren

@os-warrenos-warren commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes#50
Fixes#55

What

duly_duty.source and duly_task.source — the two caliber columns — both
declared catalog as the default option, so a hand-created record (no
source supplied) was born into the governed, scoreable set. That is the
exact inverse of the invariant source exists to serve: self-declared work
is surfaced, never scored. On the duty side it also exposed a hand-authored
duty to duly_catalog_sync, which rewrites cadence fields on anything whose
source is 'catalog'.

Moves default: true from the catalog option to the self option on both
duly_duty.source (src/objects/duty.object.ts, #50) and duly_task.source
(src/objects/task.object.ts, #55 — extended into this PR by PM call: the
task-side field is unowned this round, and splitting a one-line sibling-field
fix across two rounds was judged worse than the file-surface discipline was
worth). duly_catalog_item is untouched — a catalog item is the
organisation's declaration by construction.

Why this is safe — duty side (#50)

Every path that legitimately produces a governed duly_duty already stamps
source explicitly:

  • duly_catalog_apply writes source: 'catalog' — confirmed unchanged at
    src/actions/catalog.handlers.ts:324, and pinned by
    test/catalog-instantiate.test.ts ("copies the catalog item's content and
    cadence onto the duty").
  • The assignment fan-out (src/flows/assignment.flow.ts) writes
    source: 'assigned' — but on duly_task, not duly_duty (it never
    creates a duly_duty row at all; objectName: 'duly_task' at both
    create_record nodes). It is therefore orthogonal to this field's default.
    Confirmed unchanged by test/assignment-fanout.test.ts. Noting this
    because the issue and adjudication comment both describe the fan-out as a
    duty producer — it isn't; it produces tasks directly. Doesn't change the
    fix, but the premise as stated is imprecise (acknowledged on A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50).

So the duty-side default was only ever reachable by a hand-created
duly_duty, which is by definition self-declared.

Why this is safe — task side (#55), verified rather than copied

The producer set is different on duly_task, so each was re-checked rather
than assumed:

  • The dispatcher (src/jobs/dispatch.plan.ts, dispatch.job.ts) copies
    duty.source onto every dispatched task explicitly —
    source: duty.source ?? '' is always present in the TaskDraft, never
    omitted from the insert. Confirmed unchanged; still relies on nothing from
    the field default.
  • The assignment fan-out writes source: 'assigned' directly on both
    create_record nodes in assignment.flow.ts. Re-confirmed unchanged after
    the task-side edit.
  • The actual gap the default governs: duly_member's permission grant
    on duly_task is allowCreate: true (src/security/permission-sets.ts),
    and src/views/task.view.ts defines no create form that stamps source.
    A member hand-creating their own task falls through to the field default —
    which is exactly the self-declared case this fix protects. No producer was
    found riding on the old default; the finding is the create-path gap itself,
    now closed by the same mechanism as A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50.

Checked and found clean

  • docs/product/data-model.md's caliber paragraph — describes catalog/
    assigned as governed and self as surfaced-never-scored, but never
    states which is the default. No edit needed.
  • The seed (Demo seed data — the product working on first boot #7) — not yet landed (no seed files exist outside
    node_modules). Nothing to fix.
  • src/views/duty.view.ts — puts source on the form as a plain field with
    no override either way; out of file surface, unaffected by the fix.

Tests

test/invariants.test.ts carries one generalized test — a hand-created record is self-declared, not born governed (#50, #55) — looping over both
duly_duty and duly_task rather than duplicating the block per object, so
a third caliber-bearing object landing with the wrong default fails the same
assertion. Each iteration asserts exactly one source option carries
default: true, that its value is 'self', and that neither catalog nor
assigned does.

Ablation (both halves, same script shape)

For each object: committed the fix first, moved default: true back onto
catalog on disk, confirmed the mutation landed via grep/git diff --stat
before measuring, ran test/invariants.test.ts and got the expected red
naming that object (AssertionError: <object>.source: expected 'catalog' to be 'self'), then restored via a trap ... EXIT INT TERM from the committed
state. Verified git status --short / git diff --stat empty after each
restore, and the full suite green again both times.

Gates (all green on 1123013, final head)

pnpm validate # ✓ Validation passed
pnpm typecheck # ✓ (tsc --noEmit, no output)
pnpm test # ✓ 12 files, 371 tests passed
pnpm build # ✓ Build complete, dist/objectstack.json written

File surface

src/objects/duty.object.ts, src/objects/task.object.ts (PM-extended,
unowned this round — no collision with #46/#51/#27), test/invariants.test.ts.
Nothing in objectstack.config.ts or AGENTS.md touched.


Generated by Claude Code

A hand-created duty was born into the governed, scoreable set because
the source select's default option was 'catalog'. Every path that
legitimately produces a governed duty already stamps source
explicitly (duly_catalog_apply writes 'catalog' per #34; the
assignment fan-out writes 'assigned' on duly_task per #33), so the
field default was only ever reached by a hand-created duty, which is
by definition self-declared.
Moves default: true from the catalog option to the self option on
duly_duty.source. Adds a test pinning the direction next to the
existing invariant tests: the default is self, and both governed
values (catalog, assigned) are reachable only by explicit assignment,
never as a fallback.
Same defaulting bug as #50, on the sibling caliber column. Verified
before changing rather than copying: both manufactured producers
already stamp source explicitly and do not rely on the field default
-- the dispatcher copies duty.source onto every dispatched task
(dispatch.plan.ts), and the assignment fan-out writes 'assigned'
directly on both create_record nodes (assignment.flow.ts). The path
that actually reaches the default is duly_member's allowCreate: true
on duly_task with no create form stamping source -- a member
hand-creating their own task, which is self-declared by definition.
Generalizes the #50 pinning test in test/invariants.test.ts to assert
the caliber-defaults-to-self property on both duly_duty and duly_task
instead of duplicating the block, per PM extension of #50's file
surface to include this sibling field.
@os-warrenos-warren changed the title Flip duly_duty.source default from catalog to selfFlip duly_duty.source and duly_task.source defaults from catalog to selfSep 1, 2026
@os-warren
os-warren marked this pull request as ready for review September 1, 2026 06:06
@os-warren
os-warren merged commit 7c30a39 into mainSep 1, 2026
1 check passed
os-warren pushed a commit that referenced this pull request Sep 1, 2026
Picks up #54 (source defaults to self) and #56 (hierarchy-security). Both
touch objects this guard resolves against; no field was renamed or removed,
only `default:` flags on select options.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SqkTcrxUFci7nqXdbBSe2p
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant

@os-warren
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Flip duly_duty.source and duly_task.source defaults from catalog to self - #54

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default
Sep 1, 2026
Merged

Flip duly_duty.source and duly_task.source defaults from catalog to self#54
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default

Conversation

@os-warren

@os-warrenos-warren commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes#50
Fixes#55

What

duly_duty.source and duly_task.source — the two caliber columns — both
declared catalog as the default option, so a hand-created record (no
source supplied) was born into the governed, scoreable set. That is the
exact inverse of the invariant source exists to serve: self-declared work
is surfaced, never scored. On the duty side it also exposed a hand-authored
duty to duly_catalog_sync, which rewrites cadence fields on anything whose
source is 'catalog'.

Moves default: true from the catalog option to the self option on both
duly_duty.source (src/objects/duty.object.ts, #50) and duly_task.source
(src/objects/task.object.ts, #55 — extended into this PR by PM call: the
task-side field is unowned this round, and splitting a one-line sibling-field
fix across two rounds was judged worse than the file-surface discipline was
worth). duly_catalog_item is untouched — a catalog item is the
organisation's declaration by construction.

Why this is safe — duty side (#50)

Every path that legitimately produces a governed duly_duty already stamps
source explicitly:

  • duly_catalog_apply writes source: 'catalog' — confirmed unchanged at
    src/actions/catalog.handlers.ts:324, and pinned by
    test/catalog-instantiate.test.ts ("copies the catalog item's content and
    cadence onto the duty").
  • The assignment fan-out (src/flows/assignment.flow.ts) writes
    source: 'assigned' — but on duly_task, not duly_duty (it never
    creates a duly_duty row at all; objectName: 'duly_task' at both
    create_record nodes). It is therefore orthogonal to this field's default.
    Confirmed unchanged by test/assignment-fanout.test.ts. Noting this
    because the issue and adjudication comment both describe the fan-out as a
    duty producer — it isn't; it produces tasks directly. Doesn't change the
    fix, but the premise as stated is imprecise (acknowledged on A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50).

So the duty-side default was only ever reachable by a hand-created
duly_duty, which is by definition self-declared.

Why this is safe — task side (#55), verified rather than copied

The producer set is different on duly_task, so each was re-checked rather
than assumed:

  • The dispatcher (src/jobs/dispatch.plan.ts, dispatch.job.ts) copies
    duty.source onto every dispatched task explicitly —
    source: duty.source ?? '' is always present in the TaskDraft, never
    omitted from the insert. Confirmed unchanged; still relies on nothing from
    the field default.
  • The assignment fan-out writes source: 'assigned' directly on both
    create_record nodes in assignment.flow.ts. Re-confirmed unchanged after
    the task-side edit.
  • The actual gap the default governs: duly_member's permission grant
    on duly_task is allowCreate: true (src/security/permission-sets.ts),
    and src/views/task.view.ts defines no create form that stamps source.
    A member hand-creating their own task falls through to the field default —
    which is exactly the self-declared case this fix protects. No producer was
    found riding on the old default; the finding is the create-path gap itself,
    now closed by the same mechanism as A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50.

Checked and found clean

  • docs/product/data-model.md's caliber paragraph — describes catalog/
    assigned as governed and self as surfaced-never-scored, but never
    states which is the default. No edit needed.
  • The seed (Demo seed data — the product working on first boot #7) — not yet landed (no seed files exist outside
    node_modules). Nothing to fix.
  • src/views/duty.view.ts — puts source on the form as a plain field with
    no override either way; out of file surface, unaffected by the fix.

Tests

test/invariants.test.ts carries one generalized test — a hand-created record is self-declared, not born governed (#50, #55) — looping over both
duly_duty and duly_task rather than duplicating the block per object, so
a third caliber-bearing object landing with the wrong default fails the same
assertion. Each iteration asserts exactly one source option carries
default: true, that its value is 'self', and that neither catalog nor
assigned does.

Ablation (both halves, same script shape)

For each object: committed the fix first, moved default: true back onto
catalog on disk, confirmed the mutation landed via grep/git diff --stat
before measuring, ran test/invariants.test.ts and got the expected red
naming that object (AssertionError: <object>.source: expected 'catalog' to be 'self'), then restored via a trap ... EXIT INT TERM from the committed
state. Verified git status --short / git diff --stat empty after each
restore, and the full suite green again both times.

Gates (all green on 1123013, final head)

pnpm validate # ✓ Validation passed
pnpm typecheck # ✓ (tsc --noEmit, no output)
pnpm test # ✓ 12 files, 371 tests passed
pnpm build # ✓ Build complete, dist/objectstack.json written

File surface

src/objects/duty.object.ts, src/objects/task.object.ts (PM-extended,
unowned this round — no collision with #46/#51/#27), test/invariants.test.ts.
Nothing in objectstack.config.ts or AGENTS.md touched.


Generated by Claude Code

A hand-created duty was born into the governed, scoreable set because
the source select's default option was 'catalog'. Every path that
legitimately produces a governed duty already stamps source
explicitly (duly_catalog_apply writes 'catalog' per #34; the
assignment fan-out writes 'assigned' on duly_task per #33), so the
field default was only ever reached by a hand-created duty, which is
by definition self-declared.
Moves default: true from the catalog option to the self option on
duly_duty.source. Adds a test pinning the direction next to the
existing invariant tests: the default is self, and both governed
values (catalog, assigned) are reachable only by explicit assignment,
never as a fallback.
Same defaulting bug as #50, on the sibling caliber column. Verified
before changing rather than copying: both manufactured producers
already stamp source explicitly and do not rely on the field default
-- the dispatcher copies duty.source onto every dispatched task
(dispatch.plan.ts), and the assignment fan-out writes 'assigned'
directly on both create_record nodes (assignment.flow.ts). The path
that actually reaches the default is duly_member's allowCreate: true
on duly_task with no create form stamping source -- a member
hand-creating their own task, which is self-declared by definition.
Generalizes the #50 pinning test in test/invariants.test.ts to assert
the caliber-defaults-to-self property on both duly_duty and duly_task
instead of duplicating the block, per PM extension of #50's file
surface to include this sibling field.
@os-warrenos-warren changed the title Flip duly_duty.source default from catalog to selfFlip duly_duty.source and duly_task.source defaults from catalog to selfSep 1, 2026
@os-warren
os-warren marked this pull request as ready for review September 1, 2026 06:06
@os-warren
os-warren merged commit 7c30a39 into mainSep 1, 2026
1 check passed
os-warren pushed a commit that referenced this pull request Sep 1, 2026
Picks up #54 (source defaults to self) and #56 (hierarchy-security). Both
touch objects this guard resolves against; no field was renamed or removed,
only `default:` flags on select options.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SqkTcrxUFci7nqXdbBSe2p
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant

@os-warren
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Flip duly_duty.source and duly_task.source defaults from catalog to self - #54

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default
Sep 1, 2026
Merged

Flip duly_duty.source and duly_task.source defaults from catalog to self#54
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default

Conversation

@os-warren

@os-warrenos-warren commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes#50
Fixes#55

What

duly_duty.source and duly_task.source — the two caliber columns — both
declared catalog as the default option, so a hand-created record (no
source supplied) was born into the governed, scoreable set. That is the
exact inverse of the invariant source exists to serve: self-declared work
is surfaced, never scored. On the duty side it also exposed a hand-authored
duty to duly_catalog_sync, which rewrites cadence fields on anything whose
source is 'catalog'.

Moves default: true from the catalog option to the self option on both
duly_duty.source (src/objects/duty.object.ts, #50) and duly_task.source
(src/objects/task.object.ts, #55 — extended into this PR by PM call: the
task-side field is unowned this round, and splitting a one-line sibling-field
fix across two rounds was judged worse than the file-surface discipline was
worth). duly_catalog_item is untouched — a catalog item is the
organisation's declaration by construction.

Why this is safe — duty side (#50)

Every path that legitimately produces a governed duly_duty already stamps
source explicitly:

  • duly_catalog_apply writes source: 'catalog' — confirmed unchanged at
    src/actions/catalog.handlers.ts:324, and pinned by
    test/catalog-instantiate.test.ts ("copies the catalog item's content and
    cadence onto the duty").
  • The assignment fan-out (src/flows/assignment.flow.ts) writes
    source: 'assigned' — but on duly_task, not duly_duty (it never
    creates a duly_duty row at all; objectName: 'duly_task' at both
    create_record nodes). It is therefore orthogonal to this field's default.
    Confirmed unchanged by test/assignment-fanout.test.ts. Noting this
    because the issue and adjudication comment both describe the fan-out as a
    duty producer — it isn't; it produces tasks directly. Doesn't change the
    fix, but the premise as stated is imprecise (acknowledged on A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50).

So the duty-side default was only ever reachable by a hand-created
duly_duty, which is by definition self-declared.

Why this is safe — task side (#55), verified rather than copied

The producer set is different on duly_task, so each was re-checked rather
than assumed:

  • The dispatcher (src/jobs/dispatch.plan.ts, dispatch.job.ts) copies
    duty.source onto every dispatched task explicitly —
    source: duty.source ?? '' is always present in the TaskDraft, never
    omitted from the insert. Confirmed unchanged; still relies on nothing from
    the field default.
  • The assignment fan-out writes source: 'assigned' directly on both
    create_record nodes in assignment.flow.ts. Re-confirmed unchanged after
    the task-side edit.
  • The actual gap the default governs: duly_member's permission grant
    on duly_task is allowCreate: true (src/security/permission-sets.ts),
    and src/views/task.view.ts defines no create form that stamps source.
    A member hand-creating their own task falls through to the field default —
    which is exactly the self-declared case this fix protects. No producer was
    found riding on the old default; the finding is the create-path gap itself,
    now closed by the same mechanism as A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50.

Checked and found clean

  • docs/product/data-model.md's caliber paragraph — describes catalog/
    assigned as governed and self as surfaced-never-scored, but never
    states which is the default. No edit needed.
  • The seed (Demo seed data — the product working on first boot #7) — not yet landed (no seed files exist outside
    node_modules). Nothing to fix.
  • src/views/duty.view.ts — puts source on the form as a plain field with
    no override either way; out of file surface, unaffected by the fix.

Tests

test/invariants.test.ts carries one generalized test — a hand-created record is self-declared, not born governed (#50, #55) — looping over both
duly_duty and duly_task rather than duplicating the block per object, so
a third caliber-bearing object landing with the wrong default fails the same
assertion. Each iteration asserts exactly one source option carries
default: true, that its value is 'self', and that neither catalog nor
assigned does.

Ablation (both halves, same script shape)

For each object: committed the fix first, moved default: true back onto
catalog on disk, confirmed the mutation landed via grep/git diff --stat
before measuring, ran test/invariants.test.ts and got the expected red
naming that object (AssertionError: <object>.source: expected 'catalog' to be 'self'), then restored via a trap ... EXIT INT TERM from the committed
state. Verified git status --short / git diff --stat empty after each
restore, and the full suite green again both times.

Gates (all green on 1123013, final head)

pnpm validate # ✓ Validation passed
pnpm typecheck # ✓ (tsc --noEmit, no output)
pnpm test # ✓ 12 files, 371 tests passed
pnpm build # ✓ Build complete, dist/objectstack.json written

File surface

src/objects/duty.object.ts, src/objects/task.object.ts (PM-extended,
unowned this round — no collision with #46/#51/#27), test/invariants.test.ts.
Nothing in objectstack.config.ts or AGENTS.md touched.


Generated by Claude Code

A hand-created duty was born into the governed, scoreable set because
the source select's default option was 'catalog'. Every path that
legitimately produces a governed duty already stamps source
explicitly (duly_catalog_apply writes 'catalog' per #34; the
assignment fan-out writes 'assigned' on duly_task per #33), so the
field default was only ever reached by a hand-created duty, which is
by definition self-declared.
Moves default: true from the catalog option to the self option on
duly_duty.source. Adds a test pinning the direction next to the
existing invariant tests: the default is self, and both governed
values (catalog, assigned) are reachable only by explicit assignment,
never as a fallback.
Same defaulting bug as #50, on the sibling caliber column. Verified
before changing rather than copying: both manufactured producers
already stamp source explicitly and do not rely on the field default
-- the dispatcher copies duty.source onto every dispatched task
(dispatch.plan.ts), and the assignment fan-out writes 'assigned'
directly on both create_record nodes (assignment.flow.ts). The path
that actually reaches the default is duly_member's allowCreate: true
on duly_task with no create form stamping source -- a member
hand-creating their own task, which is self-declared by definition.
Generalizes the #50 pinning test in test/invariants.test.ts to assert
the caliber-defaults-to-self property on both duly_duty and duly_task
instead of duplicating the block, per PM extension of #50's file
surface to include this sibling field.
@os-warrenos-warren changed the title Flip duly_duty.source default from catalog to selfFlip duly_duty.source and duly_task.source defaults from catalog to selfSep 1, 2026
@os-warren
os-warren marked this pull request as ready for review September 1, 2026 06:06
@os-warren
os-warren merged commit 7c30a39 into mainSep 1, 2026
1 check passed
os-warren pushed a commit that referenced this pull request Sep 1, 2026
Picks up #54 (source defaults to self) and #56 (hierarchy-security). Both
touch objects this guard resolves against; no field was renamed or removed,
only `default:` flags on select options.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SqkTcrxUFci7nqXdbBSe2p
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant

@os-warren
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Flip duly_duty.source and duly_task.source defaults from catalog to self - #54

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default
Sep 1, 2026
Merged

Flip duly_duty.source and duly_task.source defaults from catalog to self#54
os-warren merged 2 commits into
mainfrom
claude/issue-50-source-default

Conversation

@os-warren

@os-warrenos-warren commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes#50
Fixes#55

What

duly_duty.source and duly_task.source — the two caliber columns — both
declared catalog as the default option, so a hand-created record (no
source supplied) was born into the governed, scoreable set. That is the
exact inverse of the invariant source exists to serve: self-declared work
is surfaced, never scored. On the duty side it also exposed a hand-authored
duty to duly_catalog_sync, which rewrites cadence fields on anything whose
source is 'catalog'.

Moves default: true from the catalog option to the self option on both
duly_duty.source (src/objects/duty.object.ts, #50) and duly_task.source
(src/objects/task.object.ts, #55 — extended into this PR by PM call: the
task-side field is unowned this round, and splitting a one-line sibling-field
fix across two rounds was judged worse than the file-surface discipline was
worth). duly_catalog_item is untouched — a catalog item is the
organisation's declaration by construction.

Why this is safe — duty side (#50)

Every path that legitimately produces a governed duly_duty already stamps
source explicitly:

  • duly_catalog_apply writes source: 'catalog' — confirmed unchanged at
    src/actions/catalog.handlers.ts:324, and pinned by
    test/catalog-instantiate.test.ts ("copies the catalog item's content and
    cadence onto the duty").
  • The assignment fan-out (src/flows/assignment.flow.ts) writes
    source: 'assigned' — but on duly_task, not duly_duty (it never
    creates a duly_duty row at all; objectName: 'duly_task' at both
    create_record nodes). It is therefore orthogonal to this field's default.
    Confirmed unchanged by test/assignment-fanout.test.ts. Noting this
    because the issue and adjudication comment both describe the fan-out as a
    duty producer — it isn't; it produces tasks directly. Doesn't change the
    fix, but the premise as stated is imprecise (acknowledged on A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50).

So the duty-side default was only ever reachable by a hand-created
duly_duty, which is by definition self-declared.

Why this is safe — task side (#55), verified rather than copied

The producer set is different on duly_task, so each was re-checked rather
than assumed:

  • The dispatcher (src/jobs/dispatch.plan.ts, dispatch.job.ts) copies
    duty.source onto every dispatched task explicitly —
    source: duty.source ?? '' is always present in the TaskDraft, never
    omitted from the insert. Confirmed unchanged; still relies on nothing from
    the field default.
  • The assignment fan-out writes source: 'assigned' directly on both
    create_record nodes in assignment.flow.ts. Re-confirmed unchanged after
    the task-side edit.
  • The actual gap the default governs: duly_member's permission grant
    on duly_task is allowCreate: true (src/security/permission-sets.ts),
    and src/views/task.view.ts defines no create form that stamps source.
    A member hand-creating their own task falls through to the field default —
    which is exactly the self-declared case this fix protects. No producer was
    found riding on the old default; the finding is the create-path gap itself,
    now closed by the same mechanism as A hand-created duty defaults to source: 'catalog', so a self-declared duty is born scoreable #50.

Checked and found clean

  • docs/product/data-model.md's caliber paragraph — describes catalog/
    assigned as governed and self as surfaced-never-scored, but never
    states which is the default. No edit needed.
  • The seed (Demo seed data — the product working on first boot #7) — not yet landed (no seed files exist outside
    node_modules). Nothing to fix.
  • src/views/duty.view.ts — puts source on the form as a plain field with
    no override either way; out of file surface, unaffected by the fix.

Tests

test/invariants.test.ts carries one generalized test — a hand-created record is self-declared, not born governed (#50, #55) — looping over both
duly_duty and duly_task rather than duplicating the block per object, so
a third caliber-bearing object landing with the wrong default fails the same
assertion. Each iteration asserts exactly one source option carries
default: true, that its value is 'self', and that neither catalog nor
assigned does.

Ablation (both halves, same script shape)

For each object: committed the fix first, moved default: true back onto
catalog on disk, confirmed the mutation landed via grep/git diff --stat
before measuring, ran test/invariants.test.ts and got the expected red
naming that object (AssertionError: <object>.source: expected 'catalog' to be 'self'), then restored via a trap ... EXIT INT TERM from the committed
state. Verified git status --short / git diff --stat empty after each
restore, and the full suite green again both times.

Gates (all green on 1123013, final head)

pnpm validate # ✓ Validation passed
pnpm typecheck # ✓ (tsc --noEmit, no output)
pnpm test # ✓ 12 files, 371 tests passed
pnpm build # ✓ Build complete, dist/objectstack.json written

File surface

src/objects/duty.object.ts, src/objects/task.object.ts (PM-extended,
unowned this round — no collision with #46/#51/#27), test/invariants.test.ts.
Nothing in objectstack.config.ts or AGENTS.md touched.


Generated by Claude Code

A hand-created duty was born into the governed, scoreable set because
the source select's default option was 'catalog'. Every path that
legitimately produces a governed duty already stamps source
explicitly (duly_catalog_apply writes 'catalog' per #34; the
assignment fan-out writes 'assigned' on duly_task per #33), so the
field default was only ever reached by a hand-created duty, which is
by definition self-declared.
Moves default: true from the catalog option to the self option on
duly_duty.source. Adds a test pinning the direction next to the
existing invariant tests: the default is self, and both governed
values (catalog, assigned) are reachable only by explicit assignment,
never as a fallback.
Same defaulting bug as #50, on the sibling caliber column. Verified
before changing rather than copying: both manufactured producers
already stamp source explicitly and do not rely on the field default
-- the dispatcher copies duty.source onto every dispatched task
(dispatch.plan.ts), and the assignment fan-out writes 'assigned'
directly on both create_record nodes (assignment.flow.ts). The path
that actually reaches the default is duly_member's allowCreate: true
on duly_task with no create form stamping source -- a member
hand-creating their own task, which is self-declared by definition.
Generalizes the #50 pinning test in test/invariants.test.ts to assert
the caliber-defaults-to-self property on both duly_duty and duly_task
instead of duplicating the block, per PM extension of #50's file
surface to include this sibling field.
@os-warrenos-warren changed the title Flip duly_duty.source default from catalog to selfFlip duly_duty.source and duly_task.source defaults from catalog to selfSep 1, 2026
@os-warren
os-warren marked this pull request as ready for review September 1, 2026 06:06
@os-warren
os-warren merged commit 7c30a39 into mainSep 1, 2026
1 check passed
os-warren pushed a commit that referenced this pull request Sep 1, 2026
Picks up #54 (source defaults to self) and #56 (hierarchy-security). Both
touch objects this guard resolves against; no field was renamed or removed,
only `default:` flags on select options.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SqkTcrxUFci7nqXdbBSe2p
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant

@os-warren