Uh oh!
There was an error while loading. Please reload this page.
feat(showcase): chart gallery shows only distinctly-renderable chart types - #1690
Merged
Conversation
…types Pairs the objectui console build (objectui#1624) that routes dataset widgets to their TRUE chart renderer with a trimmed Chart Gallery (27 → 17 widgets): one widget per family the renderer draws distinctly. Removed the families that only fall back to a near-relative (grouped/stacked/bi-polar bars, stacked-area, step-line, spline, pyramid, bubble) and the dial-less performance variants (kpi/gauge/solid-gauge/bullet, identical to `metric`) — a "sankey" widget that draws bars is worse than not offering it. - chart-gallery.dashboard.ts → 17 canonical widgets (metric ×3 for format variety, then bar/column/horizontal-bar/line/area/pie/donut/funnel/scatter/ radar/treemap/sankey, table/pivot with multiple measures). - coverage.test → "covers every distinctly-renderable ChartType" (allowlist of the fallback-only families, documented for the follow-up `ChartTypeSchema` trim). - .objectui-sha → 76094e0d (vendors the true-chart-type routing). Browser-verified: pie/donut/funnel/line/area/sankey render distinctly; table/pivot render real tables with resolved labels + currency format. turbo build 72/72, test 123/123. objectui@76094e0d4ed79b8732ba9879c75aa5ab8283180d Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs the objectui console build (objectui#1624 — dataset widgets render their true chart type) with a trimmed, honest Chart Gallery.
Changes
metric ×3(count / decimal / currency — to show the format feature), then bar / column / horizontal-bar / line / area / pie / donut / funnel / scatter / radar / treemap / sankey, andtable/pivotwith multiple measures. Removed the families that only fall back to a near-relative (grouped/stacked/bi-polar bars, stacked-area, step-line, spline, pyramid, bubble) and the dial-less performance variants (kpi/gauge/solid-gauge/bullet, identical tometric).covers every distinctly-renderable ChartType(explicit allowlist of the fallback-only families, documented for the follow-upChartTypeSchematrim).76094e0d(vendors the true-chart-type routing).Verification
Browser-tested on the showcase Chart Gallery with this console build:
turbo build72/72,turbo test123/123.Recommended follow-up
Trim
ChartTypeSchema(spec) to the renderable set so spec ↔ renderer ↔ showcase stay in lockstep — a breaking spec change best aligned with the next major.🤖 Generated with Claude Code