Uh oh!
There was an error while loading. Please reload this page.
feat(spec)!: trim ChartTypeSchema to distinctly-renderable families - #1692
Merged
Conversation
Merge pull request #1626 from objectstack-ai/fix-flowrunner-terminal-failure-reset objectui@ec530a92ba2cdb6dbb0a1f5ee3b800503296e2f1
Drops 8 variant types that only rendered as their base chart, so the taxonomy no longer advertises a type that renders as something else: grouped-bar / stacked-bar / bi-polar-bar (→bar), stacked-area (→area), step-line / spline (→line), pyramid (→funnel), bubble (→scatter). 0 downstream usages (the showcase gallery was already trimmed; hotcrm/templates use none of them). Kept: the rendered families + the single-value performance group (metric / kpi / gauge / solid-gauge / bullet) — honest values today, a dial when a gauge renderer lands; `gauge` is used downstream (hotcrm SLA widget). - chart.zod: enum trimmed + taxonomy NOTE documents both exclusion groups. - chart.test: removed types moved to the reject list (+ a dedicated case). - showcase coverage.test: FALLBACK_ONLY simplified to the 4 metric-synonyms now that the 8 variants are gone from the enum. spec 6527/6527, turbo build 72/72, test 123/123. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChartTypeSchemadrops 8 variant types that only rendered as their base chart — so the taxonomy no longer advertises a type that renders as something else (the last item from the Chart Gallery review: spec ↔ renderer ↔ showcase now in lockstep).Removed (→ what they actually drew):
grouped-bar/stacked-bar/bi-polar-bar(→ bar, no multi-series grouping/stacking),stacked-area(→ area),step-line/spline(→ line),pyramid(→ funnel),bubble(→ scatter, no size encoding).Kept: bar / horizontal-bar / column, line / area, pie / donut / funnel, scatter, treemap / sankey, radar, table / pivot, and the single-value performance group
metric/kpi/gauge/solid-gauge/bullet(honest values today; a real dial when a gauge renderer lands —gaugeis used downstream by hotcrm's SLA widget, so it stays).Why safe
0 downstream usages of the 8 removed types — the showcase gallery was already trimmed (#1690), and hotcrm/templates use none of them (verified). Only spec tests + the regenerated reference doc needed updating.
Changes
chart.zod.ts— enum trimmed; taxonomy NOTE documents both exclusion groups (unmodellable families + fallback-only variants).chart.test.ts— removed types moved to the reject list (dedicated case).coverage.test.ts—FALLBACK_ONLYsimplified to the 4 metric-synonyms (the 8 variants are gone from the enum).references/ui/chart.mdx.Migration
A widget/series using a removed type switches to its base:
stacked-bar→bar,spline→line,pyramid→funnel,bubble→scatter, etc. They can return via an opt-in renderer once a real renderer + data model backs them.@objectstack/spec6527/6527,turbo build72/72,test123/123.🤖 Generated with Claude Code