Skip to content

ci: run the build check on merge_group — queued PRs wait forever for a required check that never starts #76

Description

@os-support-ai

Maintainer-ordered (2026-08-18, PM chat with the skills seat, session session_01WswfK2yNYT9hNnMH6TzAwL): this repository adopted a merge queue today and the ruleset now requires the build check (maintainer confirmation in chat: 「已完成 objectos ruleset 里必查项勾 build」). Cross-repo decision trail: objectstack-ai/objectstack#9551 (queue adoption = Option A, comment 5327457987).

The defect

.github/workflows/ci.yml declares:

on:
push:
branches: [main]pull_request:
branches: [main]

No merge_group: trigger. A merge queue validates candidates on a temporary merge-group ref whose checks come from workflows listening to the merge_group event — with build required and never produced there, every queued PR hangs as permanently "expected". The queue is armed today, so this is live, not latent.

The fix

Add the trigger to on: in ci.yml:

merge_group:

Nothing else. The fix PR can land through the queue itself: merge-group runs execute the workflow as defined at the merge-group ref, which includes the PR's own change.

Notes for the implementer

  • Repo facts (per the objectstack protocol's dispatch-expectations notice): no changeset flow, no packages/, CI shape differs from the sibling repos.
  • deploy-docs.yml (push-to-main deploy) and translations.yml (path-filtered, correctly NOT required) need no change — do not widen scope.
  • Adjacent but distinct: The CI test job executes nothing and cannot go red #72 records that the test turbo task executes nothing; that is a separate finding, not this card's scope.
  • pm label vocabulary is not yet seeded in this repository (pending ensure-pm-labels.sh run); state is carried by assignee + comments on this card in the meantime.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions