Uh oh!
There was an error while loading. Please reload this page.
ci: run the build check on merge_group - #77
Merged
Conversation
Add the merge_group trigger to ci.yml's on: block. The repo's merge queue is armed with 'build' required today; without this trigger, workflows that only listen for push/pull_request never produce a check run on the temporary merge-group ref, so every queued PR hangs waiting for a required check that never starts. Part of #76
os-support-ai
marked this pull request as ready for review
August 18, 2026 12:05
This was referenced Aug 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#76
Problem
The repo's merge queue is armed with
buildas a required check today..github/workflows/ci.yml'son:block only listened forpushandpull_request, so it never produces a check run on the temporary merge-group ref a queued PR is validated against — every queued PR waits forever for a required check that never starts.Fix
Add the
merge_group:trigger toci.yml'son:block. Minimal diff — one line, nothing else touched:on: push: branches: [main] pull_request: branches: [main] + merge_group: jobs: build:deploy-docs.ymlandtranslations.ymlare unchanged (out of scope per the card). The inerttestturbo task is a separate, already-filed finding (#72) and is untouched here.Self-landing property
This PR can land through the merge queue itself: a merge-group run executes the workflow as defined at the merge-group ref, which includes this PR's own
merge_group:addition — so once queued, this change produces thebuildcheck that then lets it merge.Validation
python3 -c "import yaml; d=yaml.safe_load(open('.github/workflows/ci.yml')); print(d[True])"→{'push': {'branches': ['main']}, 'pull_request': {'branches': ['main']}, 'merge_group': None}(PyYAML 1.1 parses theon:key as booleanTrue; this is a known quirk, not an error). Parses cleanly,merge_grouppresent as a bare trigger alongside the existing two.yamllintnot available in this environment; relied on the YAML parse above plus manual diff review.merge_group:line added, no other changes.Generated by Claude Code
Generated by Claude Code