spec: ApprovalDecisionResult's docblock does not record that a stranded decision's four facts ride the ERROR body — execution item 2 of #13807's batch #37 ruling #15439

Description

@os-warren

Blocked-by: #13807

Filed by the domain:services execution seat (session 03324ae2-0f5b-5ad2-8a2e-cf4aaff5a909, seat post #6021) as the spec half left unowned by the maintainer's 2026-09-04 ruling on #13807 (director batch #37, verbatim 「同意」 on 1B · 2及, issuecomment-5541861039). Cross-lane request into the domain:spec lane. ⛔ domain:*, type and priority are triage's — this seat does not produce them.

What the ruling owes here

The ruling's execution list, item 2, verbatim:

The ApprovalDecisionResult contract docblock records the declared posture: a finalised decision whose resume fails throws with the decision and run identified, never a half-state; the fields are the published way to read it.

The services half is implemented in PR #15436 (draft, head 13b58ed7d, under Clause-② contract review): serviceResume carries status, and a stranded decision's 500-class RESUME_FAILED error body gains finalized, decision, runId and a repairable flag.

Why it is not in that PR

packages/spec/src/contracts/approval-service.ts is a single-owner lane the implementing seat is read-only in — declared in its claim comment (issuecomment-5541965534) before it started, and honoured. It reported the item rather than editing across the boundary. ⇒ Filed here so the ruling's item 2 has an owner instead of evaporating between two lanes.

What is and is not owed

⚠️The contract TYPE needs no new fields. Measured on origin/main: ApprovalDecisionResult (packages/spec/src/contracts/approval-service.ts, ~:622) already declares request, finalized, decision, runId?, resumed? and resumeError?, and its resumed docblock already states the #4420 posture — "A decision that finalises a flow-bound request and CANNOT resume its run throws rather than returning resumed: false — a recorded decision whose flow never advances is the zombie half-state of #4420."

The four facts ride the error body, not the success shape. So what is owed is prose, not a field: the docblock should record that when that throw happens, the failure is now readablefinalized / decision / runId / the repairable flag are the published way to read the already-declared posture, rather than the caller being left with a bare 500.

⛔ Do not add the four fields to ApprovalDecisionResult. That would declare a success shape that never carries them.

Sequencing

Blocked-by: #13807 is deliberate: the sentence describes fields that do not exist on main until PR #15436 lands. Writing it earlier would put a false statement in the contract — the same defect class this repo keeps finding, where a surface documents itself as covered by something that has not shipped (see PR #15365's own account of a p0 seam that did exactly that).

⚠️ Whoever takes this: re-read the docblock on the then-current origin/main rather than inheriting the :622 anchor — PR #15436 adds ~52 lines of docblocks to approval-service.ts in plugin-approvals, and this repo's line refs rot fast enough that the #13807 dev found a card ref that had drifted ~223 lines and named the wrong mechanism.

Refs: #13807 (the ruled card) · PR #15436 (the services half) · #4420 (the posture this records) · #13937 / PR #15237 (the shape-4 ruling that excluded compensation) · #15221 (the generic resume door, measured NOT the same seam).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
      Skip to content

      spec: ApprovalDecisionResult's docblock does not record that a stranded decision's four facts ride the ERROR body — execution item 2 of #13807's batch #37 ruling #15439

      Description

      @os-warren

      Blocked-by: #13807

      Filed by the domain:services execution seat (session 03324ae2-0f5b-5ad2-8a2e-cf4aaff5a909, seat post #6021) as the spec half left unowned by the maintainer's 2026-09-04 ruling on #13807 (director batch #37, verbatim 「同意」 on 1B · 2及, issuecomment-5541861039). Cross-lane request into the domain:spec lane. ⛔ domain:*, type and priority are triage's — this seat does not produce them.

      What the ruling owes here

      The ruling's execution list, item 2, verbatim:

      The ApprovalDecisionResult contract docblock records the declared posture: a finalised decision whose resume fails throws with the decision and run identified, never a half-state; the fields are the published way to read it.

      The services half is implemented in PR #15436 (draft, head 13b58ed7d, under Clause-② contract review): serviceResume carries status, and a stranded decision's 500-class RESUME_FAILED error body gains finalized, decision, runId and a repairable flag.

      Why it is not in that PR

      packages/spec/src/contracts/approval-service.ts is a single-owner lane the implementing seat is read-only in — declared in its claim comment (issuecomment-5541965534) before it started, and honoured. It reported the item rather than editing across the boundary. ⇒ Filed here so the ruling's item 2 has an owner instead of evaporating between two lanes.

      What is and is not owed

      ⚠️The contract TYPE needs no new fields. Measured on origin/main: ApprovalDecisionResult (packages/spec/src/contracts/approval-service.ts, ~:622) already declares request, finalized, decision, runId?, resumed? and resumeError?, and its resumed docblock already states the #4420 posture — "A decision that finalises a flow-bound request and CANNOT resume its run throws rather than returning resumed: false — a recorded decision whose flow never advances is the zombie half-state of #4420."

      The four facts ride the error body, not the success shape. So what is owed is prose, not a field: the docblock should record that when that throw happens, the failure is now readablefinalized / decision / runId / the repairable flag are the published way to read the already-declared posture, rather than the caller being left with a bare 500.

      ⛔ Do not add the four fields to ApprovalDecisionResult. That would declare a success shape that never carries them.

      Sequencing

      Blocked-by: #13807 is deliberate: the sentence describes fields that do not exist on main until PR #15436 lands. Writing it earlier would put a false statement in the contract — the same defect class this repo keeps finding, where a surface documents itself as covered by something that has not shipped (see PR #15365's own account of a p0 seam that did exactly that).

      ⚠️ Whoever takes this: re-read the docblock on the then-current origin/main rather than inheriting the :622 anchor — PR #15436 adds ~52 lines of docblocks to approval-service.ts in plugin-approvals, and this repo's line refs rot fast enough that the #13807 dev found a card ref that had drifted ~223 lines and named the wrong mechanism.

      Refs: #13807 (the ruled card) · PR #15436 (the services half) · #4420 (the posture this records) · #13937 / PR #15237 (the shape-4 ruling that excluded compensation) · #15221 (the generic resume door, measured NOT the same seam).

      Activity

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
          Skip to content

          spec: ApprovalDecisionResult's docblock does not record that a stranded decision's four facts ride the ERROR body — execution item 2 of #13807's batch #37 ruling #15439

          Description

          @os-warren

          Blocked-by: #13807

          Filed by the domain:services execution seat (session 03324ae2-0f5b-5ad2-8a2e-cf4aaff5a909, seat post #6021) as the spec half left unowned by the maintainer's 2026-09-04 ruling on #13807 (director batch #37, verbatim 「同意」 on 1B · 2及, issuecomment-5541861039). Cross-lane request into the domain:spec lane. ⛔ domain:*, type and priority are triage's — this seat does not produce them.

          What the ruling owes here

          The ruling's execution list, item 2, verbatim:

          The ApprovalDecisionResult contract docblock records the declared posture: a finalised decision whose resume fails throws with the decision and run identified, never a half-state; the fields are the published way to read it.

          The services half is implemented in PR #15436 (draft, head 13b58ed7d, under Clause-② contract review): serviceResume carries status, and a stranded decision's 500-class RESUME_FAILED error body gains finalized, decision, runId and a repairable flag.

          Why it is not in that PR

          packages/spec/src/contracts/approval-service.ts is a single-owner lane the implementing seat is read-only in — declared in its claim comment (issuecomment-5541965534) before it started, and honoured. It reported the item rather than editing across the boundary. ⇒ Filed here so the ruling's item 2 has an owner instead of evaporating between two lanes.

          What is and is not owed

          ⚠️The contract TYPE needs no new fields. Measured on origin/main: ApprovalDecisionResult (packages/spec/src/contracts/approval-service.ts, ~:622) already declares request, finalized, decision, runId?, resumed? and resumeError?, and its resumed docblock already states the #4420 posture — "A decision that finalises a flow-bound request and CANNOT resume its run throws rather than returning resumed: false — a recorded decision whose flow never advances is the zombie half-state of #4420."

          The four facts ride the error body, not the success shape. So what is owed is prose, not a field: the docblock should record that when that throw happens, the failure is now readablefinalized / decision / runId / the repairable flag are the published way to read the already-declared posture, rather than the caller being left with a bare 500.

          ⛔ Do not add the four fields to ApprovalDecisionResult. That would declare a success shape that never carries them.

          Sequencing

          Blocked-by: #13807 is deliberate: the sentence describes fields that do not exist on main until PR #15436 lands. Writing it earlier would put a false statement in the contract — the same defect class this repo keeps finding, where a surface documents itself as covered by something that has not shipped (see PR #15365's own account of a p0 seam that did exactly that).

          ⚠️ Whoever takes this: re-read the docblock on the then-current origin/main rather than inheriting the :622 anchor — PR #15436 adds ~52 lines of docblocks to approval-service.ts in plugin-approvals, and this repo's line refs rot fast enough that the #13807 dev found a card ref that had drifted ~223 lines and named the wrong mechanism.

          Refs: #13807 (the ruled card) · PR #15436 (the services half) · #4420 (the posture this records) · #13937 / PR #15237 (the shape-4 ruling that excluded compensation) · #15221 (the generic resume door, measured NOT the same seam).

          Activity

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              spec: ApprovalDecisionResult's docblock does not record that a stranded decision's four facts ride the ERROR body — execution item 2 of #13807's batch #37 ruling #15439

              Description

              @os-warren

              Blocked-by: #13807

              Filed by the domain:services execution seat (session 03324ae2-0f5b-5ad2-8a2e-cf4aaff5a909, seat post #6021) as the spec half left unowned by the maintainer's 2026-09-04 ruling on #13807 (director batch #37, verbatim 「同意」 on 1B · 2及, issuecomment-5541861039). Cross-lane request into the domain:spec lane. ⛔ domain:*, type and priority are triage's — this seat does not produce them.

              What the ruling owes here

              The ruling's execution list, item 2, verbatim:

              The ApprovalDecisionResult contract docblock records the declared posture: a finalised decision whose resume fails throws with the decision and run identified, never a half-state; the fields are the published way to read it.

              The services half is implemented in PR #15436 (draft, head 13b58ed7d, under Clause-② contract review): serviceResume carries status, and a stranded decision's 500-class RESUME_FAILED error body gains finalized, decision, runId and a repairable flag.

              Why it is not in that PR

              packages/spec/src/contracts/approval-service.ts is a single-owner lane the implementing seat is read-only in — declared in its claim comment (issuecomment-5541965534) before it started, and honoured. It reported the item rather than editing across the boundary. ⇒ Filed here so the ruling's item 2 has an owner instead of evaporating between two lanes.

              What is and is not owed

              ⚠️The contract TYPE needs no new fields. Measured on origin/main: ApprovalDecisionResult (packages/spec/src/contracts/approval-service.ts, ~:622) already declares request, finalized, decision, runId?, resumed? and resumeError?, and its resumed docblock already states the #4420 posture — "A decision that finalises a flow-bound request and CANNOT resume its run throws rather than returning resumed: false — a recorded decision whose flow never advances is the zombie half-state of #4420."

              The four facts ride the error body, not the success shape. So what is owed is prose, not a field: the docblock should record that when that throw happens, the failure is now readablefinalized / decision / runId / the repairable flag are the published way to read the already-declared posture, rather than the caller being left with a bare 500.

              ⛔ Do not add the four fields to ApprovalDecisionResult. That would declare a success shape that never carries them.

              Sequencing

              Blocked-by: #13807 is deliberate: the sentence describes fields that do not exist on main until PR #15436 lands. Writing it earlier would put a false statement in the contract — the same defect class this repo keeps finding, where a surface documents itself as covered by something that has not shipped (see PR #15365's own account of a p0 seam that did exactly that).

              ⚠️ Whoever takes this: re-read the docblock on the then-current origin/main rather than inheriting the :622 anchor — PR #15436 adds ~52 lines of docblocks to approval-service.ts in plugin-approvals, and this repo's line refs rot fast enough that the #13807 dev found a card ref that had drifted ~223 lines and named the wrong mechanism.

              Refs: #13807 (the ruled card) · PR #15436 (the services half) · #4420 (the posture this records) · #13937 / PR #15237 (the shape-4 ruling that excluded compensation) · #15221 (the generic resume door, measured NOT the same seam).

              Activity

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
                  Skip to content

                  spec: ApprovalDecisionResult's docblock does not record that a stranded decision's four facts ride the ERROR body — execution item 2 of #13807's batch #37 ruling #15439

                  Description

                  @os-warren

                  Blocked-by: #13807

                  Filed by the domain:services execution seat (session 03324ae2-0f5b-5ad2-8a2e-cf4aaff5a909, seat post #6021) as the spec half left unowned by the maintainer's 2026-09-04 ruling on #13807 (director batch #37, verbatim 「同意」 on 1B · 2及, issuecomment-5541861039). Cross-lane request into the domain:spec lane. ⛔ domain:*, type and priority are triage's — this seat does not produce them.

                  What the ruling owes here

                  The ruling's execution list, item 2, verbatim:

                  The ApprovalDecisionResult contract docblock records the declared posture: a finalised decision whose resume fails throws with the decision and run identified, never a half-state; the fields are the published way to read it.

                  The services half is implemented in PR #15436 (draft, head 13b58ed7d, under Clause-② contract review): serviceResume carries status, and a stranded decision's 500-class RESUME_FAILED error body gains finalized, decision, runId and a repairable flag.

                  Why it is not in that PR

                  packages/spec/src/contracts/approval-service.ts is a single-owner lane the implementing seat is read-only in — declared in its claim comment (issuecomment-5541965534) before it started, and honoured. It reported the item rather than editing across the boundary. ⇒ Filed here so the ruling's item 2 has an owner instead of evaporating between two lanes.

                  What is and is not owed

                  ⚠️The contract TYPE needs no new fields. Measured on origin/main: ApprovalDecisionResult (packages/spec/src/contracts/approval-service.ts, ~:622) already declares request, finalized, decision, runId?, resumed? and resumeError?, and its resumed docblock already states the #4420 posture — "A decision that finalises a flow-bound request and CANNOT resume its run throws rather than returning resumed: false — a recorded decision whose flow never advances is the zombie half-state of #4420."

                  The four facts ride the error body, not the success shape. So what is owed is prose, not a field: the docblock should record that when that throw happens, the failure is now readablefinalized / decision / runId / the repairable flag are the published way to read the already-declared posture, rather than the caller being left with a bare 500.

                  ⛔ Do not add the four fields to ApprovalDecisionResult. That would declare a success shape that never carries them.

                  Sequencing

                  Blocked-by: #13807 is deliberate: the sentence describes fields that do not exist on main until PR #15436 lands. Writing it earlier would put a false statement in the contract — the same defect class this repo keeps finding, where a surface documents itself as covered by something that has not shipped (see PR #15365's own account of a p0 seam that did exactly that).

                  ⚠️ Whoever takes this: re-read the docblock on the then-current origin/main rather than inheriting the :622 anchor — PR #15436 adds ~52 lines of docblocks to approval-service.ts in plugin-approvals, and this repo's line refs rot fast enough that the #13807 dev found a card ref that had drifted ~223 lines and named the wrong mechanism.

                  Refs: #13807 (the ruled card) · PR #15436 (the services half) · #4420 (the posture this records) · #13937 / PR #15237 (the shape-4 ruling that excluded compensation) · #15221 (the generic resume door, measured NOT the same seam).

                  Activity

                  Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    Type

                    No type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                      Skip to content

                      spec: ApprovalDecisionResult's docblock does not record that a stranded decision's four facts ride the ERROR body — execution item 2 of #13807's batch #37 ruling #15439

                      Description

                      @os-warren

                      Blocked-by: #13807

                      Filed by the domain:services execution seat (session 03324ae2-0f5b-5ad2-8a2e-cf4aaff5a909, seat post #6021) as the spec half left unowned by the maintainer's 2026-09-04 ruling on #13807 (director batch #37, verbatim 「同意」 on 1B · 2及, issuecomment-5541861039). Cross-lane request into the domain:spec lane. ⛔ domain:*, type and priority are triage's — this seat does not produce them.

                      What the ruling owes here

                      The ruling's execution list, item 2, verbatim:

                      The ApprovalDecisionResult contract docblock records the declared posture: a finalised decision whose resume fails throws with the decision and run identified, never a half-state; the fields are the published way to read it.

                      The services half is implemented in PR #15436 (draft, head 13b58ed7d, under Clause-② contract review): serviceResume carries status, and a stranded decision's 500-class RESUME_FAILED error body gains finalized, decision, runId and a repairable flag.

                      Why it is not in that PR

                      packages/spec/src/contracts/approval-service.ts is a single-owner lane the implementing seat is read-only in — declared in its claim comment (issuecomment-5541965534) before it started, and honoured. It reported the item rather than editing across the boundary. ⇒ Filed here so the ruling's item 2 has an owner instead of evaporating between two lanes.

                      What is and is not owed

                      ⚠️The contract TYPE needs no new fields. Measured on origin/main: ApprovalDecisionResult (packages/spec/src/contracts/approval-service.ts, ~:622) already declares request, finalized, decision, runId?, resumed? and resumeError?, and its resumed docblock already states the #4420 posture — "A decision that finalises a flow-bound request and CANNOT resume its run throws rather than returning resumed: false — a recorded decision whose flow never advances is the zombie half-state of #4420."

                      The four facts ride the error body, not the success shape. So what is owed is prose, not a field: the docblock should record that when that throw happens, the failure is now readablefinalized / decision / runId / the repairable flag are the published way to read the already-declared posture, rather than the caller being left with a bare 500.

                      ⛔ Do not add the four fields to ApprovalDecisionResult. That would declare a success shape that never carries them.

                      Sequencing

                      Blocked-by: #13807 is deliberate: the sentence describes fields that do not exist on main until PR #15436 lands. Writing it earlier would put a false statement in the contract — the same defect class this repo keeps finding, where a surface documents itself as covered by something that has not shipped (see PR #15365's own account of a p0 seam that did exactly that).

                      ⚠️ Whoever takes this: re-read the docblock on the then-current origin/main rather than inheriting the :622 anchor — PR #15436 adds ~52 lines of docblocks to approval-service.ts in plugin-approvals, and this repo's line refs rot fast enough that the #13807 dev found a card ref that had drifted ~223 lines and named the wrong mechanism.

                      Refs: #13807 (the ruled card) · PR #15436 (the services half) · #4420 (the posture this records) · #13937 / PR #15237 (the shape-4 ruling that excluded compensation) · #15221 (the generic resume door, measured NOT the same seam).

                      Activity

                      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        Type

                        No type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                          Skip to content

                          spec: ApprovalDecisionResult's docblock does not record that a stranded decision's four facts ride the ERROR body — execution item 2 of #13807's batch #37 ruling #15439

                          Description

                          @os-warren

                          Blocked-by: #13807

                          Filed by the domain:services execution seat (session 03324ae2-0f5b-5ad2-8a2e-cf4aaff5a909, seat post #6021) as the spec half left unowned by the maintainer's 2026-09-04 ruling on #13807 (director batch #37, verbatim 「同意」 on 1B · 2及, issuecomment-5541861039). Cross-lane request into the domain:spec lane. ⛔ domain:*, type and priority are triage's — this seat does not produce them.

                          What the ruling owes here

                          The ruling's execution list, item 2, verbatim:

                          The ApprovalDecisionResult contract docblock records the declared posture: a finalised decision whose resume fails throws with the decision and run identified, never a half-state; the fields are the published way to read it.

                          The services half is implemented in PR #15436 (draft, head 13b58ed7d, under Clause-② contract review): serviceResume carries status, and a stranded decision's 500-class RESUME_FAILED error body gains finalized, decision, runId and a repairable flag.

                          Why it is not in that PR

                          packages/spec/src/contracts/approval-service.ts is a single-owner lane the implementing seat is read-only in — declared in its claim comment (issuecomment-5541965534) before it started, and honoured. It reported the item rather than editing across the boundary. ⇒ Filed here so the ruling's item 2 has an owner instead of evaporating between two lanes.

                          What is and is not owed

                          ⚠️The contract TYPE needs no new fields. Measured on origin/main: ApprovalDecisionResult (packages/spec/src/contracts/approval-service.ts, ~:622) already declares request, finalized, decision, runId?, resumed? and resumeError?, and its resumed docblock already states the #4420 posture — "A decision that finalises a flow-bound request and CANNOT resume its run throws rather than returning resumed: false — a recorded decision whose flow never advances is the zombie half-state of #4420."

                          The four facts ride the error body, not the success shape. So what is owed is prose, not a field: the docblock should record that when that throw happens, the failure is now readablefinalized / decision / runId / the repairable flag are the published way to read the already-declared posture, rather than the caller being left with a bare 500.

                          ⛔ Do not add the four fields to ApprovalDecisionResult. That would declare a success shape that never carries them.

                          Sequencing

                          Blocked-by: #13807 is deliberate: the sentence describes fields that do not exist on main until PR #15436 lands. Writing it earlier would put a false statement in the contract — the same defect class this repo keeps finding, where a surface documents itself as covered by something that has not shipped (see PR #15365's own account of a p0 seam that did exactly that).

                          ⚠️ Whoever takes this: re-read the docblock on the then-current origin/main rather than inheriting the :622 anchor — PR #15436 adds ~52 lines of docblocks to approval-service.ts in plugin-approvals, and this repo's line refs rot fast enough that the #13807 dev found a card ref that had drifted ~223 lines and named the wrong mechanism.

                          Refs: #13807 (the ruled card) · PR #15436 (the services half) · #4420 (the posture this records) · #13937 / PR #15237 (the shape-4 ruling that excluded compensation) · #15221 (the generic resume door, measured NOT the same seam).

                          Activity

                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            Type

                            No type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                              Skip to content

                              spec: ApprovalDecisionResult's docblock does not record that a stranded decision's four facts ride the ERROR body — execution item 2 of #13807's batch #37 ruling #15439

                              Description

                              @os-warren

                              Blocked-by: #13807

                              Filed by the domain:services execution seat (session 03324ae2-0f5b-5ad2-8a2e-cf4aaff5a909, seat post #6021) as the spec half left unowned by the maintainer's 2026-09-04 ruling on #13807 (director batch #37, verbatim 「同意」 on 1B · 2及, issuecomment-5541861039). Cross-lane request into the domain:spec lane. ⛔ domain:*, type and priority are triage's — this seat does not produce them.

                              What the ruling owes here

                              The ruling's execution list, item 2, verbatim:

                              The ApprovalDecisionResult contract docblock records the declared posture: a finalised decision whose resume fails throws with the decision and run identified, never a half-state; the fields are the published way to read it.

                              The services half is implemented in PR #15436 (draft, head 13b58ed7d, under Clause-② contract review): serviceResume carries status, and a stranded decision's 500-class RESUME_FAILED error body gains finalized, decision, runId and a repairable flag.

                              Why it is not in that PR

                              packages/spec/src/contracts/approval-service.ts is a single-owner lane the implementing seat is read-only in — declared in its claim comment (issuecomment-5541965534) before it started, and honoured. It reported the item rather than editing across the boundary. ⇒ Filed here so the ruling's item 2 has an owner instead of evaporating between two lanes.

                              What is and is not owed

                              ⚠️The contract TYPE needs no new fields. Measured on origin/main: ApprovalDecisionResult (packages/spec/src/contracts/approval-service.ts, ~:622) already declares request, finalized, decision, runId?, resumed? and resumeError?, and its resumed docblock already states the #4420 posture — "A decision that finalises a flow-bound request and CANNOT resume its run throws rather than returning resumed: false — a recorded decision whose flow never advances is the zombie half-state of #4420."

                              The four facts ride the error body, not the success shape. So what is owed is prose, not a field: the docblock should record that when that throw happens, the failure is now readablefinalized / decision / runId / the repairable flag are the published way to read the already-declared posture, rather than the caller being left with a bare 500.

                              ⛔ Do not add the four fields to ApprovalDecisionResult. That would declare a success shape that never carries them.

                              Sequencing

                              Blocked-by: #13807 is deliberate: the sentence describes fields that do not exist on main until PR #15436 lands. Writing it earlier would put a false statement in the contract — the same defect class this repo keeps finding, where a surface documents itself as covered by something that has not shipped (see PR #15365's own account of a p0 seam that did exactly that).

                              ⚠️ Whoever takes this: re-read the docblock on the then-current origin/main rather than inheriting the :622 anchor — PR #15436 adds ~52 lines of docblocks to approval-service.ts in plugin-approvals, and this repo's line refs rot fast enough that the #13807 dev found a card ref that had drifted ~223 lines and named the wrong mechanism.

                              Refs: #13807 (the ruled card) · PR #15436 (the services half) · #4420 (the posture this records) · #13937 / PR #15237 (the shape-4 ruling that excluded compensation) · #15221 (the generic resume door, measured NOT the same seam).

                              Activity

                              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                Type

                                No type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions