You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1959 retired the vestigial feed contracts + protocol + client surface (ADR-0052 §5): IFeedService, feed-api.zod, data/subscription.zod, the FeedProtocol slice of protocol.zod, the getFeedService plumbing in metadata-protocol, and the client.feed.* accessor. service-feed's runtime was already deleted in #1955.
A small discovery/dispatcher feed surface was deliberately left out of #1959 to keep that PR focused, because it is entangled with the comments capability. This issue tracks finishing it.
Scope
packages/spec/src/api/discovery.zod.ts
routes.feed (ApiRoutes) — the feed: '/api/v1/feed' route hint. Removing it also lets packages/client/src/index.ts drop the feed route constant it currently keeps only to satisfy the Record<ApiRouteType, string> type (see the NOTE comment added there in Retire vestigial feed contracts + protocol surface (ADR-0052 §5 follow-up) #1959).
WellKnownCapabilitiesSchema.feed — the boolean capability. Blocker to untangle:comments currently derives from the same deleted service.
packages/spec/src/api/dispatcher.zod.ts
the { prefix: '/api/v1/feed', service: 'data' } dispatcher entry.
feed: registeredServices.has('feed') — since service-feed no longer exists this is permanently false; and
comments: registeredServices.has('feed') — this also keys off the deleted 'feed' service, so comments is now permanently false too. That is a real bug: sys_comment is the canonical comments backend, so the comments capability should reflect that, not the retired feed service. Decide where comments should hang (e.g. always-on, or keyed off the data/sys_comment availability) as part of this cleanup.
Tests to update: packages/spec/src/api/discovery.test.ts, packages/spec/src/api/dispatcher.test.ts, packages/client/src/client.test.ts (capabilities.feed).
Notes
Removing WellKnownCapabilities.feed is a breaking change to the discovery response shape → needs a changeset with a FROM → TO note (capabilities.feed → capabilities.comments / the services registry).
Background
#1959 retired the vestigial feed contracts + protocol + client surface (ADR-0052 §5):
IFeedService,feed-api.zod,data/subscription.zod, theFeedProtocolslice ofprotocol.zod, thegetFeedServiceplumbing inmetadata-protocol, and theclient.feed.*accessor.service-feed's runtime was already deleted in #1955.A small discovery/dispatcher feed surface was deliberately left out of #1959 to keep that PR focused, because it is entangled with the
commentscapability. This issue tracks finishing it.Scope
packages/spec/src/api/discovery.zod.tsroutes.feed(ApiRoutes) — thefeed: '/api/v1/feed'route hint. Removing it also letspackages/client/src/index.tsdrop thefeedroute constant it currently keeps only to satisfy theRecord<ApiRouteType, string>type (see the NOTE comment added there in Retire vestigial feed contracts + protocol surface (ADR-0052 §5 follow-up) #1959).WellKnownCapabilitiesSchema.feed— the boolean capability. Blocker to untangle:commentscurrently derives from the same deleted service.packages/spec/src/api/dispatcher.zod.ts{ prefix: '/api/v1/feed', service: 'data' }dispatcher entry.packages/metadata-protocol/src/protocol.tsgetDiscovery()feed: registeredServices.has('feed')— sinceservice-feedno longer exists this is permanentlyfalse; andcomments: registeredServices.has('feed')— this also keys off the deleted'feed'service, socommentsis now permanentlyfalsetoo. That is a real bug:sys_commentis the canonical comments backend, so thecommentscapability should reflect that, not the retired feed service. Decide wherecommentsshould hang (e.g. always-on, or keyed off the data/sys_commentavailability) as part of this cleanup.packages/spec/src/api/discovery.test.ts,packages/spec/src/api/dispatcher.test.ts,packages/client/src/client.test.ts(capabilities.feed).Notes
WellKnownCapabilities.feedis a breaking change to the discovery response shape → needs a changeset with a FROM → TO note (capabilities.feed→capabilities.comments/ theservicesregistry).gen:schemamay need a manifest key removal for the discovery schema,gen:api-surface,gen:docs) as in Retire vestigial feed contracts + protocol surface (ADR-0052 §5 follow-up) #1959.