Uh oh!
There was an error while loading. Please reload this page.
refactor(audit): retire service-feed; sys_comment canonical (ADR-0052 §5) - #1955
Merged
Conversation
…ckend (ADR-0052 §5) Ends the split-brain. There were two parallel record-collaboration/timeline implementations: sys_comment/sys_activity (DB-backed, default-loaded, the ChatterPanel's actual source of truth) and @objectstack/service-feed (an in-memory, non-durable, UI-unconsumed parallel feed whose nested REST route was never even mounted). Decision (ADR-0052 §5): keep sys_comment as canonical and retire service-feed. - Delete the @objectstack/service-feed package (in-memory adapter, feed_item/ feed_reaction/record_subscription objects, FeedServicePlugin). - Remove the `feed` capability from the CLI CAPABILITY_PROVIDERS resolver and the cli → service-feed dependency; drop it from the changeset package list. - Fix a stale comment in system-file.object.ts. - ADR-0052 §5 records the decision + rationale (durable/UI-wired wins over an unshippable better-model); the unified typed timeline lives on sys_activity. No app depended on service-feed (CLI was the only referencer). The vestigial spec contracts (feed.zod/feed-api.zod/IFeedService) are woven into component.zod/ protocol.zod/objectql and are a separate type-surface cleanup (follow-up). NOTE: the CLI build is red on main from a pre-existing CEL drift in validate-expressions.ts (#1933 area, in-flight in another worktree), unrelated to this change — this commit touches none of those files. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 18 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This was referenced Jun 24, 2026
This was referenced Jul 18, 2026
os-zhuang added a commit
that referenced
this pull request
Jul 18, 2026
… (#3186) ADR-0052 §5 follow-up. `service-feed`'s runtime was deleted in #1955; `sys_comment` / `sys_activity` are the canonical record-collaboration / timeline backend. This removes the dead type surface that still pointed at the deleted runtime — every removed method was already unreachable (feed REST was never mounted → 404; the protocol impl was never wired with a feed service, so requireFeedService() could only throw). No behavior change. Removed: - spec: contracts/feed-service (IFeedService), api/feed-api.zod (FeedApiContracts + request/response types), data/subscription.zod, and the four feed regions of api/protocol.zod (imports, z.function stubs, type re-exports, FeedProtocol interface + mixin) — plus their tests and barrels. - metadata-protocol: the getFeedService ctor param, requireFeedService(), and the 14 feed method implementations. Constructor is now (engine, getServicesRegistry?, environmentId?). - objectql: protocol-feed.test.ts + the positional call-site updates. - client: the feed = {...} SDK accessor and its feed response type imports. Kept: data/feed.zod trimmed to FeedItemType / FeedFilterMode (live UI config for the record activity component). Regenerated api-surface.json, json-schema.manifest.json, and content/docs/references. The residual discovery/dispatcher feed capability surface is tracked as a follow-up (#3180). Claude-Session: https://claude.ai/code/session_01HtN5uPoPnFzkSJ2HcwzgtG Co-authored-by: Claude <noreply@anthropic.com>
os-zhuang added a commit
that referenced
this pull request
Jul 18, 2026
#3204) Follow-up to #1959 / ADR-0052 §5. The feed backend was retired long ago; this removes the last discovery/dispatcher references to it and fixes a real bug in the comments capability. - spec: remove WellKnownCapabilitiesSchema.feed and ApiRoutesSchema.feed (routes.feed); drop the /api/v1/feed entry from DEFAULT_DISPATCHER_ROUTES. - metadata-protocol: getDiscovery() no longer emits the always-false feed service/capability. Bug fix — the `comments` capability keyed off the deleted 'feed' service (permanently false since #1955); it now tracks the sys_comment object (always-on audit slate), so declared === enforced. - client: drop the internal feed route constant (only existed to satisfy the now-removed ApiRoutes.feed type; unused). - tests: update discovery/dispatcher/client capability tests; add positive coverage that comments=true when sys_comment is registered. Comments/activity are served by the generic data API on sys_comment / sys_activity. Regenerated content/docs/references/api/discovery.mdx. Claude-Session: https://claude.ai/code/session_01HtN5uPoPnFzkSJ2HcwzgtG Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ADR-0052 §5 decision:
sys_comment/sys_activityis the canonical record-collaboration + timeline backend;@objectstack/service-feedis retired. Ends the split-brain.There were two parallel implementations of "comments + reactions + timeline + subscriptions on a record":
sys_comment/sys_activity(kept)service-feed(retired)feedwas a verified no-op)/data/{obj}/{id}/feedunmounted (404)Picking the durable, default, UI-wired system reaches "one backend" now at near-zero risk;
service-feed's only edge (a unified typed stream) is obtained onsys_activity(itstypeenum already carries event kinds). Investing inservice-feedwould mean weeks of cross-repo work (DB adapter + REST + ChatterPanel + migration) to duplicate a working system.Changes
@objectstack/service-feedpackage.feedcapability from the CLICAPABILITY_PROVIDERS+ the cli→service-feed dep + the changeset package list.No app depended on it (CLI was the only referencer; HotCRM had it transitively but never
required it; objectui doesn't consume it). The vestigial spec contracts (feed.zod/feed-api.zod/IFeedService) are woven intocomponent.zod/protocol.zod/objectql — a separate type-surface cleanup, tracked as follow-up.The CLI build is already red on
mainfrom a pre-existing CEL drift invalidate-expressions.ts(ExprSchemaHint/ExprValidationResult, #1933 area — in-flight in another worktree). This PR touches none of those files (onlyserve.ts/package.json/changeset+ the deleted package);serve.tscompiles cleanly. The red is not introduced here and clears when the CEL fix lands.🤖 Generated with Claude Code