Skip to content

Stale transitional NOTE in packages/apps/account/src/index.ts — says the package is "NOT yet wired into the dev/serve plugin set" but serve.ts loads it #9696

Description

@os-elon

The header comment in packages/apps/account/src/index.ts still describes a transitional state that has since been completed. It contradicts the boot path in the same repo.

The stale claim

packages/apps/account/src/index.ts, lines 16-19 on origin/main (f6c71ea):

 * NOTE (transitional): `ACCOUNT_APP` is still imported from
* `@objectstack/platform-objects/apps`, and this package is NOT yet wired into
* the dev/serve plugin set — that boot-path switch lands separately so it can
* be verified against a live `os dev` boot.

It is wired

packages/cli/src/commands/serve.ts, lines 2236-2239 on the same revision, loads it in the ADR-0048 platform-app loop:

for(const[appPkg,factory]of[['@objectstack/setup','createSetupAppPlugin'],['@objectstack/account','createAccountAppPlugin'],]asconst){

And the "verified against a live os dev boot" the comment defers to has already happened: a @objectstack/cli@17.0.0 boot on a clean home lists @objectstack/account among the 30 loaded plugins (measured transcript in objectstack-ai/objectos#94, comment 5329804967).

Only the second half of the NOTE is stale. The first half still holds — ACCOUNT_APP is genuinely still imported from @objectstack/platform-objects/apps — so this is a wording fix to the wiring clause, not a deletion of the whole block.

Why it is worth a card

The comment is the first thing read in the file that defines the Account app package, and it tells the reader the boot-path switch has not landed. That is how a reader concludes the app is unreachable — which is exactly the wrong conclusion now that /apps/account is the account surface.

Provenance

Found while ruling on the retired /_account/ HTTP surface for the docs: objectstack-ai/objectos#108. Reported there as an out-of-scope finding; the fix lands in this repo, so the card is filed here. Unassigned.


Generated by Claude Code

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions