Skip to content

docs(account): fix stale transitional wiring NOTE in index.ts - #10020

Merged
os-warren merged 1 commit into
mainfrom
claude/issue-9696-account-app-stale-wiring-note
Aug 19, 2026
Merged

docs(account): fix stale transitional wiring NOTE in index.ts#10020
os-warren merged 1 commit into
mainfrom
claude/issue-9696-account-app-stale-wiring-note

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#9696

What

packages/apps/account/src/index.ts carried a transitional header NOTE claiming
the package was "NOT yet wired into the dev/serve plugin set." That boot-path
switch has already landed — this PR rewrites the stale half of the NOTE to
match reality, comment-only.

Evidence

  • packages/cli/src/commands/serve.ts:2293-2295 loads @objectstack/account
    in the ADR-0048 platform-app loop:
    for(const[appPkg,factory]of[['@objectstack/setup','createSetupAppPlugin'],['@objectstack/account','createAccountAppPlugin'],]asconst){
  • The boot path has been verified against a live os dev boot: a
    @objectstack/cli@17.0.0 boot on a clean home lists @objectstack/account
    among the 30 loaded plugins — measured transcript in
    quickstart.mdx sample os start output does not match what CLI 17.0.0 prints, and the plugin count is wrong objectos#94, comment 5329804967.
  • The other half of the NOTE — ACCOUNT_APP is still imported from
    @objectstack/platform-objects/apps — is still true and is kept verbatim.

Scope

Comment-only diff, one file, no executable line changed:

 * NOTE (transitional): `ACCOUNT_APP` is still imported from
-* `@objectstack/platform-objects/apps`, and this package is NOT yet wired into
-* the dev/serve plugin set — that boot-path switch lands separately so it can
-* be verified against a live `os dev` boot.
+* `@objectstack/platform-objects/apps`. The package IS wired into the
+* dev/serve plugin set — `packages/cli/src/commands/serve.ts` loads it via
+* the ADR-0048 platform-app loop (`['@objectstack/account',
+* 'createAccountAppPlugin']`) — and that boot path has been verified against
+* a live `os dev` boot (transcript: objectstack-ai/objectos#94, comment
+* 5329804967).

Changeset

Comment-only change in a published package — no user-visible behavior change.
Rationale for skip-changeset label (this repo's real mechanism; see PR #9918,
PR #10017 for worked examples), applied to this PR rather than an empty
changeset file.

Tests

  • pnpm --filter @objectstack/account typecheck — pass, unchanged from main
    (comment-only diff).
  • pnpm --filter @objectstack/account test — package has no test script
    (build, typecheck only); nothing to run.
  • Named gates re-derived via node scripts/pm/dispatch-gates.mjs against the
    actual diff (4 matched: check:slot-lookup, check:test-source-alias,
    check:type-source-resolution, check-affected-docs.mjs) — all pass, see
    dev report for verdict lines.
  • Ablation: not applicable — nothing executable changed.

Commit under review: 2705d5f8a.

Generated by Claude Code


Generated by Claude Code

The header comment claimed the account app was "NOT yet wired into the
dev/serve plugin set" — that boot-path switch has already landed.
serve.ts loads it in the ADR-0048 platform-app loop
(['@objectstack/account', 'createAccountAppPlugin']), and the boot
path has been verified against a live `os dev` boot (transcript:
objectstack-ai/objectos#94, comment 5329804967). Rewrite the stale
clause and keep the ACCOUNT_APP import sentence, which is still true.
Comment-only change, no executable line touched.
Fixes#9696
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PnJHU45vPJj5UQrxe946Bx
@os-warrenos-warren added skip-changeset PR has no user-facing published change; bypasses the changeset gate and removed size/xs labels Aug 19, 2026 — with Claude
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them. ✅

What this run could not see

Coarse fallback — 1 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 43cd348a2f0b91ea1035c4c055fbed160bfb4acapackageMentionDocs.

Which tree this was computed on

This run read content/docs from 436a08e075551d385c30d9f9bb9077426a079552 — the merge of head 2705d5f8a66932a35abdcfe1f48ae44e112ffda4 into base 43cd348a2f0b91ea1035c4c055fbed160bfb4aca, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 436a08e075551d385c30d9f9bb9077426a079552 && git checkout 436a08e075551d385c30d9f9bb9077426a079552
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 43cd348a2f0b91ea1035c4c055fbed160bfb4aca 2705d5f8a66932a35abdcfe1f48ae44e112ffda4 && git checkout -B drift-repro 43cd348a2f0b91ea1035c4c055fbed160bfb4aca && git merge --no-ff 2705d5f8a66932a35abdcfe1f48ae44e112ffda4
node scripts/docs-audit/affected-docs.mjs --json 43cd348a2f0b91ea1035c4c055fbed160bfb4aca

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@os-warren
os-warren marked this pull request as ready for review August 19, 2026 15:46
@os-warren
os-warren added this pull request to the merge queueAug 19, 2026
Merged via the queue into main with commit f8afa0bAug 19, 2026
32 checks passed
@os-warren
os-warren deleted the claude/issue-9696-account-app-stale-wiring-note branch August 19, 2026 15:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants

@os-warren@claude