Uh oh!
There was an error while loading. Please reload this page.
fix(spec): re-point dead #6590 citations to the live v18 tracker #11509 - #11612
Merged
Conversation
Two comment-prose sites in component.zod.ts anchored a v18 decision (retire the flat object/filter data-binding family, dataSource as the single data-binding door) to a tracking issue number that now 404s (deleted / transferred / converted). The triage seat filed a fresh tracker as the re-anchor; this points both citations at it. Citations only -- the zod shapes are byte-identical, comment prose is the entire diff. Confirmed via check:generated (14/14 artifacts still up to date) that neither site is inside a .describe() string, so no generated docs need regeneration.
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
os-steve
marked this pull request as ready for review
August 24, 2026 08:47
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#11269
Two comment-prose sites in
packages/spec/src/ui/component.zod.tsanchored a v18 direction-B decision (retire the flatobject/filterdata-binding family,dataSourceas the single data-binding door) to#6590, which now 404s (deleted/transferred/converted — undeterminable, per #11269's measurement). The triage seat filed #11509 as the resolvable re-anchor tracker. This PR re-points both citations.What changed
Citations only — the zod shapes are byte-identical, the two-line diff is entirely comment prose:
component.zod.ts:137—// v18 as #6590 — not rejected.→// v18 as #11509 — not rejected.component.zod.ts:1896(now:1919after rebasing past docs(spec): visibleWhen's describe states the bound roots per ADR-0068 (was three of nine) #11600, below) —tracked as #6590 for v18→tracked as #11509 for v18No breadcrumb (
re-anchor of deleted #6590) added to either site: the swapped sentence is fully true on its own (#11509is the v18 direction-B tracker), and the historical link back to #6590 is already preserved at the issue level — #11509's own title and body record it as "re-anchor of the deleted #6590 tracker".Repo-wide under
packages/spec/src, grep for6590found exactly these two sites (matching #11269's measurement); zero remain after the edit. The only other repo hit ispackages/spec/CHANGELOG.md(historical release-note text, generated/append-only — correctly left untouched).Neither site is inside a
.describe()stringLine 137 is a
//line comment inside a top-level architecture note (not attached to any schema). Line 1896 is inside a/** */JSDoc block that precedes an export but is plain source comment, not a.describe(...)call —build-docs.tsextracts descriptions from the runtime zod schema's.description(populated only by.describe()), and has no JSDoc-scraping path. Confirmed empirically:check:generatedreports all 14 generated artifacts still up to date after the edit (zero regeneration diff), so no.mdxreference doc needed touching.The #9249 landing note
#9249's triage ruling assigned its PM a landing-time step: "leave the subsumption note on hold #6590" — undeliverable to a 404. That note is delivered as a comment on #11509 (the resolvable home), not here — out of this PR's file surface: #11509 (comment)
Changeset:
skip-changeset, not a changeset fileThe repo's convention for comment-only spec diffs picks the changeset route by whether the diff touches a
.describe()string: #11215/PR #11593 used a patch changeset because its diff regenerated docs. This diff does not —check:generatedconfirms zero doc regeneration (see above) — so it falls in the "pure comment diff" carve-out and uses theskip-changesetlabel (#11416/#11403 precedent) instead. Label applied at PR creation via the additive labels endpoint per AGENTS.md; read back below.Verification
Gate list derived mechanically:
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack(provenance: this checkout at5fba383c64). All commands' exit codes captured before any pipe; quotes below are each gate's own printed verdict line.pnpm --filter @objectstack/spec build— exit 0.pnpm --filter @objectstack/spec check:generated—✓ All 14 generated artifacts are up to date.pnpm --filter @objectstack/spec test—Test Files 420 passed (420)/Tests 11213 passed (11213).pnpm --filter @objectstack/spec typecheck—check:test-typecheck: OK.check:cross-package-test-inputs,check:merge-driver,check:published-files,check:slot-lookup,check:spec-parsed-alias,check:test-source-alias,check:type-source-resolution,check:doc-formula-expressions(lint),check:empty-state,check:liveness,check:strictness-ledger,check:variant-docs(spec-liveness-check family),check-ci-filter-parity,check-cross-package-test-inputs,check-plugin-teardown-shape,check-affected-docs.check:dev-prereqs— not cleared locally, by design. It fails on a workspace-build precondition (this worktree has only@objectstack/specbuilt), not on anything in this diff; PR docs(spec): visibleWhen's describe states the bound roots per ADR-0068 (was three of nine) #11600 (same lane, landed just before this one) treated it identically: "a repo-scale run CI performs before its gates," not runnable meaningfully in a single-package worktree.pnpm lintis CI-owned, not run locally; no lint-rule surface touched by a two-line comment diff.Sibling-PR rebase
This branch shares its file (
component.zod.ts) with PR #11600 (PageTabsProps.visibleWhenregion, lines ~662–700), a disjoint hunk. Per the PM's guidance this PR was held un-opened until #11600 merged (644ad5043e, confirmed via polling before this branch was pushed), then rebased onto the neworigin/main— a clean rebase, no conflicts, as expected from the disjoint hunks. The rebase shifted the second citation site from:1896to:1919(+23 lines from #11600's own docblock expansion above it); line 137 is unaffected (before #11600's insertion point).build/check:generated/test/typecheckwere all re-run on the rebased head (5fba383c64) and are the results quoted above — not carried over from the pre-rebase run.Fences honored
content/docs/releases/: untouched.check:generated.#11509touched by exactly one comment (the delivered landing note above), nothing else.Generated by Claude Code