Uh oh!
There was an error while loading. Please reload this page.
Fix login page vertical centering - #1207
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/7dafd954-6639-450b-adda-2e6d7080a244 Co-authored-by: os-zhuang <277994282+os-zhuang@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
marked this pull request as ready for review
April 21, 2026 15:33
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login and register pages were not vertically centered because the unauthenticated layout lacked a container with viewport height.
Changes
<div className="flex min-h-screen w-full">in__root.tsx:160flex flex-1 items-center justify-center, which now properly stretches to fill the viewportThis matches the pattern used for loading states elsewhere in the root layout.