Uh oh!
There was an error while loading. Please reload this page.
fix(devx): lower plugin-approvals TEST_DEBT surplus, repoint dead #6376 advisory - #12110
Merged
Merged
Conversation
… advisory (#11497) Re-measured on 0e0bf80: plugin-approvals' TEST_DEBT surplus is real (348 recorded / 347 measured, matching #11497's and #11525's readings) and is now lowered via `--lower`, with its note re-tallied by hand -- the -1 is a fully attributable single-error retirement (TS2353, all seven other codes unchanged to the unit). runtime's surplus is gone: it now measures exactly 227, so that row of the card is premise-false and is left alone. Repoints the gate's advisory line (and a stale design comment) away from #6376, which is closed/completed -- it was the design discussion that produced this surplus-reporting + `--lower` mechanism, not a standing tracker for individual surpluses, and following it now dead-ends (as #11525 measured). No successor tracker is named because none is needed: the mechanism itself (this advisory + `--lower`) is the remedy. Fixes#11497
yinlianghui
marked this pull request as ready for review
August 25, 2026 09:30
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#11497
What this does
Re-measured
check:type-check-debt --re-measureonorigin/main=0e0bf8049(workspace closure built first, exactly aslint.ymldoes:pnpm exec turbo run build --filter='./packages/*' --filter='./packages/*/*', 70/70 tasks, ~5m34s).Measured values — both re-derived, not taken from the card:
@objectstack/plugin-approvals@objectstack/runtimeplugin-approvalscorroborates both the card's own measurement and the independent one from #11525 this morning.runtimedoes not — the re-measure (run twice, before and after--lower, both at227) shows no surplus at all: whatever produced the −1 three days ago is no longer present, so that row of the card is premise-false. Nothing was touched on that entry.plugin-authwas correctly left alone, per the card's own scope exclusion and the claim comment's confirmation that its −12 is already resolved (mainrecords 97, note reads "RE-TALLIED from tsc at the 97 below (#10615)").The lowering, and the note re-tally
--lowerwroteerrors: 348 → 347forplugin-approvals. Its note uses aTSxxxx xN-style composition (not thecode-tier/config-tier/noisephrasingcompositionAtreconciliation reads), so the tool correctly did not attach acompositionAtfield — and the note was re-tallied by hand instead, per the card's clause 4. I reproduced the exact 347-error tsc run standalone (same generatedtsconfig.debt-remeasure.jsonshaperemeasureProjectbuilds) and diffed error-code counts against the recorded 348 composition: all seven other codes are unchanged to the unit (TS2339 x296, TS2550 x20, TS2345 x16, TS18048 x10, TS2554 x2, TS1470 x1, TS2352 x1, TS6133 x1); the soleTS2353singleton is gone. That is a fully attributable single-error retirement, not a rescale, and the note now says so.The advisory line
The gate's
--re-measuresummary printed(${SURPLUS_ISSUE})— i.e. #6376 — on every surplus report, and #6376 isclosed/completed(2026-08-08, PR #6510). Read #6376 itself: it was the design discussion that produced this exact mechanism (the surplus print +--lower), not a standing tracker meant to stay open for future instances — and per the claim comment, a dev on #11525 already followed that link to a dead end and filed nothing.There is no live successor issue to repoint it to (checked the open
tooling-labeled backlog — nothing else serves as a "class tracker" for ratchet surplus), and none is needed: the mechanism itself is the remedy — a surplus this line reports is closed by running--lower, not by reading a card. So the fix drops the dead issue reference from the printed advisory and explains why in an adjacent comment, and fixes the one design-rationale comment nearby that still called the enforcement question "#6376's open question" (it isn't open — #6376 closed having decided not to enforce, report +--loweronly).Gates run (this repo,
dispatch-gates.mjs --repo objectstack-ai/objectstackat this branch's head)9 families derived, all green at the final commit (
6c80b8256):check:agent-test-spelling·check:cross-package-test-inputs·check:entry-guard·check:parse-guard·check:pnpm-filter-targets·check:type-check-coverage(self-test + structural) ·check:type-check-debt(self-test +--re-measure, surplus: none) ·check-ci-filter-parity.mjs·check-cross-package-test-inputs.mjs. Also rancheck:nul-bytes(any edit) and the gate's own--self-test(47+65+29+28+19 cases, all hold).Bare-root obligation: not applicable — this PR edits ledger data and prose inside an existing gate, assembling no new scan root.
Changeset:
skip-changeset— root isscripts/, nothing published changes. The additive labels REST endpoint was unreachable from this session (proxy declined directapi.github.comcalls), so the label was applied via the documented fallback instead: read current labels (size/s), union withskip-changeset, whole-set write, then read back — confirmed present (size/s,skip-changeset) as of this PR body's last edit.Generated by Claude Code