Uh oh!
There was an error while loading. Please reload this page.
Restore lockstep release: add missing service-cluster packages to changesets fixed + CI guard - #1343
Merged
Merged
Conversation
Copilotcreated this pull request from a session on behalf of os-zhuangMay 25, 2026 09:28 View session
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hotlong
approved these changes
May 25, 2026
hotlong
marked this pull request as ready for review
May 25, 2026 09:29
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@objectstack/service-clusterand@objectstack/service-cluster-rediswere absent fromfixedin.changeset/config.json, so the last release bumped them out of lockstep with the rest of@objectstack/*. Nothing prevented this drift from happening again the next time a public package is added.Fix
fixedgroup; the workspace now has 60/60 public packages covered.Guard against recurrence
scripts/check-changeset-fixed.mjs— zero-dependency validator. Readspnpm-workspace.yaml, enumerates every non-privatepackage.json, and diffs againstfixed. Reports both missing names (new package not enrolled) and stale names (renamed/deleted package still listed). Non-zero exit on drift.package.json— exposed aspnpm run lint:changesetfor local use..github/workflows/validate-deps.yml— runs the validator on PRs touching**/package.json,pnpm-workspace.yaml,.changeset/config.json, or the script. Fast feedback before merge..github/workflows/release.yml— runs the validator beforepnpm run build/changeset publish. Final gate so a release cannot ship while the group is out of sync.CHANGELOG.md— entry under[Unreleased].Why a custom script and not
@changesets/*Changesets has no built-in "all public packages must be in a fixed/linked group" lint. The script is ~140 LOC, has no runtime deps, and runs before
pnpm install, so it adds no dependency surface and works on a cold CI runner.Failure output (verified locally)