Skip to content

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES - #13728

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry
Aug 31, 2026
Merged

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES#13728
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13695

SEARCHABLE_ENUM_TYPES in packages/spec/src/data/search-fields.ts declared
new Set(['select', 'status']). 'status' is not — and per git log on
field.zod.ts and a repo-wide grep, has never been planned to become — a
member of the 49-value FieldType enum, so the entry could never match a
real field's type. Dropped it, leaving new Set(['select']).

Premise, verified mechanically (not read) on this checkout:

FieldType member count: 49
'status' in FieldType: false
'select' in FieldType: true

No in-flight plan for a status field type: no hits in field.zod.ts's
git log, no mention in packages/spec/src or docs//content/docs/.
Clause-②: no accept/reject behaviour changes — 'status' never matched
anything, so every resolution SEARCHABLE_ENUM_TYPES feeds
(autoDefaultFields, the #4254 REST ingress gate, the linter) is
byte-identical for every real object in the tree.

Pin added, scoped narrowly. The existing [#6934] pins in
search-fields.test.ts check the four search vocabularies
(SEARCHABLE_TEXTUAL_TYPES, SEARCHABLE_ENUM_TYPES, SEARCH_AUTO_EXCLUDED_TYPES,
SEARCH_VIRTUAL_TYPES) against each other for pairwise disjointness, but
never against FieldType itself — so a pure ghost member (matching nothing,
as opposed to overlapping something) passed every one of them silently. This
adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES ⊆ FieldType.

Why the pin stops at this one set. Running the same membership check
against all four vocabularies during verification turned up 4 more ghosts in
SEARCH_AUTO_EXCLUDED_TYPES ('object', 'grid', 'geometry',
'encrypted' — none is a FieldType member either). That's a larger, separate
finding — two of the four names read as plausible stale spellings of real
types (geometrylocation, encryptedsecret) rather than pure dead
code, so it needs its own triage rather than a drop-on-sight fix riding this
PR. Filed as #13716; left untouched here per clause-② guidance (a subset pin
that turns something else red is a stop-and-report, not a widen-the-fix).

Tests

  • pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/data/search-fields.test.ts — 25 passed (was 22; the 3 new assertions ran)
  • pnpm --filter @objectstack/spec test — 444 test files / 11882 tests passed (post-merge-with-main count)
  • pnpm --filter @objectstack/spec typecheck — clean (tsc --noEmit + scripts + test-layer typecheck)
  • pnpm --filter @objectstack/spec check:generated — all 14 generated artifacts up to date (re-verified after merging origin/main, which touched packages/spec on its own side too)
  • node scripts/pm/dispatch-gates.mjs (42 path-matched + 6 convention-triggered = 46 local gate commands, re-derived after the merge) — 40 passed; 6 NOT MEASURED, all "prerequisite not met" (never a red caused by this diff):
    • check:dev-prereqs, check:dual-build-cjs-loads, check:type-check-debt, check:doc-formula-expressions — each refuses outright on an unbuilt 79-package workspace dist/ closure (their own error text names this and says so explicitly); CI builds that closure as part of the required jobs.
    • check:test-completeness.mjs — its own no-argument branch: it grades a saved turbo run test log, and produces no log itself.
    • pm/check-half-states.mjs — needs a repo-scoped GitHub REST read, which this container's egress proxy 403s (confirmed by hand: curl against api.github.com/repos/.../issues/13695 from this container returns the same 403 before any of this ran); its own text names this exact container class as the affected one.
  • Ran at commit 80d2fb96.

Generated by Claude Code


Generated by Claude Code

'status' is not a member of the 49-value FieldType enum, so it could
never match a real field type — dead vocabulary in search-fields.ts
(verified mechanically: FieldType has 49 members, 'status' is absent,
'select' is present; no in-flight plan for a status field type found).
Adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES stays a real
FieldType subset, scoped to that one set — it closes the probe gap
that let this sit unnoticed (the existing [#6934] pins check the
search vocabularies against each other, never against FieldType
itself). A parallel ghost-member finding in SEARCH_AUTO_EXCLUDED_TYPES
is out of scope for this fix and filed separately.
Includes a patch changeset for @objectstack/spec.
_Generated by [Claude Code](https://claude.ai/code)_
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53packageMentionDocs.

Which tree this was computed on

This run read content/docs from d3dc761311d61ec556eefe2a25872451534605e4 — the merge of head 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 into base 8fb2d295c70dd8c560451a8c5fb22e608de5fe53, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin d3dc761311d61ec556eefe2a25872451534605e4 && git checkout d3dc761311d61ec556eefe2a25872451534605e4
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 && git checkout -B drift-repro 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 && git merge --no-ff 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46
node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 09:06
@os-warren
os-warren enabled auto-merge August 31, 2026 09:06
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit cff17afAug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13695-searchable-enum-dead-entry branch August 31, 2026 09:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/steststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] SEARCHABLE_ENUM_TYPES contains 'status', which is not a member of the 49-value FieldType enum — dead vocabulary entry in search-fields.ts

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES by os-warren · Pull Request #13728 · objectstack-ai/objectstack · GitHub
Skip to content

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES - #13728

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry
Aug 31, 2026
Merged

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES#13728
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13695

SEARCHABLE_ENUM_TYPES in packages/spec/src/data/search-fields.ts declared
new Set(['select', 'status']). 'status' is not — and per git log on
field.zod.ts and a repo-wide grep, has never been planned to become — a
member of the 49-value FieldType enum, so the entry could never match a
real field's type. Dropped it, leaving new Set(['select']).

Premise, verified mechanically (not read) on this checkout:

FieldType member count: 49
'status' in FieldType: false
'select' in FieldType: true

No in-flight plan for a status field type: no hits in field.zod.ts's
git log, no mention in packages/spec/src or docs//content/docs/.
Clause-②: no accept/reject behaviour changes — 'status' never matched
anything, so every resolution SEARCHABLE_ENUM_TYPES feeds
(autoDefaultFields, the #4254 REST ingress gate, the linter) is
byte-identical for every real object in the tree.

Pin added, scoped narrowly. The existing [#6934] pins in
search-fields.test.ts check the four search vocabularies
(SEARCHABLE_TEXTUAL_TYPES, SEARCHABLE_ENUM_TYPES, SEARCH_AUTO_EXCLUDED_TYPES,
SEARCH_VIRTUAL_TYPES) against each other for pairwise disjointness, but
never against FieldType itself — so a pure ghost member (matching nothing,
as opposed to overlapping something) passed every one of them silently. This
adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES ⊆ FieldType.

Why the pin stops at this one set. Running the same membership check
against all four vocabularies during verification turned up 4 more ghosts in
SEARCH_AUTO_EXCLUDED_TYPES ('object', 'grid', 'geometry',
'encrypted' — none is a FieldType member either). That's a larger, separate
finding — two of the four names read as plausible stale spellings of real
types (geometrylocation, encryptedsecret) rather than pure dead
code, so it needs its own triage rather than a drop-on-sight fix riding this
PR. Filed as #13716; left untouched here per clause-② guidance (a subset pin
that turns something else red is a stop-and-report, not a widen-the-fix).

Tests

  • pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/data/search-fields.test.ts — 25 passed (was 22; the 3 new assertions ran)
  • pnpm --filter @objectstack/spec test — 444 test files / 11882 tests passed (post-merge-with-main count)
  • pnpm --filter @objectstack/spec typecheck — clean (tsc --noEmit + scripts + test-layer typecheck)
  • pnpm --filter @objectstack/spec check:generated — all 14 generated artifacts up to date (re-verified after merging origin/main, which touched packages/spec on its own side too)
  • node scripts/pm/dispatch-gates.mjs (42 path-matched + 6 convention-triggered = 46 local gate commands, re-derived after the merge) — 40 passed; 6 NOT MEASURED, all "prerequisite not met" (never a red caused by this diff):
    • check:dev-prereqs, check:dual-build-cjs-loads, check:type-check-debt, check:doc-formula-expressions — each refuses outright on an unbuilt 79-package workspace dist/ closure (their own error text names this and says so explicitly); CI builds that closure as part of the required jobs.
    • check:test-completeness.mjs — its own no-argument branch: it grades a saved turbo run test log, and produces no log itself.
    • pm/check-half-states.mjs — needs a repo-scoped GitHub REST read, which this container's egress proxy 403s (confirmed by hand: curl against api.github.com/repos/.../issues/13695 from this container returns the same 403 before any of this ran); its own text names this exact container class as the affected one.
  • Ran at commit 80d2fb96.

Generated by Claude Code


Generated by Claude Code

'status' is not a member of the 49-value FieldType enum, so it could
never match a real field type — dead vocabulary in search-fields.ts
(verified mechanically: FieldType has 49 members, 'status' is absent,
'select' is present; no in-flight plan for a status field type found).
Adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES stays a real
FieldType subset, scoped to that one set — it closes the probe gap
that let this sit unnoticed (the existing [#6934] pins check the
search vocabularies against each other, never against FieldType
itself). A parallel ghost-member finding in SEARCH_AUTO_EXCLUDED_TYPES
is out of scope for this fix and filed separately.
Includes a patch changeset for @objectstack/spec.
_Generated by [Claude Code](https://claude.ai/code)_
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53packageMentionDocs.

Which tree this was computed on

This run read content/docs from d3dc761311d61ec556eefe2a25872451534605e4 — the merge of head 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 into base 8fb2d295c70dd8c560451a8c5fb22e608de5fe53, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin d3dc761311d61ec556eefe2a25872451534605e4 && git checkout d3dc761311d61ec556eefe2a25872451534605e4
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 && git checkout -B drift-repro 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 && git merge --no-ff 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46
node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 09:06
@os-warren
os-warren enabled auto-merge August 31, 2026 09:06
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit cff17afAug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13695-searchable-enum-dead-entry branch August 31, 2026 09:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/steststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] SEARCHABLE_ENUM_TYPES contains 'status', which is not a member of the 49-value FieldType enum — dead vocabulary entry in search-fields.ts

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES by os-warren · Pull Request #13728 · objectstack-ai/objectstack · GitHub
Skip to content

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES - #13728

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry
Aug 31, 2026
Merged

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES#13728
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13695

SEARCHABLE_ENUM_TYPES in packages/spec/src/data/search-fields.ts declared
new Set(['select', 'status']). 'status' is not — and per git log on
field.zod.ts and a repo-wide grep, has never been planned to become — a
member of the 49-value FieldType enum, so the entry could never match a
real field's type. Dropped it, leaving new Set(['select']).

Premise, verified mechanically (not read) on this checkout:

FieldType member count: 49
'status' in FieldType: false
'select' in FieldType: true

No in-flight plan for a status field type: no hits in field.zod.ts's
git log, no mention in packages/spec/src or docs//content/docs/.
Clause-②: no accept/reject behaviour changes — 'status' never matched
anything, so every resolution SEARCHABLE_ENUM_TYPES feeds
(autoDefaultFields, the #4254 REST ingress gate, the linter) is
byte-identical for every real object in the tree.

Pin added, scoped narrowly. The existing [#6934] pins in
search-fields.test.ts check the four search vocabularies
(SEARCHABLE_TEXTUAL_TYPES, SEARCHABLE_ENUM_TYPES, SEARCH_AUTO_EXCLUDED_TYPES,
SEARCH_VIRTUAL_TYPES) against each other for pairwise disjointness, but
never against FieldType itself — so a pure ghost member (matching nothing,
as opposed to overlapping something) passed every one of them silently. This
adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES ⊆ FieldType.

Why the pin stops at this one set. Running the same membership check
against all four vocabularies during verification turned up 4 more ghosts in
SEARCH_AUTO_EXCLUDED_TYPES ('object', 'grid', 'geometry',
'encrypted' — none is a FieldType member either). That's a larger, separate
finding — two of the four names read as plausible stale spellings of real
types (geometrylocation, encryptedsecret) rather than pure dead
code, so it needs its own triage rather than a drop-on-sight fix riding this
PR. Filed as #13716; left untouched here per clause-② guidance (a subset pin
that turns something else red is a stop-and-report, not a widen-the-fix).

Tests

  • pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/data/search-fields.test.ts — 25 passed (was 22; the 3 new assertions ran)
  • pnpm --filter @objectstack/spec test — 444 test files / 11882 tests passed (post-merge-with-main count)
  • pnpm --filter @objectstack/spec typecheck — clean (tsc --noEmit + scripts + test-layer typecheck)
  • pnpm --filter @objectstack/spec check:generated — all 14 generated artifacts up to date (re-verified after merging origin/main, which touched packages/spec on its own side too)
  • node scripts/pm/dispatch-gates.mjs (42 path-matched + 6 convention-triggered = 46 local gate commands, re-derived after the merge) — 40 passed; 6 NOT MEASURED, all "prerequisite not met" (never a red caused by this diff):
    • check:dev-prereqs, check:dual-build-cjs-loads, check:type-check-debt, check:doc-formula-expressions — each refuses outright on an unbuilt 79-package workspace dist/ closure (their own error text names this and says so explicitly); CI builds that closure as part of the required jobs.
    • check:test-completeness.mjs — its own no-argument branch: it grades a saved turbo run test log, and produces no log itself.
    • pm/check-half-states.mjs — needs a repo-scoped GitHub REST read, which this container's egress proxy 403s (confirmed by hand: curl against api.github.com/repos/.../issues/13695 from this container returns the same 403 before any of this ran); its own text names this exact container class as the affected one.
  • Ran at commit 80d2fb96.

Generated by Claude Code


Generated by Claude Code

'status' is not a member of the 49-value FieldType enum, so it could
never match a real field type — dead vocabulary in search-fields.ts
(verified mechanically: FieldType has 49 members, 'status' is absent,
'select' is present; no in-flight plan for a status field type found).
Adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES stays a real
FieldType subset, scoped to that one set — it closes the probe gap
that let this sit unnoticed (the existing [#6934] pins check the
search vocabularies against each other, never against FieldType
itself). A parallel ghost-member finding in SEARCH_AUTO_EXCLUDED_TYPES
is out of scope for this fix and filed separately.
Includes a patch changeset for @objectstack/spec.
_Generated by [Claude Code](https://claude.ai/code)_
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53packageMentionDocs.

Which tree this was computed on

This run read content/docs from d3dc761311d61ec556eefe2a25872451534605e4 — the merge of head 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 into base 8fb2d295c70dd8c560451a8c5fb22e608de5fe53, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin d3dc761311d61ec556eefe2a25872451534605e4 && git checkout d3dc761311d61ec556eefe2a25872451534605e4
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 && git checkout -B drift-repro 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 && git merge --no-ff 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46
node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 09:06
@os-warren
os-warren enabled auto-merge August 31, 2026 09:06
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit cff17afAug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13695-searchable-enum-dead-entry branch August 31, 2026 09:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/steststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] SEARCHABLE_ENUM_TYPES contains 'status', which is not a member of the 49-value FieldType enum — dead vocabulary entry in search-fields.ts

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES by os-warren · Pull Request #13728 · objectstack-ai/objectstack · GitHub
Skip to content

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES - #13728

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry
Aug 31, 2026
Merged

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES#13728
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13695

SEARCHABLE_ENUM_TYPES in packages/spec/src/data/search-fields.ts declared
new Set(['select', 'status']). 'status' is not — and per git log on
field.zod.ts and a repo-wide grep, has never been planned to become — a
member of the 49-value FieldType enum, so the entry could never match a
real field's type. Dropped it, leaving new Set(['select']).

Premise, verified mechanically (not read) on this checkout:

FieldType member count: 49
'status' in FieldType: false
'select' in FieldType: true

No in-flight plan for a status field type: no hits in field.zod.ts's
git log, no mention in packages/spec/src or docs//content/docs/.
Clause-②: no accept/reject behaviour changes — 'status' never matched
anything, so every resolution SEARCHABLE_ENUM_TYPES feeds
(autoDefaultFields, the #4254 REST ingress gate, the linter) is
byte-identical for every real object in the tree.

Pin added, scoped narrowly. The existing [#6934] pins in
search-fields.test.ts check the four search vocabularies
(SEARCHABLE_TEXTUAL_TYPES, SEARCHABLE_ENUM_TYPES, SEARCH_AUTO_EXCLUDED_TYPES,
SEARCH_VIRTUAL_TYPES) against each other for pairwise disjointness, but
never against FieldType itself — so a pure ghost member (matching nothing,
as opposed to overlapping something) passed every one of them silently. This
adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES ⊆ FieldType.

Why the pin stops at this one set. Running the same membership check
against all four vocabularies during verification turned up 4 more ghosts in
SEARCH_AUTO_EXCLUDED_TYPES ('object', 'grid', 'geometry',
'encrypted' — none is a FieldType member either). That's a larger, separate
finding — two of the four names read as plausible stale spellings of real
types (geometrylocation, encryptedsecret) rather than pure dead
code, so it needs its own triage rather than a drop-on-sight fix riding this
PR. Filed as #13716; left untouched here per clause-② guidance (a subset pin
that turns something else red is a stop-and-report, not a widen-the-fix).

Tests

  • pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/data/search-fields.test.ts — 25 passed (was 22; the 3 new assertions ran)
  • pnpm --filter @objectstack/spec test — 444 test files / 11882 tests passed (post-merge-with-main count)
  • pnpm --filter @objectstack/spec typecheck — clean (tsc --noEmit + scripts + test-layer typecheck)
  • pnpm --filter @objectstack/spec check:generated — all 14 generated artifacts up to date (re-verified after merging origin/main, which touched packages/spec on its own side too)
  • node scripts/pm/dispatch-gates.mjs (42 path-matched + 6 convention-triggered = 46 local gate commands, re-derived after the merge) — 40 passed; 6 NOT MEASURED, all "prerequisite not met" (never a red caused by this diff):
    • check:dev-prereqs, check:dual-build-cjs-loads, check:type-check-debt, check:doc-formula-expressions — each refuses outright on an unbuilt 79-package workspace dist/ closure (their own error text names this and says so explicitly); CI builds that closure as part of the required jobs.
    • check:test-completeness.mjs — its own no-argument branch: it grades a saved turbo run test log, and produces no log itself.
    • pm/check-half-states.mjs — needs a repo-scoped GitHub REST read, which this container's egress proxy 403s (confirmed by hand: curl against api.github.com/repos/.../issues/13695 from this container returns the same 403 before any of this ran); its own text names this exact container class as the affected one.
  • Ran at commit 80d2fb96.

Generated by Claude Code


Generated by Claude Code

'status' is not a member of the 49-value FieldType enum, so it could
never match a real field type — dead vocabulary in search-fields.ts
(verified mechanically: FieldType has 49 members, 'status' is absent,
'select' is present; no in-flight plan for a status field type found).
Adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES stays a real
FieldType subset, scoped to that one set — it closes the probe gap
that let this sit unnoticed (the existing [#6934] pins check the
search vocabularies against each other, never against FieldType
itself). A parallel ghost-member finding in SEARCH_AUTO_EXCLUDED_TYPES
is out of scope for this fix and filed separately.
Includes a patch changeset for @objectstack/spec.
_Generated by [Claude Code](https://claude.ai/code)_
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53packageMentionDocs.

Which tree this was computed on

This run read content/docs from d3dc761311d61ec556eefe2a25872451534605e4 — the merge of head 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 into base 8fb2d295c70dd8c560451a8c5fb22e608de5fe53, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin d3dc761311d61ec556eefe2a25872451534605e4 && git checkout d3dc761311d61ec556eefe2a25872451534605e4
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 && git checkout -B drift-repro 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 && git merge --no-ff 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46
node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 09:06
@os-warren
os-warren enabled auto-merge August 31, 2026 09:06
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit cff17afAug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13695-searchable-enum-dead-entry branch August 31, 2026 09:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/steststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] SEARCHABLE_ENUM_TYPES contains 'status', which is not a member of the 49-value FieldType enum — dead vocabulary entry in search-fields.ts

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES by os-warren · Pull Request #13728 · objectstack-ai/objectstack · GitHub
Skip to content

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES - #13728

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry
Aug 31, 2026
Merged

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES#13728
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13695

SEARCHABLE_ENUM_TYPES in packages/spec/src/data/search-fields.ts declared
new Set(['select', 'status']). 'status' is not — and per git log on
field.zod.ts and a repo-wide grep, has never been planned to become — a
member of the 49-value FieldType enum, so the entry could never match a
real field's type. Dropped it, leaving new Set(['select']).

Premise, verified mechanically (not read) on this checkout:

FieldType member count: 49
'status' in FieldType: false
'select' in FieldType: true

No in-flight plan for a status field type: no hits in field.zod.ts's
git log, no mention in packages/spec/src or docs//content/docs/.
Clause-②: no accept/reject behaviour changes — 'status' never matched
anything, so every resolution SEARCHABLE_ENUM_TYPES feeds
(autoDefaultFields, the #4254 REST ingress gate, the linter) is
byte-identical for every real object in the tree.

Pin added, scoped narrowly. The existing [#6934] pins in
search-fields.test.ts check the four search vocabularies
(SEARCHABLE_TEXTUAL_TYPES, SEARCHABLE_ENUM_TYPES, SEARCH_AUTO_EXCLUDED_TYPES,
SEARCH_VIRTUAL_TYPES) against each other for pairwise disjointness, but
never against FieldType itself — so a pure ghost member (matching nothing,
as opposed to overlapping something) passed every one of them silently. This
adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES ⊆ FieldType.

Why the pin stops at this one set. Running the same membership check
against all four vocabularies during verification turned up 4 more ghosts in
SEARCH_AUTO_EXCLUDED_TYPES ('object', 'grid', 'geometry',
'encrypted' — none is a FieldType member either). That's a larger, separate
finding — two of the four names read as plausible stale spellings of real
types (geometrylocation, encryptedsecret) rather than pure dead
code, so it needs its own triage rather than a drop-on-sight fix riding this
PR. Filed as #13716; left untouched here per clause-② guidance (a subset pin
that turns something else red is a stop-and-report, not a widen-the-fix).

Tests

  • pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/data/search-fields.test.ts — 25 passed (was 22; the 3 new assertions ran)
  • pnpm --filter @objectstack/spec test — 444 test files / 11882 tests passed (post-merge-with-main count)
  • pnpm --filter @objectstack/spec typecheck — clean (tsc --noEmit + scripts + test-layer typecheck)
  • pnpm --filter @objectstack/spec check:generated — all 14 generated artifacts up to date (re-verified after merging origin/main, which touched packages/spec on its own side too)
  • node scripts/pm/dispatch-gates.mjs (42 path-matched + 6 convention-triggered = 46 local gate commands, re-derived after the merge) — 40 passed; 6 NOT MEASURED, all "prerequisite not met" (never a red caused by this diff):
    • check:dev-prereqs, check:dual-build-cjs-loads, check:type-check-debt, check:doc-formula-expressions — each refuses outright on an unbuilt 79-package workspace dist/ closure (their own error text names this and says so explicitly); CI builds that closure as part of the required jobs.
    • check:test-completeness.mjs — its own no-argument branch: it grades a saved turbo run test log, and produces no log itself.
    • pm/check-half-states.mjs — needs a repo-scoped GitHub REST read, which this container's egress proxy 403s (confirmed by hand: curl against api.github.com/repos/.../issues/13695 from this container returns the same 403 before any of this ran); its own text names this exact container class as the affected one.
  • Ran at commit 80d2fb96.

Generated by Claude Code


Generated by Claude Code

'status' is not a member of the 49-value FieldType enum, so it could
never match a real field type — dead vocabulary in search-fields.ts
(verified mechanically: FieldType has 49 members, 'status' is absent,
'select' is present; no in-flight plan for a status field type found).
Adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES stays a real
FieldType subset, scoped to that one set — it closes the probe gap
that let this sit unnoticed (the existing [#6934] pins check the
search vocabularies against each other, never against FieldType
itself). A parallel ghost-member finding in SEARCH_AUTO_EXCLUDED_TYPES
is out of scope for this fix and filed separately.
Includes a patch changeset for @objectstack/spec.
_Generated by [Claude Code](https://claude.ai/code)_
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53packageMentionDocs.

Which tree this was computed on

This run read content/docs from d3dc761311d61ec556eefe2a25872451534605e4 — the merge of head 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 into base 8fb2d295c70dd8c560451a8c5fb22e608de5fe53, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin d3dc761311d61ec556eefe2a25872451534605e4 && git checkout d3dc761311d61ec556eefe2a25872451534605e4
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 && git checkout -B drift-repro 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 && git merge --no-ff 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46
node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 09:06
@os-warren
os-warren enabled auto-merge August 31, 2026 09:06
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit cff17afAug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13695-searchable-enum-dead-entry branch August 31, 2026 09:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/steststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] SEARCHABLE_ENUM_TYPES contains 'status', which is not a member of the 49-value FieldType enum — dead vocabulary entry in search-fields.ts

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES by os-warren · Pull Request #13728 · objectstack-ai/objectstack · GitHub
Skip to content

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES - #13728

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry
Aug 31, 2026
Merged

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES#13728
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13695

SEARCHABLE_ENUM_TYPES in packages/spec/src/data/search-fields.ts declared
new Set(['select', 'status']). 'status' is not — and per git log on
field.zod.ts and a repo-wide grep, has never been planned to become — a
member of the 49-value FieldType enum, so the entry could never match a
real field's type. Dropped it, leaving new Set(['select']).

Premise, verified mechanically (not read) on this checkout:

FieldType member count: 49
'status' in FieldType: false
'select' in FieldType: true

No in-flight plan for a status field type: no hits in field.zod.ts's
git log, no mention in packages/spec/src or docs//content/docs/.
Clause-②: no accept/reject behaviour changes — 'status' never matched
anything, so every resolution SEARCHABLE_ENUM_TYPES feeds
(autoDefaultFields, the #4254 REST ingress gate, the linter) is
byte-identical for every real object in the tree.

Pin added, scoped narrowly. The existing [#6934] pins in
search-fields.test.ts check the four search vocabularies
(SEARCHABLE_TEXTUAL_TYPES, SEARCHABLE_ENUM_TYPES, SEARCH_AUTO_EXCLUDED_TYPES,
SEARCH_VIRTUAL_TYPES) against each other for pairwise disjointness, but
never against FieldType itself — so a pure ghost member (matching nothing,
as opposed to overlapping something) passed every one of them silently. This
adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES ⊆ FieldType.

Why the pin stops at this one set. Running the same membership check
against all four vocabularies during verification turned up 4 more ghosts in
SEARCH_AUTO_EXCLUDED_TYPES ('object', 'grid', 'geometry',
'encrypted' — none is a FieldType member either). That's a larger, separate
finding — two of the four names read as plausible stale spellings of real
types (geometrylocation, encryptedsecret) rather than pure dead
code, so it needs its own triage rather than a drop-on-sight fix riding this
PR. Filed as #13716; left untouched here per clause-② guidance (a subset pin
that turns something else red is a stop-and-report, not a widen-the-fix).

Tests

  • pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/data/search-fields.test.ts — 25 passed (was 22; the 3 new assertions ran)
  • pnpm --filter @objectstack/spec test — 444 test files / 11882 tests passed (post-merge-with-main count)
  • pnpm --filter @objectstack/spec typecheck — clean (tsc --noEmit + scripts + test-layer typecheck)
  • pnpm --filter @objectstack/spec check:generated — all 14 generated artifacts up to date (re-verified after merging origin/main, which touched packages/spec on its own side too)
  • node scripts/pm/dispatch-gates.mjs (42 path-matched + 6 convention-triggered = 46 local gate commands, re-derived after the merge) — 40 passed; 6 NOT MEASURED, all "prerequisite not met" (never a red caused by this diff):
    • check:dev-prereqs, check:dual-build-cjs-loads, check:type-check-debt, check:doc-formula-expressions — each refuses outright on an unbuilt 79-package workspace dist/ closure (their own error text names this and says so explicitly); CI builds that closure as part of the required jobs.
    • check:test-completeness.mjs — its own no-argument branch: it grades a saved turbo run test log, and produces no log itself.
    • pm/check-half-states.mjs — needs a repo-scoped GitHub REST read, which this container's egress proxy 403s (confirmed by hand: curl against api.github.com/repos/.../issues/13695 from this container returns the same 403 before any of this ran); its own text names this exact container class as the affected one.
  • Ran at commit 80d2fb96.

Generated by Claude Code


Generated by Claude Code

'status' is not a member of the 49-value FieldType enum, so it could
never match a real field type — dead vocabulary in search-fields.ts
(verified mechanically: FieldType has 49 members, 'status' is absent,
'select' is present; no in-flight plan for a status field type found).
Adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES stays a real
FieldType subset, scoped to that one set — it closes the probe gap
that let this sit unnoticed (the existing [#6934] pins check the
search vocabularies against each other, never against FieldType
itself). A parallel ghost-member finding in SEARCH_AUTO_EXCLUDED_TYPES
is out of scope for this fix and filed separately.
Includes a patch changeset for @objectstack/spec.
_Generated by [Claude Code](https://claude.ai/code)_
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53packageMentionDocs.

Which tree this was computed on

This run read content/docs from d3dc761311d61ec556eefe2a25872451534605e4 — the merge of head 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 into base 8fb2d295c70dd8c560451a8c5fb22e608de5fe53, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin d3dc761311d61ec556eefe2a25872451534605e4 && git checkout d3dc761311d61ec556eefe2a25872451534605e4
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 && git checkout -B drift-repro 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 && git merge --no-ff 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46
node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 09:06
@os-warren
os-warren enabled auto-merge August 31, 2026 09:06
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit cff17afAug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13695-searchable-enum-dead-entry branch August 31, 2026 09:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/steststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] SEARCHABLE_ENUM_TYPES contains 'status', which is not a member of the 49-value FieldType enum — dead vocabulary entry in search-fields.ts

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES by os-warren · Pull Request #13728 · objectstack-ai/objectstack · GitHub
Skip to content

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES - #13728

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry
Aug 31, 2026
Merged

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES#13728
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13695

SEARCHABLE_ENUM_TYPES in packages/spec/src/data/search-fields.ts declared
new Set(['select', 'status']). 'status' is not — and per git log on
field.zod.ts and a repo-wide grep, has never been planned to become — a
member of the 49-value FieldType enum, so the entry could never match a
real field's type. Dropped it, leaving new Set(['select']).

Premise, verified mechanically (not read) on this checkout:

FieldType member count: 49
'status' in FieldType: false
'select' in FieldType: true

No in-flight plan for a status field type: no hits in field.zod.ts's
git log, no mention in packages/spec/src or docs//content/docs/.
Clause-②: no accept/reject behaviour changes — 'status' never matched
anything, so every resolution SEARCHABLE_ENUM_TYPES feeds
(autoDefaultFields, the #4254 REST ingress gate, the linter) is
byte-identical for every real object in the tree.

Pin added, scoped narrowly. The existing [#6934] pins in
search-fields.test.ts check the four search vocabularies
(SEARCHABLE_TEXTUAL_TYPES, SEARCHABLE_ENUM_TYPES, SEARCH_AUTO_EXCLUDED_TYPES,
SEARCH_VIRTUAL_TYPES) against each other for pairwise disjointness, but
never against FieldType itself — so a pure ghost member (matching nothing,
as opposed to overlapping something) passed every one of them silently. This
adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES ⊆ FieldType.

Why the pin stops at this one set. Running the same membership check
against all four vocabularies during verification turned up 4 more ghosts in
SEARCH_AUTO_EXCLUDED_TYPES ('object', 'grid', 'geometry',
'encrypted' — none is a FieldType member either). That's a larger, separate
finding — two of the four names read as plausible stale spellings of real
types (geometrylocation, encryptedsecret) rather than pure dead
code, so it needs its own triage rather than a drop-on-sight fix riding this
PR. Filed as #13716; left untouched here per clause-② guidance (a subset pin
that turns something else red is a stop-and-report, not a widen-the-fix).

Tests

  • pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/data/search-fields.test.ts — 25 passed (was 22; the 3 new assertions ran)
  • pnpm --filter @objectstack/spec test — 444 test files / 11882 tests passed (post-merge-with-main count)
  • pnpm --filter @objectstack/spec typecheck — clean (tsc --noEmit + scripts + test-layer typecheck)
  • pnpm --filter @objectstack/spec check:generated — all 14 generated artifacts up to date (re-verified after merging origin/main, which touched packages/spec on its own side too)
  • node scripts/pm/dispatch-gates.mjs (42 path-matched + 6 convention-triggered = 46 local gate commands, re-derived after the merge) — 40 passed; 6 NOT MEASURED, all "prerequisite not met" (never a red caused by this diff):
    • check:dev-prereqs, check:dual-build-cjs-loads, check:type-check-debt, check:doc-formula-expressions — each refuses outright on an unbuilt 79-package workspace dist/ closure (their own error text names this and says so explicitly); CI builds that closure as part of the required jobs.
    • check:test-completeness.mjs — its own no-argument branch: it grades a saved turbo run test log, and produces no log itself.
    • pm/check-half-states.mjs — needs a repo-scoped GitHub REST read, which this container's egress proxy 403s (confirmed by hand: curl against api.github.com/repos/.../issues/13695 from this container returns the same 403 before any of this ran); its own text names this exact container class as the affected one.
  • Ran at commit 80d2fb96.

Generated by Claude Code


Generated by Claude Code

'status' is not a member of the 49-value FieldType enum, so it could
never match a real field type — dead vocabulary in search-fields.ts
(verified mechanically: FieldType has 49 members, 'status' is absent,
'select' is present; no in-flight plan for a status field type found).
Adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES stays a real
FieldType subset, scoped to that one set — it closes the probe gap
that let this sit unnoticed (the existing [#6934] pins check the
search vocabularies against each other, never against FieldType
itself). A parallel ghost-member finding in SEARCH_AUTO_EXCLUDED_TYPES
is out of scope for this fix and filed separately.
Includes a patch changeset for @objectstack/spec.
_Generated by [Claude Code](https://claude.ai/code)_
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53packageMentionDocs.

Which tree this was computed on

This run read content/docs from d3dc761311d61ec556eefe2a25872451534605e4 — the merge of head 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 into base 8fb2d295c70dd8c560451a8c5fb22e608de5fe53, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin d3dc761311d61ec556eefe2a25872451534605e4 && git checkout d3dc761311d61ec556eefe2a25872451534605e4
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 && git checkout -B drift-repro 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 && git merge --no-ff 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46
node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 09:06
@os-warren
os-warren enabled auto-merge August 31, 2026 09:06
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit cff17afAug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13695-searchable-enum-dead-entry branch August 31, 2026 09:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/steststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] SEARCHABLE_ENUM_TYPES contains 'status', which is not a member of the 49-value FieldType enum — dead vocabulary entry in search-fields.ts

2 participants

@os-warren@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES by os-warren · Pull Request #13728 · objectstack-ai/objectstack · GitHub
Skip to content

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES - #13728

Merged
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry
Aug 31, 2026
Merged

fix(spec): drop dead 'status' member from SEARCHABLE_ENUM_TYPES#13728
os-warren merged 2 commits into
mainfrom
claude/issue-13695-searchable-enum-dead-entry

Conversation

@os-warren

Copy link
Copy Markdown
Collaborator

Fixes#13695

SEARCHABLE_ENUM_TYPES in packages/spec/src/data/search-fields.ts declared
new Set(['select', 'status']). 'status' is not — and per git log on
field.zod.ts and a repo-wide grep, has never been planned to become — a
member of the 49-value FieldType enum, so the entry could never match a
real field's type. Dropped it, leaving new Set(['select']).

Premise, verified mechanically (not read) on this checkout:

FieldType member count: 49
'status' in FieldType: false
'select' in FieldType: true

No in-flight plan for a status field type: no hits in field.zod.ts's
git log, no mention in packages/spec/src or docs//content/docs/.
Clause-②: no accept/reject behaviour changes — 'status' never matched
anything, so every resolution SEARCHABLE_ENUM_TYPES feeds
(autoDefaultFields, the #4254 REST ingress gate, the linter) is
byte-identical for every real object in the tree.

Pin added, scoped narrowly. The existing [#6934] pins in
search-fields.test.ts check the four search vocabularies
(SEARCHABLE_TEXTUAL_TYPES, SEARCHABLE_ENUM_TYPES, SEARCH_AUTO_EXCLUDED_TYPES,
SEARCH_VIRTUAL_TYPES) against each other for pairwise disjointness, but
never against FieldType itself — so a pure ghost member (matching nothing,
as opposed to overlapping something) passed every one of them silently. This
adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES ⊆ FieldType.

Why the pin stops at this one set. Running the same membership check
against all four vocabularies during verification turned up 4 more ghosts in
SEARCH_AUTO_EXCLUDED_TYPES ('object', 'grid', 'geometry',
'encrypted' — none is a FieldType member either). That's a larger, separate
finding — two of the four names read as plausible stale spellings of real
types (geometrylocation, encryptedsecret) rather than pure dead
code, so it needs its own triage rather than a drop-on-sight fix riding this
PR. Filed as #13716; left untouched here per clause-② guidance (a subset pin
that turns something else red is a stop-and-report, not a widen-the-fix).

Tests

  • pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/data/search-fields.test.ts — 25 passed (was 22; the 3 new assertions ran)
  • pnpm --filter @objectstack/spec test — 444 test files / 11882 tests passed (post-merge-with-main count)
  • pnpm --filter @objectstack/spec typecheck — clean (tsc --noEmit + scripts + test-layer typecheck)
  • pnpm --filter @objectstack/spec check:generated — all 14 generated artifacts up to date (re-verified after merging origin/main, which touched packages/spec on its own side too)
  • node scripts/pm/dispatch-gates.mjs (42 path-matched + 6 convention-triggered = 46 local gate commands, re-derived after the merge) — 40 passed; 6 NOT MEASURED, all "prerequisite not met" (never a red caused by this diff):
    • check:dev-prereqs, check:dual-build-cjs-loads, check:type-check-debt, check:doc-formula-expressions — each refuses outright on an unbuilt 79-package workspace dist/ closure (their own error text names this and says so explicitly); CI builds that closure as part of the required jobs.
    • check:test-completeness.mjs — its own no-argument branch: it grades a saved turbo run test log, and produces no log itself.
    • pm/check-half-states.mjs — needs a repo-scoped GitHub REST read, which this container's egress proxy 403s (confirmed by hand: curl against api.github.com/repos/.../issues/13695 from this container returns the same 403 before any of this ran); its own text names this exact container class as the affected one.
  • Ran at commit 80d2fb96.

Generated by Claude Code


Generated by Claude Code

'status' is not a member of the 49-value FieldType enum, so it could
never match a real field type — dead vocabulary in search-fields.ts
(verified mechanically: FieldType has 49 members, 'status' is absent,
'select' is present; no in-flight plan for a status field type found).
Adds a [#13695] pin asserting SEARCHABLE_ENUM_TYPES stays a real
FieldType subset, scoped to that one set — it closes the probe gap
that let this sit unnoticed (the existing [#6934] pins check the
search vocabularies against each other, never against FieldType
itself). A parallel ghost-member finding in SEARCH_AUTO_EXCLUDED_TYPES
is out of scope for this fix and filed separately.
Includes a patch changeset for @objectstack/spec.
_Generated by [Claude Code](https://claude.ai/code)_
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53packageMentionDocs.

Which tree this was computed on

This run read content/docs from d3dc761311d61ec556eefe2a25872451534605e4 — the merge of head 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 into base 8fb2d295c70dd8c560451a8c5fb22e608de5fe53, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin d3dc761311d61ec556eefe2a25872451534605e4 && git checkout d3dc761311d61ec556eefe2a25872451534605e4
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46 && git checkout -B drift-repro 8fb2d295c70dd8c560451a8c5fb22e608de5fe53 && git merge --no-ff 80d2fb96d7ccf0314c7b4ad4a352a701a0578c46
node scripts/docs-audit/affected-docs.mjs --json 8fb2d295c70dd8c560451a8c5fb22e608de5fe53

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation protocol:data tests tooling labels Aug 31, 2026
@os-warren
os-warren marked this pull request as ready for review August 31, 2026 09:06
@os-warren
os-warren enabled auto-merge August 31, 2026 09:06
@os-warren
os-warren added this pull request to the merge queueAug 31, 2026
Merged via the queue into main with commit cff17afAug 31, 2026
35 checks passed
@os-warren
os-warren deleted the claude/issue-13695-searchable-enum-dead-entry branch August 31, 2026 09:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationprotocol:datasize/steststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] SEARCHABLE_ENUM_TYPES contains 'status', which is not a member of the 49-value FieldType enum — dead vocabulary entry in search-fields.ts

2 participants

@os-warren@claude