ci(devx): label-gated opt-in pre-merge pack smoke - #14266

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke
Sep 1, 2026
Merged

ci(devx): label-gated opt-in pre-merge pack smoke#14266
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#14214

Adds the missing trigger for the packed-install smoke: while a PR carries needs:pack-smoke, CI runs the existing pack smoke against that PR's merge preview, before the merge, as a check run the author already reads.

Derived from the maintainer-approved ruling on #14000 (2026-09-01, director batch #23, 「同意」; the follow-up recommendation 「label 门控 opt-in」 was the one approved).

Premise re-check (done first, on fresh origin/main)

The card's premise holds. Verified at base 035951faf:

  • git grep -n 'labeled' -- .github/workflows/ returns no labeled trigger anywhere — every hit is prose, or pr-automation.yml explicitly excludinglabeled/unlabeled from its jobs. There was no pre-merge pack-smoke trigger of any kind to collide with.
  • Positive control (the leg the card describes) is present and reads exactly as described: publish-smoke.yml triggers on: workflow_run: workflows: [Release], resolves the open changeset-release/main PR, and reports publish-smoke / packed-tarballs as a commit status on the release branch head. That is a release surface, not a PR surface — which is the whole gap.
  • Base already carries fix(devx): re-pin the publish smoke to the declared first-run contract #14255 (035951fa), so the driver reused here is the re-pinned one.

Driver-contract verification (read off the driver, not invented)

Verified in scripts/publish-smoke.sh rather than assumed:

ContractReading
Invocationbash scripts/publish-smoke.sh — identical to publish-smoke.yml's pack-smoke step
ModeSMOKE_MODE defaults to pack, so no env is needed
Prereqthe script fails fast unless packages/cli/dist and the create-objectstack bin exist, i.e. pnpm install + pnpm run build must precede it
Target treeit packs from REPO_ROOT, resolved from the script's own location — whatever tree is checked out

The merge preview is a valid target and needs no plumbing. The one risk worth checking was whether pack mode assumes a release-branch layout the preview lacks; it does not. The release-branch coupling in publish-smoke.yml lives entirely in its resolve job (finding the release PR and a report-sha to post a status to), never in the driver. On pull_request the default actions/checkout ref is already refs/pull/N/merge, and the check run lands on the PR itself — so this workflow needs noresolve job, noresolve-guard, and nostatuses: write. It runs with contents: read only. No driver changes were required, and none were made.

Scope boundaries, honoured

Design decisions worth review

The label

needs:pack-smoke did not exist. It was created on this repo (colour 006b75, description 94 chars), and — more importantly — declared in scripts/pm/ensure-pm-labels.sh, the repo's only declared home for a label object. An undeclared label is the grey / empty-description drift that file's header describes: auto-created by its first application and unrepairable by any rerun. Declaring it also puts its description under check:pm-label-desc-cap.

The added comment states plainly that this is the first row in that file that is not part of the PM state machine — it is written by the PR author about their own diff, names a property of the change rather than a position on the board, and no sweep in scripts/pm/ reads it.

⛔ It is never auto-applied: no .github/labeler.yml rule, by design. Path-derived application would be a different design from the one ruled, and would put the ~45-minute cost back into the default inner loop the ruling kept it out of.

Documentation line

One line in CONTRIBUTING.md's "Before Submitting" checklist — where a PR author actually meets it — carrying the ruling's criterion verbatim in substance: the PR changes the auth/audience defaults or the accept/reject behaviour of the unauthenticated surface.

Residual risk, stated rather than hidden

Self-declaration only covers the author who recognises their change as breaking. An author who does not realise they widened the unauthenticated surface still gets no pre-merge pack coverage; the release-time leg remains the backstop for that case. Closing that would need a detection rule — a different card and a different ruling. This is written into the workflow header too, so the next reader does not mistake the opt-in shape for full coverage.

Checks

Gate families derived mechanically from the real changeset — node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack (no hand-written path list) — which named 31 families; harvested with --commands and all 31 run.

  • 30 of 31 green.
  • 1 NOT MEASURED, not a red:scripts/check-test-completeness.mjs exits 3 with no test log to read, and says so itself: "the local reading for this gate is NOT MEASURED … ⛔ It is not a red, and there is nothing here to fix." CI tees it a real log and passes the path, so that branch is unreachable there.

Re-run union on the final commit 820a49923 (12 families, all green), quoting each gate's own verdict line:

check-workflow-status-functions: OK (scanned 30 workflow file(s), 53 job(s), 26 job-level if: expression(s);
10 read needs.*.outputs.*, all naming a status function).
check:pm-label-desc-cap: 22 label descriptions in scripts/pm/ensure-pm-labels.sh, all <=100 characters
(longest: 100, repo:objectui).
check-required-contexts: 6 required context name(s) pinned across 2 workflow(s).
check-stall-guard-budget: OK (30 workflow file(s), 53 job(s), 572 step(s), 7 guard-wrapped step(s);
every effective cap clears its job budget by at least one stall window).
check-nul-bytes: OK (scanned 7794 text file(s); no raw ASCII control bytes).
check:declared-population-live - 156 of 200 famil(ies) declare a path population, and every one reaches this tree.
check-bash32-floor: 26 tracked shell file(s) ... name no bash 4+ construct outside a comment.

Plus pnpm check:ratchet-remedy-authority (green: 183 scripts swept) and pnpm check:pm-dispatch-gates (green: 1140 self-test cases), both requested for the scripts/** touch.

The new workflow was also parsed with the repo's own yaml library to confirm on: did not fall into the YAML-1.1 true trap and that the guard expression survives folding intact.

Releases nothing (.github/, scripts/pm/, CONTRIBUTING.md), so skip-changeset is applied per the Check Changeset step's own route 2.

Demonstration run

needs:pack-smoke is applied to this draft PR so the new job fires on it — the trigger demonstrating itself. The run is cited in a follow-up comment once it has a URL. Note the smoke exercises the merge preview of this PR, whose diff is CI wiring only, so a green here demonstrates the trigger, not any auth/audience behaviour.

⛔ Draft on purpose — not to be marked ready by an agent.


Generated by Claude Code

Add a `pull_request` trigger that runs the existing pack-install smoke on a
PR's merge preview while the PR carries `needs:pack-smoke`.
The pack smoke previously ran only on `workflow_run` after a Release run, so
its verdict landed as a commit status on the changesets release branch head --
a surface no PR author reads. A breaking auth/audience change therefore merged
with zero packed-install coverage on its own PR, and the smoke then sat red on
the release candidate for ~7 days.
This adds the trigger only. The driver, its probes and every assertion in
scripts/publish-smoke.sh are untouched: re-pinning those to the declared
first-run contract was a separate deliverable that has already landed.
Opt-in by ruling -- an unlabelled PR pays no new cost. The guard's second limb
keeps an unrelated label add (size/*, ci/cd) from restarting a 45-minute smoke,
and the concurrency group sits at job level so a run that skips can never
cancel a run that is really smoking.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actionsgithub-actionsBot added size/m ci/cd documentation Improvements or additions to documentation labels Sep 1, 2026
@claudeclaudeBot added needs:pack-smoke Opt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md) skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 1, 2026
@claude

claudeBot commented Sep 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Demonstration run — all three arms observed live on this PR

The trigger demonstrating itself. Three pull_request runs of Pack Smoke (opt-in) landed on this PR, and between them they exercise every arm of the guard — measured, not asserted:

RunEventJob outcomeWhat it demonstrates
33539960970opened, no label yetskipped⛔ boundary #2 of the ruling: an unlabelled PR pays zero new cost
33540022686labeledskip-changesetskippedthe guard's SECOND limb: an unrelated label add does not start a 45-minute smoke of an unchanged tree
33540022809labeledneeds:pack-smokein_progressthe trigger fires on the opt-in label, against the merge preview

The middle row is the one that would otherwise be easy to get wrong and impossible to notice: without that limb, every size/* and ci/cd label the automation adds to an already-labelled PR would each start another full smoke.

Note the smoke here exercises the merge preview of this PR, whose diff is CI wiring only — so its eventual colour demonstrates the trigger, not any auth/audience behaviour. Per the dispatch contract the report is filed at draft-PR time rather than waiting for the ~45-minute run to converge; the run above is cited at in_progress.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 18:02
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 54c37fbSep 1, 2026
40 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14214-labeled-pack-smoke branch September 1, 2026 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cddocumentationImprovements or additions to documentationneeds:pack-smokeOpt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md)size/mskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label 门控的 opt-in 预合并 pack-smoke —— 破坏性 auth/audience 面 PR 在合并前跑一次打包安装冒烟(#14000 附问裁决派生)

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

ci(devx): label-gated opt-in pre-merge pack smoke - #14266

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke
Sep 1, 2026
Merged

ci(devx): label-gated opt-in pre-merge pack smoke#14266
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#14214

Adds the missing trigger for the packed-install smoke: while a PR carries needs:pack-smoke, CI runs the existing pack smoke against that PR's merge preview, before the merge, as a check run the author already reads.

Derived from the maintainer-approved ruling on #14000 (2026-09-01, director batch #23, 「同意」; the follow-up recommendation 「label 门控 opt-in」 was the one approved).

Premise re-check (done first, on fresh origin/main)

The card's premise holds. Verified at base 035951faf:

  • git grep -n 'labeled' -- .github/workflows/ returns no labeled trigger anywhere — every hit is prose, or pr-automation.yml explicitly excludinglabeled/unlabeled from its jobs. There was no pre-merge pack-smoke trigger of any kind to collide with.
  • Positive control (the leg the card describes) is present and reads exactly as described: publish-smoke.yml triggers on: workflow_run: workflows: [Release], resolves the open changeset-release/main PR, and reports publish-smoke / packed-tarballs as a commit status on the release branch head. That is a release surface, not a PR surface — which is the whole gap.
  • Base already carries fix(devx): re-pin the publish smoke to the declared first-run contract #14255 (035951fa), so the driver reused here is the re-pinned one.

Driver-contract verification (read off the driver, not invented)

Verified in scripts/publish-smoke.sh rather than assumed:

ContractReading
Invocationbash scripts/publish-smoke.sh — identical to publish-smoke.yml's pack-smoke step
ModeSMOKE_MODE defaults to pack, so no env is needed
Prereqthe script fails fast unless packages/cli/dist and the create-objectstack bin exist, i.e. pnpm install + pnpm run build must precede it
Target treeit packs from REPO_ROOT, resolved from the script's own location — whatever tree is checked out

The merge preview is a valid target and needs no plumbing. The one risk worth checking was whether pack mode assumes a release-branch layout the preview lacks; it does not. The release-branch coupling in publish-smoke.yml lives entirely in its resolve job (finding the release PR and a report-sha to post a status to), never in the driver. On pull_request the default actions/checkout ref is already refs/pull/N/merge, and the check run lands on the PR itself — so this workflow needs noresolve job, noresolve-guard, and nostatuses: write. It runs with contents: read only. No driver changes were required, and none were made.

Scope boundaries, honoured

Design decisions worth review

The label

needs:pack-smoke did not exist. It was created on this repo (colour 006b75, description 94 chars), and — more importantly — declared in scripts/pm/ensure-pm-labels.sh, the repo's only declared home for a label object. An undeclared label is the grey / empty-description drift that file's header describes: auto-created by its first application and unrepairable by any rerun. Declaring it also puts its description under check:pm-label-desc-cap.

The added comment states plainly that this is the first row in that file that is not part of the PM state machine — it is written by the PR author about their own diff, names a property of the change rather than a position on the board, and no sweep in scripts/pm/ reads it.

⛔ It is never auto-applied: no .github/labeler.yml rule, by design. Path-derived application would be a different design from the one ruled, and would put the ~45-minute cost back into the default inner loop the ruling kept it out of.

Documentation line

One line in CONTRIBUTING.md's "Before Submitting" checklist — where a PR author actually meets it — carrying the ruling's criterion verbatim in substance: the PR changes the auth/audience defaults or the accept/reject behaviour of the unauthenticated surface.

Residual risk, stated rather than hidden

Self-declaration only covers the author who recognises their change as breaking. An author who does not realise they widened the unauthenticated surface still gets no pre-merge pack coverage; the release-time leg remains the backstop for that case. Closing that would need a detection rule — a different card and a different ruling. This is written into the workflow header too, so the next reader does not mistake the opt-in shape for full coverage.

Checks

Gate families derived mechanically from the real changeset — node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack (no hand-written path list) — which named 31 families; harvested with --commands and all 31 run.

  • 30 of 31 green.
  • 1 NOT MEASURED, not a red:scripts/check-test-completeness.mjs exits 3 with no test log to read, and says so itself: "the local reading for this gate is NOT MEASURED … ⛔ It is not a red, and there is nothing here to fix." CI tees it a real log and passes the path, so that branch is unreachable there.

Re-run union on the final commit 820a49923 (12 families, all green), quoting each gate's own verdict line:

check-workflow-status-functions: OK (scanned 30 workflow file(s), 53 job(s), 26 job-level if: expression(s);
10 read needs.*.outputs.*, all naming a status function).
check:pm-label-desc-cap: 22 label descriptions in scripts/pm/ensure-pm-labels.sh, all <=100 characters
(longest: 100, repo:objectui).
check-required-contexts: 6 required context name(s) pinned across 2 workflow(s).
check-stall-guard-budget: OK (30 workflow file(s), 53 job(s), 572 step(s), 7 guard-wrapped step(s);
every effective cap clears its job budget by at least one stall window).
check-nul-bytes: OK (scanned 7794 text file(s); no raw ASCII control bytes).
check:declared-population-live - 156 of 200 famil(ies) declare a path population, and every one reaches this tree.
check-bash32-floor: 26 tracked shell file(s) ... name no bash 4+ construct outside a comment.

Plus pnpm check:ratchet-remedy-authority (green: 183 scripts swept) and pnpm check:pm-dispatch-gates (green: 1140 self-test cases), both requested for the scripts/** touch.

The new workflow was also parsed with the repo's own yaml library to confirm on: did not fall into the YAML-1.1 true trap and that the guard expression survives folding intact.

Releases nothing (.github/, scripts/pm/, CONTRIBUTING.md), so skip-changeset is applied per the Check Changeset step's own route 2.

Demonstration run

needs:pack-smoke is applied to this draft PR so the new job fires on it — the trigger demonstrating itself. The run is cited in a follow-up comment once it has a URL. Note the smoke exercises the merge preview of this PR, whose diff is CI wiring only, so a green here demonstrates the trigger, not any auth/audience behaviour.

⛔ Draft on purpose — not to be marked ready by an agent.


Generated by Claude Code

Add a `pull_request` trigger that runs the existing pack-install smoke on a
PR's merge preview while the PR carries `needs:pack-smoke`.
The pack smoke previously ran only on `workflow_run` after a Release run, so
its verdict landed as a commit status on the changesets release branch head --
a surface no PR author reads. A breaking auth/audience change therefore merged
with zero packed-install coverage on its own PR, and the smoke then sat red on
the release candidate for ~7 days.
This adds the trigger only. The driver, its probes and every assertion in
scripts/publish-smoke.sh are untouched: re-pinning those to the declared
first-run contract was a separate deliverable that has already landed.
Opt-in by ruling -- an unlabelled PR pays no new cost. The guard's second limb
keeps an unrelated label add (size/*, ci/cd) from restarting a 45-minute smoke,
and the concurrency group sits at job level so a run that skips can never
cancel a run that is really smoking.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actionsgithub-actionsBot added size/m ci/cd documentation Improvements or additions to documentation labels Sep 1, 2026
@claudeclaudeBot added needs:pack-smoke Opt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md) skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 1, 2026
@claude

claudeBot commented Sep 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Demonstration run — all three arms observed live on this PR

The trigger demonstrating itself. Three pull_request runs of Pack Smoke (opt-in) landed on this PR, and between them they exercise every arm of the guard — measured, not asserted:

RunEventJob outcomeWhat it demonstrates
33539960970opened, no label yetskipped⛔ boundary #2 of the ruling: an unlabelled PR pays zero new cost
33540022686labeledskip-changesetskippedthe guard's SECOND limb: an unrelated label add does not start a 45-minute smoke of an unchanged tree
33540022809labeledneeds:pack-smokein_progressthe trigger fires on the opt-in label, against the merge preview

The middle row is the one that would otherwise be easy to get wrong and impossible to notice: without that limb, every size/* and ci/cd label the automation adds to an already-labelled PR would each start another full smoke.

Note the smoke here exercises the merge preview of this PR, whose diff is CI wiring only — so its eventual colour demonstrates the trigger, not any auth/audience behaviour. Per the dispatch contract the report is filed at draft-PR time rather than waiting for the ~45-minute run to converge; the run above is cited at in_progress.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 18:02
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 54c37fbSep 1, 2026
40 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14214-labeled-pack-smoke branch September 1, 2026 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cddocumentationImprovements or additions to documentationneeds:pack-smokeOpt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md)size/mskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label 门控的 opt-in 预合并 pack-smoke —— 破坏性 auth/audience 面 PR 在合并前跑一次打包安装冒烟(#14000 附问裁决派生)

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ci(devx): label-gated opt-in pre-merge pack smoke - #14266

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke
Sep 1, 2026
Merged

ci(devx): label-gated opt-in pre-merge pack smoke#14266
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#14214

Adds the missing trigger for the packed-install smoke: while a PR carries needs:pack-smoke, CI runs the existing pack smoke against that PR's merge preview, before the merge, as a check run the author already reads.

Derived from the maintainer-approved ruling on #14000 (2026-09-01, director batch #23, 「同意」; the follow-up recommendation 「label 门控 opt-in」 was the one approved).

Premise re-check (done first, on fresh origin/main)

The card's premise holds. Verified at base 035951faf:

  • git grep -n 'labeled' -- .github/workflows/ returns no labeled trigger anywhere — every hit is prose, or pr-automation.yml explicitly excludinglabeled/unlabeled from its jobs. There was no pre-merge pack-smoke trigger of any kind to collide with.
  • Positive control (the leg the card describes) is present and reads exactly as described: publish-smoke.yml triggers on: workflow_run: workflows: [Release], resolves the open changeset-release/main PR, and reports publish-smoke / packed-tarballs as a commit status on the release branch head. That is a release surface, not a PR surface — which is the whole gap.
  • Base already carries fix(devx): re-pin the publish smoke to the declared first-run contract #14255 (035951fa), so the driver reused here is the re-pinned one.

Driver-contract verification (read off the driver, not invented)

Verified in scripts/publish-smoke.sh rather than assumed:

ContractReading
Invocationbash scripts/publish-smoke.sh — identical to publish-smoke.yml's pack-smoke step
ModeSMOKE_MODE defaults to pack, so no env is needed
Prereqthe script fails fast unless packages/cli/dist and the create-objectstack bin exist, i.e. pnpm install + pnpm run build must precede it
Target treeit packs from REPO_ROOT, resolved from the script's own location — whatever tree is checked out

The merge preview is a valid target and needs no plumbing. The one risk worth checking was whether pack mode assumes a release-branch layout the preview lacks; it does not. The release-branch coupling in publish-smoke.yml lives entirely in its resolve job (finding the release PR and a report-sha to post a status to), never in the driver. On pull_request the default actions/checkout ref is already refs/pull/N/merge, and the check run lands on the PR itself — so this workflow needs noresolve job, noresolve-guard, and nostatuses: write. It runs with contents: read only. No driver changes were required, and none were made.

Scope boundaries, honoured

Design decisions worth review

The label

needs:pack-smoke did not exist. It was created on this repo (colour 006b75, description 94 chars), and — more importantly — declared in scripts/pm/ensure-pm-labels.sh, the repo's only declared home for a label object. An undeclared label is the grey / empty-description drift that file's header describes: auto-created by its first application and unrepairable by any rerun. Declaring it also puts its description under check:pm-label-desc-cap.

The added comment states plainly that this is the first row in that file that is not part of the PM state machine — it is written by the PR author about their own diff, names a property of the change rather than a position on the board, and no sweep in scripts/pm/ reads it.

⛔ It is never auto-applied: no .github/labeler.yml rule, by design. Path-derived application would be a different design from the one ruled, and would put the ~45-minute cost back into the default inner loop the ruling kept it out of.

Documentation line

One line in CONTRIBUTING.md's "Before Submitting" checklist — where a PR author actually meets it — carrying the ruling's criterion verbatim in substance: the PR changes the auth/audience defaults or the accept/reject behaviour of the unauthenticated surface.

Residual risk, stated rather than hidden

Self-declaration only covers the author who recognises their change as breaking. An author who does not realise they widened the unauthenticated surface still gets no pre-merge pack coverage; the release-time leg remains the backstop for that case. Closing that would need a detection rule — a different card and a different ruling. This is written into the workflow header too, so the next reader does not mistake the opt-in shape for full coverage.

Checks

Gate families derived mechanically from the real changeset — node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack (no hand-written path list) — which named 31 families; harvested with --commands and all 31 run.

  • 30 of 31 green.
  • 1 NOT MEASURED, not a red:scripts/check-test-completeness.mjs exits 3 with no test log to read, and says so itself: "the local reading for this gate is NOT MEASURED … ⛔ It is not a red, and there is nothing here to fix." CI tees it a real log and passes the path, so that branch is unreachable there.

Re-run union on the final commit 820a49923 (12 families, all green), quoting each gate's own verdict line:

check-workflow-status-functions: OK (scanned 30 workflow file(s), 53 job(s), 26 job-level if: expression(s);
10 read needs.*.outputs.*, all naming a status function).
check:pm-label-desc-cap: 22 label descriptions in scripts/pm/ensure-pm-labels.sh, all <=100 characters
(longest: 100, repo:objectui).
check-required-contexts: 6 required context name(s) pinned across 2 workflow(s).
check-stall-guard-budget: OK (30 workflow file(s), 53 job(s), 572 step(s), 7 guard-wrapped step(s);
every effective cap clears its job budget by at least one stall window).
check-nul-bytes: OK (scanned 7794 text file(s); no raw ASCII control bytes).
check:declared-population-live - 156 of 200 famil(ies) declare a path population, and every one reaches this tree.
check-bash32-floor: 26 tracked shell file(s) ... name no bash 4+ construct outside a comment.

Plus pnpm check:ratchet-remedy-authority (green: 183 scripts swept) and pnpm check:pm-dispatch-gates (green: 1140 self-test cases), both requested for the scripts/** touch.

The new workflow was also parsed with the repo's own yaml library to confirm on: did not fall into the YAML-1.1 true trap and that the guard expression survives folding intact.

Releases nothing (.github/, scripts/pm/, CONTRIBUTING.md), so skip-changeset is applied per the Check Changeset step's own route 2.

Demonstration run

needs:pack-smoke is applied to this draft PR so the new job fires on it — the trigger demonstrating itself. The run is cited in a follow-up comment once it has a URL. Note the smoke exercises the merge preview of this PR, whose diff is CI wiring only, so a green here demonstrates the trigger, not any auth/audience behaviour.

⛔ Draft on purpose — not to be marked ready by an agent.


Generated by Claude Code

Add a `pull_request` trigger that runs the existing pack-install smoke on a
PR's merge preview while the PR carries `needs:pack-smoke`.
The pack smoke previously ran only on `workflow_run` after a Release run, so
its verdict landed as a commit status on the changesets release branch head --
a surface no PR author reads. A breaking auth/audience change therefore merged
with zero packed-install coverage on its own PR, and the smoke then sat red on
the release candidate for ~7 days.
This adds the trigger only. The driver, its probes and every assertion in
scripts/publish-smoke.sh are untouched: re-pinning those to the declared
first-run contract was a separate deliverable that has already landed.
Opt-in by ruling -- an unlabelled PR pays no new cost. The guard's second limb
keeps an unrelated label add (size/*, ci/cd) from restarting a 45-minute smoke,
and the concurrency group sits at job level so a run that skips can never
cancel a run that is really smoking.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actionsgithub-actionsBot added size/m ci/cd documentation Improvements or additions to documentation labels Sep 1, 2026
@claudeclaudeBot added needs:pack-smoke Opt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md) skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 1, 2026
@claude

claudeBot commented Sep 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Demonstration run — all three arms observed live on this PR

The trigger demonstrating itself. Three pull_request runs of Pack Smoke (opt-in) landed on this PR, and between them they exercise every arm of the guard — measured, not asserted:

RunEventJob outcomeWhat it demonstrates
33539960970opened, no label yetskipped⛔ boundary #2 of the ruling: an unlabelled PR pays zero new cost
33540022686labeledskip-changesetskippedthe guard's SECOND limb: an unrelated label add does not start a 45-minute smoke of an unchanged tree
33540022809labeledneeds:pack-smokein_progressthe trigger fires on the opt-in label, against the merge preview

The middle row is the one that would otherwise be easy to get wrong and impossible to notice: without that limb, every size/* and ci/cd label the automation adds to an already-labelled PR would each start another full smoke.

Note the smoke here exercises the merge preview of this PR, whose diff is CI wiring only — so its eventual colour demonstrates the trigger, not any auth/audience behaviour. Per the dispatch contract the report is filed at draft-PR time rather than waiting for the ~45-minute run to converge; the run above is cited at in_progress.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 18:02
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 54c37fbSep 1, 2026
40 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14214-labeled-pack-smoke branch September 1, 2026 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cddocumentationImprovements or additions to documentationneeds:pack-smokeOpt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md)size/mskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label 门控的 opt-in 预合并 pack-smoke —— 破坏性 auth/audience 面 PR 在合并前跑一次打包安装冒烟(#14000 附问裁决派生)

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ci(devx): label-gated opt-in pre-merge pack smoke - #14266

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke
Sep 1, 2026
Merged

ci(devx): label-gated opt-in pre-merge pack smoke#14266
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#14214

Adds the missing trigger for the packed-install smoke: while a PR carries needs:pack-smoke, CI runs the existing pack smoke against that PR's merge preview, before the merge, as a check run the author already reads.

Derived from the maintainer-approved ruling on #14000 (2026-09-01, director batch #23, 「同意」; the follow-up recommendation 「label 门控 opt-in」 was the one approved).

Premise re-check (done first, on fresh origin/main)

The card's premise holds. Verified at base 035951faf:

  • git grep -n 'labeled' -- .github/workflows/ returns no labeled trigger anywhere — every hit is prose, or pr-automation.yml explicitly excludinglabeled/unlabeled from its jobs. There was no pre-merge pack-smoke trigger of any kind to collide with.
  • Positive control (the leg the card describes) is present and reads exactly as described: publish-smoke.yml triggers on: workflow_run: workflows: [Release], resolves the open changeset-release/main PR, and reports publish-smoke / packed-tarballs as a commit status on the release branch head. That is a release surface, not a PR surface — which is the whole gap.
  • Base already carries fix(devx): re-pin the publish smoke to the declared first-run contract #14255 (035951fa), so the driver reused here is the re-pinned one.

Driver-contract verification (read off the driver, not invented)

Verified in scripts/publish-smoke.sh rather than assumed:

ContractReading
Invocationbash scripts/publish-smoke.sh — identical to publish-smoke.yml's pack-smoke step
ModeSMOKE_MODE defaults to pack, so no env is needed
Prereqthe script fails fast unless packages/cli/dist and the create-objectstack bin exist, i.e. pnpm install + pnpm run build must precede it
Target treeit packs from REPO_ROOT, resolved from the script's own location — whatever tree is checked out

The merge preview is a valid target and needs no plumbing. The one risk worth checking was whether pack mode assumes a release-branch layout the preview lacks; it does not. The release-branch coupling in publish-smoke.yml lives entirely in its resolve job (finding the release PR and a report-sha to post a status to), never in the driver. On pull_request the default actions/checkout ref is already refs/pull/N/merge, and the check run lands on the PR itself — so this workflow needs noresolve job, noresolve-guard, and nostatuses: write. It runs with contents: read only. No driver changes were required, and none were made.

Scope boundaries, honoured

Design decisions worth review

The label

needs:pack-smoke did not exist. It was created on this repo (colour 006b75, description 94 chars), and — more importantly — declared in scripts/pm/ensure-pm-labels.sh, the repo's only declared home for a label object. An undeclared label is the grey / empty-description drift that file's header describes: auto-created by its first application and unrepairable by any rerun. Declaring it also puts its description under check:pm-label-desc-cap.

The added comment states plainly that this is the first row in that file that is not part of the PM state machine — it is written by the PR author about their own diff, names a property of the change rather than a position on the board, and no sweep in scripts/pm/ reads it.

⛔ It is never auto-applied: no .github/labeler.yml rule, by design. Path-derived application would be a different design from the one ruled, and would put the ~45-minute cost back into the default inner loop the ruling kept it out of.

Documentation line

One line in CONTRIBUTING.md's "Before Submitting" checklist — where a PR author actually meets it — carrying the ruling's criterion verbatim in substance: the PR changes the auth/audience defaults or the accept/reject behaviour of the unauthenticated surface.

Residual risk, stated rather than hidden

Self-declaration only covers the author who recognises their change as breaking. An author who does not realise they widened the unauthenticated surface still gets no pre-merge pack coverage; the release-time leg remains the backstop for that case. Closing that would need a detection rule — a different card and a different ruling. This is written into the workflow header too, so the next reader does not mistake the opt-in shape for full coverage.

Checks

Gate families derived mechanically from the real changeset — node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack (no hand-written path list) — which named 31 families; harvested with --commands and all 31 run.

  • 30 of 31 green.
  • 1 NOT MEASURED, not a red:scripts/check-test-completeness.mjs exits 3 with no test log to read, and says so itself: "the local reading for this gate is NOT MEASURED … ⛔ It is not a red, and there is nothing here to fix." CI tees it a real log and passes the path, so that branch is unreachable there.

Re-run union on the final commit 820a49923 (12 families, all green), quoting each gate's own verdict line:

check-workflow-status-functions: OK (scanned 30 workflow file(s), 53 job(s), 26 job-level if: expression(s);
10 read needs.*.outputs.*, all naming a status function).
check:pm-label-desc-cap: 22 label descriptions in scripts/pm/ensure-pm-labels.sh, all <=100 characters
(longest: 100, repo:objectui).
check-required-contexts: 6 required context name(s) pinned across 2 workflow(s).
check-stall-guard-budget: OK (30 workflow file(s), 53 job(s), 572 step(s), 7 guard-wrapped step(s);
every effective cap clears its job budget by at least one stall window).
check-nul-bytes: OK (scanned 7794 text file(s); no raw ASCII control bytes).
check:declared-population-live - 156 of 200 famil(ies) declare a path population, and every one reaches this tree.
check-bash32-floor: 26 tracked shell file(s) ... name no bash 4+ construct outside a comment.

Plus pnpm check:ratchet-remedy-authority (green: 183 scripts swept) and pnpm check:pm-dispatch-gates (green: 1140 self-test cases), both requested for the scripts/** touch.

The new workflow was also parsed with the repo's own yaml library to confirm on: did not fall into the YAML-1.1 true trap and that the guard expression survives folding intact.

Releases nothing (.github/, scripts/pm/, CONTRIBUTING.md), so skip-changeset is applied per the Check Changeset step's own route 2.

Demonstration run

needs:pack-smoke is applied to this draft PR so the new job fires on it — the trigger demonstrating itself. The run is cited in a follow-up comment once it has a URL. Note the smoke exercises the merge preview of this PR, whose diff is CI wiring only, so a green here demonstrates the trigger, not any auth/audience behaviour.

⛔ Draft on purpose — not to be marked ready by an agent.


Generated by Claude Code

Add a `pull_request` trigger that runs the existing pack-install smoke on a
PR's merge preview while the PR carries `needs:pack-smoke`.
The pack smoke previously ran only on `workflow_run` after a Release run, so
its verdict landed as a commit status on the changesets release branch head --
a surface no PR author reads. A breaking auth/audience change therefore merged
with zero packed-install coverage on its own PR, and the smoke then sat red on
the release candidate for ~7 days.
This adds the trigger only. The driver, its probes and every assertion in
scripts/publish-smoke.sh are untouched: re-pinning those to the declared
first-run contract was a separate deliverable that has already landed.
Opt-in by ruling -- an unlabelled PR pays no new cost. The guard's second limb
keeps an unrelated label add (size/*, ci/cd) from restarting a 45-minute smoke,
and the concurrency group sits at job level so a run that skips can never
cancel a run that is really smoking.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actionsgithub-actionsBot added size/m ci/cd documentation Improvements or additions to documentation labels Sep 1, 2026
@claudeclaudeBot added needs:pack-smoke Opt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md) skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 1, 2026
@claude

claudeBot commented Sep 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Demonstration run — all three arms observed live on this PR

The trigger demonstrating itself. Three pull_request runs of Pack Smoke (opt-in) landed on this PR, and between them they exercise every arm of the guard — measured, not asserted:

RunEventJob outcomeWhat it demonstrates
33539960970opened, no label yetskipped⛔ boundary #2 of the ruling: an unlabelled PR pays zero new cost
33540022686labeledskip-changesetskippedthe guard's SECOND limb: an unrelated label add does not start a 45-minute smoke of an unchanged tree
33540022809labeledneeds:pack-smokein_progressthe trigger fires on the opt-in label, against the merge preview

The middle row is the one that would otherwise be easy to get wrong and impossible to notice: without that limb, every size/* and ci/cd label the automation adds to an already-labelled PR would each start another full smoke.

Note the smoke here exercises the merge preview of this PR, whose diff is CI wiring only — so its eventual colour demonstrates the trigger, not any auth/audience behaviour. Per the dispatch contract the report is filed at draft-PR time rather than waiting for the ~45-minute run to converge; the run above is cited at in_progress.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 18:02
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 54c37fbSep 1, 2026
40 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14214-labeled-pack-smoke branch September 1, 2026 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cddocumentationImprovements or additions to documentationneeds:pack-smokeOpt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md)size/mskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label 门控的 opt-in 预合并 pack-smoke —— 破坏性 auth/audience 面 PR 在合并前跑一次打包安装冒烟(#14000 附问裁决派生)

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

ci(devx): label-gated opt-in pre-merge pack smoke - #14266

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke
Sep 1, 2026
Merged

ci(devx): label-gated opt-in pre-merge pack smoke#14266
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#14214

Adds the missing trigger for the packed-install smoke: while a PR carries needs:pack-smoke, CI runs the existing pack smoke against that PR's merge preview, before the merge, as a check run the author already reads.

Derived from the maintainer-approved ruling on #14000 (2026-09-01, director batch #23, 「同意」; the follow-up recommendation 「label 门控 opt-in」 was the one approved).

Premise re-check (done first, on fresh origin/main)

The card's premise holds. Verified at base 035951faf:

  • git grep -n 'labeled' -- .github/workflows/ returns no labeled trigger anywhere — every hit is prose, or pr-automation.yml explicitly excludinglabeled/unlabeled from its jobs. There was no pre-merge pack-smoke trigger of any kind to collide with.
  • Positive control (the leg the card describes) is present and reads exactly as described: publish-smoke.yml triggers on: workflow_run: workflows: [Release], resolves the open changeset-release/main PR, and reports publish-smoke / packed-tarballs as a commit status on the release branch head. That is a release surface, not a PR surface — which is the whole gap.
  • Base already carries fix(devx): re-pin the publish smoke to the declared first-run contract #14255 (035951fa), so the driver reused here is the re-pinned one.

Driver-contract verification (read off the driver, not invented)

Verified in scripts/publish-smoke.sh rather than assumed:

ContractReading
Invocationbash scripts/publish-smoke.sh — identical to publish-smoke.yml's pack-smoke step
ModeSMOKE_MODE defaults to pack, so no env is needed
Prereqthe script fails fast unless packages/cli/dist and the create-objectstack bin exist, i.e. pnpm install + pnpm run build must precede it
Target treeit packs from REPO_ROOT, resolved from the script's own location — whatever tree is checked out

The merge preview is a valid target and needs no plumbing. The one risk worth checking was whether pack mode assumes a release-branch layout the preview lacks; it does not. The release-branch coupling in publish-smoke.yml lives entirely in its resolve job (finding the release PR and a report-sha to post a status to), never in the driver. On pull_request the default actions/checkout ref is already refs/pull/N/merge, and the check run lands on the PR itself — so this workflow needs noresolve job, noresolve-guard, and nostatuses: write. It runs with contents: read only. No driver changes were required, and none were made.

Scope boundaries, honoured

Design decisions worth review

The label

needs:pack-smoke did not exist. It was created on this repo (colour 006b75, description 94 chars), and — more importantly — declared in scripts/pm/ensure-pm-labels.sh, the repo's only declared home for a label object. An undeclared label is the grey / empty-description drift that file's header describes: auto-created by its first application and unrepairable by any rerun. Declaring it also puts its description under check:pm-label-desc-cap.

The added comment states plainly that this is the first row in that file that is not part of the PM state machine — it is written by the PR author about their own diff, names a property of the change rather than a position on the board, and no sweep in scripts/pm/ reads it.

⛔ It is never auto-applied: no .github/labeler.yml rule, by design. Path-derived application would be a different design from the one ruled, and would put the ~45-minute cost back into the default inner loop the ruling kept it out of.

Documentation line

One line in CONTRIBUTING.md's "Before Submitting" checklist — where a PR author actually meets it — carrying the ruling's criterion verbatim in substance: the PR changes the auth/audience defaults or the accept/reject behaviour of the unauthenticated surface.

Residual risk, stated rather than hidden

Self-declaration only covers the author who recognises their change as breaking. An author who does not realise they widened the unauthenticated surface still gets no pre-merge pack coverage; the release-time leg remains the backstop for that case. Closing that would need a detection rule — a different card and a different ruling. This is written into the workflow header too, so the next reader does not mistake the opt-in shape for full coverage.

Checks

Gate families derived mechanically from the real changeset — node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack (no hand-written path list) — which named 31 families; harvested with --commands and all 31 run.

  • 30 of 31 green.
  • 1 NOT MEASURED, not a red:scripts/check-test-completeness.mjs exits 3 with no test log to read, and says so itself: "the local reading for this gate is NOT MEASURED … ⛔ It is not a red, and there is nothing here to fix." CI tees it a real log and passes the path, so that branch is unreachable there.

Re-run union on the final commit 820a49923 (12 families, all green), quoting each gate's own verdict line:

check-workflow-status-functions: OK (scanned 30 workflow file(s), 53 job(s), 26 job-level if: expression(s);
10 read needs.*.outputs.*, all naming a status function).
check:pm-label-desc-cap: 22 label descriptions in scripts/pm/ensure-pm-labels.sh, all <=100 characters
(longest: 100, repo:objectui).
check-required-contexts: 6 required context name(s) pinned across 2 workflow(s).
check-stall-guard-budget: OK (30 workflow file(s), 53 job(s), 572 step(s), 7 guard-wrapped step(s);
every effective cap clears its job budget by at least one stall window).
check-nul-bytes: OK (scanned 7794 text file(s); no raw ASCII control bytes).
check:declared-population-live - 156 of 200 famil(ies) declare a path population, and every one reaches this tree.
check-bash32-floor: 26 tracked shell file(s) ... name no bash 4+ construct outside a comment.

Plus pnpm check:ratchet-remedy-authority (green: 183 scripts swept) and pnpm check:pm-dispatch-gates (green: 1140 self-test cases), both requested for the scripts/** touch.

The new workflow was also parsed with the repo's own yaml library to confirm on: did not fall into the YAML-1.1 true trap and that the guard expression survives folding intact.

Releases nothing (.github/, scripts/pm/, CONTRIBUTING.md), so skip-changeset is applied per the Check Changeset step's own route 2.

Demonstration run

needs:pack-smoke is applied to this draft PR so the new job fires on it — the trigger demonstrating itself. The run is cited in a follow-up comment once it has a URL. Note the smoke exercises the merge preview of this PR, whose diff is CI wiring only, so a green here demonstrates the trigger, not any auth/audience behaviour.

⛔ Draft on purpose — not to be marked ready by an agent.


Generated by Claude Code

Add a `pull_request` trigger that runs the existing pack-install smoke on a
PR's merge preview while the PR carries `needs:pack-smoke`.
The pack smoke previously ran only on `workflow_run` after a Release run, so
its verdict landed as a commit status on the changesets release branch head --
a surface no PR author reads. A breaking auth/audience change therefore merged
with zero packed-install coverage on its own PR, and the smoke then sat red on
the release candidate for ~7 days.
This adds the trigger only. The driver, its probes and every assertion in
scripts/publish-smoke.sh are untouched: re-pinning those to the declared
first-run contract was a separate deliverable that has already landed.
Opt-in by ruling -- an unlabelled PR pays no new cost. The guard's second limb
keeps an unrelated label add (size/*, ci/cd) from restarting a 45-minute smoke,
and the concurrency group sits at job level so a run that skips can never
cancel a run that is really smoking.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actionsgithub-actionsBot added size/m ci/cd documentation Improvements or additions to documentation labels Sep 1, 2026
@claudeclaudeBot added needs:pack-smoke Opt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md) skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 1, 2026
@claude

claudeBot commented Sep 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Demonstration run — all three arms observed live on this PR

The trigger demonstrating itself. Three pull_request runs of Pack Smoke (opt-in) landed on this PR, and between them they exercise every arm of the guard — measured, not asserted:

RunEventJob outcomeWhat it demonstrates
33539960970opened, no label yetskipped⛔ boundary #2 of the ruling: an unlabelled PR pays zero new cost
33540022686labeledskip-changesetskippedthe guard's SECOND limb: an unrelated label add does not start a 45-minute smoke of an unchanged tree
33540022809labeledneeds:pack-smokein_progressthe trigger fires on the opt-in label, against the merge preview

The middle row is the one that would otherwise be easy to get wrong and impossible to notice: without that limb, every size/* and ci/cd label the automation adds to an already-labelled PR would each start another full smoke.

Note the smoke here exercises the merge preview of this PR, whose diff is CI wiring only — so its eventual colour demonstrates the trigger, not any auth/audience behaviour. Per the dispatch contract the report is filed at draft-PR time rather than waiting for the ~45-minute run to converge; the run above is cited at in_progress.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 18:02
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 54c37fbSep 1, 2026
40 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14214-labeled-pack-smoke branch September 1, 2026 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cddocumentationImprovements or additions to documentationneeds:pack-smokeOpt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md)size/mskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label 门控的 opt-in 预合并 pack-smoke —— 破坏性 auth/audience 面 PR 在合并前跑一次打包安装冒烟(#14000 附问裁决派生)

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ci(devx): label-gated opt-in pre-merge pack smoke - #14266

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke
Sep 1, 2026
Merged

ci(devx): label-gated opt-in pre-merge pack smoke#14266
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#14214

Adds the missing trigger for the packed-install smoke: while a PR carries needs:pack-smoke, CI runs the existing pack smoke against that PR's merge preview, before the merge, as a check run the author already reads.

Derived from the maintainer-approved ruling on #14000 (2026-09-01, director batch #23, 「同意」; the follow-up recommendation 「label 门控 opt-in」 was the one approved).

Premise re-check (done first, on fresh origin/main)

The card's premise holds. Verified at base 035951faf:

  • git grep -n 'labeled' -- .github/workflows/ returns no labeled trigger anywhere — every hit is prose, or pr-automation.yml explicitly excludinglabeled/unlabeled from its jobs. There was no pre-merge pack-smoke trigger of any kind to collide with.
  • Positive control (the leg the card describes) is present and reads exactly as described: publish-smoke.yml triggers on: workflow_run: workflows: [Release], resolves the open changeset-release/main PR, and reports publish-smoke / packed-tarballs as a commit status on the release branch head. That is a release surface, not a PR surface — which is the whole gap.
  • Base already carries fix(devx): re-pin the publish smoke to the declared first-run contract #14255 (035951fa), so the driver reused here is the re-pinned one.

Driver-contract verification (read off the driver, not invented)

Verified in scripts/publish-smoke.sh rather than assumed:

ContractReading
Invocationbash scripts/publish-smoke.sh — identical to publish-smoke.yml's pack-smoke step
ModeSMOKE_MODE defaults to pack, so no env is needed
Prereqthe script fails fast unless packages/cli/dist and the create-objectstack bin exist, i.e. pnpm install + pnpm run build must precede it
Target treeit packs from REPO_ROOT, resolved from the script's own location — whatever tree is checked out

The merge preview is a valid target and needs no plumbing. The one risk worth checking was whether pack mode assumes a release-branch layout the preview lacks; it does not. The release-branch coupling in publish-smoke.yml lives entirely in its resolve job (finding the release PR and a report-sha to post a status to), never in the driver. On pull_request the default actions/checkout ref is already refs/pull/N/merge, and the check run lands on the PR itself — so this workflow needs noresolve job, noresolve-guard, and nostatuses: write. It runs with contents: read only. No driver changes were required, and none were made.

Scope boundaries, honoured

Design decisions worth review

The label

needs:pack-smoke did not exist. It was created on this repo (colour 006b75, description 94 chars), and — more importantly — declared in scripts/pm/ensure-pm-labels.sh, the repo's only declared home for a label object. An undeclared label is the grey / empty-description drift that file's header describes: auto-created by its first application and unrepairable by any rerun. Declaring it also puts its description under check:pm-label-desc-cap.

The added comment states plainly that this is the first row in that file that is not part of the PM state machine — it is written by the PR author about their own diff, names a property of the change rather than a position on the board, and no sweep in scripts/pm/ reads it.

⛔ It is never auto-applied: no .github/labeler.yml rule, by design. Path-derived application would be a different design from the one ruled, and would put the ~45-minute cost back into the default inner loop the ruling kept it out of.

Documentation line

One line in CONTRIBUTING.md's "Before Submitting" checklist — where a PR author actually meets it — carrying the ruling's criterion verbatim in substance: the PR changes the auth/audience defaults or the accept/reject behaviour of the unauthenticated surface.

Residual risk, stated rather than hidden

Self-declaration only covers the author who recognises their change as breaking. An author who does not realise they widened the unauthenticated surface still gets no pre-merge pack coverage; the release-time leg remains the backstop for that case. Closing that would need a detection rule — a different card and a different ruling. This is written into the workflow header too, so the next reader does not mistake the opt-in shape for full coverage.

Checks

Gate families derived mechanically from the real changeset — node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack (no hand-written path list) — which named 31 families; harvested with --commands and all 31 run.

  • 30 of 31 green.
  • 1 NOT MEASURED, not a red:scripts/check-test-completeness.mjs exits 3 with no test log to read, and says so itself: "the local reading for this gate is NOT MEASURED … ⛔ It is not a red, and there is nothing here to fix." CI tees it a real log and passes the path, so that branch is unreachable there.

Re-run union on the final commit 820a49923 (12 families, all green), quoting each gate's own verdict line:

check-workflow-status-functions: OK (scanned 30 workflow file(s), 53 job(s), 26 job-level if: expression(s);
10 read needs.*.outputs.*, all naming a status function).
check:pm-label-desc-cap: 22 label descriptions in scripts/pm/ensure-pm-labels.sh, all <=100 characters
(longest: 100, repo:objectui).
check-required-contexts: 6 required context name(s) pinned across 2 workflow(s).
check-stall-guard-budget: OK (30 workflow file(s), 53 job(s), 572 step(s), 7 guard-wrapped step(s);
every effective cap clears its job budget by at least one stall window).
check-nul-bytes: OK (scanned 7794 text file(s); no raw ASCII control bytes).
check:declared-population-live - 156 of 200 famil(ies) declare a path population, and every one reaches this tree.
check-bash32-floor: 26 tracked shell file(s) ... name no bash 4+ construct outside a comment.

Plus pnpm check:ratchet-remedy-authority (green: 183 scripts swept) and pnpm check:pm-dispatch-gates (green: 1140 self-test cases), both requested for the scripts/** touch.

The new workflow was also parsed with the repo's own yaml library to confirm on: did not fall into the YAML-1.1 true trap and that the guard expression survives folding intact.

Releases nothing (.github/, scripts/pm/, CONTRIBUTING.md), so skip-changeset is applied per the Check Changeset step's own route 2.

Demonstration run

needs:pack-smoke is applied to this draft PR so the new job fires on it — the trigger demonstrating itself. The run is cited in a follow-up comment once it has a URL. Note the smoke exercises the merge preview of this PR, whose diff is CI wiring only, so a green here demonstrates the trigger, not any auth/audience behaviour.

⛔ Draft on purpose — not to be marked ready by an agent.


Generated by Claude Code

Add a `pull_request` trigger that runs the existing pack-install smoke on a
PR's merge preview while the PR carries `needs:pack-smoke`.
The pack smoke previously ran only on `workflow_run` after a Release run, so
its verdict landed as a commit status on the changesets release branch head --
a surface no PR author reads. A breaking auth/audience change therefore merged
with zero packed-install coverage on its own PR, and the smoke then sat red on
the release candidate for ~7 days.
This adds the trigger only. The driver, its probes and every assertion in
scripts/publish-smoke.sh are untouched: re-pinning those to the declared
first-run contract was a separate deliverable that has already landed.
Opt-in by ruling -- an unlabelled PR pays no new cost. The guard's second limb
keeps an unrelated label add (size/*, ci/cd) from restarting a 45-minute smoke,
and the concurrency group sits at job level so a run that skips can never
cancel a run that is really smoking.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actionsgithub-actionsBot added size/m ci/cd documentation Improvements or additions to documentation labels Sep 1, 2026
@claudeclaudeBot added needs:pack-smoke Opt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md) skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 1, 2026
@claude

claudeBot commented Sep 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Demonstration run — all three arms observed live on this PR

The trigger demonstrating itself. Three pull_request runs of Pack Smoke (opt-in) landed on this PR, and between them they exercise every arm of the guard — measured, not asserted:

RunEventJob outcomeWhat it demonstrates
33539960970opened, no label yetskipped⛔ boundary #2 of the ruling: an unlabelled PR pays zero new cost
33540022686labeledskip-changesetskippedthe guard's SECOND limb: an unrelated label add does not start a 45-minute smoke of an unchanged tree
33540022809labeledneeds:pack-smokein_progressthe trigger fires on the opt-in label, against the merge preview

The middle row is the one that would otherwise be easy to get wrong and impossible to notice: without that limb, every size/* and ci/cd label the automation adds to an already-labelled PR would each start another full smoke.

Note the smoke here exercises the merge preview of this PR, whose diff is CI wiring only — so its eventual colour demonstrates the trigger, not any auth/audience behaviour. Per the dispatch contract the report is filed at draft-PR time rather than waiting for the ~45-minute run to converge; the run above is cited at in_progress.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 18:02
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 54c37fbSep 1, 2026
40 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14214-labeled-pack-smoke branch September 1, 2026 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cddocumentationImprovements or additions to documentationneeds:pack-smokeOpt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md)size/mskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label 门控的 opt-in 预合并 pack-smoke —— 破坏性 auth/audience 面 PR 在合并前跑一次打包安装冒烟(#14000 附问裁决派生)

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ci(devx): label-gated opt-in pre-merge pack smoke - #14266

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke
Sep 1, 2026
Merged

ci(devx): label-gated opt-in pre-merge pack smoke#14266
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#14214

Adds the missing trigger for the packed-install smoke: while a PR carries needs:pack-smoke, CI runs the existing pack smoke against that PR's merge preview, before the merge, as a check run the author already reads.

Derived from the maintainer-approved ruling on #14000 (2026-09-01, director batch #23, 「同意」; the follow-up recommendation 「label 门控 opt-in」 was the one approved).

Premise re-check (done first, on fresh origin/main)

The card's premise holds. Verified at base 035951faf:

  • git grep -n 'labeled' -- .github/workflows/ returns no labeled trigger anywhere — every hit is prose, or pr-automation.yml explicitly excludinglabeled/unlabeled from its jobs. There was no pre-merge pack-smoke trigger of any kind to collide with.
  • Positive control (the leg the card describes) is present and reads exactly as described: publish-smoke.yml triggers on: workflow_run: workflows: [Release], resolves the open changeset-release/main PR, and reports publish-smoke / packed-tarballs as a commit status on the release branch head. That is a release surface, not a PR surface — which is the whole gap.
  • Base already carries fix(devx): re-pin the publish smoke to the declared first-run contract #14255 (035951fa), so the driver reused here is the re-pinned one.

Driver-contract verification (read off the driver, not invented)

Verified in scripts/publish-smoke.sh rather than assumed:

ContractReading
Invocationbash scripts/publish-smoke.sh — identical to publish-smoke.yml's pack-smoke step
ModeSMOKE_MODE defaults to pack, so no env is needed
Prereqthe script fails fast unless packages/cli/dist and the create-objectstack bin exist, i.e. pnpm install + pnpm run build must precede it
Target treeit packs from REPO_ROOT, resolved from the script's own location — whatever tree is checked out

The merge preview is a valid target and needs no plumbing. The one risk worth checking was whether pack mode assumes a release-branch layout the preview lacks; it does not. The release-branch coupling in publish-smoke.yml lives entirely in its resolve job (finding the release PR and a report-sha to post a status to), never in the driver. On pull_request the default actions/checkout ref is already refs/pull/N/merge, and the check run lands on the PR itself — so this workflow needs noresolve job, noresolve-guard, and nostatuses: write. It runs with contents: read only. No driver changes were required, and none were made.

Scope boundaries, honoured

Design decisions worth review

The label

needs:pack-smoke did not exist. It was created on this repo (colour 006b75, description 94 chars), and — more importantly — declared in scripts/pm/ensure-pm-labels.sh, the repo's only declared home for a label object. An undeclared label is the grey / empty-description drift that file's header describes: auto-created by its first application and unrepairable by any rerun. Declaring it also puts its description under check:pm-label-desc-cap.

The added comment states plainly that this is the first row in that file that is not part of the PM state machine — it is written by the PR author about their own diff, names a property of the change rather than a position on the board, and no sweep in scripts/pm/ reads it.

⛔ It is never auto-applied: no .github/labeler.yml rule, by design. Path-derived application would be a different design from the one ruled, and would put the ~45-minute cost back into the default inner loop the ruling kept it out of.

Documentation line

One line in CONTRIBUTING.md's "Before Submitting" checklist — where a PR author actually meets it — carrying the ruling's criterion verbatim in substance: the PR changes the auth/audience defaults or the accept/reject behaviour of the unauthenticated surface.

Residual risk, stated rather than hidden

Self-declaration only covers the author who recognises their change as breaking. An author who does not realise they widened the unauthenticated surface still gets no pre-merge pack coverage; the release-time leg remains the backstop for that case. Closing that would need a detection rule — a different card and a different ruling. This is written into the workflow header too, so the next reader does not mistake the opt-in shape for full coverage.

Checks

Gate families derived mechanically from the real changeset — node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack (no hand-written path list) — which named 31 families; harvested with --commands and all 31 run.

  • 30 of 31 green.
  • 1 NOT MEASURED, not a red:scripts/check-test-completeness.mjs exits 3 with no test log to read, and says so itself: "the local reading for this gate is NOT MEASURED … ⛔ It is not a red, and there is nothing here to fix." CI tees it a real log and passes the path, so that branch is unreachable there.

Re-run union on the final commit 820a49923 (12 families, all green), quoting each gate's own verdict line:

check-workflow-status-functions: OK (scanned 30 workflow file(s), 53 job(s), 26 job-level if: expression(s);
10 read needs.*.outputs.*, all naming a status function).
check:pm-label-desc-cap: 22 label descriptions in scripts/pm/ensure-pm-labels.sh, all <=100 characters
(longest: 100, repo:objectui).
check-required-contexts: 6 required context name(s) pinned across 2 workflow(s).
check-stall-guard-budget: OK (30 workflow file(s), 53 job(s), 572 step(s), 7 guard-wrapped step(s);
every effective cap clears its job budget by at least one stall window).
check-nul-bytes: OK (scanned 7794 text file(s); no raw ASCII control bytes).
check:declared-population-live - 156 of 200 famil(ies) declare a path population, and every one reaches this tree.
check-bash32-floor: 26 tracked shell file(s) ... name no bash 4+ construct outside a comment.

Plus pnpm check:ratchet-remedy-authority (green: 183 scripts swept) and pnpm check:pm-dispatch-gates (green: 1140 self-test cases), both requested for the scripts/** touch.

The new workflow was also parsed with the repo's own yaml library to confirm on: did not fall into the YAML-1.1 true trap and that the guard expression survives folding intact.

Releases nothing (.github/, scripts/pm/, CONTRIBUTING.md), so skip-changeset is applied per the Check Changeset step's own route 2.

Demonstration run

needs:pack-smoke is applied to this draft PR so the new job fires on it — the trigger demonstrating itself. The run is cited in a follow-up comment once it has a URL. Note the smoke exercises the merge preview of this PR, whose diff is CI wiring only, so a green here demonstrates the trigger, not any auth/audience behaviour.

⛔ Draft on purpose — not to be marked ready by an agent.


Generated by Claude Code

Add a `pull_request` trigger that runs the existing pack-install smoke on a
PR's merge preview while the PR carries `needs:pack-smoke`.
The pack smoke previously ran only on `workflow_run` after a Release run, so
its verdict landed as a commit status on the changesets release branch head --
a surface no PR author reads. A breaking auth/audience change therefore merged
with zero packed-install coverage on its own PR, and the smoke then sat red on
the release candidate for ~7 days.
This adds the trigger only. The driver, its probes and every assertion in
scripts/publish-smoke.sh are untouched: re-pinning those to the declared
first-run contract was a separate deliverable that has already landed.
Opt-in by ruling -- an unlabelled PR pays no new cost. The guard's second limb
keeps an unrelated label add (size/*, ci/cd) from restarting a 45-minute smoke,
and the concurrency group sits at job level so a run that skips can never
cancel a run that is really smoking.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actionsgithub-actionsBot added size/m ci/cd documentation Improvements or additions to documentation labels Sep 1, 2026
@claudeclaudeBot added needs:pack-smoke Opt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md) skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 1, 2026
@claude

claudeBot commented Sep 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Demonstration run — all three arms observed live on this PR

The trigger demonstrating itself. Three pull_request runs of Pack Smoke (opt-in) landed on this PR, and between them they exercise every arm of the guard — measured, not asserted:

RunEventJob outcomeWhat it demonstrates
33539960970opened, no label yetskipped⛔ boundary #2 of the ruling: an unlabelled PR pays zero new cost
33540022686labeledskip-changesetskippedthe guard's SECOND limb: an unrelated label add does not start a 45-minute smoke of an unchanged tree
33540022809labeledneeds:pack-smokein_progressthe trigger fires on the opt-in label, against the merge preview

The middle row is the one that would otherwise be easy to get wrong and impossible to notice: without that limb, every size/* and ci/cd label the automation adds to an already-labelled PR would each start another full smoke.

Note the smoke here exercises the merge preview of this PR, whose diff is CI wiring only — so its eventual colour demonstrates the trigger, not any auth/audience behaviour. Per the dispatch contract the report is filed at draft-PR time rather than waiting for the ~45-minute run to converge; the run above is cited at in_progress.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 18:02
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 54c37fbSep 1, 2026
40 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14214-labeled-pack-smoke branch September 1, 2026 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cddocumentationImprovements or additions to documentationneeds:pack-smokeOpt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md)size/mskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label 门控的 opt-in 预合并 pack-smoke —— 破坏性 auth/audience 面 PR 在合并前跑一次打包安装冒烟(#14000 附问裁决派生)

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

ci(devx): label-gated opt-in pre-merge pack smoke - #14266

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke
Sep 1, 2026
Merged

ci(devx): label-gated opt-in pre-merge pack smoke#14266
baozhoutao merged 1 commit into
mainfrom
claude/issue-14214-labeled-pack-smoke

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#14214

Adds the missing trigger for the packed-install smoke: while a PR carries needs:pack-smoke, CI runs the existing pack smoke against that PR's merge preview, before the merge, as a check run the author already reads.

Derived from the maintainer-approved ruling on #14000 (2026-09-01, director batch #23, 「同意」; the follow-up recommendation 「label 门控 opt-in」 was the one approved).

Premise re-check (done first, on fresh origin/main)

The card's premise holds. Verified at base 035951faf:

  • git grep -n 'labeled' -- .github/workflows/ returns no labeled trigger anywhere — every hit is prose, or pr-automation.yml explicitly excludinglabeled/unlabeled from its jobs. There was no pre-merge pack-smoke trigger of any kind to collide with.
  • Positive control (the leg the card describes) is present and reads exactly as described: publish-smoke.yml triggers on: workflow_run: workflows: [Release], resolves the open changeset-release/main PR, and reports publish-smoke / packed-tarballs as a commit status on the release branch head. That is a release surface, not a PR surface — which is the whole gap.
  • Base already carries fix(devx): re-pin the publish smoke to the declared first-run contract #14255 (035951fa), so the driver reused here is the re-pinned one.

Driver-contract verification (read off the driver, not invented)

Verified in scripts/publish-smoke.sh rather than assumed:

ContractReading
Invocationbash scripts/publish-smoke.sh — identical to publish-smoke.yml's pack-smoke step
ModeSMOKE_MODE defaults to pack, so no env is needed
Prereqthe script fails fast unless packages/cli/dist and the create-objectstack bin exist, i.e. pnpm install + pnpm run build must precede it
Target treeit packs from REPO_ROOT, resolved from the script's own location — whatever tree is checked out

The merge preview is a valid target and needs no plumbing. The one risk worth checking was whether pack mode assumes a release-branch layout the preview lacks; it does not. The release-branch coupling in publish-smoke.yml lives entirely in its resolve job (finding the release PR and a report-sha to post a status to), never in the driver. On pull_request the default actions/checkout ref is already refs/pull/N/merge, and the check run lands on the PR itself — so this workflow needs noresolve job, noresolve-guard, and nostatuses: write. It runs with contents: read only. No driver changes were required, and none were made.

Scope boundaries, honoured

Design decisions worth review

The label

needs:pack-smoke did not exist. It was created on this repo (colour 006b75, description 94 chars), and — more importantly — declared in scripts/pm/ensure-pm-labels.sh, the repo's only declared home for a label object. An undeclared label is the grey / empty-description drift that file's header describes: auto-created by its first application and unrepairable by any rerun. Declaring it also puts its description under check:pm-label-desc-cap.

The added comment states plainly that this is the first row in that file that is not part of the PM state machine — it is written by the PR author about their own diff, names a property of the change rather than a position on the board, and no sweep in scripts/pm/ reads it.

⛔ It is never auto-applied: no .github/labeler.yml rule, by design. Path-derived application would be a different design from the one ruled, and would put the ~45-minute cost back into the default inner loop the ruling kept it out of.

Documentation line

One line in CONTRIBUTING.md's "Before Submitting" checklist — where a PR author actually meets it — carrying the ruling's criterion verbatim in substance: the PR changes the auth/audience defaults or the accept/reject behaviour of the unauthenticated surface.

Residual risk, stated rather than hidden

Self-declaration only covers the author who recognises their change as breaking. An author who does not realise they widened the unauthenticated surface still gets no pre-merge pack coverage; the release-time leg remains the backstop for that case. Closing that would need a detection rule — a different card and a different ruling. This is written into the workflow header too, so the next reader does not mistake the opt-in shape for full coverage.

Checks

Gate families derived mechanically from the real changeset — node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack (no hand-written path list) — which named 31 families; harvested with --commands and all 31 run.

  • 30 of 31 green.
  • 1 NOT MEASURED, not a red:scripts/check-test-completeness.mjs exits 3 with no test log to read, and says so itself: "the local reading for this gate is NOT MEASURED … ⛔ It is not a red, and there is nothing here to fix." CI tees it a real log and passes the path, so that branch is unreachable there.

Re-run union on the final commit 820a49923 (12 families, all green), quoting each gate's own verdict line:

check-workflow-status-functions: OK (scanned 30 workflow file(s), 53 job(s), 26 job-level if: expression(s);
10 read needs.*.outputs.*, all naming a status function).
check:pm-label-desc-cap: 22 label descriptions in scripts/pm/ensure-pm-labels.sh, all <=100 characters
(longest: 100, repo:objectui).
check-required-contexts: 6 required context name(s) pinned across 2 workflow(s).
check-stall-guard-budget: OK (30 workflow file(s), 53 job(s), 572 step(s), 7 guard-wrapped step(s);
every effective cap clears its job budget by at least one stall window).
check-nul-bytes: OK (scanned 7794 text file(s); no raw ASCII control bytes).
check:declared-population-live - 156 of 200 famil(ies) declare a path population, and every one reaches this tree.
check-bash32-floor: 26 tracked shell file(s) ... name no bash 4+ construct outside a comment.

Plus pnpm check:ratchet-remedy-authority (green: 183 scripts swept) and pnpm check:pm-dispatch-gates (green: 1140 self-test cases), both requested for the scripts/** touch.

The new workflow was also parsed with the repo's own yaml library to confirm on: did not fall into the YAML-1.1 true trap and that the guard expression survives folding intact.

Releases nothing (.github/, scripts/pm/, CONTRIBUTING.md), so skip-changeset is applied per the Check Changeset step's own route 2.

Demonstration run

needs:pack-smoke is applied to this draft PR so the new job fires on it — the trigger demonstrating itself. The run is cited in a follow-up comment once it has a URL. Note the smoke exercises the merge preview of this PR, whose diff is CI wiring only, so a green here demonstrates the trigger, not any auth/audience behaviour.

⛔ Draft on purpose — not to be marked ready by an agent.


Generated by Claude Code

Add a `pull_request` trigger that runs the existing pack-install smoke on a
PR's merge preview while the PR carries `needs:pack-smoke`.
The pack smoke previously ran only on `workflow_run` after a Release run, so
its verdict landed as a commit status on the changesets release branch head --
a surface no PR author reads. A breaking auth/audience change therefore merged
with zero packed-install coverage on its own PR, and the smoke then sat red on
the release candidate for ~7 days.
This adds the trigger only. The driver, its probes and every assertion in
scripts/publish-smoke.sh are untouched: re-pinning those to the declared
first-run contract was a separate deliverable that has already landed.
Opt-in by ruling -- an unlabelled PR pays no new cost. The guard's second limb
keeps an unrelated label add (size/*, ci/cd) from restarting a 45-minute smoke,
and the concurrency group sits at job level so a run that skips can never
cancel a run that is really smoking.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actionsgithub-actionsBot added size/m ci/cd documentation Improvements or additions to documentation labels Sep 1, 2026
@claudeclaudeBot added needs:pack-smoke Opt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md) skip-changeset PR has no user-facing published change; bypasses the changeset gate labels Sep 1, 2026
@claude

claudeBot commented Sep 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Demonstration run — all three arms observed live on this PR

The trigger demonstrating itself. Three pull_request runs of Pack Smoke (opt-in) landed on this PR, and between them they exercise every arm of the guard — measured, not asserted:

RunEventJob outcomeWhat it demonstrates
33539960970opened, no label yetskipped⛔ boundary #2 of the ruling: an unlabelled PR pays zero new cost
33540022686labeledskip-changesetskippedthe guard's SECOND limb: an unrelated label add does not start a 45-minute smoke of an unchanged tree
33540022809labeledneeds:pack-smokein_progressthe trigger fires on the opt-in label, against the merge preview

The middle row is the one that would otherwise be easy to get wrong and impossible to notice: without that limb, every size/* and ci/cd label the automation adds to an already-labelled PR would each start another full smoke.

Note the smoke here exercises the merge preview of this PR, whose diff is CI wiring only — so its eventual colour demonstrates the trigger, not any auth/audience behaviour. Per the dispatch contract the report is filed at draft-PR time rather than waiting for the ~45-minute run to converge; the run above is cited at in_progress.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 18:02
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 54c37fbSep 1, 2026
40 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14214-labeled-pack-smoke branch September 1, 2026 18:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cddocumentationImprovements or additions to documentationneeds:pack-smokeOpt-in pre-merge pack smoke: self-declared breaking auth/audience change (see CONTRIBUTING.md)size/mskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label 门控的 opt-in 预合并 pack-smoke —— 破坏性 auth/audience 面 PR 在合并前跑一次打包安装冒烟(#14000 附问裁决派生)

2 participants

@baozhoutao@claude