fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201) - #14370

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows
Sep 2, 2026
Merged

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201)#14370
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14201

What changed

packages/lint/src/validate-readonly-flow-writes.ts carried the runAs:'system'
exemption as a single flow-level early return, so an elevated flow left the walk
before either branch of the rule could judge it. That skip now gates the static
readonly branch only
; the readonlyWhen branch inspects a runAs:'system' flow
like any other, at its existing warning severity. Rule ids and severities are
untouched.

- if (flow.runAs === 'system') return;
const runAs = flow.runAs === 'user' || flow.runAs === 'system' ? flow.runAs : 'user';
+ const isSystemRun = runAs === 'system';
...
- if (meta.readonly) {+ if (meta.readonly && !isSystemRun) {

A field declaring both flags therefore falls through to the conditional branch
under runAs:'system' — which is the truth about that write: the static strip is
skipped, the conditional one is not.

Engine authority (verified on origin/main, not recalled)

packages/objectql/src/engine.ts, the by-id update path — the conditional strip runs
with no guard, and the note at the call site says so:

// [#9107] ... The API-boundary lock is unchanged - a caller cannot make its own
// value look hook-written (see `ReadonlyWhenStripOptions`) - and `isSystem`
// is still NOT an exemption here, unlike the static strip below.
hookContext.input.data = stripReadonlyWhenFields(updateSchema as any, preRoWhen, priorRecord, this.logger, roWhenParent, { supplied: suppliedValues }) as any;

The static strip, twenty lines below, is the one an elevated caller really does bypass:

if (!opCtx.context?.isSystem) {
const preRo = hookContext.input.data as Record...; // elided: a generic type argument, spelled out here to keep angle brackets out of this body
hookContext.input.data = stripReadonlyFields(updateSchema as any, preRo, suppliedValues, this.logger, { ... }) as any;

The bulk path (stripReadonlyWhenFieldsMulti / stripReadonlyFields) is split the
same way, so the asymmetry is not a by-id accident. Pinned from both sides:
engine-readonly-when-derived-writes.test.ts line 195, "LOCK 2 - isSystem does NOT
exempt a caller-supplied value (Option B stays rejected)"
, and
engine-readonly-strict-writes.test.ts.

The rule's own header already recorded this gap ("the skip above is therefore WIDER
than the conditional lock warrants ... Left as-is deliberately") — that paragraph is
now rewritten to describe the split it documents. The action sibling
validate-readonly-action-writes.ts was born with exactly this shape: an action body
is system-elevated by design, so it carries the conditional half and only that half.

Tests

packages/lint/src/validate-readonly-flow-writes.test.ts — 5 new cases, existing ones
kept:

  • positive: a runAs:'system' flow whose update_record writes a readonlyWhen
    field ⇒ one warning on flow-update-readonly-when-field, message naming the run
    identity it was judged under;
  • negative kept and re-titled: a runAs:'system' flow writing a static
    readonly:true field ⇒ still silent;
  • a system node writing both kinds plus a plain field in one payload ⇒ the conditional
    half only, no error;
  • a field declaring readonlyandreadonlyWhen ⇒ warning under system, error
    under user;
  • nested-region reach and create_record exemption, both under runAs:'system'.

Commands run (all at head 8b99b5c2d, exit codes captured before any pipe)

commandexit
pnpm --filter '@objectstack/lint^...' build0
pnpm --filter @objectstack/lint test0 — 93 files, 2720 passed / 5 skipped
pnpm --filter @objectstack/lint typecheck0
node scripts/pm/dispatch-gates.mjs --commands union (33 families)30 exit 0, 3 exit 3
node scripts/pm/dispatch-gates.mjs --ran0 — 33 derived, 33 run, 0 UNRUN

The three exit-3 rows are prerequisite-not-met, i.e. NOT MEASURED locally and not
findings, each saying so in its own verdict text: check-test-completeness.mjs (grades
a saved turbo run test log CI tees), check:dual-build-cjs-loads and
check:type-check-debt (both need the whole workspace built).

Reverse verification: with the flow-level return re-injected and the rest of the
change left in place, the rule test file goes 4 failed / 20 passed — exactly the
four new runAs:system cases — and back to 24 passed restored. The mutation was
confirmed on disk (unique anchor asserted, injected-marker grep -c = 1, mutated
git hash-object differs from the HEAD blob) and the restore proved by hash equality
with the HEAD blob plus an empty git diff HEAD; no build was involved because the
test imports the rule module by relative source path, not through dist/.

ESLint was run narrowed rather than repo-wide, and the narrowing is measured: this
repo runs one eslint.config.mjs that never enables type-aware linting for any file
(no parserOptions.project, no typed @typescript-eslint rules — stated and measured
in that config's own header), so no file's verdict depends on a file outside itself and
a two-file diff cannot move an untouched file's result. eslint --no-inline-config --format json over the diff reports 3 result entries: 0 errors / 0 warnings on both
.ts files, and the changeset .md reported as ignored (no matching configuration),
so 2 lintable files, both clean. The repo-wide sweep is CI's Lint & Repo Gates run.

Not in scope

The readonlyWhen hint text is left exactly as #14202 landed it. It reads correctly
under an elevated run too — "the conditional lock is NOT waived by a system context" is
precisely what a runAs:'system' author needs told — and message text is that card's
fence, not this one's.


Generated by Claude Code

The runAs:'system' exemption in validate-readonly-flow-writes was a single
flow-level early return, removing an elevated flow from BOTH branches of the
rule. Only the static branch warrants it: the engine skips stripReadonlyFields
under `if (!opCtx.context?.isSystem)`, while stripReadonlyWhenFields runs on the
update path with no isSystem guard at all.
The exemption now gates the static branch only, so a system flow whose
update_record node writes a readonlyWhen field reports the conditional branch's
existing warning. Rule ids and severities are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657apackageMentionDocs.

Which tree this was computed on

This run read content/docs from e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 — the merge of head 8b99b5c2dda048511ebde049bb0311052bb6b81b into base d62f990a985eb15152579ad34c99f43e76e3657a, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 && git checkout e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d62f990a985eb15152579ad34c99f43e76e3657a 8b99b5c2dda048511ebde049bb0311052bb6b81b && git checkout -B drift-repro d62f990a985eb15152579ad34c99f43e76e3657a && git merge --no-ff 8b99b5c2dda048511ebde049bb0311052bb6b81b
node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657a

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tests tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 03:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 5c28b88Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14201-readonly-when-system-flows branch September 2, 2026 04:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: flow-update-readonly-when-field skips runAs:'system' flows entirely, but the conditional strip has no isSystem exemption

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201) - #14370

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows
Sep 2, 2026
Merged

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201)#14370
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14201

What changed

packages/lint/src/validate-readonly-flow-writes.ts carried the runAs:'system'
exemption as a single flow-level early return, so an elevated flow left the walk
before either branch of the rule could judge it. That skip now gates the static
readonly branch only
; the readonlyWhen branch inspects a runAs:'system' flow
like any other, at its existing warning severity. Rule ids and severities are
untouched.

- if (flow.runAs === 'system') return;
const runAs = flow.runAs === 'user' || flow.runAs === 'system' ? flow.runAs : 'user';
+ const isSystemRun = runAs === 'system';
...
- if (meta.readonly) {+ if (meta.readonly && !isSystemRun) {

A field declaring both flags therefore falls through to the conditional branch
under runAs:'system' — which is the truth about that write: the static strip is
skipped, the conditional one is not.

Engine authority (verified on origin/main, not recalled)

packages/objectql/src/engine.ts, the by-id update path — the conditional strip runs
with no guard, and the note at the call site says so:

// [#9107] ... The API-boundary lock is unchanged - a caller cannot make its own
// value look hook-written (see `ReadonlyWhenStripOptions`) - and `isSystem`
// is still NOT an exemption here, unlike the static strip below.
hookContext.input.data = stripReadonlyWhenFields(updateSchema as any, preRoWhen, priorRecord, this.logger, roWhenParent, { supplied: suppliedValues }) as any;

The static strip, twenty lines below, is the one an elevated caller really does bypass:

if (!opCtx.context?.isSystem) {
const preRo = hookContext.input.data as Record...; // elided: a generic type argument, spelled out here to keep angle brackets out of this body
hookContext.input.data = stripReadonlyFields(updateSchema as any, preRo, suppliedValues, this.logger, { ... }) as any;

The bulk path (stripReadonlyWhenFieldsMulti / stripReadonlyFields) is split the
same way, so the asymmetry is not a by-id accident. Pinned from both sides:
engine-readonly-when-derived-writes.test.ts line 195, "LOCK 2 - isSystem does NOT
exempt a caller-supplied value (Option B stays rejected)"
, and
engine-readonly-strict-writes.test.ts.

The rule's own header already recorded this gap ("the skip above is therefore WIDER
than the conditional lock warrants ... Left as-is deliberately") — that paragraph is
now rewritten to describe the split it documents. The action sibling
validate-readonly-action-writes.ts was born with exactly this shape: an action body
is system-elevated by design, so it carries the conditional half and only that half.

Tests

packages/lint/src/validate-readonly-flow-writes.test.ts — 5 new cases, existing ones
kept:

  • positive: a runAs:'system' flow whose update_record writes a readonlyWhen
    field ⇒ one warning on flow-update-readonly-when-field, message naming the run
    identity it was judged under;
  • negative kept and re-titled: a runAs:'system' flow writing a static
    readonly:true field ⇒ still silent;
  • a system node writing both kinds plus a plain field in one payload ⇒ the conditional
    half only, no error;
  • a field declaring readonlyandreadonlyWhen ⇒ warning under system, error
    under user;
  • nested-region reach and create_record exemption, both under runAs:'system'.

Commands run (all at head 8b99b5c2d, exit codes captured before any pipe)

commandexit
pnpm --filter '@objectstack/lint^...' build0
pnpm --filter @objectstack/lint test0 — 93 files, 2720 passed / 5 skipped
pnpm --filter @objectstack/lint typecheck0
node scripts/pm/dispatch-gates.mjs --commands union (33 families)30 exit 0, 3 exit 3
node scripts/pm/dispatch-gates.mjs --ran0 — 33 derived, 33 run, 0 UNRUN

The three exit-3 rows are prerequisite-not-met, i.e. NOT MEASURED locally and not
findings, each saying so in its own verdict text: check-test-completeness.mjs (grades
a saved turbo run test log CI tees), check:dual-build-cjs-loads and
check:type-check-debt (both need the whole workspace built).

Reverse verification: with the flow-level return re-injected and the rest of the
change left in place, the rule test file goes 4 failed / 20 passed — exactly the
four new runAs:system cases — and back to 24 passed restored. The mutation was
confirmed on disk (unique anchor asserted, injected-marker grep -c = 1, mutated
git hash-object differs from the HEAD blob) and the restore proved by hash equality
with the HEAD blob plus an empty git diff HEAD; no build was involved because the
test imports the rule module by relative source path, not through dist/.

ESLint was run narrowed rather than repo-wide, and the narrowing is measured: this
repo runs one eslint.config.mjs that never enables type-aware linting for any file
(no parserOptions.project, no typed @typescript-eslint rules — stated and measured
in that config's own header), so no file's verdict depends on a file outside itself and
a two-file diff cannot move an untouched file's result. eslint --no-inline-config --format json over the diff reports 3 result entries: 0 errors / 0 warnings on both
.ts files, and the changeset .md reported as ignored (no matching configuration),
so 2 lintable files, both clean. The repo-wide sweep is CI's Lint & Repo Gates run.

Not in scope

The readonlyWhen hint text is left exactly as #14202 landed it. It reads correctly
under an elevated run too — "the conditional lock is NOT waived by a system context" is
precisely what a runAs:'system' author needs told — and message text is that card's
fence, not this one's.


Generated by Claude Code

The runAs:'system' exemption in validate-readonly-flow-writes was a single
flow-level early return, removing an elevated flow from BOTH branches of the
rule. Only the static branch warrants it: the engine skips stripReadonlyFields
under `if (!opCtx.context?.isSystem)`, while stripReadonlyWhenFields runs on the
update path with no isSystem guard at all.
The exemption now gates the static branch only, so a system flow whose
update_record node writes a readonlyWhen field reports the conditional branch's
existing warning. Rule ids and severities are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657apackageMentionDocs.

Which tree this was computed on

This run read content/docs from e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 — the merge of head 8b99b5c2dda048511ebde049bb0311052bb6b81b into base d62f990a985eb15152579ad34c99f43e76e3657a, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 && git checkout e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d62f990a985eb15152579ad34c99f43e76e3657a 8b99b5c2dda048511ebde049bb0311052bb6b81b && git checkout -B drift-repro d62f990a985eb15152579ad34c99f43e76e3657a && git merge --no-ff 8b99b5c2dda048511ebde049bb0311052bb6b81b
node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657a

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tests tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 03:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 5c28b88Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14201-readonly-when-system-flows branch September 2, 2026 04:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: flow-update-readonly-when-field skips runAs:'system' flows entirely, but the conditional strip has no isSystem exemption

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201) - #14370

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows
Sep 2, 2026
Merged

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201)#14370
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14201

What changed

packages/lint/src/validate-readonly-flow-writes.ts carried the runAs:'system'
exemption as a single flow-level early return, so an elevated flow left the walk
before either branch of the rule could judge it. That skip now gates the static
readonly branch only
; the readonlyWhen branch inspects a runAs:'system' flow
like any other, at its existing warning severity. Rule ids and severities are
untouched.

- if (flow.runAs === 'system') return;
const runAs = flow.runAs === 'user' || flow.runAs === 'system' ? flow.runAs : 'user';
+ const isSystemRun = runAs === 'system';
...
- if (meta.readonly) {+ if (meta.readonly && !isSystemRun) {

A field declaring both flags therefore falls through to the conditional branch
under runAs:'system' — which is the truth about that write: the static strip is
skipped, the conditional one is not.

Engine authority (verified on origin/main, not recalled)

packages/objectql/src/engine.ts, the by-id update path — the conditional strip runs
with no guard, and the note at the call site says so:

// [#9107] ... The API-boundary lock is unchanged - a caller cannot make its own
// value look hook-written (see `ReadonlyWhenStripOptions`) - and `isSystem`
// is still NOT an exemption here, unlike the static strip below.
hookContext.input.data = stripReadonlyWhenFields(updateSchema as any, preRoWhen, priorRecord, this.logger, roWhenParent, { supplied: suppliedValues }) as any;

The static strip, twenty lines below, is the one an elevated caller really does bypass:

if (!opCtx.context?.isSystem) {
const preRo = hookContext.input.data as Record...; // elided: a generic type argument, spelled out here to keep angle brackets out of this body
hookContext.input.data = stripReadonlyFields(updateSchema as any, preRo, suppliedValues, this.logger, { ... }) as any;

The bulk path (stripReadonlyWhenFieldsMulti / stripReadonlyFields) is split the
same way, so the asymmetry is not a by-id accident. Pinned from both sides:
engine-readonly-when-derived-writes.test.ts line 195, "LOCK 2 - isSystem does NOT
exempt a caller-supplied value (Option B stays rejected)"
, and
engine-readonly-strict-writes.test.ts.

The rule's own header already recorded this gap ("the skip above is therefore WIDER
than the conditional lock warrants ... Left as-is deliberately") — that paragraph is
now rewritten to describe the split it documents. The action sibling
validate-readonly-action-writes.ts was born with exactly this shape: an action body
is system-elevated by design, so it carries the conditional half and only that half.

Tests

packages/lint/src/validate-readonly-flow-writes.test.ts — 5 new cases, existing ones
kept:

  • positive: a runAs:'system' flow whose update_record writes a readonlyWhen
    field ⇒ one warning on flow-update-readonly-when-field, message naming the run
    identity it was judged under;
  • negative kept and re-titled: a runAs:'system' flow writing a static
    readonly:true field ⇒ still silent;
  • a system node writing both kinds plus a plain field in one payload ⇒ the conditional
    half only, no error;
  • a field declaring readonlyandreadonlyWhen ⇒ warning under system, error
    under user;
  • nested-region reach and create_record exemption, both under runAs:'system'.

Commands run (all at head 8b99b5c2d, exit codes captured before any pipe)

commandexit
pnpm --filter '@objectstack/lint^...' build0
pnpm --filter @objectstack/lint test0 — 93 files, 2720 passed / 5 skipped
pnpm --filter @objectstack/lint typecheck0
node scripts/pm/dispatch-gates.mjs --commands union (33 families)30 exit 0, 3 exit 3
node scripts/pm/dispatch-gates.mjs --ran0 — 33 derived, 33 run, 0 UNRUN

The three exit-3 rows are prerequisite-not-met, i.e. NOT MEASURED locally and not
findings, each saying so in its own verdict text: check-test-completeness.mjs (grades
a saved turbo run test log CI tees), check:dual-build-cjs-loads and
check:type-check-debt (both need the whole workspace built).

Reverse verification: with the flow-level return re-injected and the rest of the
change left in place, the rule test file goes 4 failed / 20 passed — exactly the
four new runAs:system cases — and back to 24 passed restored. The mutation was
confirmed on disk (unique anchor asserted, injected-marker grep -c = 1, mutated
git hash-object differs from the HEAD blob) and the restore proved by hash equality
with the HEAD blob plus an empty git diff HEAD; no build was involved because the
test imports the rule module by relative source path, not through dist/.

ESLint was run narrowed rather than repo-wide, and the narrowing is measured: this
repo runs one eslint.config.mjs that never enables type-aware linting for any file
(no parserOptions.project, no typed @typescript-eslint rules — stated and measured
in that config's own header), so no file's verdict depends on a file outside itself and
a two-file diff cannot move an untouched file's result. eslint --no-inline-config --format json over the diff reports 3 result entries: 0 errors / 0 warnings on both
.ts files, and the changeset .md reported as ignored (no matching configuration),
so 2 lintable files, both clean. The repo-wide sweep is CI's Lint & Repo Gates run.

Not in scope

The readonlyWhen hint text is left exactly as #14202 landed it. It reads correctly
under an elevated run too — "the conditional lock is NOT waived by a system context" is
precisely what a runAs:'system' author needs told — and message text is that card's
fence, not this one's.


Generated by Claude Code

The runAs:'system' exemption in validate-readonly-flow-writes was a single
flow-level early return, removing an elevated flow from BOTH branches of the
rule. Only the static branch warrants it: the engine skips stripReadonlyFields
under `if (!opCtx.context?.isSystem)`, while stripReadonlyWhenFields runs on the
update path with no isSystem guard at all.
The exemption now gates the static branch only, so a system flow whose
update_record node writes a readonlyWhen field reports the conditional branch's
existing warning. Rule ids and severities are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657apackageMentionDocs.

Which tree this was computed on

This run read content/docs from e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 — the merge of head 8b99b5c2dda048511ebde049bb0311052bb6b81b into base d62f990a985eb15152579ad34c99f43e76e3657a, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 && git checkout e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d62f990a985eb15152579ad34c99f43e76e3657a 8b99b5c2dda048511ebde049bb0311052bb6b81b && git checkout -B drift-repro d62f990a985eb15152579ad34c99f43e76e3657a && git merge --no-ff 8b99b5c2dda048511ebde049bb0311052bb6b81b
node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657a

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tests tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 03:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 5c28b88Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14201-readonly-when-system-flows branch September 2, 2026 04:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: flow-update-readonly-when-field skips runAs:'system' flows entirely, but the conditional strip has no isSystem exemption

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201) - #14370

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows
Sep 2, 2026
Merged

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201)#14370
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14201

What changed

packages/lint/src/validate-readonly-flow-writes.ts carried the runAs:'system'
exemption as a single flow-level early return, so an elevated flow left the walk
before either branch of the rule could judge it. That skip now gates the static
readonly branch only
; the readonlyWhen branch inspects a runAs:'system' flow
like any other, at its existing warning severity. Rule ids and severities are
untouched.

- if (flow.runAs === 'system') return;
const runAs = flow.runAs === 'user' || flow.runAs === 'system' ? flow.runAs : 'user';
+ const isSystemRun = runAs === 'system';
...
- if (meta.readonly) {+ if (meta.readonly && !isSystemRun) {

A field declaring both flags therefore falls through to the conditional branch
under runAs:'system' — which is the truth about that write: the static strip is
skipped, the conditional one is not.

Engine authority (verified on origin/main, not recalled)

packages/objectql/src/engine.ts, the by-id update path — the conditional strip runs
with no guard, and the note at the call site says so:

// [#9107] ... The API-boundary lock is unchanged - a caller cannot make its own
// value look hook-written (see `ReadonlyWhenStripOptions`) - and `isSystem`
// is still NOT an exemption here, unlike the static strip below.
hookContext.input.data = stripReadonlyWhenFields(updateSchema as any, preRoWhen, priorRecord, this.logger, roWhenParent, { supplied: suppliedValues }) as any;

The static strip, twenty lines below, is the one an elevated caller really does bypass:

if (!opCtx.context?.isSystem) {
const preRo = hookContext.input.data as Record...; // elided: a generic type argument, spelled out here to keep angle brackets out of this body
hookContext.input.data = stripReadonlyFields(updateSchema as any, preRo, suppliedValues, this.logger, { ... }) as any;

The bulk path (stripReadonlyWhenFieldsMulti / stripReadonlyFields) is split the
same way, so the asymmetry is not a by-id accident. Pinned from both sides:
engine-readonly-when-derived-writes.test.ts line 195, "LOCK 2 - isSystem does NOT
exempt a caller-supplied value (Option B stays rejected)"
, and
engine-readonly-strict-writes.test.ts.

The rule's own header already recorded this gap ("the skip above is therefore WIDER
than the conditional lock warrants ... Left as-is deliberately") — that paragraph is
now rewritten to describe the split it documents. The action sibling
validate-readonly-action-writes.ts was born with exactly this shape: an action body
is system-elevated by design, so it carries the conditional half and only that half.

Tests

packages/lint/src/validate-readonly-flow-writes.test.ts — 5 new cases, existing ones
kept:

  • positive: a runAs:'system' flow whose update_record writes a readonlyWhen
    field ⇒ one warning on flow-update-readonly-when-field, message naming the run
    identity it was judged under;
  • negative kept and re-titled: a runAs:'system' flow writing a static
    readonly:true field ⇒ still silent;
  • a system node writing both kinds plus a plain field in one payload ⇒ the conditional
    half only, no error;
  • a field declaring readonlyandreadonlyWhen ⇒ warning under system, error
    under user;
  • nested-region reach and create_record exemption, both under runAs:'system'.

Commands run (all at head 8b99b5c2d, exit codes captured before any pipe)

commandexit
pnpm --filter '@objectstack/lint^...' build0
pnpm --filter @objectstack/lint test0 — 93 files, 2720 passed / 5 skipped
pnpm --filter @objectstack/lint typecheck0
node scripts/pm/dispatch-gates.mjs --commands union (33 families)30 exit 0, 3 exit 3
node scripts/pm/dispatch-gates.mjs --ran0 — 33 derived, 33 run, 0 UNRUN

The three exit-3 rows are prerequisite-not-met, i.e. NOT MEASURED locally and not
findings, each saying so in its own verdict text: check-test-completeness.mjs (grades
a saved turbo run test log CI tees), check:dual-build-cjs-loads and
check:type-check-debt (both need the whole workspace built).

Reverse verification: with the flow-level return re-injected and the rest of the
change left in place, the rule test file goes 4 failed / 20 passed — exactly the
four new runAs:system cases — and back to 24 passed restored. The mutation was
confirmed on disk (unique anchor asserted, injected-marker grep -c = 1, mutated
git hash-object differs from the HEAD blob) and the restore proved by hash equality
with the HEAD blob plus an empty git diff HEAD; no build was involved because the
test imports the rule module by relative source path, not through dist/.

ESLint was run narrowed rather than repo-wide, and the narrowing is measured: this
repo runs one eslint.config.mjs that never enables type-aware linting for any file
(no parserOptions.project, no typed @typescript-eslint rules — stated and measured
in that config's own header), so no file's verdict depends on a file outside itself and
a two-file diff cannot move an untouched file's result. eslint --no-inline-config --format json over the diff reports 3 result entries: 0 errors / 0 warnings on both
.ts files, and the changeset .md reported as ignored (no matching configuration),
so 2 lintable files, both clean. The repo-wide sweep is CI's Lint & Repo Gates run.

Not in scope

The readonlyWhen hint text is left exactly as #14202 landed it. It reads correctly
under an elevated run too — "the conditional lock is NOT waived by a system context" is
precisely what a runAs:'system' author needs told — and message text is that card's
fence, not this one's.


Generated by Claude Code

The runAs:'system' exemption in validate-readonly-flow-writes was a single
flow-level early return, removing an elevated flow from BOTH branches of the
rule. Only the static branch warrants it: the engine skips stripReadonlyFields
under `if (!opCtx.context?.isSystem)`, while stripReadonlyWhenFields runs on the
update path with no isSystem guard at all.
The exemption now gates the static branch only, so a system flow whose
update_record node writes a readonlyWhen field reports the conditional branch's
existing warning. Rule ids and severities are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657apackageMentionDocs.

Which tree this was computed on

This run read content/docs from e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 — the merge of head 8b99b5c2dda048511ebde049bb0311052bb6b81b into base d62f990a985eb15152579ad34c99f43e76e3657a, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 && git checkout e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d62f990a985eb15152579ad34c99f43e76e3657a 8b99b5c2dda048511ebde049bb0311052bb6b81b && git checkout -B drift-repro d62f990a985eb15152579ad34c99f43e76e3657a && git merge --no-ff 8b99b5c2dda048511ebde049bb0311052bb6b81b
node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657a

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tests tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 03:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 5c28b88Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14201-readonly-when-system-flows branch September 2, 2026 04:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: flow-update-readonly-when-field skips runAs:'system' flows entirely, but the conditional strip has no isSystem exemption

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201) - #14370

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows
Sep 2, 2026
Merged

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201)#14370
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14201

What changed

packages/lint/src/validate-readonly-flow-writes.ts carried the runAs:'system'
exemption as a single flow-level early return, so an elevated flow left the walk
before either branch of the rule could judge it. That skip now gates the static
readonly branch only
; the readonlyWhen branch inspects a runAs:'system' flow
like any other, at its existing warning severity. Rule ids and severities are
untouched.

- if (flow.runAs === 'system') return;
const runAs = flow.runAs === 'user' || flow.runAs === 'system' ? flow.runAs : 'user';
+ const isSystemRun = runAs === 'system';
...
- if (meta.readonly) {+ if (meta.readonly && !isSystemRun) {

A field declaring both flags therefore falls through to the conditional branch
under runAs:'system' — which is the truth about that write: the static strip is
skipped, the conditional one is not.

Engine authority (verified on origin/main, not recalled)

packages/objectql/src/engine.ts, the by-id update path — the conditional strip runs
with no guard, and the note at the call site says so:

// [#9107] ... The API-boundary lock is unchanged - a caller cannot make its own
// value look hook-written (see `ReadonlyWhenStripOptions`) - and `isSystem`
// is still NOT an exemption here, unlike the static strip below.
hookContext.input.data = stripReadonlyWhenFields(updateSchema as any, preRoWhen, priorRecord, this.logger, roWhenParent, { supplied: suppliedValues }) as any;

The static strip, twenty lines below, is the one an elevated caller really does bypass:

if (!opCtx.context?.isSystem) {
const preRo = hookContext.input.data as Record...; // elided: a generic type argument, spelled out here to keep angle brackets out of this body
hookContext.input.data = stripReadonlyFields(updateSchema as any, preRo, suppliedValues, this.logger, { ... }) as any;

The bulk path (stripReadonlyWhenFieldsMulti / stripReadonlyFields) is split the
same way, so the asymmetry is not a by-id accident. Pinned from both sides:
engine-readonly-when-derived-writes.test.ts line 195, "LOCK 2 - isSystem does NOT
exempt a caller-supplied value (Option B stays rejected)"
, and
engine-readonly-strict-writes.test.ts.

The rule's own header already recorded this gap ("the skip above is therefore WIDER
than the conditional lock warrants ... Left as-is deliberately") — that paragraph is
now rewritten to describe the split it documents. The action sibling
validate-readonly-action-writes.ts was born with exactly this shape: an action body
is system-elevated by design, so it carries the conditional half and only that half.

Tests

packages/lint/src/validate-readonly-flow-writes.test.ts — 5 new cases, existing ones
kept:

  • positive: a runAs:'system' flow whose update_record writes a readonlyWhen
    field ⇒ one warning on flow-update-readonly-when-field, message naming the run
    identity it was judged under;
  • negative kept and re-titled: a runAs:'system' flow writing a static
    readonly:true field ⇒ still silent;
  • a system node writing both kinds plus a plain field in one payload ⇒ the conditional
    half only, no error;
  • a field declaring readonlyandreadonlyWhen ⇒ warning under system, error
    under user;
  • nested-region reach and create_record exemption, both under runAs:'system'.

Commands run (all at head 8b99b5c2d, exit codes captured before any pipe)

commandexit
pnpm --filter '@objectstack/lint^...' build0
pnpm --filter @objectstack/lint test0 — 93 files, 2720 passed / 5 skipped
pnpm --filter @objectstack/lint typecheck0
node scripts/pm/dispatch-gates.mjs --commands union (33 families)30 exit 0, 3 exit 3
node scripts/pm/dispatch-gates.mjs --ran0 — 33 derived, 33 run, 0 UNRUN

The three exit-3 rows are prerequisite-not-met, i.e. NOT MEASURED locally and not
findings, each saying so in its own verdict text: check-test-completeness.mjs (grades
a saved turbo run test log CI tees), check:dual-build-cjs-loads and
check:type-check-debt (both need the whole workspace built).

Reverse verification: with the flow-level return re-injected and the rest of the
change left in place, the rule test file goes 4 failed / 20 passed — exactly the
four new runAs:system cases — and back to 24 passed restored. The mutation was
confirmed on disk (unique anchor asserted, injected-marker grep -c = 1, mutated
git hash-object differs from the HEAD blob) and the restore proved by hash equality
with the HEAD blob plus an empty git diff HEAD; no build was involved because the
test imports the rule module by relative source path, not through dist/.

ESLint was run narrowed rather than repo-wide, and the narrowing is measured: this
repo runs one eslint.config.mjs that never enables type-aware linting for any file
(no parserOptions.project, no typed @typescript-eslint rules — stated and measured
in that config's own header), so no file's verdict depends on a file outside itself and
a two-file diff cannot move an untouched file's result. eslint --no-inline-config --format json over the diff reports 3 result entries: 0 errors / 0 warnings on both
.ts files, and the changeset .md reported as ignored (no matching configuration),
so 2 lintable files, both clean. The repo-wide sweep is CI's Lint & Repo Gates run.

Not in scope

The readonlyWhen hint text is left exactly as #14202 landed it. It reads correctly
under an elevated run too — "the conditional lock is NOT waived by a system context" is
precisely what a runAs:'system' author needs told — and message text is that card's
fence, not this one's.


Generated by Claude Code

The runAs:'system' exemption in validate-readonly-flow-writes was a single
flow-level early return, removing an elevated flow from BOTH branches of the
rule. Only the static branch warrants it: the engine skips stripReadonlyFields
under `if (!opCtx.context?.isSystem)`, while stripReadonlyWhenFields runs on the
update path with no isSystem guard at all.
The exemption now gates the static branch only, so a system flow whose
update_record node writes a readonlyWhen field reports the conditional branch's
existing warning. Rule ids and severities are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657apackageMentionDocs.

Which tree this was computed on

This run read content/docs from e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 — the merge of head 8b99b5c2dda048511ebde049bb0311052bb6b81b into base d62f990a985eb15152579ad34c99f43e76e3657a, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 && git checkout e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d62f990a985eb15152579ad34c99f43e76e3657a 8b99b5c2dda048511ebde049bb0311052bb6b81b && git checkout -B drift-repro d62f990a985eb15152579ad34c99f43e76e3657a && git merge --no-ff 8b99b5c2dda048511ebde049bb0311052bb6b81b
node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657a

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tests tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 03:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 5c28b88Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14201-readonly-when-system-flows branch September 2, 2026 04:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: flow-update-readonly-when-field skips runAs:'system' flows entirely, but the conditional strip has no isSystem exemption

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201) - #14370

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows
Sep 2, 2026
Merged

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201)#14370
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14201

What changed

packages/lint/src/validate-readonly-flow-writes.ts carried the runAs:'system'
exemption as a single flow-level early return, so an elevated flow left the walk
before either branch of the rule could judge it. That skip now gates the static
readonly branch only
; the readonlyWhen branch inspects a runAs:'system' flow
like any other, at its existing warning severity. Rule ids and severities are
untouched.

- if (flow.runAs === 'system') return;
const runAs = flow.runAs === 'user' || flow.runAs === 'system' ? flow.runAs : 'user';
+ const isSystemRun = runAs === 'system';
...
- if (meta.readonly) {+ if (meta.readonly && !isSystemRun) {

A field declaring both flags therefore falls through to the conditional branch
under runAs:'system' — which is the truth about that write: the static strip is
skipped, the conditional one is not.

Engine authority (verified on origin/main, not recalled)

packages/objectql/src/engine.ts, the by-id update path — the conditional strip runs
with no guard, and the note at the call site says so:

// [#9107] ... The API-boundary lock is unchanged - a caller cannot make its own
// value look hook-written (see `ReadonlyWhenStripOptions`) - and `isSystem`
// is still NOT an exemption here, unlike the static strip below.
hookContext.input.data = stripReadonlyWhenFields(updateSchema as any, preRoWhen, priorRecord, this.logger, roWhenParent, { supplied: suppliedValues }) as any;

The static strip, twenty lines below, is the one an elevated caller really does bypass:

if (!opCtx.context?.isSystem) {
const preRo = hookContext.input.data as Record...; // elided: a generic type argument, spelled out here to keep angle brackets out of this body
hookContext.input.data = stripReadonlyFields(updateSchema as any, preRo, suppliedValues, this.logger, { ... }) as any;

The bulk path (stripReadonlyWhenFieldsMulti / stripReadonlyFields) is split the
same way, so the asymmetry is not a by-id accident. Pinned from both sides:
engine-readonly-when-derived-writes.test.ts line 195, "LOCK 2 - isSystem does NOT
exempt a caller-supplied value (Option B stays rejected)"
, and
engine-readonly-strict-writes.test.ts.

The rule's own header already recorded this gap ("the skip above is therefore WIDER
than the conditional lock warrants ... Left as-is deliberately") — that paragraph is
now rewritten to describe the split it documents. The action sibling
validate-readonly-action-writes.ts was born with exactly this shape: an action body
is system-elevated by design, so it carries the conditional half and only that half.

Tests

packages/lint/src/validate-readonly-flow-writes.test.ts — 5 new cases, existing ones
kept:

  • positive: a runAs:'system' flow whose update_record writes a readonlyWhen
    field ⇒ one warning on flow-update-readonly-when-field, message naming the run
    identity it was judged under;
  • negative kept and re-titled: a runAs:'system' flow writing a static
    readonly:true field ⇒ still silent;
  • a system node writing both kinds plus a plain field in one payload ⇒ the conditional
    half only, no error;
  • a field declaring readonlyandreadonlyWhen ⇒ warning under system, error
    under user;
  • nested-region reach and create_record exemption, both under runAs:'system'.

Commands run (all at head 8b99b5c2d, exit codes captured before any pipe)

commandexit
pnpm --filter '@objectstack/lint^...' build0
pnpm --filter @objectstack/lint test0 — 93 files, 2720 passed / 5 skipped
pnpm --filter @objectstack/lint typecheck0
node scripts/pm/dispatch-gates.mjs --commands union (33 families)30 exit 0, 3 exit 3
node scripts/pm/dispatch-gates.mjs --ran0 — 33 derived, 33 run, 0 UNRUN

The three exit-3 rows are prerequisite-not-met, i.e. NOT MEASURED locally and not
findings, each saying so in its own verdict text: check-test-completeness.mjs (grades
a saved turbo run test log CI tees), check:dual-build-cjs-loads and
check:type-check-debt (both need the whole workspace built).

Reverse verification: with the flow-level return re-injected and the rest of the
change left in place, the rule test file goes 4 failed / 20 passed — exactly the
four new runAs:system cases — and back to 24 passed restored. The mutation was
confirmed on disk (unique anchor asserted, injected-marker grep -c = 1, mutated
git hash-object differs from the HEAD blob) and the restore proved by hash equality
with the HEAD blob plus an empty git diff HEAD; no build was involved because the
test imports the rule module by relative source path, not through dist/.

ESLint was run narrowed rather than repo-wide, and the narrowing is measured: this
repo runs one eslint.config.mjs that never enables type-aware linting for any file
(no parserOptions.project, no typed @typescript-eslint rules — stated and measured
in that config's own header), so no file's verdict depends on a file outside itself and
a two-file diff cannot move an untouched file's result. eslint --no-inline-config --format json over the diff reports 3 result entries: 0 errors / 0 warnings on both
.ts files, and the changeset .md reported as ignored (no matching configuration),
so 2 lintable files, both clean. The repo-wide sweep is CI's Lint & Repo Gates run.

Not in scope

The readonlyWhen hint text is left exactly as #14202 landed it. It reads correctly
under an elevated run too — "the conditional lock is NOT waived by a system context" is
precisely what a runAs:'system' author needs told — and message text is that card's
fence, not this one's.


Generated by Claude Code

The runAs:'system' exemption in validate-readonly-flow-writes was a single
flow-level early return, removing an elevated flow from BOTH branches of the
rule. Only the static branch warrants it: the engine skips stripReadonlyFields
under `if (!opCtx.context?.isSystem)`, while stripReadonlyWhenFields runs on the
update path with no isSystem guard at all.
The exemption now gates the static branch only, so a system flow whose
update_record node writes a readonlyWhen field reports the conditional branch's
existing warning. Rule ids and severities are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657apackageMentionDocs.

Which tree this was computed on

This run read content/docs from e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 — the merge of head 8b99b5c2dda048511ebde049bb0311052bb6b81b into base d62f990a985eb15152579ad34c99f43e76e3657a, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 && git checkout e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d62f990a985eb15152579ad34c99f43e76e3657a 8b99b5c2dda048511ebde049bb0311052bb6b81b && git checkout -B drift-repro d62f990a985eb15152579ad34c99f43e76e3657a && git merge --no-ff 8b99b5c2dda048511ebde049bb0311052bb6b81b
node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657a

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tests tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 03:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 5c28b88Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14201-readonly-when-system-flows branch September 2, 2026 04:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: flow-update-readonly-when-field skips runAs:'system' flows entirely, but the conditional strip has no isSystem exemption

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201) - #14370

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows
Sep 2, 2026
Merged

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201)#14370
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14201

What changed

packages/lint/src/validate-readonly-flow-writes.ts carried the runAs:'system'
exemption as a single flow-level early return, so an elevated flow left the walk
before either branch of the rule could judge it. That skip now gates the static
readonly branch only
; the readonlyWhen branch inspects a runAs:'system' flow
like any other, at its existing warning severity. Rule ids and severities are
untouched.

- if (flow.runAs === 'system') return;
const runAs = flow.runAs === 'user' || flow.runAs === 'system' ? flow.runAs : 'user';
+ const isSystemRun = runAs === 'system';
...
- if (meta.readonly) {+ if (meta.readonly && !isSystemRun) {

A field declaring both flags therefore falls through to the conditional branch
under runAs:'system' — which is the truth about that write: the static strip is
skipped, the conditional one is not.

Engine authority (verified on origin/main, not recalled)

packages/objectql/src/engine.ts, the by-id update path — the conditional strip runs
with no guard, and the note at the call site says so:

// [#9107] ... The API-boundary lock is unchanged - a caller cannot make its own
// value look hook-written (see `ReadonlyWhenStripOptions`) - and `isSystem`
// is still NOT an exemption here, unlike the static strip below.
hookContext.input.data = stripReadonlyWhenFields(updateSchema as any, preRoWhen, priorRecord, this.logger, roWhenParent, { supplied: suppliedValues }) as any;

The static strip, twenty lines below, is the one an elevated caller really does bypass:

if (!opCtx.context?.isSystem) {
const preRo = hookContext.input.data as Record...; // elided: a generic type argument, spelled out here to keep angle brackets out of this body
hookContext.input.data = stripReadonlyFields(updateSchema as any, preRo, suppliedValues, this.logger, { ... }) as any;

The bulk path (stripReadonlyWhenFieldsMulti / stripReadonlyFields) is split the
same way, so the asymmetry is not a by-id accident. Pinned from both sides:
engine-readonly-when-derived-writes.test.ts line 195, "LOCK 2 - isSystem does NOT
exempt a caller-supplied value (Option B stays rejected)"
, and
engine-readonly-strict-writes.test.ts.

The rule's own header already recorded this gap ("the skip above is therefore WIDER
than the conditional lock warrants ... Left as-is deliberately") — that paragraph is
now rewritten to describe the split it documents. The action sibling
validate-readonly-action-writes.ts was born with exactly this shape: an action body
is system-elevated by design, so it carries the conditional half and only that half.

Tests

packages/lint/src/validate-readonly-flow-writes.test.ts — 5 new cases, existing ones
kept:

  • positive: a runAs:'system' flow whose update_record writes a readonlyWhen
    field ⇒ one warning on flow-update-readonly-when-field, message naming the run
    identity it was judged under;
  • negative kept and re-titled: a runAs:'system' flow writing a static
    readonly:true field ⇒ still silent;
  • a system node writing both kinds plus a plain field in one payload ⇒ the conditional
    half only, no error;
  • a field declaring readonlyandreadonlyWhen ⇒ warning under system, error
    under user;
  • nested-region reach and create_record exemption, both under runAs:'system'.

Commands run (all at head 8b99b5c2d, exit codes captured before any pipe)

commandexit
pnpm --filter '@objectstack/lint^...' build0
pnpm --filter @objectstack/lint test0 — 93 files, 2720 passed / 5 skipped
pnpm --filter @objectstack/lint typecheck0
node scripts/pm/dispatch-gates.mjs --commands union (33 families)30 exit 0, 3 exit 3
node scripts/pm/dispatch-gates.mjs --ran0 — 33 derived, 33 run, 0 UNRUN

The three exit-3 rows are prerequisite-not-met, i.e. NOT MEASURED locally and not
findings, each saying so in its own verdict text: check-test-completeness.mjs (grades
a saved turbo run test log CI tees), check:dual-build-cjs-loads and
check:type-check-debt (both need the whole workspace built).

Reverse verification: with the flow-level return re-injected and the rest of the
change left in place, the rule test file goes 4 failed / 20 passed — exactly the
four new runAs:system cases — and back to 24 passed restored. The mutation was
confirmed on disk (unique anchor asserted, injected-marker grep -c = 1, mutated
git hash-object differs from the HEAD blob) and the restore proved by hash equality
with the HEAD blob plus an empty git diff HEAD; no build was involved because the
test imports the rule module by relative source path, not through dist/.

ESLint was run narrowed rather than repo-wide, and the narrowing is measured: this
repo runs one eslint.config.mjs that never enables type-aware linting for any file
(no parserOptions.project, no typed @typescript-eslint rules — stated and measured
in that config's own header), so no file's verdict depends on a file outside itself and
a two-file diff cannot move an untouched file's result. eslint --no-inline-config --format json over the diff reports 3 result entries: 0 errors / 0 warnings on both
.ts files, and the changeset .md reported as ignored (no matching configuration),
so 2 lintable files, both clean. The repo-wide sweep is CI's Lint & Repo Gates run.

Not in scope

The readonlyWhen hint text is left exactly as #14202 landed it. It reads correctly
under an elevated run too — "the conditional lock is NOT waived by a system context" is
precisely what a runAs:'system' author needs told — and message text is that card's
fence, not this one's.


Generated by Claude Code

The runAs:'system' exemption in validate-readonly-flow-writes was a single
flow-level early return, removing an elevated flow from BOTH branches of the
rule. Only the static branch warrants it: the engine skips stripReadonlyFields
under `if (!opCtx.context?.isSystem)`, while stripReadonlyWhenFields runs on the
update path with no isSystem guard at all.
The exemption now gates the static branch only, so a system flow whose
update_record node writes a readonlyWhen field reports the conditional branch's
existing warning. Rule ids and severities are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657apackageMentionDocs.

Which tree this was computed on

This run read content/docs from e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 — the merge of head 8b99b5c2dda048511ebde049bb0311052bb6b81b into base d62f990a985eb15152579ad34c99f43e76e3657a, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 && git checkout e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d62f990a985eb15152579ad34c99f43e76e3657a 8b99b5c2dda048511ebde049bb0311052bb6b81b && git checkout -B drift-repro d62f990a985eb15152579ad34c99f43e76e3657a && git merge --no-ff 8b99b5c2dda048511ebde049bb0311052bb6b81b
node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657a

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tests tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 03:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 5c28b88Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14201-readonly-when-system-flows branch September 2, 2026 04:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: flow-update-readonly-when-field skips runAs:'system' flows entirely, but the conditional strip has no isSystem exemption

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201) - #14370

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows
Sep 2, 2026
Merged

fix(lint): inspect runAs:'system' flows on the readonlyWhen branch (#14201)#14370
baozhoutao merged 1 commit into
mainfrom
claude/issue-14201-readonly-when-system-flows

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14201

What changed

packages/lint/src/validate-readonly-flow-writes.ts carried the runAs:'system'
exemption as a single flow-level early return, so an elevated flow left the walk
before either branch of the rule could judge it. That skip now gates the static
readonly branch only
; the readonlyWhen branch inspects a runAs:'system' flow
like any other, at its existing warning severity. Rule ids and severities are
untouched.

- if (flow.runAs === 'system') return;
const runAs = flow.runAs === 'user' || flow.runAs === 'system' ? flow.runAs : 'user';
+ const isSystemRun = runAs === 'system';
...
- if (meta.readonly) {+ if (meta.readonly && !isSystemRun) {

A field declaring both flags therefore falls through to the conditional branch
under runAs:'system' — which is the truth about that write: the static strip is
skipped, the conditional one is not.

Engine authority (verified on origin/main, not recalled)

packages/objectql/src/engine.ts, the by-id update path — the conditional strip runs
with no guard, and the note at the call site says so:

// [#9107] ... The API-boundary lock is unchanged - a caller cannot make its own
// value look hook-written (see `ReadonlyWhenStripOptions`) - and `isSystem`
// is still NOT an exemption here, unlike the static strip below.
hookContext.input.data = stripReadonlyWhenFields(updateSchema as any, preRoWhen, priorRecord, this.logger, roWhenParent, { supplied: suppliedValues }) as any;

The static strip, twenty lines below, is the one an elevated caller really does bypass:

if (!opCtx.context?.isSystem) {
const preRo = hookContext.input.data as Record...; // elided: a generic type argument, spelled out here to keep angle brackets out of this body
hookContext.input.data = stripReadonlyFields(updateSchema as any, preRo, suppliedValues, this.logger, { ... }) as any;

The bulk path (stripReadonlyWhenFieldsMulti / stripReadonlyFields) is split the
same way, so the asymmetry is not a by-id accident. Pinned from both sides:
engine-readonly-when-derived-writes.test.ts line 195, "LOCK 2 - isSystem does NOT
exempt a caller-supplied value (Option B stays rejected)"
, and
engine-readonly-strict-writes.test.ts.

The rule's own header already recorded this gap ("the skip above is therefore WIDER
than the conditional lock warrants ... Left as-is deliberately") — that paragraph is
now rewritten to describe the split it documents. The action sibling
validate-readonly-action-writes.ts was born with exactly this shape: an action body
is system-elevated by design, so it carries the conditional half and only that half.

Tests

packages/lint/src/validate-readonly-flow-writes.test.ts — 5 new cases, existing ones
kept:

  • positive: a runAs:'system' flow whose update_record writes a readonlyWhen
    field ⇒ one warning on flow-update-readonly-when-field, message naming the run
    identity it was judged under;
  • negative kept and re-titled: a runAs:'system' flow writing a static
    readonly:true field ⇒ still silent;
  • a system node writing both kinds plus a plain field in one payload ⇒ the conditional
    half only, no error;
  • a field declaring readonlyandreadonlyWhen ⇒ warning under system, error
    under user;
  • nested-region reach and create_record exemption, both under runAs:'system'.

Commands run (all at head 8b99b5c2d, exit codes captured before any pipe)

commandexit
pnpm --filter '@objectstack/lint^...' build0
pnpm --filter @objectstack/lint test0 — 93 files, 2720 passed / 5 skipped
pnpm --filter @objectstack/lint typecheck0
node scripts/pm/dispatch-gates.mjs --commands union (33 families)30 exit 0, 3 exit 3
node scripts/pm/dispatch-gates.mjs --ran0 — 33 derived, 33 run, 0 UNRUN

The three exit-3 rows are prerequisite-not-met, i.e. NOT MEASURED locally and not
findings, each saying so in its own verdict text: check-test-completeness.mjs (grades
a saved turbo run test log CI tees), check:dual-build-cjs-loads and
check:type-check-debt (both need the whole workspace built).

Reverse verification: with the flow-level return re-injected and the rest of the
change left in place, the rule test file goes 4 failed / 20 passed — exactly the
four new runAs:system cases — and back to 24 passed restored. The mutation was
confirmed on disk (unique anchor asserted, injected-marker grep -c = 1, mutated
git hash-object differs from the HEAD blob) and the restore proved by hash equality
with the HEAD blob plus an empty git diff HEAD; no build was involved because the
test imports the rule module by relative source path, not through dist/.

ESLint was run narrowed rather than repo-wide, and the narrowing is measured: this
repo runs one eslint.config.mjs that never enables type-aware linting for any file
(no parserOptions.project, no typed @typescript-eslint rules — stated and measured
in that config's own header), so no file's verdict depends on a file outside itself and
a two-file diff cannot move an untouched file's result. eslint --no-inline-config --format json over the diff reports 3 result entries: 0 errors / 0 warnings on both
.ts files, and the changeset .md reported as ignored (no matching configuration),
so 2 lintable files, both clean. The repo-wide sweep is CI's Lint & Repo Gates run.

Not in scope

The readonlyWhen hint text is left exactly as #14202 landed it. It reads correctly
under an elevated run too — "the conditional lock is NOT waived by a system context" is
precisely what a runAs:'system' author needs told — and message text is that card's
fence, not this one's.


Generated by Claude Code

The runAs:'system' exemption in validate-readonly-flow-writes was a single
flow-level early return, removing an elevated flow from BOTH branches of the
rule. Only the static branch warrants it: the engine skips stripReadonlyFields
under `if (!opCtx.context?.isSystem)`, while stripReadonlyWhenFields runs on the
update path with no isSystem guard at all.
The exemption now gates the static branch only, so a system flow whose
update_record node writes a readonlyWhen field reports the conditional branch's
existing warning. Rule ids and severities are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

1 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to listnot a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run.

What this run could not see
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657apackageMentionDocs.

Which tree this was computed on

This run read content/docs from e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 — the merge of head 8b99b5c2dda048511ebde049bb0311052bb6b81b into base d62f990a985eb15152579ad34c99f43e76e3657a, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2 && git checkout e8cc6a53793d2fb2a4debec4a1275eb13d0c59e2
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin d62f990a985eb15152579ad34c99f43e76e3657a 8b99b5c2dda048511ebde049bb0311052bb6b81b && git checkout -B drift-repro d62f990a985eb15152579ad34c99f43e76e3657a && git merge --no-ff 8b99b5c2dda048511ebde049bb0311052bb6b81b
node scripts/docs-audit/affected-docs.mjs --json d62f990a985eb15152579ad34c99f43e76e3657a

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tests tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 03:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit 5c28b88Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14201-readonly-when-system-flows branch September 2, 2026 04:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mteststooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: flow-update-readonly-when-field skips runAs:'system' flows entirely, but the conditional strip has no isSystem exemption

2 participants

@baozhoutao@claude