fix(lint): wire test layer into check:test-typecheck (#14173) - #14494

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck
Sep 2, 2026
Merged

fix(lint): wire test layer into check:test-typecheck (#14173)#14494
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14173

What

packages/lint's typecheck script was a bare tsc --noEmit against a
tsconfig.json that excluded **/*.test.ts and **/*.spec.ts, so no gate
anywhere read a lint test file with a type checker (vitest transpiles through
esbuild, types stripped, never resolved). src/validate-expressions.test.ts
alone is ~2,700 lines built almost entirely out of compile-time and meta pins
(the #5017 receiver scan, the TRACKED_UNDECLARED_READS shrink-only list, the
residual-root table) — none of it type-checked by anything.

Wired per the triage ruling (comment 5502888897) to the mechanism #14062 (PR
#14420) landed on: scripts/check-test-typecheck.mts, per package, with a
sibling tsconfig.test.json the typecheck script NAMES.

Measurement

--listFiles on origin/main6aea1f559 (workspace closure built first):

validate-expressions.test.ts -> 0
validate-expressions.ts -> 1

New packages/lint/tsconfig.test.json (module semantics only — esnext /
bundler / lib: ["ES2022"] — matching how vitest actually executes these
files; strictness and rootDir untouched, inherited):

errors under BUILD semantics (NodeNext, tests included) 22 (11 TS7006 + 5 TS2835 + 6 TS6059)
errors under THIS config (test tsconfig) 6 (6 TS6059)

The TS7006/TS2835 pile (16 errors — exactly the coverage gate's recorded
@objectstack/lint TEST_DEBT total) dissolves under bundler resolution, the
same "config tier, not the tests" effect packages/spec/packages/rest/the
packages/plugins/** family measured. The 6 residual TS6059 are
rootDir-violation errors from two test files importing example-app fixtures
outside this package (examples/app-showcase) — pre-existing, and (per the
coverage gate's own historical note on this exact entry) never this package's
debt; rootDir is inherited untouched here, so they surface rather than being
suppressed.

Authority boundary: this is a CONVERSION of the coverage gate's existing
@objectstack/lint TEST_DEBT entry (errors: 16) to per-file/per-signature
form, not a new debt-opening decision — legitimate while the measured total
stays ≤ 16. Measured: 6 ≤ 16. Within bounds.

check:type-check-coverage: GREEN with the '@objectstack/lint' TEST_DEBT
entry deleted and the #14062 graduation docblock carrying lint's line (68/78
packages type-checked, no lint exception listed). The RECONCILED rule this
gate documents ("a TEST_DEBT entry ONLY where no tsconfig the typecheck script
invokes reads the tests") is what forces the entry's removal once typecheck
names a test program — I attempted to capture the RED reading directly (entry
restored on top of the already-wired typecheck script, via a temporary git checkout HEAD --/git apply round-trip, nothing left uncommitted) but three
attempts under heavy shared-box contention each hit os-verify-lock's
queue-timeout (one holder alone held the lock 12+ minutes on an unrelated
command) without ever acquiring; I did not keep retrying past that and report
this one specific reading as NOT MEASURED rather than fabricate it. The final
GREEN state (below) is measured, and re-confirmed again after merging
origin/main (ledger re-regenerates identically: 2 files / 6 errors / 2
signatures, unchanged by the concurrent PR #14437 that also touches
packages/lint/src/**).

Not in scope

Per the file-surface constraint, no edits to packages/lint/src/** — the 6
TS6059 errors are ledgered, never fixed here.

Gates

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RUN_RECORD_PATH
at 0a2b43d11 (post-merge, no staleness warning): 46 derived, 46 run, 0
NOT-MEASURED, 0 UNRUN.
Of those 46, three exit 3 (documented PREREQUISITE
NOT MET, not a red): check:dual-build-cjs-loads and check:type-check-debt --re-measure (both need a full pnpm build workspace closure this run never
built) and check:test-completeness (needs a saved turbo run test log CI
produces). Everything else passed. Also ran (touched scripts/**):
check:ratchet-remedy-authority, check:declared-population-live,
check-self-test-wired.mjs, check-self-test-workflow-commands.mjs,
check-type-check-coverage.mjs --self-test — all green.


Generated by Claude Code


Generated by Claude Code

…ne rule pin file is type-checked (#14173)
Onboarded by wiring to the mechanism #14062 (PR #14420) landed on, per the
triage ruling on this card (comment 5502888897): a sibling tsconfig.test.json
matching vitest's real module semantics, named by `typecheck`. Measured: 6
residual TS6059 errors over 2 files (rootDir violations from imports outside
this package, pre-existing, config-tier), recorded in the new
test-typecheck-debt.json as a CONVERSION of the coverage gate's existing
16-error TEST_DEBT entry, which is deleted as the graduation that pairing
forces.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7cbe705b03384f1bde55fd159a6a16ef6322caf2packageMentionDocs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] packages/lint has no tsc program that compiles its tests — the 2,700-line rule pin file, receiver scan included, is type-checked by nobody

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(lint): wire test layer into check:test-typecheck (#14173) - #14494

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck
Sep 2, 2026
Merged

fix(lint): wire test layer into check:test-typecheck (#14173)#14494
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14173

What

packages/lint's typecheck script was a bare tsc --noEmit against a
tsconfig.json that excluded **/*.test.ts and **/*.spec.ts, so no gate
anywhere read a lint test file with a type checker (vitest transpiles through
esbuild, types stripped, never resolved). src/validate-expressions.test.ts
alone is ~2,700 lines built almost entirely out of compile-time and meta pins
(the #5017 receiver scan, the TRACKED_UNDECLARED_READS shrink-only list, the
residual-root table) — none of it type-checked by anything.

Wired per the triage ruling (comment 5502888897) to the mechanism #14062 (PR
#14420) landed on: scripts/check-test-typecheck.mts, per package, with a
sibling tsconfig.test.json the typecheck script NAMES.

Measurement

--listFiles on origin/main6aea1f559 (workspace closure built first):

validate-expressions.test.ts -> 0
validate-expressions.ts -> 1

New packages/lint/tsconfig.test.json (module semantics only — esnext /
bundler / lib: ["ES2022"] — matching how vitest actually executes these
files; strictness and rootDir untouched, inherited):

errors under BUILD semantics (NodeNext, tests included) 22 (11 TS7006 + 5 TS2835 + 6 TS6059)
errors under THIS config (test tsconfig) 6 (6 TS6059)

The TS7006/TS2835 pile (16 errors — exactly the coverage gate's recorded
@objectstack/lint TEST_DEBT total) dissolves under bundler resolution, the
same "config tier, not the tests" effect packages/spec/packages/rest/the
packages/plugins/** family measured. The 6 residual TS6059 are
rootDir-violation errors from two test files importing example-app fixtures
outside this package (examples/app-showcase) — pre-existing, and (per the
coverage gate's own historical note on this exact entry) never this package's
debt; rootDir is inherited untouched here, so they surface rather than being
suppressed.

Authority boundary: this is a CONVERSION of the coverage gate's existing
@objectstack/lint TEST_DEBT entry (errors: 16) to per-file/per-signature
form, not a new debt-opening decision — legitimate while the measured total
stays ≤ 16. Measured: 6 ≤ 16. Within bounds.

check:type-check-coverage: GREEN with the '@objectstack/lint' TEST_DEBT
entry deleted and the #14062 graduation docblock carrying lint's line (68/78
packages type-checked, no lint exception listed). The RECONCILED rule this
gate documents ("a TEST_DEBT entry ONLY where no tsconfig the typecheck script
invokes reads the tests") is what forces the entry's removal once typecheck
names a test program — I attempted to capture the RED reading directly (entry
restored on top of the already-wired typecheck script, via a temporary git checkout HEAD --/git apply round-trip, nothing left uncommitted) but three
attempts under heavy shared-box contention each hit os-verify-lock's
queue-timeout (one holder alone held the lock 12+ minutes on an unrelated
command) without ever acquiring; I did not keep retrying past that and report
this one specific reading as NOT MEASURED rather than fabricate it. The final
GREEN state (below) is measured, and re-confirmed again after merging
origin/main (ledger re-regenerates identically: 2 files / 6 errors / 2
signatures, unchanged by the concurrent PR #14437 that also touches
packages/lint/src/**).

Not in scope

Per the file-surface constraint, no edits to packages/lint/src/** — the 6
TS6059 errors are ledgered, never fixed here.

Gates

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RUN_RECORD_PATH
at 0a2b43d11 (post-merge, no staleness warning): 46 derived, 46 run, 0
NOT-MEASURED, 0 UNRUN.
Of those 46, three exit 3 (documented PREREQUISITE
NOT MET, not a red): check:dual-build-cjs-loads and check:type-check-debt --re-measure (both need a full pnpm build workspace closure this run never
built) and check:test-completeness (needs a saved turbo run test log CI
produces). Everything else passed. Also ran (touched scripts/**):
check:ratchet-remedy-authority, check:declared-population-live,
check-self-test-wired.mjs, check-self-test-workflow-commands.mjs,
check-type-check-coverage.mjs --self-test — all green.


Generated by Claude Code


Generated by Claude Code

…ne rule pin file is type-checked (#14173)
Onboarded by wiring to the mechanism #14062 (PR #14420) landed on, per the
triage ruling on this card (comment 5502888897): a sibling tsconfig.test.json
matching vitest's real module semantics, named by `typecheck`. Measured: 6
residual TS6059 errors over 2 files (rootDir violations from imports outside
this package, pre-existing, config-tier), recorded in the new
test-typecheck-debt.json as a CONVERSION of the coverage gate's existing
16-error TEST_DEBT entry, which is deleted as the graduation that pairing
forces.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7cbe705b03384f1bde55fd159a6a16ef6322caf2packageMentionDocs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] packages/lint has no tsc program that compiles its tests — the 2,700-line rule pin file, receiver scan included, is type-checked by nobody

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): wire test layer into check:test-typecheck (#14173) - #14494

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck
Sep 2, 2026
Merged

fix(lint): wire test layer into check:test-typecheck (#14173)#14494
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14173

What

packages/lint's typecheck script was a bare tsc --noEmit against a
tsconfig.json that excluded **/*.test.ts and **/*.spec.ts, so no gate
anywhere read a lint test file with a type checker (vitest transpiles through
esbuild, types stripped, never resolved). src/validate-expressions.test.ts
alone is ~2,700 lines built almost entirely out of compile-time and meta pins
(the #5017 receiver scan, the TRACKED_UNDECLARED_READS shrink-only list, the
residual-root table) — none of it type-checked by anything.

Wired per the triage ruling (comment 5502888897) to the mechanism #14062 (PR
#14420) landed on: scripts/check-test-typecheck.mts, per package, with a
sibling tsconfig.test.json the typecheck script NAMES.

Measurement

--listFiles on origin/main6aea1f559 (workspace closure built first):

validate-expressions.test.ts -> 0
validate-expressions.ts -> 1

New packages/lint/tsconfig.test.json (module semantics only — esnext /
bundler / lib: ["ES2022"] — matching how vitest actually executes these
files; strictness and rootDir untouched, inherited):

errors under BUILD semantics (NodeNext, tests included) 22 (11 TS7006 + 5 TS2835 + 6 TS6059)
errors under THIS config (test tsconfig) 6 (6 TS6059)

The TS7006/TS2835 pile (16 errors — exactly the coverage gate's recorded
@objectstack/lint TEST_DEBT total) dissolves under bundler resolution, the
same "config tier, not the tests" effect packages/spec/packages/rest/the
packages/plugins/** family measured. The 6 residual TS6059 are
rootDir-violation errors from two test files importing example-app fixtures
outside this package (examples/app-showcase) — pre-existing, and (per the
coverage gate's own historical note on this exact entry) never this package's
debt; rootDir is inherited untouched here, so they surface rather than being
suppressed.

Authority boundary: this is a CONVERSION of the coverage gate's existing
@objectstack/lint TEST_DEBT entry (errors: 16) to per-file/per-signature
form, not a new debt-opening decision — legitimate while the measured total
stays ≤ 16. Measured: 6 ≤ 16. Within bounds.

check:type-check-coverage: GREEN with the '@objectstack/lint' TEST_DEBT
entry deleted and the #14062 graduation docblock carrying lint's line (68/78
packages type-checked, no lint exception listed). The RECONCILED rule this
gate documents ("a TEST_DEBT entry ONLY where no tsconfig the typecheck script
invokes reads the tests") is what forces the entry's removal once typecheck
names a test program — I attempted to capture the RED reading directly (entry
restored on top of the already-wired typecheck script, via a temporary git checkout HEAD --/git apply round-trip, nothing left uncommitted) but three
attempts under heavy shared-box contention each hit os-verify-lock's
queue-timeout (one holder alone held the lock 12+ minutes on an unrelated
command) without ever acquiring; I did not keep retrying past that and report
this one specific reading as NOT MEASURED rather than fabricate it. The final
GREEN state (below) is measured, and re-confirmed again after merging
origin/main (ledger re-regenerates identically: 2 files / 6 errors / 2
signatures, unchanged by the concurrent PR #14437 that also touches
packages/lint/src/**).

Not in scope

Per the file-surface constraint, no edits to packages/lint/src/** — the 6
TS6059 errors are ledgered, never fixed here.

Gates

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RUN_RECORD_PATH
at 0a2b43d11 (post-merge, no staleness warning): 46 derived, 46 run, 0
NOT-MEASURED, 0 UNRUN.
Of those 46, three exit 3 (documented PREREQUISITE
NOT MET, not a red): check:dual-build-cjs-loads and check:type-check-debt --re-measure (both need a full pnpm build workspace closure this run never
built) and check:test-completeness (needs a saved turbo run test log CI
produces). Everything else passed. Also ran (touched scripts/**):
check:ratchet-remedy-authority, check:declared-population-live,
check-self-test-wired.mjs, check-self-test-workflow-commands.mjs,
check-type-check-coverage.mjs --self-test — all green.


Generated by Claude Code


Generated by Claude Code

…ne rule pin file is type-checked (#14173)
Onboarded by wiring to the mechanism #14062 (PR #14420) landed on, per the
triage ruling on this card (comment 5502888897): a sibling tsconfig.test.json
matching vitest's real module semantics, named by `typecheck`. Measured: 6
residual TS6059 errors over 2 files (rootDir violations from imports outside
this package, pre-existing, config-tier), recorded in the new
test-typecheck-debt.json as a CONVERSION of the coverage gate's existing
16-error TEST_DEBT entry, which is deleted as the graduation that pairing
forces.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7cbe705b03384f1bde55fd159a6a16ef6322caf2packageMentionDocs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] packages/lint has no tsc program that compiles its tests — the 2,700-line rule pin file, receiver scan included, is type-checked by nobody

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): wire test layer into check:test-typecheck (#14173) - #14494

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck
Sep 2, 2026
Merged

fix(lint): wire test layer into check:test-typecheck (#14173)#14494
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14173

What

packages/lint's typecheck script was a bare tsc --noEmit against a
tsconfig.json that excluded **/*.test.ts and **/*.spec.ts, so no gate
anywhere read a lint test file with a type checker (vitest transpiles through
esbuild, types stripped, never resolved). src/validate-expressions.test.ts
alone is ~2,700 lines built almost entirely out of compile-time and meta pins
(the #5017 receiver scan, the TRACKED_UNDECLARED_READS shrink-only list, the
residual-root table) — none of it type-checked by anything.

Wired per the triage ruling (comment 5502888897) to the mechanism #14062 (PR
#14420) landed on: scripts/check-test-typecheck.mts, per package, with a
sibling tsconfig.test.json the typecheck script NAMES.

Measurement

--listFiles on origin/main6aea1f559 (workspace closure built first):

validate-expressions.test.ts -> 0
validate-expressions.ts -> 1

New packages/lint/tsconfig.test.json (module semantics only — esnext /
bundler / lib: ["ES2022"] — matching how vitest actually executes these
files; strictness and rootDir untouched, inherited):

errors under BUILD semantics (NodeNext, tests included) 22 (11 TS7006 + 5 TS2835 + 6 TS6059)
errors under THIS config (test tsconfig) 6 (6 TS6059)

The TS7006/TS2835 pile (16 errors — exactly the coverage gate's recorded
@objectstack/lint TEST_DEBT total) dissolves under bundler resolution, the
same "config tier, not the tests" effect packages/spec/packages/rest/the
packages/plugins/** family measured. The 6 residual TS6059 are
rootDir-violation errors from two test files importing example-app fixtures
outside this package (examples/app-showcase) — pre-existing, and (per the
coverage gate's own historical note on this exact entry) never this package's
debt; rootDir is inherited untouched here, so they surface rather than being
suppressed.

Authority boundary: this is a CONVERSION of the coverage gate's existing
@objectstack/lint TEST_DEBT entry (errors: 16) to per-file/per-signature
form, not a new debt-opening decision — legitimate while the measured total
stays ≤ 16. Measured: 6 ≤ 16. Within bounds.

check:type-check-coverage: GREEN with the '@objectstack/lint' TEST_DEBT
entry deleted and the #14062 graduation docblock carrying lint's line (68/78
packages type-checked, no lint exception listed). The RECONCILED rule this
gate documents ("a TEST_DEBT entry ONLY where no tsconfig the typecheck script
invokes reads the tests") is what forces the entry's removal once typecheck
names a test program — I attempted to capture the RED reading directly (entry
restored on top of the already-wired typecheck script, via a temporary git checkout HEAD --/git apply round-trip, nothing left uncommitted) but three
attempts under heavy shared-box contention each hit os-verify-lock's
queue-timeout (one holder alone held the lock 12+ minutes on an unrelated
command) without ever acquiring; I did not keep retrying past that and report
this one specific reading as NOT MEASURED rather than fabricate it. The final
GREEN state (below) is measured, and re-confirmed again after merging
origin/main (ledger re-regenerates identically: 2 files / 6 errors / 2
signatures, unchanged by the concurrent PR #14437 that also touches
packages/lint/src/**).

Not in scope

Per the file-surface constraint, no edits to packages/lint/src/** — the 6
TS6059 errors are ledgered, never fixed here.

Gates

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RUN_RECORD_PATH
at 0a2b43d11 (post-merge, no staleness warning): 46 derived, 46 run, 0
NOT-MEASURED, 0 UNRUN.
Of those 46, three exit 3 (documented PREREQUISITE
NOT MET, not a red): check:dual-build-cjs-loads and check:type-check-debt --re-measure (both need a full pnpm build workspace closure this run never
built) and check:test-completeness (needs a saved turbo run test log CI
produces). Everything else passed. Also ran (touched scripts/**):
check:ratchet-remedy-authority, check:declared-population-live,
check-self-test-wired.mjs, check-self-test-workflow-commands.mjs,
check-type-check-coverage.mjs --self-test — all green.


Generated by Claude Code


Generated by Claude Code

…ne rule pin file is type-checked (#14173)
Onboarded by wiring to the mechanism #14062 (PR #14420) landed on, per the
triage ruling on this card (comment 5502888897): a sibling tsconfig.test.json
matching vitest's real module semantics, named by `typecheck`. Measured: 6
residual TS6059 errors over 2 files (rootDir violations from imports outside
this package, pre-existing, config-tier), recorded in the new
test-typecheck-debt.json as a CONVERSION of the coverage gate's existing
16-error TEST_DEBT entry, which is deleted as the graduation that pairing
forces.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7cbe705b03384f1bde55fd159a6a16ef6322caf2packageMentionDocs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] packages/lint has no tsc program that compiles its tests — the 2,700-line rule pin file, receiver scan included, is type-checked by nobody

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(lint): wire test layer into check:test-typecheck (#14173) - #14494

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck
Sep 2, 2026
Merged

fix(lint): wire test layer into check:test-typecheck (#14173)#14494
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14173

What

packages/lint's typecheck script was a bare tsc --noEmit against a
tsconfig.json that excluded **/*.test.ts and **/*.spec.ts, so no gate
anywhere read a lint test file with a type checker (vitest transpiles through
esbuild, types stripped, never resolved). src/validate-expressions.test.ts
alone is ~2,700 lines built almost entirely out of compile-time and meta pins
(the #5017 receiver scan, the TRACKED_UNDECLARED_READS shrink-only list, the
residual-root table) — none of it type-checked by anything.

Wired per the triage ruling (comment 5502888897) to the mechanism #14062 (PR
#14420) landed on: scripts/check-test-typecheck.mts, per package, with a
sibling tsconfig.test.json the typecheck script NAMES.

Measurement

--listFiles on origin/main6aea1f559 (workspace closure built first):

validate-expressions.test.ts -> 0
validate-expressions.ts -> 1

New packages/lint/tsconfig.test.json (module semantics only — esnext /
bundler / lib: ["ES2022"] — matching how vitest actually executes these
files; strictness and rootDir untouched, inherited):

errors under BUILD semantics (NodeNext, tests included) 22 (11 TS7006 + 5 TS2835 + 6 TS6059)
errors under THIS config (test tsconfig) 6 (6 TS6059)

The TS7006/TS2835 pile (16 errors — exactly the coverage gate's recorded
@objectstack/lint TEST_DEBT total) dissolves under bundler resolution, the
same "config tier, not the tests" effect packages/spec/packages/rest/the
packages/plugins/** family measured. The 6 residual TS6059 are
rootDir-violation errors from two test files importing example-app fixtures
outside this package (examples/app-showcase) — pre-existing, and (per the
coverage gate's own historical note on this exact entry) never this package's
debt; rootDir is inherited untouched here, so they surface rather than being
suppressed.

Authority boundary: this is a CONVERSION of the coverage gate's existing
@objectstack/lint TEST_DEBT entry (errors: 16) to per-file/per-signature
form, not a new debt-opening decision — legitimate while the measured total
stays ≤ 16. Measured: 6 ≤ 16. Within bounds.

check:type-check-coverage: GREEN with the '@objectstack/lint' TEST_DEBT
entry deleted and the #14062 graduation docblock carrying lint's line (68/78
packages type-checked, no lint exception listed). The RECONCILED rule this
gate documents ("a TEST_DEBT entry ONLY where no tsconfig the typecheck script
invokes reads the tests") is what forces the entry's removal once typecheck
names a test program — I attempted to capture the RED reading directly (entry
restored on top of the already-wired typecheck script, via a temporary git checkout HEAD --/git apply round-trip, nothing left uncommitted) but three
attempts under heavy shared-box contention each hit os-verify-lock's
queue-timeout (one holder alone held the lock 12+ minutes on an unrelated
command) without ever acquiring; I did not keep retrying past that and report
this one specific reading as NOT MEASURED rather than fabricate it. The final
GREEN state (below) is measured, and re-confirmed again after merging
origin/main (ledger re-regenerates identically: 2 files / 6 errors / 2
signatures, unchanged by the concurrent PR #14437 that also touches
packages/lint/src/**).

Not in scope

Per the file-surface constraint, no edits to packages/lint/src/** — the 6
TS6059 errors are ledgered, never fixed here.

Gates

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RUN_RECORD_PATH
at 0a2b43d11 (post-merge, no staleness warning): 46 derived, 46 run, 0
NOT-MEASURED, 0 UNRUN.
Of those 46, three exit 3 (documented PREREQUISITE
NOT MET, not a red): check:dual-build-cjs-loads and check:type-check-debt --re-measure (both need a full pnpm build workspace closure this run never
built) and check:test-completeness (needs a saved turbo run test log CI
produces). Everything else passed. Also ran (touched scripts/**):
check:ratchet-remedy-authority, check:declared-population-live,
check-self-test-wired.mjs, check-self-test-workflow-commands.mjs,
check-type-check-coverage.mjs --self-test — all green.


Generated by Claude Code


Generated by Claude Code

…ne rule pin file is type-checked (#14173)
Onboarded by wiring to the mechanism #14062 (PR #14420) landed on, per the
triage ruling on this card (comment 5502888897): a sibling tsconfig.test.json
matching vitest's real module semantics, named by `typecheck`. Measured: 6
residual TS6059 errors over 2 files (rootDir violations from imports outside
this package, pre-existing, config-tier), recorded in the new
test-typecheck-debt.json as a CONVERSION of the coverage gate's existing
16-error TEST_DEBT entry, which is deleted as the graduation that pairing
forces.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7cbe705b03384f1bde55fd159a6a16ef6322caf2packageMentionDocs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] packages/lint has no tsc program that compiles its tests — the 2,700-line rule pin file, receiver scan included, is type-checked by nobody

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): wire test layer into check:test-typecheck (#14173) - #14494

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck
Sep 2, 2026
Merged

fix(lint): wire test layer into check:test-typecheck (#14173)#14494
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14173

What

packages/lint's typecheck script was a bare tsc --noEmit against a
tsconfig.json that excluded **/*.test.ts and **/*.spec.ts, so no gate
anywhere read a lint test file with a type checker (vitest transpiles through
esbuild, types stripped, never resolved). src/validate-expressions.test.ts
alone is ~2,700 lines built almost entirely out of compile-time and meta pins
(the #5017 receiver scan, the TRACKED_UNDECLARED_READS shrink-only list, the
residual-root table) — none of it type-checked by anything.

Wired per the triage ruling (comment 5502888897) to the mechanism #14062 (PR
#14420) landed on: scripts/check-test-typecheck.mts, per package, with a
sibling tsconfig.test.json the typecheck script NAMES.

Measurement

--listFiles on origin/main6aea1f559 (workspace closure built first):

validate-expressions.test.ts -> 0
validate-expressions.ts -> 1

New packages/lint/tsconfig.test.json (module semantics only — esnext /
bundler / lib: ["ES2022"] — matching how vitest actually executes these
files; strictness and rootDir untouched, inherited):

errors under BUILD semantics (NodeNext, tests included) 22 (11 TS7006 + 5 TS2835 + 6 TS6059)
errors under THIS config (test tsconfig) 6 (6 TS6059)

The TS7006/TS2835 pile (16 errors — exactly the coverage gate's recorded
@objectstack/lint TEST_DEBT total) dissolves under bundler resolution, the
same "config tier, not the tests" effect packages/spec/packages/rest/the
packages/plugins/** family measured. The 6 residual TS6059 are
rootDir-violation errors from two test files importing example-app fixtures
outside this package (examples/app-showcase) — pre-existing, and (per the
coverage gate's own historical note on this exact entry) never this package's
debt; rootDir is inherited untouched here, so they surface rather than being
suppressed.

Authority boundary: this is a CONVERSION of the coverage gate's existing
@objectstack/lint TEST_DEBT entry (errors: 16) to per-file/per-signature
form, not a new debt-opening decision — legitimate while the measured total
stays ≤ 16. Measured: 6 ≤ 16. Within bounds.

check:type-check-coverage: GREEN with the '@objectstack/lint' TEST_DEBT
entry deleted and the #14062 graduation docblock carrying lint's line (68/78
packages type-checked, no lint exception listed). The RECONCILED rule this
gate documents ("a TEST_DEBT entry ONLY where no tsconfig the typecheck script
invokes reads the tests") is what forces the entry's removal once typecheck
names a test program — I attempted to capture the RED reading directly (entry
restored on top of the already-wired typecheck script, via a temporary git checkout HEAD --/git apply round-trip, nothing left uncommitted) but three
attempts under heavy shared-box contention each hit os-verify-lock's
queue-timeout (one holder alone held the lock 12+ minutes on an unrelated
command) without ever acquiring; I did not keep retrying past that and report
this one specific reading as NOT MEASURED rather than fabricate it. The final
GREEN state (below) is measured, and re-confirmed again after merging
origin/main (ledger re-regenerates identically: 2 files / 6 errors / 2
signatures, unchanged by the concurrent PR #14437 that also touches
packages/lint/src/**).

Not in scope

Per the file-surface constraint, no edits to packages/lint/src/** — the 6
TS6059 errors are ledgered, never fixed here.

Gates

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RUN_RECORD_PATH
at 0a2b43d11 (post-merge, no staleness warning): 46 derived, 46 run, 0
NOT-MEASURED, 0 UNRUN.
Of those 46, three exit 3 (documented PREREQUISITE
NOT MET, not a red): check:dual-build-cjs-loads and check:type-check-debt --re-measure (both need a full pnpm build workspace closure this run never
built) and check:test-completeness (needs a saved turbo run test log CI
produces). Everything else passed. Also ran (touched scripts/**):
check:ratchet-remedy-authority, check:declared-population-live,
check-self-test-wired.mjs, check-self-test-workflow-commands.mjs,
check-type-check-coverage.mjs --self-test — all green.


Generated by Claude Code


Generated by Claude Code

…ne rule pin file is type-checked (#14173)
Onboarded by wiring to the mechanism #14062 (PR #14420) landed on, per the
triage ruling on this card (comment 5502888897): a sibling tsconfig.test.json
matching vitest's real module semantics, named by `typecheck`. Measured: 6
residual TS6059 errors over 2 files (rootDir violations from imports outside
this package, pre-existing, config-tier), recorded in the new
test-typecheck-debt.json as a CONVERSION of the coverage gate's existing
16-error TEST_DEBT entry, which is deleted as the graduation that pairing
forces.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7cbe705b03384f1bde55fd159a6a16ef6322caf2packageMentionDocs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] packages/lint has no tsc program that compiles its tests — the 2,700-line rule pin file, receiver scan included, is type-checked by nobody

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): wire test layer into check:test-typecheck (#14173) - #14494

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck
Sep 2, 2026
Merged

fix(lint): wire test layer into check:test-typecheck (#14173)#14494
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14173

What

packages/lint's typecheck script was a bare tsc --noEmit against a
tsconfig.json that excluded **/*.test.ts and **/*.spec.ts, so no gate
anywhere read a lint test file with a type checker (vitest transpiles through
esbuild, types stripped, never resolved). src/validate-expressions.test.ts
alone is ~2,700 lines built almost entirely out of compile-time and meta pins
(the #5017 receiver scan, the TRACKED_UNDECLARED_READS shrink-only list, the
residual-root table) — none of it type-checked by anything.

Wired per the triage ruling (comment 5502888897) to the mechanism #14062 (PR
#14420) landed on: scripts/check-test-typecheck.mts, per package, with a
sibling tsconfig.test.json the typecheck script NAMES.

Measurement

--listFiles on origin/main6aea1f559 (workspace closure built first):

validate-expressions.test.ts -> 0
validate-expressions.ts -> 1

New packages/lint/tsconfig.test.json (module semantics only — esnext /
bundler / lib: ["ES2022"] — matching how vitest actually executes these
files; strictness and rootDir untouched, inherited):

errors under BUILD semantics (NodeNext, tests included) 22 (11 TS7006 + 5 TS2835 + 6 TS6059)
errors under THIS config (test tsconfig) 6 (6 TS6059)

The TS7006/TS2835 pile (16 errors — exactly the coverage gate's recorded
@objectstack/lint TEST_DEBT total) dissolves under bundler resolution, the
same "config tier, not the tests" effect packages/spec/packages/rest/the
packages/plugins/** family measured. The 6 residual TS6059 are
rootDir-violation errors from two test files importing example-app fixtures
outside this package (examples/app-showcase) — pre-existing, and (per the
coverage gate's own historical note on this exact entry) never this package's
debt; rootDir is inherited untouched here, so they surface rather than being
suppressed.

Authority boundary: this is a CONVERSION of the coverage gate's existing
@objectstack/lint TEST_DEBT entry (errors: 16) to per-file/per-signature
form, not a new debt-opening decision — legitimate while the measured total
stays ≤ 16. Measured: 6 ≤ 16. Within bounds.

check:type-check-coverage: GREEN with the '@objectstack/lint' TEST_DEBT
entry deleted and the #14062 graduation docblock carrying lint's line (68/78
packages type-checked, no lint exception listed). The RECONCILED rule this
gate documents ("a TEST_DEBT entry ONLY where no tsconfig the typecheck script
invokes reads the tests") is what forces the entry's removal once typecheck
names a test program — I attempted to capture the RED reading directly (entry
restored on top of the already-wired typecheck script, via a temporary git checkout HEAD --/git apply round-trip, nothing left uncommitted) but three
attempts under heavy shared-box contention each hit os-verify-lock's
queue-timeout (one holder alone held the lock 12+ minutes on an unrelated
command) without ever acquiring; I did not keep retrying past that and report
this one specific reading as NOT MEASURED rather than fabricate it. The final
GREEN state (below) is measured, and re-confirmed again after merging
origin/main (ledger re-regenerates identically: 2 files / 6 errors / 2
signatures, unchanged by the concurrent PR #14437 that also touches
packages/lint/src/**).

Not in scope

Per the file-surface constraint, no edits to packages/lint/src/** — the 6
TS6059 errors are ledgered, never fixed here.

Gates

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RUN_RECORD_PATH
at 0a2b43d11 (post-merge, no staleness warning): 46 derived, 46 run, 0
NOT-MEASURED, 0 UNRUN.
Of those 46, three exit 3 (documented PREREQUISITE
NOT MET, not a red): check:dual-build-cjs-loads and check:type-check-debt --re-measure (both need a full pnpm build workspace closure this run never
built) and check:test-completeness (needs a saved turbo run test log CI
produces). Everything else passed. Also ran (touched scripts/**):
check:ratchet-remedy-authority, check:declared-population-live,
check-self-test-wired.mjs, check-self-test-workflow-commands.mjs,
check-type-check-coverage.mjs --self-test — all green.


Generated by Claude Code


Generated by Claude Code

…ne rule pin file is type-checked (#14173)
Onboarded by wiring to the mechanism #14062 (PR #14420) landed on, per the
triage ruling on this card (comment 5502888897): a sibling tsconfig.test.json
matching vitest's real module semantics, named by `typecheck`. Measured: 6
residual TS6059 errors over 2 files (rootDir violations from imports outside
this package, pre-existing, config-tier), recorded in the new
test-typecheck-debt.json as a CONVERSION of the coverage gate's existing
16-error TEST_DEBT entry, which is deleted as the graduation that pairing
forces.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7cbe705b03384f1bde55fd159a6a16ef6322caf2packageMentionDocs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] packages/lint has no tsc program that compiles its tests — the 2,700-line rule pin file, receiver scan included, is type-checked by nobody

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(lint): wire test layer into check:test-typecheck (#14173) - #14494

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck
Sep 2, 2026
Merged

fix(lint): wire test layer into check:test-typecheck (#14173)#14494
baozhoutao merged 3 commits into
mainfrom
claude/issue-14173-lint-test-typecheck

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14173

What

packages/lint's typecheck script was a bare tsc --noEmit against a
tsconfig.json that excluded **/*.test.ts and **/*.spec.ts, so no gate
anywhere read a lint test file with a type checker (vitest transpiles through
esbuild, types stripped, never resolved). src/validate-expressions.test.ts
alone is ~2,700 lines built almost entirely out of compile-time and meta pins
(the #5017 receiver scan, the TRACKED_UNDECLARED_READS shrink-only list, the
residual-root table) — none of it type-checked by anything.

Wired per the triage ruling (comment 5502888897) to the mechanism #14062 (PR
#14420) landed on: scripts/check-test-typecheck.mts, per package, with a
sibling tsconfig.test.json the typecheck script NAMES.

Measurement

--listFiles on origin/main6aea1f559 (workspace closure built first):

validate-expressions.test.ts -> 0
validate-expressions.ts -> 1

New packages/lint/tsconfig.test.json (module semantics only — esnext /
bundler / lib: ["ES2022"] — matching how vitest actually executes these
files; strictness and rootDir untouched, inherited):

errors under BUILD semantics (NodeNext, tests included) 22 (11 TS7006 + 5 TS2835 + 6 TS6059)
errors under THIS config (test tsconfig) 6 (6 TS6059)

The TS7006/TS2835 pile (16 errors — exactly the coverage gate's recorded
@objectstack/lint TEST_DEBT total) dissolves under bundler resolution, the
same "config tier, not the tests" effect packages/spec/packages/rest/the
packages/plugins/** family measured. The 6 residual TS6059 are
rootDir-violation errors from two test files importing example-app fixtures
outside this package (examples/app-showcase) — pre-existing, and (per the
coverage gate's own historical note on this exact entry) never this package's
debt; rootDir is inherited untouched here, so they surface rather than being
suppressed.

Authority boundary: this is a CONVERSION of the coverage gate's existing
@objectstack/lint TEST_DEBT entry (errors: 16) to per-file/per-signature
form, not a new debt-opening decision — legitimate while the measured total
stays ≤ 16. Measured: 6 ≤ 16. Within bounds.

check:type-check-coverage: GREEN with the '@objectstack/lint' TEST_DEBT
entry deleted and the #14062 graduation docblock carrying lint's line (68/78
packages type-checked, no lint exception listed). The RECONCILED rule this
gate documents ("a TEST_DEBT entry ONLY where no tsconfig the typecheck script
invokes reads the tests") is what forces the entry's removal once typecheck
names a test program — I attempted to capture the RED reading directly (entry
restored on top of the already-wired typecheck script, via a temporary git checkout HEAD --/git apply round-trip, nothing left uncommitted) but three
attempts under heavy shared-box contention each hit os-verify-lock's
queue-timeout (one holder alone held the lock 12+ minutes on an unrelated
command) without ever acquiring; I did not keep retrying past that and report
this one specific reading as NOT MEASURED rather than fabricate it. The final
GREEN state (below) is measured, and re-confirmed again after merging
origin/main (ledger re-regenerates identically: 2 files / 6 errors / 2
signatures, unchanged by the concurrent PR #14437 that also touches
packages/lint/src/**).

Not in scope

Per the file-surface constraint, no edits to packages/lint/src/** — the 6
TS6059 errors are ledgered, never fixed here.

Gates

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RUN_RECORD_PATH
at 0a2b43d11 (post-merge, no staleness warning): 46 derived, 46 run, 0
NOT-MEASURED, 0 UNRUN.
Of those 46, three exit 3 (documented PREREQUISITE
NOT MET, not a red): check:dual-build-cjs-loads and check:type-check-debt --re-measure (both need a full pnpm build workspace closure this run never
built) and check:test-completeness (needs a saved turbo run test log CI
produces). Everything else passed. Also ran (touched scripts/**):
check:ratchet-remedy-authority, check:declared-population-live,
check-self-test-wired.mjs, check-self-test-workflow-commands.mjs,
check-type-check-coverage.mjs --self-test — all green.


Generated by Claude Code


Generated by Claude Code

…ne rule pin file is type-checked (#14173)
Onboarded by wiring to the mechanism #14062 (PR #14420) landed on, per the
triage ruling on this card (comment 5502888897): a sibling tsconfig.test.json
matching vitest's real module semantics, named by `typecheck`. Measured: 6
residual TS6059 errors over 2 files (rootDir violations from imports outside
this package, pre-existing, config-tier), recorded in the new
test-typecheck-debt.json as a CONVERSION of the coverage gate's existing
16-error TEST_DEBT entry, which is deleted as the graduation that pairing
forces.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)).

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/lint/test-typecheck-debt.json) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7cbe705b03384f1bde55fd159a6a16ef6322caf2packageMentionDocs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] packages/lint has no tsc program that compiles its tests — the 2,700-line rule pin file, receiver scan included, is type-checked by nobody

2 participants

@baozhoutao@claude