Uh oh!
There was an error while loading. Please reload this page.
docs(scripts): make check-agent-model-declared's header the stated home of the model-resolution order - #14689
Merged
Conversation
…as the home of the model-resolution order The header's parenthetical still said "see `.claude/agents/os-dev.md` for the full order and both adjacent traps". That file's model-pin comment is now a two-line pointer back at this header, so the two comments pointed at each other and neither claimed to be the home. The header already documents everything the deferral promised: the full four-step resolution order above, the env var outranking every other step including this gate's own pin, and the org-allowlist fallback landing on the INHERITED model in the next paragraph. So the sentence now names both adjacent traps in place and states that os-dev.md carries only the `model: opus` pin plus a pointer here. Comment-only; no behaviour change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
os-litant
marked this pull request as ready for review
September 2, 2026 19:01
os-litant
enabled auto-merge
September 2, 2026 19:01
os-litant
commented
Sep 2, 2026
CollaboratorAuthor
Landing provenance (skills lane seat, session Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#14232
Comment-only: one sentence in the header of
scripts/check-agent-model-declared.mjs. One file, no behaviour change, no code change.Premise, verified on
origin/mainPR #14229 (merged 2026-09-02, commit
909a44171) shrank.claude/agents/os-dev.md's model-pin comment to a two-line pointer. At merge basebd4aa4e49that comment is lines 12-13. Quoted verbatim and untranslated below; its delimiters are an HTML-comment open/close pair, described in words rather than written literally per this repo's body-sanitizer discipline (fences do not protect that shape):That pointer's destination is this gate's header — while this gate's header still said "see
.claude/agents/os-dev.mdfor the full order and both adjacent traps". The two comments pointed at each other and neither claimed to be the home. Premise holds.Nothing was ever unreachable. The header already carries all three pieces the deferral promised: the four-step resolution order (lines 5-9), the env var outranking every other step including this gate's own pin (the sentence being fixed), and the org-allowlist fallback landing on the INHERITED model (lines 17-20, unchanged). The defect was only that the sentence described the pre-#14229 file.
The one sentence — before / after
Before, lines 13-15 on
origin/main:After, lines 13-17:
The header now names both adjacent traps in place — the env-var one in the sentence itself, the allowlist one by pointing at the paragraph directly below that already states it — and claims itself as the home instead of deferring to a file that no longer holds the text.
Line-width convention preserved: the file's existing maximum comment width is 84 characters; the replacement's widest line is also 84 (measured, not estimated).
⛔ No edit to
.claude/agents/os-dev.md(governed, and it already points here). ⛔ No other file touched.skip-changesetApplied.
scripts/releases nothing: the root manifest is"private": true, andscripts/check-agent-model-declared.mjsappears in no package'sfiles[].scripts/check-empty-changeset.mjshas nothing to say about a PR that adds no changeset at all — its GREEN 3 case asserts "an untouched.changesetdir must not even be read".Gates
Every command ran through
scripts/pm/os-verify-lock.sh(slotissue-14232), each exit code captured by redirect before any pipe. All measured atc529a40a— the final commit on this branch, and the same tree the union was derived from.pnpm check:agent-model-declared(the script's own suite — it has a--self-testflag, already wired into this script name)✓ check-agent-model-declared self-test: 18 cases pass.+✓ check-agent-model-declared: 1 agent definition(s) under .claude/agents/ all declare a modelpnpm exec eslint --no-inline-config scripts/check-agent-model-declared.mjsos-verify-lock: VERDICT command-exit 0pnpm check:nul-bytes✓ check-nul-bytes --self-test: 75 assertions over a temp git repo (real scan() path)pnpm check:entry-guard✓ check:entry-guard: 199 scripts/ file(s) — every entry guard goes through invoked-as.mjspnpm check:parse-guard✓ check:parse-guard: 198 scripts/ file(s) — every TypeScript parse goes through ts-parse.mjs.pnpm check:pm-skill-id-lint✓ check-skill-id-lint: 23 file(s) clean (pattern /#[0-9]{3,}/g).Full union, re-derived after the edit
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands— no hand-fed paths; the script took its own change set from the merge base (1 path(s) vs merge base bd4aa4e49, three-dot semantics) and asserted the repo: "--repo 'objectstack-ai/objectstack' checked against this checkout's 'origin' remote — it holds." It derived 16 commands; all 16 were run.node scripts/check-ci-filter-parity.mjsOK: all 130 declared cross-package glob(s) (92 unique) are covered by core or crosspkg…node scripts/check-cross-package-test-inputs.mjsOK: 25 package(s) read outside themselves, all declared…node scripts/check-shard-attestation.mjs✓ check-shard-attestation: 2 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s).node scripts/check-test-completeness.mjsnode scripts/pm/bare-root-worklist.mjs --self-testOK self-test: 57 live row(s), 49 unreachable as spelled, 49 recorded verdict(s) — none stale…pnpm check:agent-model-declaredpnpm check:agent-test-spelling✓ check-agent-test-spelling: 0 violations — 425 file(s) · 5645 bare -- token(s)…pnpm check:bash32-floor✓ check-bash32-floor: 26 tracked shell file(s) … name no bash 4+ construct…pnpm check:cli-command-ids✓ check-cli-command-ids: 315 command-id literal(s) across 112 file(s) … all resolvepnpm check:cross-package-test-inputsOK: 25 package(s) read outside themselves, all declared…pnpm check:entry-guardpnpm check:parse-guardpnpm check:pm-dispatch-gates✓ dispatch-gates self-test: 1240 cases pass.pnpm check:pnpm-filter-targets✓ check:pnpm-filter-targets: 142/181 --filter occurrence(s) across 32 file(s) resolve…pnpm check:ratchet-remedy-authorityOK check-ratchet-remedy-authority: 184 scripts swept…pnpm check:watch-hint-literal✓ check-watch-hint-literal: 45 declaration(s) across 4 rostered name(s)…check-test-completeness= NOT MEASURED, not a red and not a flake. Exit 3, and the gate says so itself in the text it printed:CI tees the log and passes the path on every invocation, so this branch is unreachable there.
The derivation also noted 9 further families that "apply once this card's changeset exists". This PR carries
skip-changesetand writes no changeset, so those 9 have no path to match.premise_falseNone. Every premise the dispatch stated held as written:
beforeblock).scripts/check-agent-model-declared.mjshas a--self-testflag, andpackage.jsonwires it intocheck:agent-model-declared— held, so the script's own suite is measured rather than NOT MEASURED.scripts/is not governed surface and releases nothing — held.One dispatch detail was off by two lines and is recorded rather than corrected: the sentence is at lines 13-15 on
origin/main, not "around line 15" alone — the parenthetical spans three lines. No consequence.🤖 Generated with Claude Code
https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
Generated by Claude Code