Uh oh!
There was an error while loading. Please reload this page.
chore(lint): delete inert eslint-disable family comments in package sources - #14801
Conversation
…ources package.json's lint script runs eslint with --no-inline-config, so every inline eslint-disable / eslint-disable-next-line / eslint-enable comment is ignored by the repo's only lint invocation. This deletes the 58 such comments across 26 non-test source files under packages/** that carry them at this branch's base (89a156a) -- comment removal only, no code change. Per-comment measurement against eslint.config.mjs (see PR body) confirms none of the named rules are configured there either, so the deletion cannot expose a live finding. Also re-anchors 5 line-number references in content/docs/permissions/system-context.mdx that check:system-context-census pins to exact lines in packages/rest/src/rest-server.ts -- one of this PR's comment deletions shifted those lines by one, and the gate's own --fix brought the anchors back in sync (verified green before and after). Fixes#14529 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
…lete-inert-eslint-disable
📓 Docs Drift CheckThis PR changes 17 package(s): 6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:
⛔ 1 release-owned page(s) also name something this change touched. These are read-only:
What this run could not see
Coarse fallback — 68 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): Which tree this was computed onThis run read A worktree cut from an older # while this PR is open — GitHub drops the merge commit once it closes
git fetch origin cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c && git checkout cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2d40f9146800dcf625fc54696f6435e676b1ed96 7b8f2ec797b37c35e61687627f4fcaf284614cc2 && git checkout -B drift-repro 2d40f9146800dcf625fc54696f6435e676b1ed96 && git merge --no-ff 7b8f2ec797b37c35e61687627f4fcaf284614cc2
node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96
|
…lete-inert-eslint-disable
Re-trigger via PR-side CI on Generated by Claude Code |
Uh oh!
There was an error while loading. Please reload this page.
Fixes#14529
What
Deletes all
eslint-disable/eslint-disable-next-line/eslint-enablefamilycomments from non-test source files under
packages/**(maintainer-ruled A,ruling comment 5518653161).
package.json:32's only lint invocation(
eslint . --no-inline-config) ignores every inline configuration comment, sothese are inert regardless of which rule they name;
--no-inline-configstaysunchanged.
Measured at branch base
89a156af8(The card's original estimate was 134/45 at
ed44512; re-measuring the samepopulation definition directly against that commit —
git grepoverpackages/**, excludingdist/,node_modules/,*.test.*,test/,tests/,__tests__/— also returns 58/26, not 134/45, so the discrepancypredates this branch and isn't drift from commits landing between
ed44512and
89a156af8. Reported as measured, not reconciled against the originalcount.)
Step 1 — per-comment measurement against
eslint.config.mjsEvery rule named by the 58 comments, checked for a
rules:entry ineslint.config.mjs:eslint.config.mjs?@typescript-eslint/no-explicit-anyno-consoleeqeqeq@typescript-eslint/no-unused-varsno-constant-conditionno-newno-control-regex@typescript-eslint/ban-ts-comment@typescript-eslint/no-implied-eval, no-new-func/* eslint-disable */(no rule named)Zero of the named rules are configured. So the deletion is doubly safe:
inert under
--no-inline-config, and would still be inert without that flag(matching the card's own example —
no-consolewas never configured either).No configured-rule row exists, so no follow-up card is filed for an exposed
finding.
Step 2 — delete
58 lines deleted across 26 files, all whole-line comments (none were trailing
comments on a code line, verified before deleting) — pure comment removal,
git diff --statshows only deletions in the 26 source files.Step 3 — collateral: one line-anchored ledger needed re-syncing
check:system-context-censuspins exact line numbers incontent/docs/permissions/system-context.mdxto elevation-read sites inpackages/rest/src/rest-server.ts. Deleting the oneeslint-disable-next-linecomment in that file (originally line 4331) shifted 5 downstream anchors by
one line, which the gate correctly flagged as line rot
(
site-without-a-row/anchor-is-not-a-read-site, 10 problems). This is thegate's own maintained repair path, not a new finding:
node scripts/check-system-context-census.mjs --fixre-anchored the 5 references(
4716→4715,6079→6078,6327→6326,6758→6757,6951→6950) with nocontent change beyond the line numbers, and the gate is green before and after
on the re-synced tree. One line changed in
content/docs/permissions/system-context.mdx(not
content/docs/releases/**).pnpm lintis green both before and after this diff (same result — the flagmakes the comments' removal a no-op for lint's own verdict, confirming the
premise).
Tests
pnpm lint(viascripts/pm/os-verify-lock.sh): green, before deletion andafter, both on the pre-merge tree and again on the merged head
aca7d5cd4d.pnpm exec turbo run build+pnpm exec turbo run typecheck, scoped to the17 touched packages plus their full dependency closure (turbo resolves
^build/^typecheck): green — 57/57 build tasks, 67/67 typecheck tasks.node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands:34 local gate families named for this diff. Ran all 34:
check:system-context-census: 10 problems from line-number rot (see Step 3above) — fixed with the gate's own
--fix, verified green after.check:dual-build-cjs-loadsandcheck:i18n-coverage: both exitPREREQUISITE-NOT-MET / COULD-NOT-MEASURE — each needs a full-workspace
pnpm build(dozens of packages, e.g.@objectstack/connector-mcp,@objectstack/studio) that this scoped verification didn't run; NOTMEASURED locally, not a finding. CI's
Build Core/Type Checkjobsbuild the full workspace and will measure these for real.
check-test-completeness.mjs: exits 3 by design without aturbo run testlog path (CI-only invocation) — NOT MEASURED locally, not a finding.
Scope
Comment-only diff; no code, no
eslint.config.mjs, nopackage.jsonlintflag.
skip-changesetlabel applied (no public surface moves).PR session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
🤖 Generated with Claude Code
https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Generated by Claude Code