chore(lint): delete inert eslint-disable family comments in package sources - #14801

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable
Sep 3, 2026
Merged

chore(lint): delete inert eslint-disable family comments in package sources#14801
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable

Conversation

@claude

@claudeclaudeBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes#14529

What

Deletes all eslint-disable / eslint-disable-next-line / eslint-enable family
comments from non-test source files under packages/** (maintainer-ruled A,
ruling comment 5518653161). package.json:32's only lint invocation
(eslint . --no-inline-config) ignores every inline configuration comment, so
these are inert regardless of which rule they name; --no-inline-config stays
unchanged.

Measured at branch base 89a156af8

eslint-disable family comments in packages/** (non-test): 58
files carrying them: 26

(The card's original estimate was 134/45 at ed44512; re-measuring the same
population definition directly against that commit — git grep over
packages/**, excluding dist/, node_modules/, *.test.*, test/,
tests/, __tests__/ — also returns 58/26, not 134/45, so the discrepancy
predates this branch and isn't drift from commits landing between ed44512
and 89a156af8. Reported as measured, not reconciled against the original
count.)

Step 1 — per-comment measurement against eslint.config.mjs

Every rule named by the 58 comments, checked for a rules: entry in
eslint.config.mjs:

Rule namedOccurrencesConfigured in eslint.config.mjs?
@typescript-eslint/no-explicit-any29No
no-console20No
eqeqeq3No
@typescript-eslint/no-unused-vars3No
no-constant-condition2No
no-new1No
no-control-regex1No
@typescript-eslint/ban-ts-comment1No
@typescript-eslint/no-implied-eval, no-new-func1 (2 rules)No
bare /* eslint-disable */ (no rule named)1N/A

Zero of the named rules are configured. So the deletion is doubly safe:
inert under --no-inline-config, and would still be inert without that flag
(matching the card's own example — no-console was never configured either).
No configured-rule row exists, so no follow-up card is filed for an exposed
finding.

Step 2 — delete

58 lines deleted across 26 files, all whole-line comments (none were trailing
comments on a code line, verified before deleting) — pure comment removal, git diff --stat shows only deletions in the 26 source files.

Step 3 — collateral: one line-anchored ledger needed re-syncing

check:system-context-census pins exact line numbers in
content/docs/permissions/system-context.mdx to elevation-read sites in
packages/rest/src/rest-server.ts. Deleting the one eslint-disable-next-line
comment in that file (originally line 4331) shifted 5 downstream anchors by
one line, which the gate correctly flagged as line rot
(site-without-a-row / anchor-is-not-a-read-site, 10 problems). This is the
gate's own maintained repair path, not a new finding: node scripts/check-system-context-census.mjs --fix re-anchored the 5 references
(4716→4715, 6079→6078, 6327→6326, 6758→6757, 6951→6950) with no
content change beyond the line numbers, and the gate is green before and after
on the re-synced tree. One line changed in content/docs/permissions/system-context.mdx
(not content/docs/releases/**).

pnpm lint is green both before and after this diff (same result — the flag
makes the comments' removal a no-op for lint's own verdict, confirming the
premise).

Tests

  • pnpm lint (via scripts/pm/os-verify-lock.sh): green, before deletion and
    after, both on the pre-merge tree and again on the merged head aca7d5cd4d.
  • pnpm exec turbo run build + pnpm exec turbo run typecheck, scoped to the
    17 touched packages plus their full dependency closure (turbo resolves
    ^build/^typecheck): green — 57/57 build tasks, 67/67 typecheck tasks.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands:
    34 local gate families named for this diff. Ran all 34:
    • 32 green.
    • check:system-context-census: 10 problems from line-number rot (see Step 3
      above) — fixed with the gate's own --fix, verified green after.
    • check:dual-build-cjs-loads and check:i18n-coverage: both exit
      PREREQUISITE-NOT-MET / COULD-NOT-MEASURE — each needs a full-workspace
      pnpm build (dozens of packages, e.g. @objectstack/connector-mcp,
      @objectstack/studio) that this scoped verification didn't run; NOT
      MEASURED locally
      , not a finding. CI's Build Core / Type Check jobs
      build the full workspace and will measure these for real.
    • check-test-completeness.mjs: exits 3 by design without a turbo run test
      log path (CI-only invocation) — NOT MEASURED locally, not a finding.

Scope

Comment-only diff; no code, no eslint.config.mjs, no package.json lint
flag. skip-changeset label applied (no public surface moves).

PR session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

…ources
package.json's lint script runs eslint with --no-inline-config, so every
inline eslint-disable / eslint-disable-next-line / eslint-enable comment
is ignored by the repo's only lint invocation. This deletes the 58 such
comments across 26 non-test source files under packages/** that carry
them at this branch's base (89a156a) -- comment removal only, no code
change. Per-comment measurement against eslint.config.mjs (see PR body)
confirms none of the named rules are configured there either, so the
deletion cannot expose a live finding.
Also re-anchors 5 line-number references in
content/docs/permissions/system-context.mdx that check:system-context-census
pins to exact lines in packages/rest/src/rest-server.ts -- one of this PR's
comment deletions shifted those lines by one, and the gate's own --fix
brought the anchors back in sync (verified green before and after).
Fixes#14529
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 17 package(s): @objectstack/hono, @objectstack/cli, @objectstack/core, @objectstack/driver-sqlite-wasm, @objectstack/metadata-protocol, @objectstack/metadata, @objectstack/objectql, @objectstack/plugin-auth, @objectstack/rest, @objectstack/runtime, @objectstack/sdui-parser, @objectstack/service-automation, @objectstack/service-cluster-redis, @objectstack/service-cluster, @objectstack/service-datasource, @objectstack/types, @objectstack/verify, touching 21 documentable anchor(s). ⚠️7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/environment-routing.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/concepts/metadata-lifecycle.mdx(via SysMetadataRepository (symbol, a top-level class))
  • content/docs/data-modeling/drivers.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/deployment/cli.mdx(via loadArtifactBundle (symbol, a top-level function))
  • content/docs/deployment/single-project-mode.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/plugins/index.mdx(via createStandaloneStack (symbol, a top-level function))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via bootStack (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …) — pages documenting those are invisible to this run
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 68 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96packageMentionDocs.

Which tree this was computed on

This run read content/docs from cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c — the merge of head 7b8f2ec797b37c35e61687627f4fcaf284614cc2 into base 2d40f9146800dcf625fc54696f6435e676b1ed96, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c && git checkout cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2d40f9146800dcf625fc54696f6435e676b1ed96 7b8f2ec797b37c35e61687627f4fcaf284614cc2 && git checkout -B drift-repro 2d40f9146800dcf625fc54696f6435e676b1ed96 && git merge --no-ff 7b8f2ec797b37c35e61687627f4fcaf284614cc2
node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 2d40f9146800dcf625fc54696f6435e676b1ed96 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@claude

claudeBot commented Sep 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Re-trigger via update-branch (domain:devx execution seat, session session_01LAwHpn4uVuf4N1geBcD5i3).

PR-side CI on cd73b0c40 is red only on Test Core (1/6) (packages/clipnpm run test exit 1 — check-run annotations carry the exit code, the log download is refused from this container; same shard/package as the #14648 signature, and this diff does not touch packages/cli test code). This head does not contain the merged fix accb9231c7 (PR #14715; verified git merge-base --is-ancestor), so this is the "base lacks a merged fix ⇒ merge main, push a new head" branch, not a re-run: GitHub merges main into the branch (a real merge commit, no rewrite). If Test Core (1/6) reds again on the new head with the same file, it parks under the #14648 post-fix reading like PR #14774; any other red is real. #14529 stays pm:dispatched; flip + arm on green.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 3, 2026 04:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit 8bcc348Sep 3, 2026
36 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14529-delete-inert-eslint-disable branch September 3, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/sskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

134 eslint-disable comments across 45 source files are structurally inert — pnpm lint runs --no-inline-config

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

chore(lint): delete inert eslint-disable family comments in package sources - #14801

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable
Sep 3, 2026
Merged

chore(lint): delete inert eslint-disable family comments in package sources#14801
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable

Conversation

@claude

@claudeclaudeBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes#14529

What

Deletes all eslint-disable / eslint-disable-next-line / eslint-enable family
comments from non-test source files under packages/** (maintainer-ruled A,
ruling comment 5518653161). package.json:32's only lint invocation
(eslint . --no-inline-config) ignores every inline configuration comment, so
these are inert regardless of which rule they name; --no-inline-config stays
unchanged.

Measured at branch base 89a156af8

eslint-disable family comments in packages/** (non-test): 58
files carrying them: 26

(The card's original estimate was 134/45 at ed44512; re-measuring the same
population definition directly against that commit — git grep over
packages/**, excluding dist/, node_modules/, *.test.*, test/,
tests/, __tests__/ — also returns 58/26, not 134/45, so the discrepancy
predates this branch and isn't drift from commits landing between ed44512
and 89a156af8. Reported as measured, not reconciled against the original
count.)

Step 1 — per-comment measurement against eslint.config.mjs

Every rule named by the 58 comments, checked for a rules: entry in
eslint.config.mjs:

Rule namedOccurrencesConfigured in eslint.config.mjs?
@typescript-eslint/no-explicit-any29No
no-console20No
eqeqeq3No
@typescript-eslint/no-unused-vars3No
no-constant-condition2No
no-new1No
no-control-regex1No
@typescript-eslint/ban-ts-comment1No
@typescript-eslint/no-implied-eval, no-new-func1 (2 rules)No
bare /* eslint-disable */ (no rule named)1N/A

Zero of the named rules are configured. So the deletion is doubly safe:
inert under --no-inline-config, and would still be inert without that flag
(matching the card's own example — no-console was never configured either).
No configured-rule row exists, so no follow-up card is filed for an exposed
finding.

Step 2 — delete

58 lines deleted across 26 files, all whole-line comments (none were trailing
comments on a code line, verified before deleting) — pure comment removal, git diff --stat shows only deletions in the 26 source files.

Step 3 — collateral: one line-anchored ledger needed re-syncing

check:system-context-census pins exact line numbers in
content/docs/permissions/system-context.mdx to elevation-read sites in
packages/rest/src/rest-server.ts. Deleting the one eslint-disable-next-line
comment in that file (originally line 4331) shifted 5 downstream anchors by
one line, which the gate correctly flagged as line rot
(site-without-a-row / anchor-is-not-a-read-site, 10 problems). This is the
gate's own maintained repair path, not a new finding: node scripts/check-system-context-census.mjs --fix re-anchored the 5 references
(4716→4715, 6079→6078, 6327→6326, 6758→6757, 6951→6950) with no
content change beyond the line numbers, and the gate is green before and after
on the re-synced tree. One line changed in content/docs/permissions/system-context.mdx
(not content/docs/releases/**).

pnpm lint is green both before and after this diff (same result — the flag
makes the comments' removal a no-op for lint's own verdict, confirming the
premise).

Tests

  • pnpm lint (via scripts/pm/os-verify-lock.sh): green, before deletion and
    after, both on the pre-merge tree and again on the merged head aca7d5cd4d.
  • pnpm exec turbo run build + pnpm exec turbo run typecheck, scoped to the
    17 touched packages plus their full dependency closure (turbo resolves
    ^build/^typecheck): green — 57/57 build tasks, 67/67 typecheck tasks.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands:
    34 local gate families named for this diff. Ran all 34:
    • 32 green.
    • check:system-context-census: 10 problems from line-number rot (see Step 3
      above) — fixed with the gate's own --fix, verified green after.
    • check:dual-build-cjs-loads and check:i18n-coverage: both exit
      PREREQUISITE-NOT-MET / COULD-NOT-MEASURE — each needs a full-workspace
      pnpm build (dozens of packages, e.g. @objectstack/connector-mcp,
      @objectstack/studio) that this scoped verification didn't run; NOT
      MEASURED locally
      , not a finding. CI's Build Core / Type Check jobs
      build the full workspace and will measure these for real.
    • check-test-completeness.mjs: exits 3 by design without a turbo run test
      log path (CI-only invocation) — NOT MEASURED locally, not a finding.

Scope

Comment-only diff; no code, no eslint.config.mjs, no package.json lint
flag. skip-changeset label applied (no public surface moves).

PR session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

…ources
package.json's lint script runs eslint with --no-inline-config, so every
inline eslint-disable / eslint-disable-next-line / eslint-enable comment
is ignored by the repo's only lint invocation. This deletes the 58 such
comments across 26 non-test source files under packages/** that carry
them at this branch's base (89a156a) -- comment removal only, no code
change. Per-comment measurement against eslint.config.mjs (see PR body)
confirms none of the named rules are configured there either, so the
deletion cannot expose a live finding.
Also re-anchors 5 line-number references in
content/docs/permissions/system-context.mdx that check:system-context-census
pins to exact lines in packages/rest/src/rest-server.ts -- one of this PR's
comment deletions shifted those lines by one, and the gate's own --fix
brought the anchors back in sync (verified green before and after).
Fixes#14529
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 17 package(s): @objectstack/hono, @objectstack/cli, @objectstack/core, @objectstack/driver-sqlite-wasm, @objectstack/metadata-protocol, @objectstack/metadata, @objectstack/objectql, @objectstack/plugin-auth, @objectstack/rest, @objectstack/runtime, @objectstack/sdui-parser, @objectstack/service-automation, @objectstack/service-cluster-redis, @objectstack/service-cluster, @objectstack/service-datasource, @objectstack/types, @objectstack/verify, touching 21 documentable anchor(s). ⚠️7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/environment-routing.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/concepts/metadata-lifecycle.mdx(via SysMetadataRepository (symbol, a top-level class))
  • content/docs/data-modeling/drivers.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/deployment/cli.mdx(via loadArtifactBundle (symbol, a top-level function))
  • content/docs/deployment/single-project-mode.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/plugins/index.mdx(via createStandaloneStack (symbol, a top-level function))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via bootStack (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …) — pages documenting those are invisible to this run
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 68 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96packageMentionDocs.

Which tree this was computed on

This run read content/docs from cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c — the merge of head 7b8f2ec797b37c35e61687627f4fcaf284614cc2 into base 2d40f9146800dcf625fc54696f6435e676b1ed96, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c && git checkout cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2d40f9146800dcf625fc54696f6435e676b1ed96 7b8f2ec797b37c35e61687627f4fcaf284614cc2 && git checkout -B drift-repro 2d40f9146800dcf625fc54696f6435e676b1ed96 && git merge --no-ff 7b8f2ec797b37c35e61687627f4fcaf284614cc2
node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 2d40f9146800dcf625fc54696f6435e676b1ed96 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@claude

claudeBot commented Sep 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Re-trigger via update-branch (domain:devx execution seat, session session_01LAwHpn4uVuf4N1geBcD5i3).

PR-side CI on cd73b0c40 is red only on Test Core (1/6) (packages/clipnpm run test exit 1 — check-run annotations carry the exit code, the log download is refused from this container; same shard/package as the #14648 signature, and this diff does not touch packages/cli test code). This head does not contain the merged fix accb9231c7 (PR #14715; verified git merge-base --is-ancestor), so this is the "base lacks a merged fix ⇒ merge main, push a new head" branch, not a re-run: GitHub merges main into the branch (a real merge commit, no rewrite). If Test Core (1/6) reds again on the new head with the same file, it parks under the #14648 post-fix reading like PR #14774; any other red is real. #14529 stays pm:dispatched; flip + arm on green.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 3, 2026 04:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit 8bcc348Sep 3, 2026
36 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14529-delete-inert-eslint-disable branch September 3, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/sskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

134 eslint-disable comments across 45 source files are structurally inert — pnpm lint runs --no-inline-config

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(lint): delete inert eslint-disable family comments in package sources - #14801

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable
Sep 3, 2026
Merged

chore(lint): delete inert eslint-disable family comments in package sources#14801
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable

Conversation

@claude

@claudeclaudeBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes#14529

What

Deletes all eslint-disable / eslint-disable-next-line / eslint-enable family
comments from non-test source files under packages/** (maintainer-ruled A,
ruling comment 5518653161). package.json:32's only lint invocation
(eslint . --no-inline-config) ignores every inline configuration comment, so
these are inert regardless of which rule they name; --no-inline-config stays
unchanged.

Measured at branch base 89a156af8

eslint-disable family comments in packages/** (non-test): 58
files carrying them: 26

(The card's original estimate was 134/45 at ed44512; re-measuring the same
population definition directly against that commit — git grep over
packages/**, excluding dist/, node_modules/, *.test.*, test/,
tests/, __tests__/ — also returns 58/26, not 134/45, so the discrepancy
predates this branch and isn't drift from commits landing between ed44512
and 89a156af8. Reported as measured, not reconciled against the original
count.)

Step 1 — per-comment measurement against eslint.config.mjs

Every rule named by the 58 comments, checked for a rules: entry in
eslint.config.mjs:

Rule namedOccurrencesConfigured in eslint.config.mjs?
@typescript-eslint/no-explicit-any29No
no-console20No
eqeqeq3No
@typescript-eslint/no-unused-vars3No
no-constant-condition2No
no-new1No
no-control-regex1No
@typescript-eslint/ban-ts-comment1No
@typescript-eslint/no-implied-eval, no-new-func1 (2 rules)No
bare /* eslint-disable */ (no rule named)1N/A

Zero of the named rules are configured. So the deletion is doubly safe:
inert under --no-inline-config, and would still be inert without that flag
(matching the card's own example — no-console was never configured either).
No configured-rule row exists, so no follow-up card is filed for an exposed
finding.

Step 2 — delete

58 lines deleted across 26 files, all whole-line comments (none were trailing
comments on a code line, verified before deleting) — pure comment removal, git diff --stat shows only deletions in the 26 source files.

Step 3 — collateral: one line-anchored ledger needed re-syncing

check:system-context-census pins exact line numbers in
content/docs/permissions/system-context.mdx to elevation-read sites in
packages/rest/src/rest-server.ts. Deleting the one eslint-disable-next-line
comment in that file (originally line 4331) shifted 5 downstream anchors by
one line, which the gate correctly flagged as line rot
(site-without-a-row / anchor-is-not-a-read-site, 10 problems). This is the
gate's own maintained repair path, not a new finding: node scripts/check-system-context-census.mjs --fix re-anchored the 5 references
(4716→4715, 6079→6078, 6327→6326, 6758→6757, 6951→6950) with no
content change beyond the line numbers, and the gate is green before and after
on the re-synced tree. One line changed in content/docs/permissions/system-context.mdx
(not content/docs/releases/**).

pnpm lint is green both before and after this diff (same result — the flag
makes the comments' removal a no-op for lint's own verdict, confirming the
premise).

Tests

  • pnpm lint (via scripts/pm/os-verify-lock.sh): green, before deletion and
    after, both on the pre-merge tree and again on the merged head aca7d5cd4d.
  • pnpm exec turbo run build + pnpm exec turbo run typecheck, scoped to the
    17 touched packages plus their full dependency closure (turbo resolves
    ^build/^typecheck): green — 57/57 build tasks, 67/67 typecheck tasks.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands:
    34 local gate families named for this diff. Ran all 34:
    • 32 green.
    • check:system-context-census: 10 problems from line-number rot (see Step 3
      above) — fixed with the gate's own --fix, verified green after.
    • check:dual-build-cjs-loads and check:i18n-coverage: both exit
      PREREQUISITE-NOT-MET / COULD-NOT-MEASURE — each needs a full-workspace
      pnpm build (dozens of packages, e.g. @objectstack/connector-mcp,
      @objectstack/studio) that this scoped verification didn't run; NOT
      MEASURED locally
      , not a finding. CI's Build Core / Type Check jobs
      build the full workspace and will measure these for real.
    • check-test-completeness.mjs: exits 3 by design without a turbo run test
      log path (CI-only invocation) — NOT MEASURED locally, not a finding.

Scope

Comment-only diff; no code, no eslint.config.mjs, no package.json lint
flag. skip-changeset label applied (no public surface moves).

PR session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

…ources
package.json's lint script runs eslint with --no-inline-config, so every
inline eslint-disable / eslint-disable-next-line / eslint-enable comment
is ignored by the repo's only lint invocation. This deletes the 58 such
comments across 26 non-test source files under packages/** that carry
them at this branch's base (89a156a) -- comment removal only, no code
change. Per-comment measurement against eslint.config.mjs (see PR body)
confirms none of the named rules are configured there either, so the
deletion cannot expose a live finding.
Also re-anchors 5 line-number references in
content/docs/permissions/system-context.mdx that check:system-context-census
pins to exact lines in packages/rest/src/rest-server.ts -- one of this PR's
comment deletions shifted those lines by one, and the gate's own --fix
brought the anchors back in sync (verified green before and after).
Fixes#14529
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 17 package(s): @objectstack/hono, @objectstack/cli, @objectstack/core, @objectstack/driver-sqlite-wasm, @objectstack/metadata-protocol, @objectstack/metadata, @objectstack/objectql, @objectstack/plugin-auth, @objectstack/rest, @objectstack/runtime, @objectstack/sdui-parser, @objectstack/service-automation, @objectstack/service-cluster-redis, @objectstack/service-cluster, @objectstack/service-datasource, @objectstack/types, @objectstack/verify, touching 21 documentable anchor(s). ⚠️7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/environment-routing.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/concepts/metadata-lifecycle.mdx(via SysMetadataRepository (symbol, a top-level class))
  • content/docs/data-modeling/drivers.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/deployment/cli.mdx(via loadArtifactBundle (symbol, a top-level function))
  • content/docs/deployment/single-project-mode.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/plugins/index.mdx(via createStandaloneStack (symbol, a top-level function))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via bootStack (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …) — pages documenting those are invisible to this run
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 68 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96packageMentionDocs.

Which tree this was computed on

This run read content/docs from cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c — the merge of head 7b8f2ec797b37c35e61687627f4fcaf284614cc2 into base 2d40f9146800dcf625fc54696f6435e676b1ed96, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c && git checkout cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2d40f9146800dcf625fc54696f6435e676b1ed96 7b8f2ec797b37c35e61687627f4fcaf284614cc2 && git checkout -B drift-repro 2d40f9146800dcf625fc54696f6435e676b1ed96 && git merge --no-ff 7b8f2ec797b37c35e61687627f4fcaf284614cc2
node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 2d40f9146800dcf625fc54696f6435e676b1ed96 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@claude

claudeBot commented Sep 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Re-trigger via update-branch (domain:devx execution seat, session session_01LAwHpn4uVuf4N1geBcD5i3).

PR-side CI on cd73b0c40 is red only on Test Core (1/6) (packages/clipnpm run test exit 1 — check-run annotations carry the exit code, the log download is refused from this container; same shard/package as the #14648 signature, and this diff does not touch packages/cli test code). This head does not contain the merged fix accb9231c7 (PR #14715; verified git merge-base --is-ancestor), so this is the "base lacks a merged fix ⇒ merge main, push a new head" branch, not a re-run: GitHub merges main into the branch (a real merge commit, no rewrite). If Test Core (1/6) reds again on the new head with the same file, it parks under the #14648 post-fix reading like PR #14774; any other red is real. #14529 stays pm:dispatched; flip + arm on green.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 3, 2026 04:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit 8bcc348Sep 3, 2026
36 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14529-delete-inert-eslint-disable branch September 3, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/sskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

134 eslint-disable comments across 45 source files are structurally inert — pnpm lint runs --no-inline-config

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(lint): delete inert eslint-disable family comments in package sources - #14801

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable
Sep 3, 2026
Merged

chore(lint): delete inert eslint-disable family comments in package sources#14801
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable

Conversation

@claude

@claudeclaudeBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes#14529

What

Deletes all eslint-disable / eslint-disable-next-line / eslint-enable family
comments from non-test source files under packages/** (maintainer-ruled A,
ruling comment 5518653161). package.json:32's only lint invocation
(eslint . --no-inline-config) ignores every inline configuration comment, so
these are inert regardless of which rule they name; --no-inline-config stays
unchanged.

Measured at branch base 89a156af8

eslint-disable family comments in packages/** (non-test): 58
files carrying them: 26

(The card's original estimate was 134/45 at ed44512; re-measuring the same
population definition directly against that commit — git grep over
packages/**, excluding dist/, node_modules/, *.test.*, test/,
tests/, __tests__/ — also returns 58/26, not 134/45, so the discrepancy
predates this branch and isn't drift from commits landing between ed44512
and 89a156af8. Reported as measured, not reconciled against the original
count.)

Step 1 — per-comment measurement against eslint.config.mjs

Every rule named by the 58 comments, checked for a rules: entry in
eslint.config.mjs:

Rule namedOccurrencesConfigured in eslint.config.mjs?
@typescript-eslint/no-explicit-any29No
no-console20No
eqeqeq3No
@typescript-eslint/no-unused-vars3No
no-constant-condition2No
no-new1No
no-control-regex1No
@typescript-eslint/ban-ts-comment1No
@typescript-eslint/no-implied-eval, no-new-func1 (2 rules)No
bare /* eslint-disable */ (no rule named)1N/A

Zero of the named rules are configured. So the deletion is doubly safe:
inert under --no-inline-config, and would still be inert without that flag
(matching the card's own example — no-console was never configured either).
No configured-rule row exists, so no follow-up card is filed for an exposed
finding.

Step 2 — delete

58 lines deleted across 26 files, all whole-line comments (none were trailing
comments on a code line, verified before deleting) — pure comment removal, git diff --stat shows only deletions in the 26 source files.

Step 3 — collateral: one line-anchored ledger needed re-syncing

check:system-context-census pins exact line numbers in
content/docs/permissions/system-context.mdx to elevation-read sites in
packages/rest/src/rest-server.ts. Deleting the one eslint-disable-next-line
comment in that file (originally line 4331) shifted 5 downstream anchors by
one line, which the gate correctly flagged as line rot
(site-without-a-row / anchor-is-not-a-read-site, 10 problems). This is the
gate's own maintained repair path, not a new finding: node scripts/check-system-context-census.mjs --fix re-anchored the 5 references
(4716→4715, 6079→6078, 6327→6326, 6758→6757, 6951→6950) with no
content change beyond the line numbers, and the gate is green before and after
on the re-synced tree. One line changed in content/docs/permissions/system-context.mdx
(not content/docs/releases/**).

pnpm lint is green both before and after this diff (same result — the flag
makes the comments' removal a no-op for lint's own verdict, confirming the
premise).

Tests

  • pnpm lint (via scripts/pm/os-verify-lock.sh): green, before deletion and
    after, both on the pre-merge tree and again on the merged head aca7d5cd4d.
  • pnpm exec turbo run build + pnpm exec turbo run typecheck, scoped to the
    17 touched packages plus their full dependency closure (turbo resolves
    ^build/^typecheck): green — 57/57 build tasks, 67/67 typecheck tasks.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands:
    34 local gate families named for this diff. Ran all 34:
    • 32 green.
    • check:system-context-census: 10 problems from line-number rot (see Step 3
      above) — fixed with the gate's own --fix, verified green after.
    • check:dual-build-cjs-loads and check:i18n-coverage: both exit
      PREREQUISITE-NOT-MET / COULD-NOT-MEASURE — each needs a full-workspace
      pnpm build (dozens of packages, e.g. @objectstack/connector-mcp,
      @objectstack/studio) that this scoped verification didn't run; NOT
      MEASURED locally
      , not a finding. CI's Build Core / Type Check jobs
      build the full workspace and will measure these for real.
    • check-test-completeness.mjs: exits 3 by design without a turbo run test
      log path (CI-only invocation) — NOT MEASURED locally, not a finding.

Scope

Comment-only diff; no code, no eslint.config.mjs, no package.json lint
flag. skip-changeset label applied (no public surface moves).

PR session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

…ources
package.json's lint script runs eslint with --no-inline-config, so every
inline eslint-disable / eslint-disable-next-line / eslint-enable comment
is ignored by the repo's only lint invocation. This deletes the 58 such
comments across 26 non-test source files under packages/** that carry
them at this branch's base (89a156a) -- comment removal only, no code
change. Per-comment measurement against eslint.config.mjs (see PR body)
confirms none of the named rules are configured there either, so the
deletion cannot expose a live finding.
Also re-anchors 5 line-number references in
content/docs/permissions/system-context.mdx that check:system-context-census
pins to exact lines in packages/rest/src/rest-server.ts -- one of this PR's
comment deletions shifted those lines by one, and the gate's own --fix
brought the anchors back in sync (verified green before and after).
Fixes#14529
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 17 package(s): @objectstack/hono, @objectstack/cli, @objectstack/core, @objectstack/driver-sqlite-wasm, @objectstack/metadata-protocol, @objectstack/metadata, @objectstack/objectql, @objectstack/plugin-auth, @objectstack/rest, @objectstack/runtime, @objectstack/sdui-parser, @objectstack/service-automation, @objectstack/service-cluster-redis, @objectstack/service-cluster, @objectstack/service-datasource, @objectstack/types, @objectstack/verify, touching 21 documentable anchor(s). ⚠️7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/environment-routing.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/concepts/metadata-lifecycle.mdx(via SysMetadataRepository (symbol, a top-level class))
  • content/docs/data-modeling/drivers.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/deployment/cli.mdx(via loadArtifactBundle (symbol, a top-level function))
  • content/docs/deployment/single-project-mode.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/plugins/index.mdx(via createStandaloneStack (symbol, a top-level function))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via bootStack (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …) — pages documenting those are invisible to this run
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 68 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96packageMentionDocs.

Which tree this was computed on

This run read content/docs from cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c — the merge of head 7b8f2ec797b37c35e61687627f4fcaf284614cc2 into base 2d40f9146800dcf625fc54696f6435e676b1ed96, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c && git checkout cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2d40f9146800dcf625fc54696f6435e676b1ed96 7b8f2ec797b37c35e61687627f4fcaf284614cc2 && git checkout -B drift-repro 2d40f9146800dcf625fc54696f6435e676b1ed96 && git merge --no-ff 7b8f2ec797b37c35e61687627f4fcaf284614cc2
node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 2d40f9146800dcf625fc54696f6435e676b1ed96 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@claude

claudeBot commented Sep 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Re-trigger via update-branch (domain:devx execution seat, session session_01LAwHpn4uVuf4N1geBcD5i3).

PR-side CI on cd73b0c40 is red only on Test Core (1/6) (packages/clipnpm run test exit 1 — check-run annotations carry the exit code, the log download is refused from this container; same shard/package as the #14648 signature, and this diff does not touch packages/cli test code). This head does not contain the merged fix accb9231c7 (PR #14715; verified git merge-base --is-ancestor), so this is the "base lacks a merged fix ⇒ merge main, push a new head" branch, not a re-run: GitHub merges main into the branch (a real merge commit, no rewrite). If Test Core (1/6) reds again on the new head with the same file, it parks under the #14648 post-fix reading like PR #14774; any other red is real. #14529 stays pm:dispatched; flip + arm on green.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 3, 2026 04:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit 8bcc348Sep 3, 2026
36 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14529-delete-inert-eslint-disable branch September 3, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/sskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

134 eslint-disable comments across 45 source files are structurally inert — pnpm lint runs --no-inline-config

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

chore(lint): delete inert eslint-disable family comments in package sources - #14801

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable
Sep 3, 2026
Merged

chore(lint): delete inert eslint-disable family comments in package sources#14801
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable

Conversation

@claude

@claudeclaudeBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes#14529

What

Deletes all eslint-disable / eslint-disable-next-line / eslint-enable family
comments from non-test source files under packages/** (maintainer-ruled A,
ruling comment 5518653161). package.json:32's only lint invocation
(eslint . --no-inline-config) ignores every inline configuration comment, so
these are inert regardless of which rule they name; --no-inline-config stays
unchanged.

Measured at branch base 89a156af8

eslint-disable family comments in packages/** (non-test): 58
files carrying them: 26

(The card's original estimate was 134/45 at ed44512; re-measuring the same
population definition directly against that commit — git grep over
packages/**, excluding dist/, node_modules/, *.test.*, test/,
tests/, __tests__/ — also returns 58/26, not 134/45, so the discrepancy
predates this branch and isn't drift from commits landing between ed44512
and 89a156af8. Reported as measured, not reconciled against the original
count.)

Step 1 — per-comment measurement against eslint.config.mjs

Every rule named by the 58 comments, checked for a rules: entry in
eslint.config.mjs:

Rule namedOccurrencesConfigured in eslint.config.mjs?
@typescript-eslint/no-explicit-any29No
no-console20No
eqeqeq3No
@typescript-eslint/no-unused-vars3No
no-constant-condition2No
no-new1No
no-control-regex1No
@typescript-eslint/ban-ts-comment1No
@typescript-eslint/no-implied-eval, no-new-func1 (2 rules)No
bare /* eslint-disable */ (no rule named)1N/A

Zero of the named rules are configured. So the deletion is doubly safe:
inert under --no-inline-config, and would still be inert without that flag
(matching the card's own example — no-console was never configured either).
No configured-rule row exists, so no follow-up card is filed for an exposed
finding.

Step 2 — delete

58 lines deleted across 26 files, all whole-line comments (none were trailing
comments on a code line, verified before deleting) — pure comment removal, git diff --stat shows only deletions in the 26 source files.

Step 3 — collateral: one line-anchored ledger needed re-syncing

check:system-context-census pins exact line numbers in
content/docs/permissions/system-context.mdx to elevation-read sites in
packages/rest/src/rest-server.ts. Deleting the one eslint-disable-next-line
comment in that file (originally line 4331) shifted 5 downstream anchors by
one line, which the gate correctly flagged as line rot
(site-without-a-row / anchor-is-not-a-read-site, 10 problems). This is the
gate's own maintained repair path, not a new finding: node scripts/check-system-context-census.mjs --fix re-anchored the 5 references
(4716→4715, 6079→6078, 6327→6326, 6758→6757, 6951→6950) with no
content change beyond the line numbers, and the gate is green before and after
on the re-synced tree. One line changed in content/docs/permissions/system-context.mdx
(not content/docs/releases/**).

pnpm lint is green both before and after this diff (same result — the flag
makes the comments' removal a no-op for lint's own verdict, confirming the
premise).

Tests

  • pnpm lint (via scripts/pm/os-verify-lock.sh): green, before deletion and
    after, both on the pre-merge tree and again on the merged head aca7d5cd4d.
  • pnpm exec turbo run build + pnpm exec turbo run typecheck, scoped to the
    17 touched packages plus their full dependency closure (turbo resolves
    ^build/^typecheck): green — 57/57 build tasks, 67/67 typecheck tasks.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands:
    34 local gate families named for this diff. Ran all 34:
    • 32 green.
    • check:system-context-census: 10 problems from line-number rot (see Step 3
      above) — fixed with the gate's own --fix, verified green after.
    • check:dual-build-cjs-loads and check:i18n-coverage: both exit
      PREREQUISITE-NOT-MET / COULD-NOT-MEASURE — each needs a full-workspace
      pnpm build (dozens of packages, e.g. @objectstack/connector-mcp,
      @objectstack/studio) that this scoped verification didn't run; NOT
      MEASURED locally
      , not a finding. CI's Build Core / Type Check jobs
      build the full workspace and will measure these for real.
    • check-test-completeness.mjs: exits 3 by design without a turbo run test
      log path (CI-only invocation) — NOT MEASURED locally, not a finding.

Scope

Comment-only diff; no code, no eslint.config.mjs, no package.json lint
flag. skip-changeset label applied (no public surface moves).

PR session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

…ources
package.json's lint script runs eslint with --no-inline-config, so every
inline eslint-disable / eslint-disable-next-line / eslint-enable comment
is ignored by the repo's only lint invocation. This deletes the 58 such
comments across 26 non-test source files under packages/** that carry
them at this branch's base (89a156a) -- comment removal only, no code
change. Per-comment measurement against eslint.config.mjs (see PR body)
confirms none of the named rules are configured there either, so the
deletion cannot expose a live finding.
Also re-anchors 5 line-number references in
content/docs/permissions/system-context.mdx that check:system-context-census
pins to exact lines in packages/rest/src/rest-server.ts -- one of this PR's
comment deletions shifted those lines by one, and the gate's own --fix
brought the anchors back in sync (verified green before and after).
Fixes#14529
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 17 package(s): @objectstack/hono, @objectstack/cli, @objectstack/core, @objectstack/driver-sqlite-wasm, @objectstack/metadata-protocol, @objectstack/metadata, @objectstack/objectql, @objectstack/plugin-auth, @objectstack/rest, @objectstack/runtime, @objectstack/sdui-parser, @objectstack/service-automation, @objectstack/service-cluster-redis, @objectstack/service-cluster, @objectstack/service-datasource, @objectstack/types, @objectstack/verify, touching 21 documentable anchor(s). ⚠️7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/environment-routing.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/concepts/metadata-lifecycle.mdx(via SysMetadataRepository (symbol, a top-level class))
  • content/docs/data-modeling/drivers.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/deployment/cli.mdx(via loadArtifactBundle (symbol, a top-level function))
  • content/docs/deployment/single-project-mode.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/plugins/index.mdx(via createStandaloneStack (symbol, a top-level function))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via bootStack (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …) — pages documenting those are invisible to this run
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 68 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96packageMentionDocs.

Which tree this was computed on

This run read content/docs from cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c — the merge of head 7b8f2ec797b37c35e61687627f4fcaf284614cc2 into base 2d40f9146800dcf625fc54696f6435e676b1ed96, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c && git checkout cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2d40f9146800dcf625fc54696f6435e676b1ed96 7b8f2ec797b37c35e61687627f4fcaf284614cc2 && git checkout -B drift-repro 2d40f9146800dcf625fc54696f6435e676b1ed96 && git merge --no-ff 7b8f2ec797b37c35e61687627f4fcaf284614cc2
node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 2d40f9146800dcf625fc54696f6435e676b1ed96 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@claude

claudeBot commented Sep 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Re-trigger via update-branch (domain:devx execution seat, session session_01LAwHpn4uVuf4N1geBcD5i3).

PR-side CI on cd73b0c40 is red only on Test Core (1/6) (packages/clipnpm run test exit 1 — check-run annotations carry the exit code, the log download is refused from this container; same shard/package as the #14648 signature, and this diff does not touch packages/cli test code). This head does not contain the merged fix accb9231c7 (PR #14715; verified git merge-base --is-ancestor), so this is the "base lacks a merged fix ⇒ merge main, push a new head" branch, not a re-run: GitHub merges main into the branch (a real merge commit, no rewrite). If Test Core (1/6) reds again on the new head with the same file, it parks under the #14648 post-fix reading like PR #14774; any other red is real. #14529 stays pm:dispatched; flip + arm on green.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 3, 2026 04:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit 8bcc348Sep 3, 2026
36 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14529-delete-inert-eslint-disable branch September 3, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/sskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

134 eslint-disable comments across 45 source files are structurally inert — pnpm lint runs --no-inline-config

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(lint): delete inert eslint-disable family comments in package sources - #14801

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable
Sep 3, 2026
Merged

chore(lint): delete inert eslint-disable family comments in package sources#14801
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable

Conversation

@claude

@claudeclaudeBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes#14529

What

Deletes all eslint-disable / eslint-disable-next-line / eslint-enable family
comments from non-test source files under packages/** (maintainer-ruled A,
ruling comment 5518653161). package.json:32's only lint invocation
(eslint . --no-inline-config) ignores every inline configuration comment, so
these are inert regardless of which rule they name; --no-inline-config stays
unchanged.

Measured at branch base 89a156af8

eslint-disable family comments in packages/** (non-test): 58
files carrying them: 26

(The card's original estimate was 134/45 at ed44512; re-measuring the same
population definition directly against that commit — git grep over
packages/**, excluding dist/, node_modules/, *.test.*, test/,
tests/, __tests__/ — also returns 58/26, not 134/45, so the discrepancy
predates this branch and isn't drift from commits landing between ed44512
and 89a156af8. Reported as measured, not reconciled against the original
count.)

Step 1 — per-comment measurement against eslint.config.mjs

Every rule named by the 58 comments, checked for a rules: entry in
eslint.config.mjs:

Rule namedOccurrencesConfigured in eslint.config.mjs?
@typescript-eslint/no-explicit-any29No
no-console20No
eqeqeq3No
@typescript-eslint/no-unused-vars3No
no-constant-condition2No
no-new1No
no-control-regex1No
@typescript-eslint/ban-ts-comment1No
@typescript-eslint/no-implied-eval, no-new-func1 (2 rules)No
bare /* eslint-disable */ (no rule named)1N/A

Zero of the named rules are configured. So the deletion is doubly safe:
inert under --no-inline-config, and would still be inert without that flag
(matching the card's own example — no-console was never configured either).
No configured-rule row exists, so no follow-up card is filed for an exposed
finding.

Step 2 — delete

58 lines deleted across 26 files, all whole-line comments (none were trailing
comments on a code line, verified before deleting) — pure comment removal, git diff --stat shows only deletions in the 26 source files.

Step 3 — collateral: one line-anchored ledger needed re-syncing

check:system-context-census pins exact line numbers in
content/docs/permissions/system-context.mdx to elevation-read sites in
packages/rest/src/rest-server.ts. Deleting the one eslint-disable-next-line
comment in that file (originally line 4331) shifted 5 downstream anchors by
one line, which the gate correctly flagged as line rot
(site-without-a-row / anchor-is-not-a-read-site, 10 problems). This is the
gate's own maintained repair path, not a new finding: node scripts/check-system-context-census.mjs --fix re-anchored the 5 references
(4716→4715, 6079→6078, 6327→6326, 6758→6757, 6951→6950) with no
content change beyond the line numbers, and the gate is green before and after
on the re-synced tree. One line changed in content/docs/permissions/system-context.mdx
(not content/docs/releases/**).

pnpm lint is green both before and after this diff (same result — the flag
makes the comments' removal a no-op for lint's own verdict, confirming the
premise).

Tests

  • pnpm lint (via scripts/pm/os-verify-lock.sh): green, before deletion and
    after, both on the pre-merge tree and again on the merged head aca7d5cd4d.
  • pnpm exec turbo run build + pnpm exec turbo run typecheck, scoped to the
    17 touched packages plus their full dependency closure (turbo resolves
    ^build/^typecheck): green — 57/57 build tasks, 67/67 typecheck tasks.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands:
    34 local gate families named for this diff. Ran all 34:
    • 32 green.
    • check:system-context-census: 10 problems from line-number rot (see Step 3
      above) — fixed with the gate's own --fix, verified green after.
    • check:dual-build-cjs-loads and check:i18n-coverage: both exit
      PREREQUISITE-NOT-MET / COULD-NOT-MEASURE — each needs a full-workspace
      pnpm build (dozens of packages, e.g. @objectstack/connector-mcp,
      @objectstack/studio) that this scoped verification didn't run; NOT
      MEASURED locally
      , not a finding. CI's Build Core / Type Check jobs
      build the full workspace and will measure these for real.
    • check-test-completeness.mjs: exits 3 by design without a turbo run test
      log path (CI-only invocation) — NOT MEASURED locally, not a finding.

Scope

Comment-only diff; no code, no eslint.config.mjs, no package.json lint
flag. skip-changeset label applied (no public surface moves).

PR session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

…ources
package.json's lint script runs eslint with --no-inline-config, so every
inline eslint-disable / eslint-disable-next-line / eslint-enable comment
is ignored by the repo's only lint invocation. This deletes the 58 such
comments across 26 non-test source files under packages/** that carry
them at this branch's base (89a156a) -- comment removal only, no code
change. Per-comment measurement against eslint.config.mjs (see PR body)
confirms none of the named rules are configured there either, so the
deletion cannot expose a live finding.
Also re-anchors 5 line-number references in
content/docs/permissions/system-context.mdx that check:system-context-census
pins to exact lines in packages/rest/src/rest-server.ts -- one of this PR's
comment deletions shifted those lines by one, and the gate's own --fix
brought the anchors back in sync (verified green before and after).
Fixes#14529
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 17 package(s): @objectstack/hono, @objectstack/cli, @objectstack/core, @objectstack/driver-sqlite-wasm, @objectstack/metadata-protocol, @objectstack/metadata, @objectstack/objectql, @objectstack/plugin-auth, @objectstack/rest, @objectstack/runtime, @objectstack/sdui-parser, @objectstack/service-automation, @objectstack/service-cluster-redis, @objectstack/service-cluster, @objectstack/service-datasource, @objectstack/types, @objectstack/verify, touching 21 documentable anchor(s). ⚠️7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/environment-routing.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/concepts/metadata-lifecycle.mdx(via SysMetadataRepository (symbol, a top-level class))
  • content/docs/data-modeling/drivers.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/deployment/cli.mdx(via loadArtifactBundle (symbol, a top-level function))
  • content/docs/deployment/single-project-mode.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/plugins/index.mdx(via createStandaloneStack (symbol, a top-level function))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via bootStack (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …) — pages documenting those are invisible to this run
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 68 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96packageMentionDocs.

Which tree this was computed on

This run read content/docs from cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c — the merge of head 7b8f2ec797b37c35e61687627f4fcaf284614cc2 into base 2d40f9146800dcf625fc54696f6435e676b1ed96, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c && git checkout cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2d40f9146800dcf625fc54696f6435e676b1ed96 7b8f2ec797b37c35e61687627f4fcaf284614cc2 && git checkout -B drift-repro 2d40f9146800dcf625fc54696f6435e676b1ed96 && git merge --no-ff 7b8f2ec797b37c35e61687627f4fcaf284614cc2
node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 2d40f9146800dcf625fc54696f6435e676b1ed96 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@claude

claudeBot commented Sep 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Re-trigger via update-branch (domain:devx execution seat, session session_01LAwHpn4uVuf4N1geBcD5i3).

PR-side CI on cd73b0c40 is red only on Test Core (1/6) (packages/clipnpm run test exit 1 — check-run annotations carry the exit code, the log download is refused from this container; same shard/package as the #14648 signature, and this diff does not touch packages/cli test code). This head does not contain the merged fix accb9231c7 (PR #14715; verified git merge-base --is-ancestor), so this is the "base lacks a merged fix ⇒ merge main, push a new head" branch, not a re-run: GitHub merges main into the branch (a real merge commit, no rewrite). If Test Core (1/6) reds again on the new head with the same file, it parks under the #14648 post-fix reading like PR #14774; any other red is real. #14529 stays pm:dispatched; flip + arm on green.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 3, 2026 04:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit 8bcc348Sep 3, 2026
36 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14529-delete-inert-eslint-disable branch September 3, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/sskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

134 eslint-disable comments across 45 source files are structurally inert — pnpm lint runs --no-inline-config

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(lint): delete inert eslint-disable family comments in package sources - #14801

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable
Sep 3, 2026
Merged

chore(lint): delete inert eslint-disable family comments in package sources#14801
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable

Conversation

@claude

@claudeclaudeBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes#14529

What

Deletes all eslint-disable / eslint-disable-next-line / eslint-enable family
comments from non-test source files under packages/** (maintainer-ruled A,
ruling comment 5518653161). package.json:32's only lint invocation
(eslint . --no-inline-config) ignores every inline configuration comment, so
these are inert regardless of which rule they name; --no-inline-config stays
unchanged.

Measured at branch base 89a156af8

eslint-disable family comments in packages/** (non-test): 58
files carrying them: 26

(The card's original estimate was 134/45 at ed44512; re-measuring the same
population definition directly against that commit — git grep over
packages/**, excluding dist/, node_modules/, *.test.*, test/,
tests/, __tests__/ — also returns 58/26, not 134/45, so the discrepancy
predates this branch and isn't drift from commits landing between ed44512
and 89a156af8. Reported as measured, not reconciled against the original
count.)

Step 1 — per-comment measurement against eslint.config.mjs

Every rule named by the 58 comments, checked for a rules: entry in
eslint.config.mjs:

Rule namedOccurrencesConfigured in eslint.config.mjs?
@typescript-eslint/no-explicit-any29No
no-console20No
eqeqeq3No
@typescript-eslint/no-unused-vars3No
no-constant-condition2No
no-new1No
no-control-regex1No
@typescript-eslint/ban-ts-comment1No
@typescript-eslint/no-implied-eval, no-new-func1 (2 rules)No
bare /* eslint-disable */ (no rule named)1N/A

Zero of the named rules are configured. So the deletion is doubly safe:
inert under --no-inline-config, and would still be inert without that flag
(matching the card's own example — no-console was never configured either).
No configured-rule row exists, so no follow-up card is filed for an exposed
finding.

Step 2 — delete

58 lines deleted across 26 files, all whole-line comments (none were trailing
comments on a code line, verified before deleting) — pure comment removal, git diff --stat shows only deletions in the 26 source files.

Step 3 — collateral: one line-anchored ledger needed re-syncing

check:system-context-census pins exact line numbers in
content/docs/permissions/system-context.mdx to elevation-read sites in
packages/rest/src/rest-server.ts. Deleting the one eslint-disable-next-line
comment in that file (originally line 4331) shifted 5 downstream anchors by
one line, which the gate correctly flagged as line rot
(site-without-a-row / anchor-is-not-a-read-site, 10 problems). This is the
gate's own maintained repair path, not a new finding: node scripts/check-system-context-census.mjs --fix re-anchored the 5 references
(4716→4715, 6079→6078, 6327→6326, 6758→6757, 6951→6950) with no
content change beyond the line numbers, and the gate is green before and after
on the re-synced tree. One line changed in content/docs/permissions/system-context.mdx
(not content/docs/releases/**).

pnpm lint is green both before and after this diff (same result — the flag
makes the comments' removal a no-op for lint's own verdict, confirming the
premise).

Tests

  • pnpm lint (via scripts/pm/os-verify-lock.sh): green, before deletion and
    after, both on the pre-merge tree and again on the merged head aca7d5cd4d.
  • pnpm exec turbo run build + pnpm exec turbo run typecheck, scoped to the
    17 touched packages plus their full dependency closure (turbo resolves
    ^build/^typecheck): green — 57/57 build tasks, 67/67 typecheck tasks.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands:
    34 local gate families named for this diff. Ran all 34:
    • 32 green.
    • check:system-context-census: 10 problems from line-number rot (see Step 3
      above) — fixed with the gate's own --fix, verified green after.
    • check:dual-build-cjs-loads and check:i18n-coverage: both exit
      PREREQUISITE-NOT-MET / COULD-NOT-MEASURE — each needs a full-workspace
      pnpm build (dozens of packages, e.g. @objectstack/connector-mcp,
      @objectstack/studio) that this scoped verification didn't run; NOT
      MEASURED locally
      , not a finding. CI's Build Core / Type Check jobs
      build the full workspace and will measure these for real.
    • check-test-completeness.mjs: exits 3 by design without a turbo run test
      log path (CI-only invocation) — NOT MEASURED locally, not a finding.

Scope

Comment-only diff; no code, no eslint.config.mjs, no package.json lint
flag. skip-changeset label applied (no public surface moves).

PR session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

…ources
package.json's lint script runs eslint with --no-inline-config, so every
inline eslint-disable / eslint-disable-next-line / eslint-enable comment
is ignored by the repo's only lint invocation. This deletes the 58 such
comments across 26 non-test source files under packages/** that carry
them at this branch's base (89a156a) -- comment removal only, no code
change. Per-comment measurement against eslint.config.mjs (see PR body)
confirms none of the named rules are configured there either, so the
deletion cannot expose a live finding.
Also re-anchors 5 line-number references in
content/docs/permissions/system-context.mdx that check:system-context-census
pins to exact lines in packages/rest/src/rest-server.ts -- one of this PR's
comment deletions shifted those lines by one, and the gate's own --fix
brought the anchors back in sync (verified green before and after).
Fixes#14529
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 17 package(s): @objectstack/hono, @objectstack/cli, @objectstack/core, @objectstack/driver-sqlite-wasm, @objectstack/metadata-protocol, @objectstack/metadata, @objectstack/objectql, @objectstack/plugin-auth, @objectstack/rest, @objectstack/runtime, @objectstack/sdui-parser, @objectstack/service-automation, @objectstack/service-cluster-redis, @objectstack/service-cluster, @objectstack/service-datasource, @objectstack/types, @objectstack/verify, touching 21 documentable anchor(s). ⚠️7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/environment-routing.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/concepts/metadata-lifecycle.mdx(via SysMetadataRepository (symbol, a top-level class))
  • content/docs/data-modeling/drivers.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/deployment/cli.mdx(via loadArtifactBundle (symbol, a top-level function))
  • content/docs/deployment/single-project-mode.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/plugins/index.mdx(via createStandaloneStack (symbol, a top-level function))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via bootStack (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …) — pages documenting those are invisible to this run
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 68 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96packageMentionDocs.

Which tree this was computed on

This run read content/docs from cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c — the merge of head 7b8f2ec797b37c35e61687627f4fcaf284614cc2 into base 2d40f9146800dcf625fc54696f6435e676b1ed96, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c && git checkout cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2d40f9146800dcf625fc54696f6435e676b1ed96 7b8f2ec797b37c35e61687627f4fcaf284614cc2 && git checkout -B drift-repro 2d40f9146800dcf625fc54696f6435e676b1ed96 && git merge --no-ff 7b8f2ec797b37c35e61687627f4fcaf284614cc2
node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 2d40f9146800dcf625fc54696f6435e676b1ed96 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@claude

claudeBot commented Sep 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Re-trigger via update-branch (domain:devx execution seat, session session_01LAwHpn4uVuf4N1geBcD5i3).

PR-side CI on cd73b0c40 is red only on Test Core (1/6) (packages/clipnpm run test exit 1 — check-run annotations carry the exit code, the log download is refused from this container; same shard/package as the #14648 signature, and this diff does not touch packages/cli test code). This head does not contain the merged fix accb9231c7 (PR #14715; verified git merge-base --is-ancestor), so this is the "base lacks a merged fix ⇒ merge main, push a new head" branch, not a re-run: GitHub merges main into the branch (a real merge commit, no rewrite). If Test Core (1/6) reds again on the new head with the same file, it parks under the #14648 post-fix reading like PR #14774; any other red is real. #14529 stays pm:dispatched; flip + arm on green.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 3, 2026 04:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit 8bcc348Sep 3, 2026
36 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14529-delete-inert-eslint-disable branch September 3, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/sskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

134 eslint-disable comments across 45 source files are structurally inert — pnpm lint runs --no-inline-config

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

chore(lint): delete inert eslint-disable family comments in package sources - #14801

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable
Sep 3, 2026
Merged

chore(lint): delete inert eslint-disable family comments in package sources#14801
baozhoutao merged 4 commits into
mainfrom
claude/issue-14529-delete-inert-eslint-disable

Conversation

@claude

@claudeclaudeBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes#14529

What

Deletes all eslint-disable / eslint-disable-next-line / eslint-enable family
comments from non-test source files under packages/** (maintainer-ruled A,
ruling comment 5518653161). package.json:32's only lint invocation
(eslint . --no-inline-config) ignores every inline configuration comment, so
these are inert regardless of which rule they name; --no-inline-config stays
unchanged.

Measured at branch base 89a156af8

eslint-disable family comments in packages/** (non-test): 58
files carrying them: 26

(The card's original estimate was 134/45 at ed44512; re-measuring the same
population definition directly against that commit — git grep over
packages/**, excluding dist/, node_modules/, *.test.*, test/,
tests/, __tests__/ — also returns 58/26, not 134/45, so the discrepancy
predates this branch and isn't drift from commits landing between ed44512
and 89a156af8. Reported as measured, not reconciled against the original
count.)

Step 1 — per-comment measurement against eslint.config.mjs

Every rule named by the 58 comments, checked for a rules: entry in
eslint.config.mjs:

Rule namedOccurrencesConfigured in eslint.config.mjs?
@typescript-eslint/no-explicit-any29No
no-console20No
eqeqeq3No
@typescript-eslint/no-unused-vars3No
no-constant-condition2No
no-new1No
no-control-regex1No
@typescript-eslint/ban-ts-comment1No
@typescript-eslint/no-implied-eval, no-new-func1 (2 rules)No
bare /* eslint-disable */ (no rule named)1N/A

Zero of the named rules are configured. So the deletion is doubly safe:
inert under --no-inline-config, and would still be inert without that flag
(matching the card's own example — no-console was never configured either).
No configured-rule row exists, so no follow-up card is filed for an exposed
finding.

Step 2 — delete

58 lines deleted across 26 files, all whole-line comments (none were trailing
comments on a code line, verified before deleting) — pure comment removal, git diff --stat shows only deletions in the 26 source files.

Step 3 — collateral: one line-anchored ledger needed re-syncing

check:system-context-census pins exact line numbers in
content/docs/permissions/system-context.mdx to elevation-read sites in
packages/rest/src/rest-server.ts. Deleting the one eslint-disable-next-line
comment in that file (originally line 4331) shifted 5 downstream anchors by
one line, which the gate correctly flagged as line rot
(site-without-a-row / anchor-is-not-a-read-site, 10 problems). This is the
gate's own maintained repair path, not a new finding: node scripts/check-system-context-census.mjs --fix re-anchored the 5 references
(4716→4715, 6079→6078, 6327→6326, 6758→6757, 6951→6950) with no
content change beyond the line numbers, and the gate is green before and after
on the re-synced tree. One line changed in content/docs/permissions/system-context.mdx
(not content/docs/releases/**).

pnpm lint is green both before and after this diff (same result — the flag
makes the comments' removal a no-op for lint's own verdict, confirming the
premise).

Tests

  • pnpm lint (via scripts/pm/os-verify-lock.sh): green, before deletion and
    after, both on the pre-merge tree and again on the merged head aca7d5cd4d.
  • pnpm exec turbo run build + pnpm exec turbo run typecheck, scoped to the
    17 touched packages plus their full dependency closure (turbo resolves
    ^build/^typecheck): green — 57/57 build tasks, 67/67 typecheck tasks.
  • node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands:
    34 local gate families named for this diff. Ran all 34:
    • 32 green.
    • check:system-context-census: 10 problems from line-number rot (see Step 3
      above) — fixed with the gate's own --fix, verified green after.
    • check:dual-build-cjs-loads and check:i18n-coverage: both exit
      PREREQUISITE-NOT-MET / COULD-NOT-MEASURE — each needs a full-workspace
      pnpm build (dozens of packages, e.g. @objectstack/connector-mcp,
      @objectstack/studio) that this scoped verification didn't run; NOT
      MEASURED locally
      , not a finding. CI's Build Core / Type Check jobs
      build the full workspace and will measure these for real.
    • check-test-completeness.mjs: exits 3 by design without a turbo run test
      log path (CI-only invocation) — NOT MEASURED locally, not a finding.

Scope

Comment-only diff; no code, no eslint.config.mjs, no package.json lint
flag. skip-changeset label applied (no public surface moves).

PR session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

…ources
package.json's lint script runs eslint with --no-inline-config, so every
inline eslint-disable / eslint-disable-next-line / eslint-enable comment
is ignored by the repo's only lint invocation. This deletes the 58 such
comments across 26 non-test source files under packages/** that carry
them at this branch's base (89a156a) -- comment removal only, no code
change. Per-comment measurement against eslint.config.mjs (see PR body)
confirms none of the named rules are configured there either, so the
deletion cannot expose a live finding.
Also re-anchors 5 line-number references in
content/docs/permissions/system-context.mdx that check:system-context-census
pins to exact lines in packages/rest/src/rest-server.ts -- one of this PR's
comment deletions shifted those lines by one, and the gate's own --fix
brought the anchors back in sync (verified green before and after).
Fixes#14529
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 17 package(s): @objectstack/hono, @objectstack/cli, @objectstack/core, @objectstack/driver-sqlite-wasm, @objectstack/metadata-protocol, @objectstack/metadata, @objectstack/objectql, @objectstack/plugin-auth, @objectstack/rest, @objectstack/runtime, @objectstack/sdui-parser, @objectstack/service-automation, @objectstack/service-cluster-redis, @objectstack/service-cluster, @objectstack/service-datasource, @objectstack/types, @objectstack/verify, touching 21 documentable anchor(s). ⚠️7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/environment-routing.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/concepts/metadata-lifecycle.mdx(via SysMetadataRepository (symbol, a top-level class))
  • content/docs/data-modeling/drivers.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/deployment/cli.mdx(via loadArtifactBundle (symbol, a top-level function))
  • content/docs/deployment/single-project-mode.mdx(via createStandaloneStack (symbol, a top-level function))
  • content/docs/plugins/index.mdx(via createStandaloneStack (symbol, a top-level function))

1 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17.mdx(via bootStack (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 7 changed file(s) yielded no anchor (packages/adapters/hono/src/index.ts, packages/rest/src/rest-server.ts, packages/sdui-parser/src/codegen.ts, …) — pages documenting those are invisible to this run
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 68 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96packageMentionDocs.

Which tree this was computed on

This run read content/docs from cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c — the merge of head 7b8f2ec797b37c35e61687627f4fcaf284614cc2 into base 2d40f9146800dcf625fc54696f6435e676b1ed96, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c && git checkout cc3ab750ef7b8dc8fa41d68f6e8429a61a5bb84c
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 2d40f9146800dcf625fc54696f6435e676b1ed96 7b8f2ec797b37c35e61687627f4fcaf284614cc2 && git checkout -B drift-repro 2d40f9146800dcf625fc54696f6435e676b1ed96 && git merge --no-ff 7b8f2ec797b37c35e61687627f4fcaf284614cc2
node scripts/docs-audit/affected-docs.mjs --json 2d40f9146800dcf625fc54696f6435e676b1ed96

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 2d40f9146800dcf625fc54696f6435e676b1ed96 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@claude

claudeBot commented Sep 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Re-trigger via update-branch (domain:devx execution seat, session session_01LAwHpn4uVuf4N1geBcD5i3).

PR-side CI on cd73b0c40 is red only on Test Core (1/6) (packages/clipnpm run test exit 1 — check-run annotations carry the exit code, the log download is refused from this container; same shard/package as the #14648 signature, and this diff does not touch packages/cli test code). This head does not contain the merged fix accb9231c7 (PR #14715; verified git merge-base --is-ancestor), so this is the "base lacks a merged fix ⇒ merge main, push a new head" branch, not a re-run: GitHub merges main into the branch (a real merge commit, no rewrite). If Test Core (1/6) reds again on the new head with the same file, it parks under the #14648 post-fix reading like PR #14774; any other red is real. #14529 stays pm:dispatched; flip + arm on green.


Generated by Claude Code

@baozhoutao
baozhoutao marked this pull request as ready for review September 3, 2026 04:56
@baozhoutao
baozhoutao added this pull request to the merge queueSep 3, 2026
Merged via the queue into main with commit 8bcc348Sep 3, 2026
36 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14529-delete-inert-eslint-disable branch September 3, 2026 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/sskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

134 eslint-disable comments across 45 source files are structurally inert — pnpm lint runs --no-inline-config

2 participants

@baozhoutao@claude