Uh oh!
There was an error while loading. Please reload this page.
chore(spec): prune 15 dead field display-config props (dead-surface plan, P2) - #1945
Merged
Conversation
…lan, P2) Removes FieldSchema enhanced-type *display* knobs that had no runtime reader and no renderer consumer — dead in both layers per the field liveness audit, and confirmed by greps (no object def / seed constructs them) + the full spec suite (6562 tests) staying green: code theme/lineNumbers · rating allowHalf · location displayMap/allowGeocoding · address addressFormat · color colorFormat/allowAlpha/presetColors · slider showValue/marks · barcode/qr barcodeFormat/qrErrorCorrection/displayValue/allowScanning Kept: the wired knobs (language, maxRating, step) and the functional nested configs (currencyConfig/vectorConfig/fileAttachmentConfig — they carry data the field type needs, e.g. vector dimensions; the audit's "flat sibling" claim lives in the objectui repo and can't be verified here, so they're left for that repo). Field *types* are unchanged; only unused optional config props are removed. field.zod.ts schema + field.test.ts (assertions/configs) + field.json ledger updated; reference docs regenerated; liveness gate green (field 34 live/24 dead). First executed batch of the dead-surface disposition plan. Pruning is a coupled refactor (schema → Field factory → tests → forms → translations), so it proceeds as small per-cluster verified PRs, not one sweep — see the plan doc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 89 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 16, 2026
os-zhuang added a commit
that referenced
this pull request
Jun 16, 2026
…tui-live (#1947) The liveness ledgers were seeded from the 2026-06 audits, whose RENDERER-side ("dead in both layers") verdicts turn out to be unreliable — the audit did not re-check the objectui repo (../objectui). Verifying directly against objectui shows 9 field props the ledger called `dead` are actually LIVE in the renderer: - externalId → apps/console/.../metadataConverters.ts:125 (reads field.externalId) - currencyConfig → packages/fields/src/index.tsx:469 (reads currencyConfig.defaultCurrency) - searchable → packages/plugin-dashboard/.../WidgetConfigPanel.tsx - inlineTitle / inlineColumns / inlineAmountField → app-shell MetadataProvider + plugin-form/deriveMasterDetail.ts - relatedList / relatedListTitle / relatedListColumns → app-shell RecordDetailView + utils/deriveRelatedLists.ts Pruning these (as the dead-surface plan proposed) would have broken detail-page / master-detail rendering. Reclassified dead→live with objectui evidence; gate green (field 43 live / 8 dead). IMPORTANT: liveness verification must include ../objectui, not just the framework runtime. The already-merged prune batches (#1945 display configs, #1946 governance) were re-verified against objectui and confirmed renderer-dead — safe. Further pruning is paused until the other ledgers + the disposition plan are re-verified against objectui. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First executed batch of the dead-surface disposition plan. Removes 15 FieldSchema enhanced-type display knobs with no runtime reader and no renderer consumer (dead in both layers per the field liveness audit): code theme/lineNumbers, rating allowHalf, location displayMap/allowGeocoding, address addressFormat, color colorFormat/allowAlpha/presetColors, slider showValue/marks, barcode/qr barcodeFormat/qrErrorCorrection/displayValue/allowScanning. Kept the wired knobs (language, maxRating, step) + functional nested configs (currencyConfig/vectorConfig/fileAttachmentConfig). Field types unchanged.
Verification: full @objectstack/spec suite green (242 files, 6562 tests); grep-confirmed no object/seed usage; ran the real app (objectstack dev showcase, 37 plugins) — boots clean, Console 200, 75 objects load, showcase_field_zoo exercises all 9 affected field types and parses+serves correctly (code field has language, no theme), no field errors in server log. Liveness gate green. (Headed-SPA screenshot not captured — no controllable Chrome in this env; pruned props have no renderer consumer.)
Note: confirmed pruning is a coupled refactor (schema → Field factory → tests → forms → translations; object props also hit NoExcessObjectKeys TS-strict defs) — remaining prunes proceed as small per-cluster verified PRs.
🤖 Generated with Claude Code