Uh oh!
There was an error while loading. Please reload this page.
fix(spec): cross-repo liveness re-audit — 16 props dead→live (objectui authoring UI) - #1956
Merged
Merged
Conversation
…ui authoring UI) Cross-repo re-audit (reading the actual consumer code in framework AND objectui) corrects 16 props the audit wrongly marked dead — they are LIVE via objectui's metadata-admin authoring UI (which the 2026-06 audit never checked): - agent.knowledge objectui AgentPreview.tsx:69 - role.parent objectui RolePreview.tsx:30 - permission.isProfile objectui PermissionPreview.tsx:92 - flow.status, flow.active objectui FlowPreview.tsx:105 - flow.nodes.boundaryConfig objectui inspectors/flow-node-config.ts:480 - tool.category/requiresConfirmation/active/builtIn objectui ToolPreview.tsx:99-103 - skill.triggerPhrases/permissions objectui SkillPreview.tsx:44,48 - action.execute/shortcut/bulkEnabled/disabled objectui ActionPreview.tsx:154-169 Each verified by opening the file and seeing the read (not a name match). The remaining ~42 dead props are confirmed dead in BOTH repos (real prune candidates; object-level dominates). Gate green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… cross-repo correction Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 89 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the liveness ledgers + the dead-surface plan after finding the 2026-06 audits missed objectui's metadata-admin authoring UI (they only checked framework runtime + end-user renderers).
What
A cross-repo re-audit — reading the actual consumer code in both
frameworkand../objectui(not grep-guessing) — found 16 props the ledgers calleddeadare actually objectui-live, reclassified dead→live with verified evidence:ToolPreview.tsx:99-103ActionPreview.tsx:154-169SkillPreview.tsx:44,48FlowPreview.tsx:105,flow-node-config.ts:480AgentPreview.tsx:69RolePreview.tsx:30PermissionPreview.tsx:92(Plus the 9 field props already fixed in #1947.) Each verified by opening the file and seeing the read.
Why it matters
Pruning these would have broken the authoring UI / detail rendering. The dead-surface plan (#1939) recommended pruning several — it's now flagged invalidated at the top; only ~42 props are confirmed dead in BOTH repos (the real prune candidates, dominated by 24 object-level props with
NoExcessObjectKeyscross-package coupling).Method note
The first attempt used a multi-agent workflow that went runaway (~633 agents vs 10 launched) — stopped and discarded. Automated grep proved unreliable here (false +/−). So this was done by directly reading the per-type metadata-admin preview/inspector files. The monthly re-audit cron was already updated to include
../objectui.Gate green. Builds on #1947 (field). The merged prunes #1945/#1946 were re-verified against objectui — safe.
🤖 Generated with Claude Code