Uh oh!
There was an error while loading. Please reload this page.
fix(spec): don't require slots on slotted pages (unblock slotted page creation in Studio) - #2261
Merged
Merged
Conversation
`PageSchema`'s superRefine rejected any `kind: 'slotted'` page without a `slots` map. But a slotted page with no overrides is valid and useful — every slot falls through to the synthesized default layout, the natural starting point before you add overrides. Requiring `slots` up front made the Studio "New Page" form a dead-end the instant you picked "slotted" (the form can't author a slot map), the same trap as the old required `regions`. Removed the superRefine clause; `slots` stays optional. Found by dogfooding the Studio page designer. Verified: slotted-without-slots now parses; 86 page tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 91 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2254, found by continuing to dogfood the Studio page designer.
Problem
After #2254 unblocked creating record/home/app pages, the last remaining create-flow dead-end was the Kind = "slotted" option:
PageSchema's superRefine rejects anykind: 'slotted'page that doesn't provide aslotsmap (slots: "slots is required when kind is 'slotted'"). The "New Page" form can't author a slot map (andcreateSeedseedsregions, notslots), so picking "slotted" instantly blocks save — the same trap as the old requiredregions/properties.Fix
Removed the superRefine clause. A slotted page with no overrides is valid and useful: every slot falls through to the synthesized default layout — the natural starting point before you add slot overrides in the editor.
slotsstays optional.Verification
slotted-without-slotsnow parses.🤖 Generated with Claude Code