Uh oh!
There was an error while loading. Please reload this page.
fix(spec): remove unrendered roadmap page types (enforce-or-remove) + liveness gate - #2265
Merged
Conversation
PageTypeSchema advertised 6 page types with no renderer (dashboard, form,
record_detail, record_review, overview, blank). Authoring one passed validation
then broke at runtime ("Unknown component type") — a false affordance, worse
because templates are AI-authored. Per ADR-0049 the enum is now the live set
(record/home/app/utility/list); removed types live in a new PAGE_TYPE_ROADMAP
export and a gate test stops the enum re-growing them. The record_review/blank
config schemas + fields are kept @deprecated (avoid breaking downstream imports,
coordinated removal to follow); `variables` is marked @experimental.
Found by dogfooding the Studio page designer (blank → "Unknown component type").
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 91 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This was referenced Jun 24, 2026
os-zhuang added a commit
that referenced
this pull request
Jun 24, 2026
…ig removal (#2268) (#2272) #2268 hard-removed 16 dead exports (6 from ./ui Blank/RecordReview, 10 from ./studio PageBuilder/Canvas/Palette) and #2265 added PAGE_TYPE_ROADMAP, but the committed api-surface.json snapshot was never regenerated — so check:api-surface has been red on main for every PR touching packages/spec/** (surfaced on #2269). Regenerate the snapshot to match the built surface. Diff is exactly the 16 intentional removals + PAGE_TYPE_ROADMAP; api-surface-signatures.json unchanged; the frozen downstream-contract gate is unaffected (it never referenced these symbols). Kept at minor (not a major bump) as a deliberate, documented exception to the ADR-0059 §4 freeze contract — see the appended note in the #2268 changeset. The removed symbols are config for renderless page types with no plausible functional consumer; the pre-publish hotcrm live gate guards any real break. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the Studio page-design dogfood (#2254 / #2261). Asked as a low-code architect: are the roadmap page types a protocol error, and should they be deleted? — yes. They're authorizable-but-unrendered, a false affordance that passes validation then breaks at runtime, worse because templates are AI-authored. This applies the codebase's own ADR-0049 enforce-or-remove.
What
PageTypeSchemaadvertised six page types with no renderer —dashboard,form,record_detail,record_review,overview,blank. Verified in-browser: authoringtype: 'blank'renders "Unknown component type: blank"; none have a dedicated renderer (blank'sblankLayoutis destructured to_blankLayoutProp— ignored).record,home,app,utility,list. Authoring a removed type now fails fast at parse (the (1) "guard" the dogfood asked for is achieved by the enum reflecting reality) instead of silently at render (2).PAGE_TYPE_ROADMAPexport tracks the removed types so the intent isn't lost — they re-enter the enum only when a renderer ships.page-type-liveness) asserts the enum never re-grows a roadmap type — the regression backstop (4), in the spirit of the existingliveness/gate (page isn't a governed type yet; full onboarding is a follow-up).recordReview/blankLayoutconfig schemas + fields kept@deprecated(their types are no longer authorizable) to avoid breaking downstream imports —objectuistill importsBlankPageLayoutSchema; hard removal is a coordinated follow-up.variablesdocumented@experimental(3): thePageVariablesProvider+usePageVariableshook exist, but nothing reads/writes them end-to-end yet (noelement:record_pickerwriter, not injected into thevisibleCEL context) — completion tracked separately.Verification
@objectstack/spectypecheck clean.type:'dashboard'hits are nav-item kinds / metadata-type refs, notPageType).Follow-ups (not in this PR)
blank/blankLayoutreferences inspec-bridge+typesso the deprecated schemas can be hard-removed.pageto theliveness/ledger (declare every authorable property + evidence).variables(writer +visible-CEL injection + example/proof) or remove it.🤖 Generated with Claude Code