Uh oh!
There was an error while loading. Please reload this page.
chore(liveness): bring page under the spec liveness gate - #2267
Merged
Conversation
Adds packages/spec/liveness/page.json and registers `page` in the governed-types list (check-liveness.mts). All 17 authorable PageSchema properties are classified with evidence: 14 live (objectui consumers as prose), 1 experimental (variables), 2 dead (recordReview/blankLayout — removed page types, framework#2265 + objectui#1949). Gate passes (exit 0); no new warnings vs baseline. Page tests still 81/81. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 91 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final follow-up to the Studio page-design dogfood. Brings the
pagemetadata type under the codebase's own spec liveness gate (ADR-0049 / #1919) — the "declare every authorable property's status with evidence, or CI fails" ratchet.pagewas not yet a governed type.What
packages/spec/liveness/page.json— all 17 top-level PageSchema properties classified (containers declared at one drill level, matchingaction.json):live— objectui renderer consumers cited as prose innote(per the README convention for objectui-repo paths).experimental—variables(PageVariablesProvider + usePageVariables exist, but no end-to-end writer/visible-CEL consumer).dead—recordReview/blankLayout: their page types were removed in framework#2265 and objectui dropped all references in objectui#1949; the fields stay@deprecatedpending hard-removal (tracked, enforce-or-remove).pageadded toGOVERNEDincheck-liveness.mts.Verification
check-liveness.mtsexits 0: "page 17 classified (live 14, experimental 1, dead 2) … all governed-type properties are classified."Follow-ups (noted, not in this PR)
deadrecordReview/blankLayoutfields +BlankPageLayoutSchema/RecordReviewConfigSchema+page-builder.zod.ts(now fully unblocked — objectui#1949 merged).variables(theexperimentalentry).🤖 Generated with Claude Code