Uh oh!
There was an error while loading. Please reload this page.
chore(spec): hard-remove dead blank/record_review page config (enforce-or-remove) - #2268
Merged
Conversation
…e-or-remove) Completes framework#2265. Deletes BlankPageLayoutSchema/BlankPageLayoutItemSchema/ RecordReviewConfigSchema (+ inferred types), the blankLayout/recordReview fields on PageSchema, and page-builder.zod.ts (the blank drag-drop canvas config) + its studio re-exports — all unreachable (their page types have no renderer and were removed from PageTypeSchema; objectui dropped refs in objectui#1949). page liveness ledger → 15 props. Verified: spec UI 787 + studio 104 tests pass, typecheck clean, liveness gate exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 91 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang added a commit
that referenced
this pull request
Jun 24, 2026
…ig removal (#2268) (#2272) #2268 hard-removed 16 dead exports (6 from ./ui Blank/RecordReview, 10 from ./studio PageBuilder/Canvas/Palette) and #2265 added PAGE_TYPE_ROADMAP, but the committed api-surface.json snapshot was never regenerated — so check:api-surface has been red on main for every PR touching packages/spec/** (surfaced on #2269). Regenerate the snapshot to match the built surface. Diff is exactly the 16 intentional removals + PAGE_TYPE_ROADMAP; api-surface-signatures.json unchanged; the frozen downstream-contract gate is unaffected (it never referenced these symbols). Kept at minor (not a major bump) as a deliberate, documented exception to the ADR-0059 §4 freeze contract — see the appended note in the #2268 changeset. The removed symbols are config for renderless page types with no plausible functional consumer; the pre-publish hotcrm live gate guards any real break. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the enforce-or-remove begun in framework#2265 — now fully unblocked (objectui dropped all references in objectui#1949).
Deletes (all unreachable — their page types have no renderer and were removed from
PageTypeSchema)BlankPageLayoutSchema,BlankPageLayoutItemSchema,RecordReviewConfigSchema+ their inferred types.blankLayout/recordReviewfields onPageSchema.page-builder.zod.ts(theblank-type drag-drop canvas config —PageBuilderConfigSchema/CanvasSnapSettingsSchema/CanvasZoomSettingsSchema/ElementPaletteItemSchema/InterfaceBuilderConfigSchema) + its@objectstack/spec/studiore-exports. Nothing in framework or objectui consumed it.The
pageliveness ledger drops to 15 props (the twodeadentries removed with the fields).Verification
@objectstack/spectypecheck clean.page 15 classified — live 14, experimental 1).This closes the full enforce-or-remove loop for unrendered page types: removed from the enum (#2265) → objectui de-referenced (objectui#1949) → governed by the liveness gate (#2267) → dead config hard-removed (this PR).
🤖 Generated with Claude Code