Skip to content

docs(audits): recheck the parsed-but-unenforced security props cluster (#1878) - #3503

Merged
os-zhuang merged 1 commit into
mainfrom
docs/security-props-liveness-recheck
Jul 26, 2026
Merged

docs(audits): recheck the parsed-but-unenforced security props cluster (#1878)#3503
os-zhuang merged 1 commit into
mainfrom
docs/security-props-liveness-recheck

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Triage follow-up under umbrella #1878. Re-verifies the security cluster the 2026-06 liveness audit flagged as "parsed-but-unenforced / false compliance" — the most serious finding of that audit — against current code (three independent read-only passes).

Finding: the cluster is largely closed

The gap was closed the correct way. Of the eight flagged items:

Full per-property table with file:line evidence is in the new doc.

Changes (docs-only)

  • Adddocs/audits/2026-07-security-props-liveness-recheck.md — the recheck + the genuine remaining loose ends.
  • Annotate the two stale 2026-06 security docs (README.md §1 + 2026-06-security-identity-property-liveness.md) — the "PolicySchema 100% dead / false compliance" framing is now factually wrong and was actively misleading.

Genuine remaining loose ends (recorded, not fixed here — each deserves its own verified PR)

  1. Prune AuditRetentionPolicySchema (system/audit.zod.ts) — real parsed-only dead schema; retention lives on the lifecycle surface.
  2. Enforce-or-prune SharingRule owner-type rules + group/guest recipients (criteria-type already enforces; the rest silently no-op).
  3. Per-org/user IP allow-list — global-only today (tracked [security][P2] Per-org / per-user IP allow-list (record-level allowed_ip_ranges) — ADR-0069 D5 #2571).
  4. Ledger/comment drift: authz-conformance.matrix.ts still marks flow-run-as removed (it's live); the agent access schema comment claims in-repo enforcement (it's in the untracked service-ai/dist).

Refs #1878.

🤖 Generated with Claude Code

#1878)
The 2026-06 audit flagged a cluster of security-shaped props as
"parsed-but-unenforced / false compliance." Re-verified against current code:
the gap was closed the correct way — PolicySchema was deleted (#2387) and its
capabilities rebuilt as enforced auth settings (ADR-0069); allowTransfer,
apiEnabled/apiMethods, flow runAs, ADR-0057 scope and criteria-type
SharingRules are enforced; agent visibility and role.parent were pruned
(positions are flat, ADR-0090).
- Add 2026-07-security-props-liveness-recheck.md: per-property status with
file:line evidence + the genuine remaining loose ends (prune
AuditRetentionPolicySchema; enforce-or-prune SharingRule owner/group/guest
recipients; per-org IP allow-list #2571; two ledger/comment drift fixes).
- Annotate the two stale 2026-06 security docs (README section 1 +
security-identity audit) as rechecked/superseded.
Docs-only; empty changeset (releases nothing).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
specErrorErrorJul 26, 2026 7:44am

Request Review

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/stooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang