Uh oh!
There was an error while loading. Please reload this page.
test(dogfood): reclassify flow runAs as enforced in the authz conformance ledger (#1888) - #3506
Merged
Merged
Conversation
…ance ledger (#1888) The authz-conformance ledger still filed `flow-run-as` under "Removed — by ADR-0049 (roadmap M2)", contradicting the live enforcement: #1888 implemented runAs for flow data nodes (crud-nodes.ts honors flow.runAs — system → RLS-bypassing, user → trigger identity), proven by flow-runas.dogfood.test.ts and flow-runas-schedule.dogfood.test.ts. Moved the entry to the "Enforced (unit-proven; e2e proof is a follow-on)" section with its runtime enforcement site + dogfood proof, satisfying the ledger's enforced-has-site / proof-exists invariants (authz-conformance.test.ts 9/9 green). Surfaced by the 2026-07 security-props recheck (#1878). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 2 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small correctness fix surfaced by the 2026-07 security-props recheck (#3503, umbrella #1878).
Problem
packages/qa/dogfood/test/authz-conformance.matrix.tsstill filedflow-run-asunder "Removed — by ADR-0049 (roadmap M2)" with noteADR-0049 → roadmap M2. That contradicts the live code: #1888 implemented flowrunAsfor data nodes —crud-nodes.tsruns create/update/delete/query under the run's effective identity (runAs:'system'→ RLS-bypassing;runAs:'user'→ the trigger user, RLS enforced as them), with the authorization envelope in theservice-automationengine (runtime-identity.ts). It is proven by two dogfood tests (flow-runas.dogfood.test.ts,flow-runas-schedule.dogfood.test.ts).Leaving it marked "removed/roadmap" is exactly the declared≠actual drift this ledger exists to prevent — here in the safe direction (understating enforcement), but still a stale entry.
Fix
Moved the entry to the "Enforced (unit-proven; e2e proof is a follow-on)" section with its runtime
enforcementsite +prooffile, and a note recording the ADR-0049 → #1888 history. Its neighborallow-transfer-restore-purgecorrectly stays removed/roadmap (those ops genuinely do not exist in ObjectQL yet).Verification
authz-conformance.test.ts9/9 green — the reclassified entry satisfies the ledger invariants (enforced-has-site, proof-file-exists).Refs #1878, #1888.
🤖 Generated with Claude Code