Uh oh!
There was an error while loading. Please reload this page.
chore(qa): drop obsolete stale-prose NOTE from records-forms.action-location-matrix - #7633
Merged
Merged
Conversation
…ocation-matrix PR #7540 rewrote RecalcSelectionAction's TSDoc in examples/app-showcase/src/ui/actions/index.ts, so the NOTE clause planted by #7323 (flagging that TSDoc as narrating the stale pre-objectui#3142 rule) is now false. Delete the NOTE clause from the second source entry of records-forms.action-location-matrix, keeping the source citation itself intact. Fixes#7547
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
huangyiirene
marked this pull request as ready for review
August 11, 2026 09:44
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#7547
What
docs/qa/platform-checklist/areas/records-forms.json, itemrecords-forms.action-location-matrix, secondsourceentry: deletes the inline NOTE clause ("NOTE: RecalcSelectionAction's TSDoc there still narrates the pre-objectui#3142 ... correct either way"). The source citation itself (file path + parenthetical describing what it documents) is kept intact.Why
PR #7540 rewrote RecalcSelectionAction's TSDoc in
examples/app-showcase/src/ui/actions/index.ts, so the NOTE — planted by #7323 as an explicit temporary marker "until this card is worked" — is now false.Premise verification
origin/main(8c20f75) still had the NOTE clause atrecords-forms.json:1444at dispatch time.examples/app-showcase/src/ui/actions/index.tsonorigin/main:grep "every location"→ zero hits, confirming PR docs(showcase): correct RecalcSelectionAction TSDoc to the post-objectui#3142 placement rule #7540's TSDoc rewrite is on main.Verification
node -e "JSON.parse(...)"→ valid.grep -n "NOTE: RecalcSelectionAction"→ no hits (clause removed);grep -n "examples/app-showcase/src/ui/actions/index.ts"→ citation still present at line 1444.pnpm check:platform-checklist: same result before and after the edit —check-platform-checklist: 1 problem(s)(coverage.json · qa: UNCLASSIFIED), a pre-existing base-red finding unrelated to this one-line NOTE deletion, not chased per dispatch instructions.node scripts/check-nul-bytes.mjs: OK, no raw control bytes.Scope
Docs-only, single-line edit in one file. No changeset — this is a QA-checklist prose correction with no user-visible product change;
skip-changesetto be applied by the PM at acceptance.Generated by Claude Code