Uh oh!
There was an error while loading. Please reload this page.
docs(devx): mark check-type-check-coverage.mjs's global-setup example historical - #8383
Merged
Merged
Conversation
… historical `scripts/check-type-check-coverage.mjs` illustrates "widen a hidden test layer's include one file at a time" with `@objectstack/example-showcase`'s handling of `e2e/global-setup.ts`. PR #8178 (#8062) made both concrete claims stale: the package's tsconfig now takes the wholesale `e2e/**/*` glob directly (not the narrow `e2e/**/*.spec.ts` this file still described), and the 6 errors the narrow glob avoided are fixed at their source rather than excluded, so `global-setup.ts` is now read by the program and type-checks clean. Per the #8189 triage ruling (direction 2): keep the worked example, mark it historical at both sites (`:507` TEST_DEBT preamble, `:1705` `measureTestDebt()` docblock — the two are two halves of one worked example and move together), naming #8062 / PR #8178 as what changed. The general lesson survives unchanged: a wholesale glob can bill a hidden test layer for a non-test file it never asked to cover, so add hidden layers one file at a time and measure each. Prose-only change inside existing comments; zero behavior change. Fixes#8189 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jqe56GnYFddggeAyfkZFVz
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
qq9340100
marked this pull request as ready for review
August 13, 2026 10:52
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#8189
scripts/check-type-check-coverage.mjsillustrates "widen a hidden test layer'sincludeone file at a time and measure each" with@objectstack/example-showcase's handling ofe2e/global-setup.ts, at two sites (the TEST_DEBT preamble andmeasureTestDebt()'s docblock — two halves of one worked example). PR #8178 (#8062) made both concrete claims stale:e2e/**/*glob directly, not the narrowe2e/**/*.spec.tsthese comments still described.declare const process, plusmkdirSync/writeFileSyncon thenode:fsshim and a minimalnode:pathmodule inexamples/app-showcase/types/node-shim.d.ts) rather than excluded, soe2e/global-setup.tsis now read by the tsc program and type-checks clean.Per the #8189 triage ruling, direction 2: keep the worked example, mark it historical, naming #8062 / PR #8178 as what changed. Both sites were updated together (they are two halves of one worked example — fixing only one would leave the file self-contradicting). The general lesson is unchanged and still stated plainly: a wholesale glob can bill a hidden test layer for a non-test file it never asked to cover, so hidden test layers get added one file at a time and each addition gets measured.
This is a prose-only change inside existing comments in
scripts/check-type-check-coverage.mjs. Zero behavior change — verified by running the file's own gates before and after with identical verdicts.Verification
Fresh worktree,
pnpm install, thenpnpm exec turbo run build --filter='./packages/*' --filter='./packages/*/*'to build the closure--re-measureneeds.Re-derived the dispatch-gates mapping against the actual changed path (
node scripts/pm/dispatch-gates.mjs scripts/check-type-check-coverage.mjs) — it surfaces exactly the three named gates above (check:type-check-coverage,check:type-check-debt,check:type-source-resolution), no additional family implicated by this diff.Scripts-only prose change —
skip-changesetlabel applied.Generated by Claude Code
Generated by Claude Code