Uh oh!
There was an error while loading. Please reload this page.
docs: mark external-lookup retired, not pending, in implementation-status - #8397
Merged
qq9340100 merged 1 commit intoAug 13, 2026
Merged
Conversation
…atus The #8075 retirement (ADR-0049 route 3) deleted data/external-lookup.zod.ts outright, but the Data-layer summary row, the remaining-gaps paragraph, and the Core Data Modeling table still described external-lookup as a pending protocol. Correct all three to say retired, with the ADR-0049/#8075 citation, and leave mapping/document (still genuinely unimplemented, non-retired) as pending. Fixes#8165 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jqe56GnYFddggeAyfkZFVz
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
qq9340100
marked this pull request as ready for review
August 13, 2026 11:18
Uh oh!
There was an error while loading. Please reload this page.
qq9340100
deleted the
claude/issue-8165-implementation-status-external-lookup
branch
August 13, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#8165
Dedicated docs-only PR — the sanctioned form for touching
content/docs/releases/. This is not a rider on a code PR; the underlying retirement (#8075) already landed onmain, and this is the follow-up doc correction filed for it, per AGENTS.md's releases-directory guardrail.What was stale
content/docs/releases/implementation-status.mdxstill describedexternal-lookupas a pending, unimplemented data protocol after #8075 retireddata/external-lookup.zod.tsoutright (ADR-0049 route 3, D3external-lookup-message-queue-families-retired). Retired-with-a-reason is the accurate voice, not "still pending" or "not planned."Three spots corrected, all in this one file:
External Lookuprow) — spec column was still✅and status❌ Not Impl, implying the schema still exists and simply hasn't been built. Changed to❌/❌ Retired — data/external-lookup.zod.ts was retired outright under ADR-0049 (route 3, D3 external-lookup-message-queue-families-retired, #8075).The "Total Protocols: 16" count for the Data row is untouched — no row was added or removed from the Data-layer tables (the External Lookup row still exists, only its status text changed), so the count claim is unaffected by this change either way.
The card's open sub-question (measured, not assumed)
The card also asked to check whether the page describes the system message-queue protocol (the same #8075 change also retired
system/message-queue.zod.tsoutright — 5 defs,MessageQueueConfig/MessageQueueProvider/TopicConfig/ConsumerConfig/DeadLetterQueue).grep -inacross the whole file forMessageQueueConfig|MessageQueueProvider|TopicConfig|ConsumerConfig|DeadLetterQueue|system/message-queue: zero matches. The only "queue" mention on the page is the Integration Layer's**Message Queue**row (@objectstack/service-queue, described as shipped) — that's a distinct, still-live protocol (theConnectorTypeenum value backed by the queue service), confirmed unrelated to the retiredsystem/message-queue.zod.tsconfig family by the retirement test's own analysis (packages/spec/src/system/message-queue-retirement.test.ts: the connector's'message_queue'value "never referenced these shapes"). No correction needed there.Verification
Re-verified both stale lines on
origin/mainbefore editing (matching the 04:03Z unlock comment)::462"document/mapping/external-lookup still pending" and:474"the mapping/document/external-lookup data protocols" — both present, unchanged, confirmed stale.Confirmed the retirement facts directly against spec source rather than trusting the issue's citation alone:
packages/spec/src/data/external-lookup.zod.ts— gone; onlyexternal-lookup-retirement.test.tsremains.packages/spec/src/system/message-queue.zod.ts— gone; onlymessage-queue-retirement.test.tsremains.packages/spec/src/conversions/registry.ts:4649-4650— "[security] Two more spec schemas permit inline credentials:ExternalDataSourceSchema.authentication(clientSecret/apiKey) andMessageQueueConfigSchema.sasl.password— census toward #7990's parked boundary-guard reopen trigger #8075 retireddata/external-lookup.zod.tsoutright — route 3, D3external-lookup-message-queue-families-retired".EventMessageQueueConfig(the live MQ surface) confirmed present inpackages/spec/src/kernel/events/{bus,integrations}.zod.ts.Gates run (all green)
All passed. Re-derived gates against the actual changed path with
node scripts/pm/dispatch-gates.mjs content/docs/releases/implementation-status.mdx— surfaced exactly the same five families named in the dispatch prompt (check:doc-formula-expressions,check:docs-audit-scope,check:quick-reference-counts,check:release-notes,check:role-word); no delta.File surface
content/docs/releases/implementation-status.mdxonly — matches the declared surface, no breach.Generated by Claude Code
Generated by Claude Code