Skip to content

docs: mark external-lookup retired, not pending, in implementation-status - #8397

Merged
qq9340100 merged 1 commit into
mainfrom
claude/issue-8165-implementation-status-external-lookup
Aug 13, 2026
Merged

docs: mark external-lookup retired, not pending, in implementation-status#8397
qq9340100 merged 1 commit into
mainfrom
claude/issue-8165-implementation-status-external-lookup

Conversation

@qq9340100

Copy link
Copy Markdown
Collaborator

Fixes#8165

Dedicated docs-only PR — the sanctioned form for touching content/docs/releases/. This is not a rider on a code PR; the underlying retirement (#8075) already landed on main, and this is the follow-up doc correction filed for it, per AGENTS.md's releases-directory guardrail.

What was stale

content/docs/releases/implementation-status.mdx still described external-lookup as a pending, unimplemented data protocol after #8075 retired data/external-lookup.zod.ts outright (ADR-0049 route 3, D3 external-lookup-message-queue-families-retired). Retired-with-a-reason is the accurate voice, not "still pending" or "not planned."

Three spots corrected, all in this one file:

  1. Core Data Modeling table (External Lookup row) — spec column was still and status ❌ Not Impl, implying the schema still exists and simply hasn't been built. Changed to / ❌ Retired — data/external-lookup.zod.ts was retired outright under ADR-0049 (route 3, D3 external-lookup-message-queue-families-retired, #8075).
  2. Summary Statistics — Data row — dropped external-lookup from "document/mapping/external-lookup still pending" (mapping/document remain genuinely unimplemented and stay in that clause) and added a clause stating external-lookup was retired outright under ADR-0049.
  3. Implementation Coverage paragraph — dropped external-lookup from "the mapping/document/external-lookup data protocols" remaining-gaps list, and added a sentence noting it was retired outright rather than left pending.

The "Total Protocols: 16" count for the Data row is untouched — no row was added or removed from the Data-layer tables (the External Lookup row still exists, only its status text changed), so the count claim is unaffected by this change either way.

The card's open sub-question (measured, not assumed)

The card also asked to check whether the page describes the system message-queue protocol (the same #8075 change also retired system/message-queue.zod.ts outright — 5 defs, MessageQueueConfig/MessageQueueProvider/TopicConfig/ConsumerConfig/DeadLetterQueue).

grep -in across the whole file for MessageQueueConfig|MessageQueueProvider|TopicConfig|ConsumerConfig|DeadLetterQueue|system/message-queue: zero matches. The only "queue" mention on the page is the Integration Layer's **Message Queue** row (@objectstack/service-queue, described as shipped) — that's a distinct, still-live protocol (the ConnectorType enum value backed by the queue service), confirmed unrelated to the retired system/message-queue.zod.ts config family by the retirement test's own analysis (packages/spec/src/system/message-queue-retirement.test.ts: the connector's 'message_queue' value "never referenced these shapes"). No correction needed there.

Verification

Re-verified both stale lines on origin/main before editing (matching the 04:03Z unlock comment): :462 "document/mapping/external-lookup still pending" and :474 "the mapping/document/external-lookup data protocols" — both present, unchanged, confirmed stale.

Confirmed the retirement facts directly against spec source rather than trusting the issue's citation alone:

Gates run (all green)

node scripts/check-nul-bytes.mjs --self-test && node scripts/check-nul-bytes.mjs
node scripts/docs-audit/affected-docs.mjs --self-test && node scripts/docs-audit/check-audit-scope.mjs --self-test && node scripts/docs-audit/check-audit-scope.mjs
node scripts/check-role-word.mjs
node scripts/check-quick-reference-counts.mjs --self-test && node scripts/check-quick-reference-counts.mjs
node scripts/check-release-notes.mjs
pnpm --filter '@objectstack/lint^...' build # dependency closure (spec, formula)
pnpm --filter @objectstack/lint run check:doc-formula-expressions

All passed. Re-derived gates against the actual changed path with node scripts/pm/dispatch-gates.mjs content/docs/releases/implementation-status.mdx — surfaced exactly the same five families named in the dispatch prompt (check:doc-formula-expressions, check:docs-audit-scope, check:quick-reference-counts, check:release-notes, check:role-word); no delta.

File surface

content/docs/releases/implementation-status.mdx only — matches the declared surface, no breach.

Generated by Claude Code


Generated by Claude Code

…atus
The #8075 retirement (ADR-0049 route 3) deleted data/external-lookup.zod.ts
outright, but the Data-layer summary row, the remaining-gaps paragraph, and
the Core Data Modeling table still described external-lookup as a pending
protocol. Correct all three to say retired, with the ADR-0049/#8075
citation, and leave mapping/document (still genuinely unimplemented,
non-retired) as pending.
Fixes#8165
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jqe56GnYFddggeAyfkZFVz
@vercel

vercelBot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectstackIgnoredIgnoredAug 13, 2026 11:03am

Request Review

@qq9340100qq9340100 added skip-changeset PR has no user-facing published change; bypasses the changeset gate and removed size/xs labels Aug 13, 2026 — with Claude
@github-actionsgithub-actionsBot added the documentation Improvements or additions to documentation label Aug 13, 2026
@qq9340100
qq9340100 marked this pull request as ready for review August 13, 2026 11:18
@qq9340100
qq9340100 added this pull request to the merge queueAug 13, 2026
Merged via the queue into main with commit 539c5a0Aug 13, 2026
28 checks passed
@qq9340100
qq9340100 deleted the claude/issue-8165-implementation-status-external-lookup branch August 13, 2026 11:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] releases/implementation-status.mdx still lists external-lookup as a pending data protocol after the #8075 retirement

2 participants

@qq9340100@claude