Uh oh!
There was an error while loading. Please reload this page.
docs(types): correct thrown-http-error.ts doc comment for #8634's re-point - #8847
Merged
Merged
Conversation
…point The TSDoc for ThrownHttpError.declaredStatus said the fallback-probe workaround (`resolveThrownHttpError(e, 0).status !== 0`) was "still spelled by hand in packages/rest's publish-classification suite". PR #8814 (closing #8634) re-pointed both call sites in that suite at `declaredStatus` directly, so the clause is now false. Corrected it to name the current call-site spelling instead. Fixes#8810 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NaS1PAHJcPfAA2acnV53Tn
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 1 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
qq9340100
marked this pull request as ready for review
August 15, 2026 09:34
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#8810
What changed
packages/types/src/thrown-http-error.ts's TSDoc forThrownHttpError.declaredStatus, under "Whystatuscannot answer this", described the pre-field fallback-probe workaround (resolveThrownHttpError(e, 0).status !== 0) as "still spelled by hand inpackages/rest's publish-classification suite". PR #8814 (closing #8634) re-pointed both call sites in that suite atdeclaredStatusdirectly, so that trailing clause is no longer true — nothing in the repo hand-spells the sentinel anymore.Corrected the sentence to name the current call-site spelling instead of the stale one, so a future reader can check it against the code with one grep:
(verified live at
packages/rest/src/package-publish-status-classification.test.ts:405).Docs-only TSDoc edit — no production/runtime change, no
.describe()/schema doc, no generated-artifact consequence.Scope
Per the card's ruling, file surface is
packages/types/src/thrown-http-error.tsonly — the one stale sentence, nothing else in the surrounding doc block touched.packages/rest's publish-classification suite (already re-pointed by #8814) is untouched, per the ruling.Premise re-verification
Re-located the stale line by content rather than trusting the
:88line number cited in the card (the file has taken merges since). Confirmed on this branch's base (origin/main@6b6b606c5) that the sentence was still present and still false — the two call sites inpackage-publish-status-classification.test.tsalready readdeclaredStatus(7 hits fordeclaredStatusinthrown-http-error.ts, 6 in the test file), matching the 09:05Z unlock-scan comment on the issue.Tests
At HEAD
c55539c05:pnpm --filter '@objectstack/types^...' build(dependency closure —@objectstack/spec): success.pnpm --filter '@objectstack/types' build: success.pnpm --filter '@objectstack/types' typecheck: exit 0.pnpm --filter '@objectstack/types' test -- --maxWorkers=2:Test Files 12 passed (12),Tests 337 passed (337), exit 0.pnpm check:nul-bytes: OK (5855 tracked files scanned, no raw control bytes).node scripts/pm/dispatch-gates.mjs packages/types/src/thrown-http-error.ts: no check family names this path specifically; no new error code, no fake engine, no test-file edit, no i18n-extract package touched — nothing else applies.Changeset: intentionally omitted (
skip-changesetlabel applied) — comment-only edit, no user-visible behavior. Matches the precedent set by #8814 (the sibling PR for #8634, same "comment-adjacent, no production change" shape), which also carriedskip-changeset.Generated by Claude Code