Skip to content

docs(types): correct thrown-http-error.ts doc comment for #8634's re-point#8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qq9340100 merged 1 commit into from
Aug 15, 2026
+5 −3
Merged

docs(types): correct thrown-http-error.ts doc comment for #8634's re-point #8847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/types/src/thrown-http-error.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,10 +85,12 @@ export interface ThrownHttpError {
* to `status: 500`, so a caller that must tell "the producer said so" from
* "I supplied the default" cannot read it off the value. The workaround in
* the repo was to probe this function with a fallback no producer declares
* — `resolveThrownHttpError(e, 0).status !== 0`, still spelled by hand in
* `packages/rest`'s publish-classification suite. That is a magic number
* — `resolveThrownHttpError(e, 0).status !== 0`. That is a magic number
* standing in for a fact this function already computed, and it fails
* silently the day a producer declares the sentinel. So the fact is stated.
* silently the day a producer declares the sentinel. So the fact is stated;
* `packages/rest`'s publish-classification suite now reads
* `resolveThrownHttpError(error).declaredStatus !== undefined` instead of
* hand-spelling the workaround.
*
* ## Who needs the distinction
*
Expand Down
Loading