Uh oh!
There was an error while loading. Please reload this page.
fix(docs): rename apps/docs's start script to match its own convention - #9097
Merged
Merged
Conversation
pnpm docs:start has never worked (both lines landed in 159e299, 2026-08-15): the root delegate calls `pnpm --filter @objectstack/docs start`, but apps/docs declared `site:start` instead. Determination: the app's script name is the outlier, not the root delegate. apps/docs/README.md already documents `pnpm start` (not `pnpm site:start`) as the local equivalent of `pnpm docs:start`, right alongside `pnpm dev`/`pnpm build` — which the root's already-working `docs:dev`/`docs:build` delegates map onto verbatim. No other file in the repo (workflows, vercel.json, scripts) references `site:start`, so renaming it is safe. The root package.json needs no change: `docs:start` was already correctly named. Fixes#9086
os-project-manager
marked this pull request as ready for review
August 16, 2026 10:58
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9086
The defect
pnpm docs:starthas never worked. Both lines landed together in159e29944(2026-08-15): the rootpackage.jsondelegate callspnpm --filter @objectstack/docs start, butapps/docs/package.jsondeclaredsite:start, notstart.Determination: the app's script name is the outlier, not the root delegate
Re-derived from scratch (not copied from the issue's provenance note):
package.json's two sibling, already-working delegates map onto bare script names inapps/docs:docs:dev→dev,docs:build→build. That is the established, working convention.apps/docs/README.md(unrelated to this fix, pre-existing) documents the deployment step as:pnpm start, notpnpm site:start.site:start— not.github/workflows/**, notapps/docs/vercel.json(which only sets a build command, not start), notscripts/**. Renaming it is safe.So the root delegate was already correctly named; the bug is that
apps/docs/package.jsondeclared the wrong script name. Fix: renamesite:start→startinapps/docs/package.json. The rootpackage.jsonis unchanged.site:lintis a separate, similarly-styled key but nothing in the repo delegates to it and it isn't broken, so it's left untouched — out of scope for this card.Proof it was broken (on
origin/main, HEAD4e3a4c3c8, before this fix)Proof it works (on this branch, HEAD
5fd08318d)Built the docs site (
pnpm docs:build, exit 0, 1184 static pages generated), then:Confirmed the response body is the real docs homepage (
<title>ObjectStack — A complete business system in 16k tokens</title>). Server stopped afterward (kill, then re-curled to confirm the port is closed — no server left running).Note:
next startprints⚠ "next start" does not work with "output: standalone" configuration. Use "node .next/standalone/server.js" instead.— pre-existing, unrelated to this fix (Next.js config choice), and the server demonstrably does work (200 + real HTML) despite the warning, so not addressed here.Verification
node scripts/pm/dispatch-gates.mjs apps/docs/package.jsonat the final diff: 0 gate families name this path directly (101 discovered, 66 silent w.r.t. this path, 35 undetermined-by-source, 0 matched).pnpm check:nul-bytes(applies to any edit): green at HEAD5fd08318d—check-nul-bytes: OK (scanned 5973 text file(s) ... no raw ASCII control bytes).pnpm docs:buildsucceeded (exit 0) at HEAD5fd08318d.node -e "JSON.parse(...)"confirmsapps/docs/package.jsonis valid JSON post-edit.Changeset
Root-manifest/app-script rename only, publishes nothing →
skip-changesetlabel applied; read back to confirm.Out of scope
site:lintnaming (same file, samesite:prefix habit, but not currently broken/referenced anywhere) — not touched. Not filed as a separate finding: nothing invokes it incorrectly, so it doesn't corroborate #9089's "invocation actually fails" class.Generated by Claude Code