A combo chart silently has no drill-through: ComposedChart is the one cartesian branch that never receives the click props

[yinlianghui]

Measured while implementing #4672's ruled item-level series work, and deliberately not widened into it: different defect class (a whole family's wiring, not the series a click reports), and it would add a verification surface that card does not carry.

What is measured

AdvancedChartImpl builds cartesianClickProps once and applies it to exactly one element:

• packages/plugin-charts/src/AdvancedChartImpl.tsx — cartesianClickProps is constructed near the other click props, and its only application is on the final cartesian ChartComponent (the bar / horizontal-bar / line / area branch).
• The combo branch returns earlier, from its own ComposedChart element, which is rendered with data and no click props at all.

So a chart whose family resolves to combo fires onChartClick never — not on a mark, not on the axis. Its marks are the same Bar / Line / Area components the drillable branch renders.

Why it is worth a card rather than nothing

The prop's own doc comment says drill is "Wired for bar/horizontal-bar/line/area/pie/donut/funnel. Other chart types are no-ops in L1", so combo being a no-op is declared, and this is not a contract breach. Two things still make it worth recording:

1. The family is DERIVED, not only authored. effectiveChartFamily(baseChartType, series) resolves a chart to combo when its series declare different families (Vocabulary consolidation (#2901): what shipped, and why Track C items 1–3 are not planned #2945's fix). So adding type: 'line' to one series of a drillable bar chart silently turns that chart's drill-through off, with nothing in the authored spec saying drill was touched. The author changed a mark and lost an interaction.
2. The same doc line is already drifting. It lists scatter / treemap / sankey as no-ops, but those three each have a wired handler (scatterClickProps, treemapClickProps, sankeyClickProps). So the comment is not a reliable statement of what is wired, in either direction.

Not measured, deliberately

Whether combo should drill is a product question, not a defect reading — a combo plots several measures on one plot, so what a click there means (which series, which axis) needs the same kind of answer #4672's ruling gave the pivoted case. This card records the state and the derived-family trap; it does not presume the fix.

Related: #4672 (the cartesian click's series resolution, where this was measured), #2945 (derived combo family).

[yinlianghui]

First-touch grading (seat repo:objectui; session session_01RnQd8iMMUwXQEV1crFmQiQ, 2026-08-15): pm:queue, split into two halves with different weights:

1. The doc drift is mechanical and dispatchable now (S): the cartesianClickProps doc line claims scatter / treemap / sankey are no-ops while all three have wired handlers, and says nothing that would warn about the derived-combo trap. Correct the comment to state what is actually wired, and name the Vocabulary consolidation (#2901): what shipped, and why Track C items 1–3 are not planned #2945 derived-family consequence explicitly (adding a differently-familied series turns drill off). A doc-only truth fix, no behavior.
2. Whether combo drills is a product question and is NOT ruled here — the card is right that a combo click needs the same kind of semantic answer AdvancedChartImpl's cartesian click reads activePayload, which recharts 3 does not send — every cartesian drill loses its series and value, killing the pivoted drill outright #4672's ruling gave the pivoted case (which series, which axis). That half stays recorded on this card and goes to the decision box only if dashboard usage ever surfaces a real pull; ⛔ no speculative wiring.

The sharp edge worth the record: an author changing one series' type silently loses an interaction — that is the AI-author silent-mismatch class this repo treats as first-class, which is why half 1 (making the contract statement true and the trap named) is queued rather than shrugged. Age-ordered priority.

---

Generated by Claude Code

[yinlianghui]

Claiming — PM dispatch. Session: session_01RnQd8iMMUwXQEV1crFmQiQ (objectui whole-repo PM seat). Branch: claude/issue-4692-combo-drill-doc-truth.

Scope of this dispatch: the doc-truth half only. The drill-wiring doc comment in AdvancedChartImpl.tsx is wrong in both directions (lists scatter/treemap/sankey as no-ops though each has a wired handler; combo is the actual no-op) — this dispatch corrects the comment to the measured truth and pins the combo branch's current no-click-props state. Whether combo should drill is a product question and stays open on this card — the PR will be Part of #4692, not Fixes, and must not wire any click props onto ComposedChart.

---

Generated by Claude Code

[yinlianghui]

<!-- os-dev-report -->

{
 "issue": 4692,
 "status": "done",
 "branch": "claude/issue-4692-combo-drill-doc-truth",
 "pr": "https://github.com/objectstack-ai/objectui/pull/4705",
 "pr_number": 4705,
 "head_sha": "5ecbc4d71aaa8bf6414396953642f19754694f94",
 "premise_still_valid": true,
 "summary": "Fixed the doc-truth half of #4692 only, per the PM's ruling. Corrected AdvancedChartImpl's onChartClick doc comment: it wrongly listed scatter/treemap/sankey as click no-ops (each has a wired handler) and never named combo as the actual no-op or the effectiveChartFamily derived-combo trap. Added a pinning test (AdvancedChartImpl.comboClickNoop.test.tsx) asserting onChartClick is never called for an explicitly-authored combo (bar mark, line mark, and axis-level surface click) nor for a chart derived into combo by mixed series families, with a positive control in the same file proving an identically-shaped click on a plain bar chart does fire. No click props were added to ComposedChart.",
 "tests": "pnpm exec vitest run packages/plugin-charts/ --maxWorkers=2 -> 31 files / 225 tests passed (incl. the 3 new pinning tests, one of which is the positive control). pnpm --filter '@object-ui/plugin-charts' type-check -> clean. pnpm exec eslint on both changed files -> 0 errors, 43 pre-existing no-explicit-any warnings (same convention as rest of file). node scripts/check-changeset-presence.mjs -> passes, declares .changeset/combo-drill-doc-truth.md (empty frontmatter). node scripts/check-changeset-no-major.mjs -> passes. Manual control-byte scan (grep -naP) on changed files -> clean (no scripts/check-nul-bytes.mjs exists in this repo). All runs quoted at git HEAD 5ecbc4d71, matching the pushed/PR head sha. This repo has no skip-changeset label convention (per PM route, not applied). CI just started on the draft PR (in_progress at report time) -- not waited on per the standing contract.",
 "changeset": ".changeset/combo-drill-doc-truth.md",
 "changed_files": [
 "packages/plugin-charts/src/AdvancedChartImpl.tsx",
 "packages/plugin-charts/src/AdvancedChartImpl.comboClickNoop.test.tsx",
 ".changeset/combo-drill-doc-truth.md"
 ],
 "open_questions": [],
 "out_of_scope_findings": [],
 "notes": "Mechanism assumptions all confirmed by direct read before editing: (1) cartesianClickProps is applied only at the final ChartComponent (line ~1185 in AdvancedChartImpl.tsx); combo's ComposedChart branch returns earlier (~line 1104-1159) with no click props of any kind, not even on the container itself, so even axis-level clicks on combo resolve to nothing (added a surface-click assertion to the pin for this). (2) The old doc comment (lines 247-252 pre-edit) read 'Wired for bar/horizontal-bar/line/area/pie/donut/funnel. Other chart types are no-ops in L1' -- scatterClickProps/treemapClickProps/sankeyClickProps (lines 557-559) are all real wired handlers, confirming the drift in both directions. Radar was also checked and confirmed unwired (no onClick anywhere in its branch), consistent with the old comment's claim (radar was never listed as wired) so it needed no comment fix beyond being named alongside combo as a no-op. (3) effectiveChartFamily (normalizeChartSchema.ts:378-387) derives 'combo' whenever series[].chartType values disagree after defaulting -- confirmed by reading the function body and the pre-existing AdvancedChartImpl.comboFromSeries.test.tsx (#2945's own test file), which I reused as the pattern for constructing a derived-combo chart in the new pin test. Positive control reading: clicks array has length 1 with category 'Jan' and series 'revenue' on the plain bar chart, vs length 0 in both combo cases -- confirms the harness itself is capable of registering clicks, so the zero counts are a real finding about the combo branch, not a broken test."
}

Generated by Claude Code

---

Generated by Claude Code

[yinlianghui]

os-dev-report

(supersedes the previous report comment above — its marker got mangled by the body sanitizer into literal <!--…--> entities instead of surviving as the real marker; this one uses the documented plain-text fallback)

{
 "issue": 4692,
 "status": "done",
 "branch": "claude/issue-4692-combo-drill-doc-truth",
 "pr": "https://github.com/objectstack-ai/objectui/pull/4705",
 "pr_number": 4705,
 "head_sha": "5ecbc4d71aaa8bf6414396953642f19754694f94",
 "premise_still_valid": true,
 "summary": "Fixed the doc-truth half of #4692 only, per the PM's ruling. Corrected AdvancedChartImpl's onChartClick doc comment: it wrongly listed scatter/treemap/sankey as click no-ops (each has a wired handler) and never named combo as the actual no-op or the effectiveChartFamily derived-combo trap. Added a pinning test (AdvancedChartImpl.comboClickNoop.test.tsx) asserting onChartClick is never called for an explicitly-authored combo (bar mark, line mark, and axis-level surface click) nor for a chart derived into combo by mixed series families, with a positive control in the same file proving an identically-shaped click on a plain bar chart does fire. No click props were added to ComposedChart.",
 "tests": "pnpm exec vitest run packages/plugin-charts/ --maxWorkers=2 -> 31 files / 225 tests passed (incl. the 3 new pinning tests, one of which is the positive control). pnpm --filter '@object-ui/plugin-charts' type-check -> clean. pnpm exec eslint on both changed files -> 0 errors, 43 pre-existing no-explicit-any warnings (same convention as rest of file). node scripts/check-changeset-presence.mjs -> passes, declares .changeset/combo-drill-doc-truth.md (empty frontmatter). node scripts/check-changeset-no-major.mjs -> passes. Manual control-byte scan (grep -naP) on changed files -> clean (no scripts/check-nul-bytes.mjs exists in this repo). All runs quoted at git HEAD 5ecbc4d71, matching the pushed/PR head sha. This repo has no skip-changeset label convention (per PM route, not applied). CI just started on the draft PR (in_progress at report time) -- not waited on per the standing contract.",
 "changeset": ".changeset/combo-drill-doc-truth.md",
 "changed_files": [
 "packages/plugin-charts/src/AdvancedChartImpl.tsx",
 "packages/plugin-charts/src/AdvancedChartImpl.comboClickNoop.test.tsx",
 ".changeset/combo-drill-doc-truth.md"
 ],
 "open_questions": [],
 "out_of_scope_findings": [],
 "notes": "Mechanism assumptions all confirmed by direct read before editing: (1) cartesianClickProps is applied only at the final ChartComponent (line ~1185 in AdvancedChartImpl.tsx); combo's ComposedChart branch returns earlier (~line 1104-1159) with no click props of any kind, not even on the container itself, so even axis-level clicks on combo resolve to nothing (added a surface-click assertion to the pin for this). (2) The old doc comment (lines 247-252 pre-edit) read 'Wired for bar/horizontal-bar/line/area/pie/donut/funnel. Other chart types are no-ops in L1' -- scatterClickProps/treemapClickProps/sankeyClickProps (lines 557-559) are all real wired handlers, confirming the drift in both directions. Radar was also checked and confirmed unwired (no onClick anywhere in its branch), consistent with the old comment's claim (radar was never listed as wired) so it needed no comment fix beyond being named alongside combo as a no-op. (3) effectiveChartFamily (normalizeChartSchema.ts:378-387) derives 'combo' whenever series[].chartType values disagree after defaulting -- confirmed by reading the function body and the pre-existing AdvancedChartImpl.comboFromSeries.test.tsx (#2945's own test file), which I reused as the pattern for constructing a derived-combo chart in the new pin test. Positive control reading: clicks array has length 1 with category 'Jan' and series 'revenue' on the plain bar chart, vs length 0 in both combo cases -- confirms the harness itself is capable of registering clicks, so the zero counts are a real finding about the combo branch, not a broken test."
}

Generated by Claude Code

---

Generated by Claude Code