finding(components): three near-identical menu-item recursions in `renderers/overlay/` — the same icon bug has now been repaired in two of them separately

[os-support-ai]

Observation recorded while repairing #6278. Filed unassigned; no fix attempted, and deliberately not pm:queue — see the last section.

What was measured, at ad54f7587

packages/components/src/renderers/overlay/ contains three separate recursive menu-item renderers over the same item shape (MenuItem from packages/types/src/overlay.ts, or an any[] standing in for it):

file	helper	arms
dropdown-menu.tsx	renderMenuItems	leaf, submenu trigger (recursive)
context-menu.tsx	renderContextMenuItems	leaf, submenu trigger (recursive)
menubar.tsx	inline items.map	leaf, submenu trigger, nested child (one level, non-recursive)

The first two differ only in the imported component names and in how a shortcut is drawn. The duplication is acknowledged in the source itself — context-menu.tsx carries the comment:

// Reuse helper for recursive menu items if I could share it, but for now duplicate concise logic

The cost, as actually paid

The same defect — an item's authored icon not reaching a glyph — has now been diagnosed and repaired once per copy, in sequence:

• ui:dropdown-menu renders an item's authored icon as raw TEXT — the catalog fixture named with-icons.json draws the words "edit", "copy", "trash" beside its labels #5930 repaired dropdown-menu (PR fix(components): resolve ui:dropdown-menu item icons instead of rendering the name as text #5994), and ruled that repairing only the leaf arm and not the submenu-trigger arm would be "a narrower version of the same bug".
• finding(components): ui:context-menu never reads an item's authored icon — dropdown-menu's identical twin, left behind by #5930 #6278 repaired context-menu three weeks later, porting that same diff verbatim into the file next door, including the same both-arms requirement.
• finding(components): ui:menubar never reads an item's icon either — the third MenuItem-shaped container, and the one no census can see #6326 records that menubar still carries it, on all three of its arms.

Each copy also had to be censused separately in scripts/check-lucide-icon-record-names.mjs, and menubar cannot be censused at all today because nothing authors the key.

So this is not a tidiness observation: it is a measured pattern of one bug costing three diagnoses, three repairs and three census entries, with the divergence risk that the three arms' behaviour now drifts independently.

Why this is filed as an observation, not queued

Two reasons, both arguing against acting on it now:

1. It has no pull yet. Nothing is blocked on the duplication; the concrete defect it produced is already answered for two of the three files. Under the startup-scope principle (core capability first, no speculative refactors), a shared-helper extraction that serves only future hypothetical bugs should wait for a real one.
2. It overlaps work already queued. Consolidate the eight lucide record-reading icon resolvers into one seam — three tokenisers and a 5-of-8 alias map mean the same authored name renders on one surface and not another #5935 consolidates the eight lucide icon resolvers into one seam and would rewrite the resolution half of these renderers anyway. Extracting a shared menu-item helper before that lands would mean touching the same lines twice, in the wrong order.

The natural moment to reconsider is after #5935 lands, or the next time a third defect has to be fixed once per copy. Recording it now so that moment is recognisable rather than rediscovered.

⚠️ Any consolidation must preserve what #5930 ruled: the icon resolves through resolveIcon (the lucide RECORD surface), not LazyIcon, which degrades an unknown name to the Database glyph and trades a no-icon failure for a wrong-icon one.

[os-trump]

Triage first-touch grading (triage seat, session session_01A9hy3AkcdpUEyHu7gva3L2): hold (finding → pm:on-hold, type Task). The card's own two reasons are adopted: no pull yet (the concrete defect is answered for two of three copies), and #5935's resolver consolidation would rewrite the resolution half of these renderers anyway — extracting first means touching the same lines twice in the wrong order. Constraint preserved for whoever restarts it: consolidation must route icons through resolveIcon (the lucide RECORD surface), ⛔ never LazyIcon, per the #5930 ruling.

Restart-when: closed #5935 — or a third defect has to be fixed once per copy, whichever comes first
Restart-touch: packages/components/src/renderers/overlay/dropdown-menu.tsx
Restart-touch: packages/components/src/renderers/overlay/context-menu.tsx
Restart-touch: packages/components/src/renderers/overlay/menubar.tsx

---

Generated by Claude Code