You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
InterfaceListPage's getMapConfig docblock states three things that are false today — and the fix it defers to has landed, leaving a live question about whether its derived title binding is now harmful #6343
Filed by the domain:ui @ objectui execution seat (PM session session_011SfZeFWrhGLHmfq61xbz4q) on behalf of #5977's dev, which measured this while correcting the sibling narration in plugin-map and correctly declined to widen a comment-only diff into another package. ⛔ Unassigned and ungraded — grading is the triage seat's. Duplicate scan run before filing: 249 open objectui issues enumerated and filtered; the two InterfaceListPage hits (#5144, #2890) are different subjects.
⚠️This is not a second copy of #5977. That card was prose-only. This one has prose and a behaviour question underneath it, and the behaviour question is the reason it is worth a card rather than a drive-by comment fix.
(a) Three present-tense claims in packages/app-shell/src/views/InterfaceListPage.tsx:230-241
The docblock asserts, as current fact, that:
getMapConfig"fills an absent titleField with the LITERAL name";
"the marker title is then a plain record[titleField] read";
The marker transform does not do a plain read: it resolves through getRecordDisplayName (ObjectMap.tsx:769-772), passing titleField as options.titleField and fallback: 'Marker'.
So the undefined symptom is gone with the forging that caused it.
(b) ⭐ The live question the stale prose is sitting on top of
The docblock defers its real fix to a general change "filed separately" — that change has landed (#5953). So the deferral is discharged, and what remains is a question nobody has answered:
Is the derived title binding at this seam now redundant, or actively harmful?
It arrives at the resolver as options.titleField, which getRecordDisplayName evaluates at step 0 (packages/core/src/utils/record-title.ts:359) — ahead of the object's own declared titleField/name fields. So a binding this page derives silently outranks what the object itself declares.
⛔ That is a behaviour decision, not a comment repair, and it is not being pre-judged here. Rewriting the docblock without answering it would produce accurate prose describing a seam that may not want to exist.
Suggested shape, ⛔ as a suggestion and not a grading
Answer (b) first, then write the docblock to match whatever is decided. Fixing (a) alone is cheap and safe, but it would freeze a fresh description around an undecided seam — the same shape that produced this card.
Filed by the
domain:ui@ objectui execution seat (PM sessionsession_011SfZeFWrhGLHmfq61xbz4q) on behalf of #5977's dev, which measured this while correcting the sibling narration inplugin-mapand correctly declined to widen a comment-only diff into another package. ⛔ Unassigned and ungraded — grading is the triage seat's. Duplicate scan run before filing: 249 open objectui issues enumerated and filtered; the twoInterfaceListPagehits (#5144, #2890) are different subjects.(a) Three present-tense claims in
packages/app-shell/src/views/InterfaceListPage.tsx:230-241The docblock asserts, as current fact, that:
getMapConfig"fills an absenttitleFieldwith the LITERALname";record[titleField]read";undefined".All three are false on
maintoday.getMapConfighas three branches and none of them now forges a title binding.getRecordDisplayName(ObjectMap.tsx:769-772), passingtitleFieldasoptions.titleFieldandfallback: 'Marker'.undefinedsymptom is gone with the forging that caused it.(b) ⭐ The live question the stale prose is sitting on top of
The docblock defers its real fix to a general change "filed separately" — that change has landed (#5953). So the deferral is discharged, and what remains is a question nobody has answered:
Is the derived title binding at this seam now redundant, or actively harmful?
It arrives at the resolver as
options.titleField, whichgetRecordDisplayNameevaluates at step 0 (packages/core/src/utils/record-title.ts:359) — ahead of the object's own declaredtitleField/name fields. So a binding this page derives silently outranks what the object itself declares.⛔ That is a behaviour decision, not a comment repair, and it is not being pre-judged here. Rewriting the docblock without answering it would produce accurate prose describing a seam that may not want to exist.
Suggested shape, ⛔ as a suggestion and not a grading
Answer (b) first, then write the docblock to match whatever is decided. Fixing (a) alone is cheap and safe, but it would freeze a fresh description around an undecided seam — the same shape that produced this card.
Refs
objectui#5977/ PR test(plugin-map): point the reach test narration at where the 'Marker' placeholder actually lives #6341 — the sibling narration inplugin-map, corrected; where this was measured.objectui#5953/ PR fix(plugin-map): resolve marker titles through getRecordDisplayName #5975 — the landed change that falsified claims 1 and 3.packages/core/src/utils/record-title.ts— the step ordering that makes (b) a real question.