Uh oh!
There was an error while loading. Please reload this page.
feat(form): subforms in DrawerForm + full-page record form (Tier 0 everywhere) - #1530
Merged
Merged
Conversation
Completes Tier 0 across all create/edit entry points: - DrawerForm hosts MasterDetailForm inside the drawer when subforms set. - RecordFormPage sources subforms from the object form view. - ObjectForm's subforms shortcut defers to drawer/modal variants (so they keep their envelope), rendering master-detail directly only for simple forms. plugin-form 77 tests pass; plugin-form + app-shell build clean; live e2e 3/3 (form-view-subforms + master-detail). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This was referenced Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes config-driven master-detail across all standard create/edit entry points (the modal landed in #1529; this finishes the drawer + full-page paths):
DrawerFormhostsMasterDetailForminside the drawer when the schema declaressubforms(it owns its Save bar; closes + refreshes on success).DrawerFormSchemagainssubforms.RecordFormPage(full-page New/Edit) sourcessubformsfrom the object's form view, so the full-page form renders inline child collections too.ObjectForm's subforms shortcut now defers to the drawer/modal variants for thoseformTypes (so they keep their envelope), rendering the master-detail form directly only for inline/simple forms.Net result: declaring
formViews.default.subforms: [{ childObject }]yields a master-detail experience in the modal, drawer, and full-page form — no bespoke page anywhere, regardless of the object's navigation mode.Testing
plugin-form77 unit tests pass;plugin-form+app-shellbuild clean.form-view-subforms+master-detail) after the change — no regression; the New Project modal still renders the inline Tasks subtable and posts one atomic/api/v1/batch.🤖 Generated with Claude Code