Skip to content

fix(plugin-report): drill by RAW stored value (correct for select/lookup dims) - #1842

Merged
xuyushun441-sys merged 1 commit into
mainfrom
feat/report-drill-raw-values
Jun 21, 2026
Merged

fix(plugin-report): drill by RAW stored value (correct for select/lookup dims)#1842
xuyushun441-sys merged 1 commit into
mainfrom
feat/report-drill-raw-values

Conversation

@xuyushun441-sys

Copy link
Copy Markdown
Contributor

The bug

The report renderer's drill emitted a groupKey of display labels (the analytics server resolves dimension buckets to labels in rows). The host (ReportView.handleDatasetDrill) then had to compensate: re-fetch the dataset definition, reverse-map select labels → option values, and skip lookup dims entirely (a lookup label is a record name, not the FK id) — so a lookup dimension drilled to a superset instead of filtering. This is the same class of bug the dashboard already fixed via drillRawRows.

The fix

The renderer already had dimensionFields + drillRawRows available from queryDataset but wasn't capturing them. Now it does, and alongside groupKey it emits:

  • object — the dataset's base object, and
  • objectFilter — an exact object FIELD → RAW stored value filter (ANDed with the render scope), built with the shared buildDatasetDrillFilter (@object-ui/core, which also now backs the dashboard's buildDrillFilter — single source of truth).

ReportView gains a fast path: when object + objectFilter are present it navigates straight to the scoped list — correct for select/lookup dims, with no dataset-definition round-trip and no label reverse-mapping. Older servers that don't return drill metadata fall back to the existing label-resolution path unchanged.

Stacked on #1841 (now merged) for the shared @object-ui/core helpers.

Behavior

dim typebeforeafter
selecthost reverse-maps label→value (extra metadata fetch)exact raw value, no fetch
lookupskipped — drills to a supersetfilters by FK id
plainOKOK (no fetch)

Tests

  • plugin-report44 passed: raw stored value (not display label), lookup FK id, matrix-cell over row+across dims, and the older-server fallback (no objectFilter).
  • plugin-dashboardDatasetWidget33 passed (buildDrillFilter re-export).
  • type-check green across core / plugin-report / plugin-dashboard / app-shell.

The ReportView host fast path is a thin URLSearchParams builder over objectFilter; its correctness-critical input is covered by the renderer + core buildDatasetDrillFilter tests. There is no existing ReportView unit harness, so I did not add a bespoke router-mock test for the 6-line nav loop.

🤖 Generated with Claude Code

…kup dims)
The report renderer's drill emitted a `groupKey` of DISPLAY labels (the server
resolves dimension buckets to labels in `rows`). The host then had to re-fetch
the dataset definition, reverse-map select labels, and SKIP lookup dims entirely
(a lookup label is a record name, not the FK id) — so lookups drilled to a
superset instead of filtering. Same bug class the dashboard already fixed.
Now the renderer captures the server's `dimensionFields` + `drillRawRows` (it
already returns them) and emits, alongside `groupKey`, the dataset's base
`object` and an exact `objectFilter` (object FIELD → RAW stored value, ANDed
with the scope filter) built via the shared `buildDatasetDrillFilter`
(@object-ui/core, also now backing the dashboard's `buildDrillFilter`).
ReportView gains a fast path: when `object` + `objectFilter` are present it
navigates straight to the scoped list — correct for select/lookup dims, with no
dataset-definition round-trip and no label reverse-mapping. Older servers
without drill metadata fall back to the existing label-resolution path.
Tests: plugin-report 44 passed (raw value, lookup FK, matrix cell, older-server
fallback); plugin-dashboard DatasetWidget 33 passed (buildDrillFilter re-export);
type-check green across core/plugin-report/plugin-dashboard/app-shell.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jun 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 21, 2026 5:00am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)58.8 KB350 KB
Entry fileindex-ByXTA5pw.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.95KB2.10KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)24.74KB6.00KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)414.34KB87.93KB
core (index.js)1.48KB0.54KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)97.05KB24.16KB
fields (index.js)158.94KB38.06KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.34KB0.93KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)40.52KB11.50KB
plugin-chatbot (index.js)141.13KB34.56KB
plugin-dashboard (index.js)99.00KB24.54KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)195.45KB47.13KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)91.29KB22.26KB
plugin-gantt (index.js)122.36KB30.13KB
plugin-grid (index.js)114.52KB30.73KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)93.13KB21.89KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.58KB4.64KB
plugin-report (index.js)35.93KB9.50KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)84.13KB20.27KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)15.64KB5.08KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@xuyushun441-sys
xuyushun441-sys merged commit 179a1d0 into mainJun 21, 2026
10 checks passed
@xuyushun441-sys
xuyushun441-sys deleted the feat/report-drill-raw-values branch June 21, 2026 05:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@xuyushun441-sys@os-zhuang