fix(metadata-admin): currency-aware, labelled headers in the dataset preview by xuyushun441-sys · Pull Request #1845 · objectstack-ai/objectui

xuyushun441-sys · 2026-06-21T05:20:45Z

What

Found during an audit of sibling dataset-render surfaces (after #1830 / #1841 / #1842). The live dataset-authoring preview (DatasetPreview) had the same three bugs the dashboard widget and report renderer were already fixed for:

Raw dimension/measure names in table headers (<th>{c}).
A local currency-blindformatCell (plain toLocaleString).
No i18n.

It renders the samequeryDataset result a dashboard/report does, so authors saw a different rendering of the exact numbers their published surfaces show.

Fix

Reuse the shared helpers instead of a bespoke formatter:

buildDatasetFieldHelpers + useSafeFieldLabel → headers resolve field label → i18n fieldLabel → raw name.
formatMeasure → measure cells use the field's declared currency (Intl symbol) + numeral format, never a misleading $; formatDimensionValue for dimensions.
The preview chart's series label now uses the display label too (was the raw measure name).

Graceful: when the result carries no field metadata (older server), headers fall back to the raw name and amounts to plain numbers — no regression (the existing fields: [] test still passes).

Tests

DatasetPreview → 6 passed (+2: labelled headers, and currency / no-currency formatting).
type-check green for app-shell.

Audit note

Swept all dataset-consuming surfaces: ReportPreview already delegates to the (fixed) DatasetReportRenderer; ObjectChart uses the label-aware buildChartSeries. DatasetPreview was the one remaining instance. Separately, plugin-grid/useColumnSummary.ts has a currency-blind aggregation footer, but it's a different data source (grid field metadata, not dataset results) — left as a potential follow-up, not in scope here.

🤖 Generated with Claude Code

…preview The live dataset-authoring preview (DatasetPreview) rendered raw dimension/ measure NAMES in its table headers and used a local currency-blind `formatCell` — the same three issues (raw-name headers, no currency awareness, no i18n) the dashboard widget and report renderer were already fixed for. It's the same dataset-bound `queryDataset` result, so authors saw a different rendering of the exact numbers their dashboards/reports show. Reuse the shared `@object-ui/core` helpers (`formatMeasure`, `formatDimensionValue`, `buildDatasetFieldHelpers`) + i18n `useSafeFieldLabel`: - headers resolve field label → i18n fieldLabel → raw name; - measure cells format with the field's declared currency (Intl symbol) + format, never a misleading "$"; - the preview chart's series label uses the display label too. Graceful: when the result carries no field metadata, headers fall back to the raw name and amounts to plain numbers (no regression). Tests: DatasetPreview 6 passed (+2: labelled headers + currency / no-currency formatting). type-check green for app-shell. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vercel · 2026-06-21T05:20:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jun 21, 2026 5:20am

github-actions · 2026-06-21T05:24:16Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	58.8 KB	350 KB
Entry file	`index-CBQjeIQe.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	5.95KB	2.10KB
app-shell (runtime-config.js)	4.72KB	1.69KB
app-shell (types.js)	0.01KB	0.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	17.16KB	3.44KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	5.11KB	1.92KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	24.74KB	6.00KB
auth (createAuthenticatedFetch.js)	3.33KB	1.32KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.01KB	0.79KB
auth (useIsWorkspaceAdmin.js)	1.28KB	0.70KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	414.34KB	87.93KB
core (index.js)	1.48KB	0.54KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	97.05KB	24.16KB
fields (index.js)	158.94KB	38.06KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.34KB	0.93KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	36.30KB	10.04KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	4.87KB	1.77KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.11KB	0.87KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.42KB	0.68KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.98KB	12.65KB
plugin-charts (index.js)	40.52KB	11.50KB
plugin-chatbot (index.js)	141.13KB	34.56KB
plugin-dashboard (index.js)	99.00KB	24.54KB
plugin-designer (index.js)	213.42KB	42.94KB
plugin-detail (index.js)	195.45KB	47.13KB
plugin-editor (index.js)	2.38KB	1.06KB
plugin-form (index.js)	91.29KB	22.26KB
plugin-gantt (index.js)	122.36KB	30.13KB
plugin-grid (index.js)	114.52KB	30.73KB
plugin-kanban (index.js)	48.82KB	13.13KB
plugin-list (index.js)	93.13KB	21.89KB
plugin-map (index.js)	16.02KB	4.98KB
plugin-markdown (index.js)	13.58KB	4.64KB
plugin-report (index.js)	35.93KB	9.50KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-view (index.js)	84.13KB	20.27KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	15.64KB	5.08KB
react (index.js)	0.76KB	0.42KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actionsBot added the tests label Jun 21, 2026

xuyushun441-sys merged commit e4afa84 into mainJun 21, 2026
10 checks passed

xuyushun441-sys deleted the fix/dataset-preview-labels-currency branch June 21, 2026 05:27

Navigation Menu

Uh oh!

fix(metadata-admin): currency-aware, labelled headers in the dataset preview - #1845

fix(metadata-admin): currency-aware, labelled headers in the dataset preview#1845
xuyushun441-sys merged 1 commit into
mainfrom
fix/dataset-preview-labels-currency

xuyushun441-sys commented Jun 21, 2026

Uh oh!

vercelBot commented Jun 21, 2026

Uh oh!

github-actionsBot commented Jun 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xuyushun441-sys commented Jun 21, 2026

What

Fix

Tests

Audit note

Uh oh!

vercelBot commented Jun 21, 2026

Uh oh!

github-actionsBot commented Jun 21, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants