Skip to content

fix(console-ai): actually render the "Proposed plan" card on /ai/build - #1878

Merged
xuyushun441-sys merged 1 commit into
mainfrom
fix/ai-plan-card-render
Jun 22, 2026
Merged

fix(console-ai): actually render the "Proposed plan" card on /ai/build#1878
xuyushun441-sys merged 1 commit into
mainfrom
fix/ai-plan-card-render

Conversation

@xuyushun441-sys

Copy link
Copy Markdown
Contributor

Problem

#1875 added the propose_blueprint review card (detector + ChatbotEnhanced body + labels), but it never rendered in the product. Two wiring gaps the detector-level unit tests couldn't catch — surfaced by a live browser test on /ai/build:

  1. RoutingChatbotEnhanced.shouldRenderDetailedTool only routed a tool to the detailed body (where the card lives) when it had draftReview items / was awaiting / failed. A propose_blueprint result carries proposedPlan but nodraftReview, so it collapsed into the summary chip strip and the card block was never reached. → route on proposedPlan too.
  2. Surface converterAiChatPage has its own history converter (hydratedMessagesToChatMessages, the /ai/build surface), separate from mapMessages (the floating chat). It wired draftReview but not proposedPlan, dropping the card on reload there. → lift proposedPlan alongside draftReview; export detectProposedPlan + ProposedPlan from the package index.

Verification

  • Live on the EE rig: a propose-only prompt on /ai/build now renders the Proposed plan card (object chips w/ field counts, totals line, assumptions, confirm-questions, approve hint).
  • Tests: ChatbotEnhanced renders the card for a proposedPlan tool (not a chip); AiChatPage hydration lifts proposedPlan from the merged tool output. plugin-chatbot 119 + app-shell hydration green; type-check clean.

Follow-up to #1875.

🤖 Generated with Claude Code

#1875 added the propose_blueprint review card (detector + ChatbotEnhanced
body + labels) but it never rendered in the product — two wiring gaps that
the detector-level unit tests couldn't catch, found by live browser test:
1. ChatbotEnhanced.shouldRenderDetailedTool only routed a tool to the
DETAILED body (where the card lives) when it had draftReview items /
was awaiting / failed — a propose_blueprint result carries `proposedPlan`
but no draftReview, so it was collapsed into the summary CHIP strip and
the card block was never reached. Route on `proposedPlan` too.
2. AiChatPage has its OWN history converter (hydratedMessagesToChatMessages,
the /ai/build surface) separate from mapMessages (the floating chat).
It wired draftReview but not proposedPlan, so the card was dropped on
reload there. Lift proposedPlan alongside draftReview, and export
detectProposedPlan + ProposedPlan from the package index.
Live-verified on the EE rig: a propose-only prompt on /ai/build now renders
the "Proposed plan" card (object chips with field counts, totals line,
assumptions, confirm-questions, approve hint).
Tests: ChatbotEnhanced renders the card for a proposedPlan tool (not a chip);
AiChatPage hydration lifts proposedPlan from the merged tool output.
plugin-chatbot 119 + app-shell hydration green; type-check clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jun 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 22, 2026 3:35am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)58.8 KB350 KB
Entry fileindex-C5nDnSUV.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.95KB2.10KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)24.74KB6.00KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)414.48KB88.02KB
core (index.js)1.48KB0.54KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)97.65KB24.24KB
fields (index.js)166.14KB40.06KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)42.55KB12.00KB
plugin-chatbot (index.js)147.52KB35.90KB
plugin-dashboard (index.js)104.31KB25.91KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)195.59KB47.19KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)93.07KB22.68KB
plugin-gantt (index.js)122.48KB30.19KB
plugin-grid (index.js)114.67KB30.78KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)93.15KB21.90KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.58KB4.64KB
plugin-report (index.js)35.93KB9.50KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)84.13KB20.27KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)15.64KB5.08KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@xuyushun441-sys
xuyushun441-sys merged commit a515c81 into mainJun 22, 2026
10 checks passed
@xuyushun441-sys
xuyushun441-sys deleted the fix/ai-plan-card-render branch June 22, 2026 03:43
xuyushun441-sys added a commit that referenced this pull request Jun 22, 2026
… gate (#1884)
The plan card (#1875/#1878) was read-only — the user had to TYPE "build it"
to proceed. Add a one-click gate, matching Airtable Omni's "Build it":
- "Build it" button sends an approval message via the existing onSendMessage
channel (same path as suggestion chips) → the agent proceeds to
apply_blueprint. It's context-aware: when the plan still carries open
questions, approval sends an accept-defaults message so a click never
silently drops them.
- "Adjust" button focuses the chat input so the user types changes in their
own words (no canned answer forced on an open-ended plan).
- Falls back to the existing static hint when the host hasn't wired
onSendMessage. Localized labels + messages on both surfaces (AiChatPage t(),
ConsoleFloatingChatbot locale; en + zh 开始搭建/调整方案).
Per-question canned quick-replies are intentionally NOT added: propose_blueprint
returns free-text questions with no structured options, so "Build it (with
defaults)" + type-to-answer is the honest affordance. A structured
questions:[{text,options}] from the backend would enable per-question chips later.
Verification: 3 new render tests (approve-with-defaults when questions exist,
plain approve when none, hint-fallback when sending unwired) — ChatbotEnhanced
40 green; plugin-chatbot + app-shell type-check clean.
Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
os-zhuang added a commit that referenced this pull request Jul 18, 2026
…ors (#1878) (#2666)
Metadata-liveness audit follow-through (umbrella #1878), objectui side.
#1891 (naming drift — dashboard title vs label): DashboardGridLayout read
only `schema.title`, but the spec's canonical top-level key is `label`, so a
spec-compliant dashboard rendered the literal "Dashboard" header. Fall back
to `schema.label` (matching DashboardView's title-then-label precedence).
#1895 (designer authoring gaps — skill): the skill authoring form exposed
only name/instructions/tools. Add editors for the activation-critical
fields that were previously hand-edit-only:
- `surface` (ask | build | both)
- `triggerPhrases` (NL activation phrases)
- `triggerConditions` (field / operator / value) — the activation-critical
programmatic conditions
plugin-dashboard suite green (89 passing); changed files add no type errors.
Claude-Session: https://claude.ai/code/session_01LddW4NaQBdf5FTEnBPpnUJ
Co-authored-by: Claude <noreply@anthropic.com>
os-zhuang added a commit that referenced this pull request Jul 26, 2026
…#2817)
`bridgePage`, `bridgeDashboard`, and the `SpecBridge#transformPage` /
`#transformDashboard` methods had no runtime consumer: pages render through
their own renderer and dashboards through `DashboardView → DashboardRenderer →
DatasetWidget` (ADR-0021), neither routing through `SpecBridge`. The dashboard
bridge's input shape (`object`/`categoryField`/`valueField`/`aggregate`) is the
pre-ADR-0021 widget model, which the strict `DashboardWidgetSchema` now rejects,
so the bridge could not receive a spec-valid dashboard even in principle.
Flagged dead by the metadata-liveness audit (framework #1878 / #1892). The
`list` and `form` bridges are the live authoring path and are untouched.
BREAKING CHANGE: removes the public exports `bridgePage`, `bridgeDashboard`,
and `SpecBridge#transformPage` / `#transformDashboard`.
Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@xuyushun441-sys@os-zhuang