Uh oh!
There was an error while loading. Please reload this page.
fix(console-ai): actually render the "Proposed plan" card on /ai/build - #1878
Merged
Conversation
#1875 added the propose_blueprint review card (detector + ChatbotEnhanced body + labels) but it never rendered in the product — two wiring gaps that the detector-level unit tests couldn't catch, found by live browser test: 1. ChatbotEnhanced.shouldRenderDetailedTool only routed a tool to the DETAILED body (where the card lives) when it had draftReview items / was awaiting / failed — a propose_blueprint result carries `proposedPlan` but no draftReview, so it was collapsed into the summary CHIP strip and the card block was never reached. Route on `proposedPlan` too. 2. AiChatPage has its OWN history converter (hydratedMessagesToChatMessages, the /ai/build surface) separate from mapMessages (the floating chat). It wired draftReview but not proposedPlan, so the card was dropped on reload there. Lift proposedPlan alongside draftReview, and export detectProposedPlan + ProposedPlan from the package index. Live-verified on the EE rig: a propose-only prompt on /ai/build now renders the "Proposed plan" card (object chips with field counts, totals line, assumptions, confirm-questions, approve hint). Tests: ChatbotEnhanced renders the card for a proposedPlan tool (not a chip); AiChatPage hydration lifts proposedPlan from the merged tool output. plugin-chatbot 119 + app-shell hydration green; type-check clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
Uh oh!
There was an error while loading. Please reload this page.
xuyushun441-sys added a commit
that referenced
this pull request
Jun 22, 2026
… gate (#1884) The plan card (#1875/#1878) was read-only — the user had to TYPE "build it" to proceed. Add a one-click gate, matching Airtable Omni's "Build it": - "Build it" button sends an approval message via the existing onSendMessage channel (same path as suggestion chips) → the agent proceeds to apply_blueprint. It's context-aware: when the plan still carries open questions, approval sends an accept-defaults message so a click never silently drops them. - "Adjust" button focuses the chat input so the user types changes in their own words (no canned answer forced on an open-ended plan). - Falls back to the existing static hint when the host hasn't wired onSendMessage. Localized labels + messages on both surfaces (AiChatPage t(), ConsoleFloatingChatbot locale; en + zh 开始搭建/调整方案). Per-question canned quick-replies are intentionally NOT added: propose_blueprint returns free-text questions with no structured options, so "Build it (with defaults)" + type-to-answer is the honest affordance. A structured questions:[{text,options}] from the backend would enable per-question chips later. Verification: 3 new render tests (approve-with-defaults when questions exist, plain approve when none, hint-fallback when sending unwired) — ChatbotEnhanced 40 green; plugin-chatbot + app-shell type-check clean. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
os-zhuang added a commit
that referenced
this pull request
Jul 18, 2026
…ors (#1878) (#2666) Metadata-liveness audit follow-through (umbrella #1878), objectui side. #1891 (naming drift — dashboard title vs label): DashboardGridLayout read only `schema.title`, but the spec's canonical top-level key is `label`, so a spec-compliant dashboard rendered the literal "Dashboard" header. Fall back to `schema.label` (matching DashboardView's title-then-label precedence). #1895 (designer authoring gaps — skill): the skill authoring form exposed only name/instructions/tools. Add editors for the activation-critical fields that were previously hand-edit-only: - `surface` (ask | build | both) - `triggerPhrases` (NL activation phrases) - `triggerConditions` (field / operator / value) — the activation-critical programmatic conditions plugin-dashboard suite green (89 passing); changed files add no type errors. Claude-Session: https://claude.ai/code/session_01LddW4NaQBdf5FTEnBPpnUJ Co-authored-by: Claude <noreply@anthropic.com>
os-zhuang added a commit
that referenced
this pull request
Jul 26, 2026
…#2817) `bridgePage`, `bridgeDashboard`, and the `SpecBridge#transformPage` / `#transformDashboard` methods had no runtime consumer: pages render through their own renderer and dashboards through `DashboardView → DashboardRenderer → DatasetWidget` (ADR-0021), neither routing through `SpecBridge`. The dashboard bridge's input shape (`object`/`categoryField`/`valueField`/`aggregate`) is the pre-ADR-0021 widget model, which the strict `DashboardWidgetSchema` now rejects, so the bridge could not receive a spec-valid dashboard even in principle. Flagged dead by the metadata-liveness audit (framework #1878 / #1892). The `list` and `form` bridges are the live authoring path and are untouched. BREAKING CHANGE: removes the public exports `bridgePage`, `bridgeDashboard`, and `SpecBridge#transformPage` / `#transformDashboard`. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#1875 added the propose_blueprint review card (detector + ChatbotEnhanced body + labels), but it never rendered in the product. Two wiring gaps the detector-level unit tests couldn't catch — surfaced by a live browser test on /ai/build:
ChatbotEnhanced.shouldRenderDetailedToolonly routed a tool to the detailed body (where the card lives) when it haddraftReviewitems / was awaiting / failed. Apropose_blueprintresult carriesproposedPlanbut nodraftReview, so it collapsed into the summary chip strip and the card block was never reached. → route onproposedPlantoo.AiChatPagehas its own history converter (hydratedMessagesToChatMessages, the /ai/build surface), separate frommapMessages(the floating chat). It wireddraftReviewbut notproposedPlan, dropping the card on reload there. → liftproposedPlanalongsidedraftReview; exportdetectProposedPlan+ProposedPlanfrom the package index.Verification
/ai/buildnow renders the Proposed plan card (object chips w/ field counts, totals line, assumptions, confirm-questions, approve hint).proposedPlantool (not a chip); AiChatPage hydration liftsproposedPlanfrom the merged tool output. plugin-chatbot 119 + app-shell hydration green; type-check clean.Follow-up to #1875.
🤖 Generated with Claude Code