Skip to content

fix(action): honor the spec disabled predicate on every action-rendering surface (#1885 follow-through) - #2863

Merged
os-zhuang merged 1 commit into
mainfrom
fix/action-disabled-all-renderers
Jul 27, 2026
Merged

fix(action): honor the spec disabled predicate on every action-rendering surface (#1885 follow-through)#2863
os-zhuang merged 1 commit into
mainfrom
fix/action-disabled-all-renderers

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Surfaced by the framework #1878 security-props recheck (the disposition doc's last OBJECTUI item), then widened by browser dogfooding. Companion showcase specimen: objectstack-ai/objectstack#3643.

Problem

The spec Action field is disabled (boolean | CEL — disabled when TRUE); the schema has no enabled key. #1885 (PR #1743) wired it in action:button only. An AI authoring disabled: 'record.status == "closed"' per spec got a fully clickable button on five other surfaces:

SurfaceBefore
action:group inline leafread non-spec enabled only
action:group dropdown itemread non-spec enabled only
action:iconread non-spec enabled only
action:menu itemread non-spec enabled only
app-shell DeclaredActionsBarread neither (disabled={loading})
plugin-detail record:quick_actionshad a disabled impl, but its typeof === 'string' split dropped the {dialect:'cel', source} envelope the server compiles authored CEL into (#2661), so it never fired on real metadata — found live in the browser (disabled: false on a record that should grey)

Fix

All surfaces now follow the #1885 idiom: feed toPredicateInput(action.disabled) to useConditionwhole (envelopes route to the canonical formula engine), disabled primary, legacy enabled kept as a deprecated fallback where it previously worked (DeclaredActionsBar gains disabled only — declared actions are spec-shaped and never carried the non-spec key).

Verification

  • New DropdownActionItem tests: disabled-when-TRUE / false-stays-clickable / disabled-wins-over-enabled / boolean literal (8/8 in file).
  • plugin-detail renderers + components action suites: 25/25; app-shell views: 50/50 earlier run.
  • Browser-verified against the showcase showcase_archive_task specimen (disabled: 'record.done != true', arriving as a CEL envelope): greyed on an in-progress task, clickable on a done one, with visible hiding Mark Done on the same screen (hide-vs-grey contrast).

🤖 Generated with Claude Code

@os-zhuang@claude
fix(action): honor the spec disabled predicate on every action-render…
b7c9665
…ing surface (#1885 follow-through)
Spec Action field is `disabled` (boolean | CEL, disabled when TRUE); the
schema has no `enabled` key. #1885 wired action:button only. Browser
dogfooding found five more surfaces where an authored `disabled` silently
did nothing:
- components: action:group leaves (inline + dropdown), action:icon,
action:menu read the legacy non-spec `enabled` only. `disabled` is now
primary (same evaluation scope as `visible`), `enabled` stays as a
deprecated fallback.
- app-shell: DeclaredActionsBar read neither; gains `disabled` (no legacy
fallback -- declared actions are spec-shaped).
- plugin-detail: record:quick_actions HAD a disabled implementation but its
`typeof === 'string'` split dropped the {dialect:'cel', source} envelope
the server compiles authored CEL into (#2661), so it never fired on real
metadata. Now feeds toPredicateInput's result to useCondition whole.
Pinned by new DropdownActionItem tests (4 cases); browser-verified against
the showcase showcase_archive_task specimen: greyed on an in-progress task,
clickable on a done one.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 27, 2026 12:30pm

Request Review

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.0 KB350 KB
Entry fileindex-CoVynzIR.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.20KB2.97KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)4.37KB1.69KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)450.90KB98.17KB
core (index.js)2.12KB0.77KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)127.29KB31.96KB
fields (index.js)218.35KB53.54KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)25.17KB5.80KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)6.84KB2.42KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.67KB1.12KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.55KB0.71KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.37KB12.48KB
plugin-charts (index.js)46.99KB13.28KB
plugin-chatbot (index.js)179.53KB42.79KB
plugin-dashboard (index.js)108.66KB28.00KB
plugin-designer (index.js)210.92KB42.69KB
plugin-detail (index.js)215.28KB52.50KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)103.53KB25.12KB
plugin-gantt (index.js)162.33KB39.53KB
plugin-grid (index.js)178.20KB46.71KB
plugin-kanban (index.js)47.82KB13.18KB
plugin-list (index.js)98.71KB23.32KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.07KB9.81KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.70KB20.87KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.00KB0.55KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.86KB0.91KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.04KB1.93KB
types (system-fields.js)2.39KB1.17KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 7b21891 into mainJul 27, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the fix/action-disabled-all-renderers branch July 27, 2026 12:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: componentsplugintests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang