fix(fields): inline-edit relational fields with the standard picker (not a text box) by os-zhuang · Pull Request #2122 · objectstack-ai/objectui

os-zhuang · 2026-06-30T21:01:31Z

What

lookup / master_detail / user / owner fields now edit inline with the standard record picker — the same LookupField / UserField the form uses — instead of falling back to a plain text box.

Why (caught in review)

Inline editing reuses the form's widgets, but the inline map (EDIT_WIDGETS) was a hand-maintained subset of the form's (fieldWidgetMap) and had drifted — relational types had perfectly good form pickers, but nobody wired them into the inline map, so they degraded to a text box (you'd type a raw record id). The form already supported them; this just reuses them.

How

lookup / master_detail → LookupField, user / owner → UserField. They read the related-object dataSource from SchemaRendererContext, which the grid already provides — drop-in, same FieldWidgetProps interface.

Verified live (:5417 field-zoo)

Clicking a Lookup → Account cell opens the record picker ("选择…") with a search box and 13 fetched Account records (Northwind, Contoso, Fabrikam, Initech…) — not a text box, not empty. master_detail / user / owner likewise render the picker.

Drift-guard (so this can't recur)

index now exports FORM_FIELD_TYPES; a test pins that every form widget type has an explicit inline decision — an editor in EDIT_WIDGETS, or an entry in the new INLINE_EXCLUDED_FIELD_TYPES (computed / binary / heavy-editor / container types, each documented). A future form widget can no longer silently become a text box or a missing editor in the grid.

+4 drift-guard tests; full @object-ui/fields suite (4918) green.

🤖 Generated with Claude Code

The inline cell editor reuses the form's widgets, but its map (EDIT_WIDGETS) was a hand-maintained subset of the form's (fieldWidgetMap) and drifted: lookup / master_detail / user / owner had real form pickers yet fell back to a plain text box inline. Wire them to the SAME widgets the form uses (lookup/master_detail → LookupField, user/owner → UserField); they read the related-object dataSource from SchemaRendererContext, which the grid provides. Browser-verified on the field-zoo: clicking a Lookup cell opens the record picker with a search box and the 13 fetched Account records — not a text box, not empty. Drift-guard: index exports FORM_FIELD_TYPES + a test pins that every form widget type has an explicit inline decision (an editor, or an entry in the new INLINE_EXCLUDED_FIELD_TYPES with a reason), so the two maps can't silently drift again. Full fields suite (4918) green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vercel · 2026-06-30T21:01:37Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jun 30, 2026 9:01pm

github-actions · 2026-06-30T21:05:53Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	59.1 KB	350 KB
Entry file	`index-CrgWeuTm.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	7.28KB	2.63KB
app-shell (runtime-config.js)	4.72KB	1.69KB
app-shell (types.js)	0.01KB	0.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	17.90KB	3.67KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	9.55KB	3.36KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	26.07KB	6.30KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.29KB	0.82KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	434.16KB	93.21KB
core (index.js)	1.65KB	0.59KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	102.28KB	25.46KB
fields (index.js)	166.19KB	40.42KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	36.30KB	10.04KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.10KB	12.33KB
plugin-charts (index.js)	46.11KB	12.99KB
plugin-chatbot (index.js)	172.75KB	41.13KB
plugin-dashboard (index.js)	108.31KB	26.87KB
plugin-designer (index.js)	213.48KB	42.95KB
plugin-detail (index.js)	200.15KB	48.14KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	96.84KB	23.41KB
plugin-gantt (index.js)	136.67KB	33.88KB
plugin-grid (index.js)	123.96KB	33.60KB
plugin-kanban (index.js)	48.15KB	12.94KB
plugin-list (index.js)	97.85KB	23.06KB
plugin-map (index.js)	16.02KB	4.98KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.21KB	2.76KB
plugin-view (index.js)	84.50KB	20.37KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…2140) Follow-up to #2125. `LookupField`'s inline display now resolves every value shape the read cell (`LookupCellRenderer`) does, closing the remaining gaps: - JSON-encoded external-id references ('{"externalId":"…"}') are parsed and shown by their external id, and excluded from the hydration fetch so we never findOne() a raw JSON string. `recordToOption` gained an `externalId` fallback for both value and label. - Tolerant id matching: a String()-coerced fallback (`findOptionLoose`) resolves a numeric cell value against a string-keyed option (and vice versa), matching the read cell's comparison. Only consulted when the strict match misses. - `normalizeId` also unwraps JSON-encoded reference strings. Adds inline-editor tests for user / owner fields (they delegate to LookupField via UserField), completing coverage for the relational set wired inline in #2122. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

github-actionsBot added the tests label Jun 30, 2026

os-zhuang merged commit 5160832 into mainJun 30, 2026
10 checks passed

os-zhuang deleted the feat/inline-edit-relational-widgets branch June 30, 2026 21:10

This was referenced Jul 1, 2026
chore: release packages #2130
Closed
chore: release packages #2166
Closed
chore: release packages #2191
Closed

Navigation Menu

Uh oh!

fix(fields): inline-edit relational fields with the standard picker (not a text box) - #2122

fix(fields): inline-edit relational fields with the standard picker (not a text box)#2122
os-zhuang merged 1 commit into
mainfrom
feat/inline-edit-relational-widgets

os-zhuang commented Jun 30, 2026

Uh oh!

vercelBot commented Jun 30, 2026

Uh oh!

github-actionsBot commented Jun 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jun 30, 2026

What

Why (caught in review)

How

Verified live (:5417 field-zoo)

Drift-guard (so this can't recur)

Uh oh!

vercelBot commented Jun 30, 2026

Uh oh!

github-actionsBot commented Jun 30, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant